Three independent test-scaffold defects blocked the unit_tests and
integration_tests gates on PR #6361's shell-safety wiring:
- features/steps/_tui_helpers.py: the mocked-shell helper patched
cleveragents.tui.input.shell_exec.run_shell_command, but modes.py
binds the symbol into its own namespace via `from ... import`. The
patch was inert, and only the CLEVERAGENTS_ALLOW_DANGEROUS_SHELL=1
gate kept the real `rm -rf /tmp` from running in the behave runner.
Patch the use site (modes.run_shell_command) instead.
- src/cleveragents/tui/widgets/prompt.py: _FallbackPromptInput (used
whenever Textual is mocked or unavailable) had no add_class /
remove_class / has_class, so the new "prompt should be marked as
dangerous" assertions raised AttributeError and the three new
scenarios errored. The production path (_TextualPromptInput) already
inherits these from textual.containers.Horizontal; the fallback now
mirrors that contract via a small self._classes set.
- robot/tui_shell_safety.robot: Catenate's space-based argument
separator collapses multi-space indentation, so the Python function
bodies (warn_callback, deny) landed at column 0 and the helper
scripts died with IndentationError before either assertion ran.
Preserve the 4-space indent with ${SPACE * 4} markers.
ISSUES CLOSED: #6361
Tests in features/config_cli_*.feature and robot/config_cli.robot /
robot/automation_profile_cli.robot patch
``cleveragents.cli.commands.config._CONFIG_DIR`` /
``_CONFIG_PATH`` with ``unittest.mock.patch.object`` to redirect
the CLI to a temp config directory. ``_get_service`` was calling
``_get_config_dir()`` and recomputing the path from
``CLEVERAGENTS_HOME`` / ``Path.home()`` on every invocation, which
bypassed the patches and routed every test through the developer's
real ``~/.cleveragents`` — producing the 8 unit_tests scenario
failures and 3 integration Robot failures observed on CI.
Read the patched module-level constants directly so the patches
take effect. Module-load-time path resolution (the assignment at
file scope) still honours ``CLEVERAGENTS_HOME``.
The 4 robot tests that had ``tdd_expected_fail`` for tdd_issue_4204
and tdd_issue_4302 now pass — drop the tag so the
tdd_expected_fail_listener doesn't invert their PASS into a FAIL.
ISSUES CLOSED: #3773
Fix 8 distinct integration test and E2E failures:
1. JSON envelope unwrapping in test helpers
Helpers were asserting keys at the top-level of the JSON envelope
({command, status, exit_code, data, timing, messages}) rather than
inside the nested 'data' field. Updated helpers to access
parsed['data'] for assertions on the actual response payload:
- helper_cli_formats.py: action_list_json, action_show_yaml,
plan_list_json, global_format_json_version, global_format_yaml_version,
global_format_shorthand
- helper_automation_profile_cli.py: test_show_json, test_list_json
- helper_cli_extensions.py: action_show_json
- helper_config_cli.py: config_set_get_roundtrip
- helper_config_project_scope.py: cli_roundtrip
2. Plan list --namespace / -n option (issue #4301)
Add 'namespace' parameter to lifecycle_list_plans() in plan.py,
passing it through to service.list_plans(namespace=...) and
displaying it in the Filters panel.
3. Config registry key count (issue #4304)
Update expected count from 105 to 106 to match current registry
(additional server key was added via the server stubs feature).
4. Container tool exec mock fix (issue #4243)
The test mocked ev.resolve_and_validate (no longer called) instead
of ev.resolve_with_precedence. Fix the mock target so ToolRunner
correctly routes to the container path and returns the expected
error when no ContainerToolExecutor is configured.
5. E2E config CLI CLEVERAGENTS_HOME support
config.py used a hardcoded Path.home() / '.cleveragents' for the
config directory, ignoring CLEVERAGENTS_HOME. E2E tests run in
isolated temporary homes set via CLEVERAGENTS_HOME; this caused the
WF07 CI Profile Configuration test to read from the global config
(returning 'review') instead of the test-scoped config. Make
_get_config_dir() and _get_service() respect CLEVERAGENTS_HOME.
ISSUES CLOSED: #4204#4205#4206#4243#4301#4302#4303#4304
- Add _apply_output_dict() building the spec-required JSON envelope
- Update lifecycle_apply_plan to use _apply_output_dict for --format json
- Rewrite robot file to use Run Process + helper dispatch pattern
- Rewrite robot helper to use real LifecyclePlan domain objects
- Apply ruff format to plan_apply_json_envelope_steps.py
The `agents plan apply --format json` command was returning a raw
plan dictionary instead of the spec-required JSON envelope. This fix
introduces a dedicated `_apply_output_dict()` helper that wraps the
non-rich format output in the proper envelope structure with
`command`, `status`, `exit_code`, `data`, `timing`, and `messages`
fields.
The `data` field contains structured information about artifacts,
changes, project, applied_at, validation (test/lint/type_check),
sandbox_cleanup, and lifecycle metrics. Other commands (plan status,
plan cancel, plan use) remain unaffected — they continue using
`_plan_spec_dict`.
Tests: 16 Behave scenarios + 15 Robot Framework integration tests
added covering envelope structure, field presence, sandbox cleanup
state derivation from actual plan state, legacy fallback, cost
metadata, and command isolation.
ISSUES CLOSED: #9449
All 9 test cases previously only called `project create` + `project show`
despite documentation claiming to test correction, plan execution, and
subplan spawning workflows. This commit fixes that.
Changes per reviewer blockers:
Blocker 1 (hollow stubs): Each test now invokes the workflow its name
and documentation describe:
- test_correction_workflow.robot: calls `plan correct --mode revert/append`
(with --dry-run for mode tests; actual correction for state transition test)
- test_project_plan_workflow.robot: Plan Execution Workflow now calls
`plan use` + `plan execute` + `plan status`; Project Creation Workflow
uses resource-based project creation and verifies list output
- test_subplan_workflow.robot: Subplan Spawning and Merge Result Validation
inspect `plan tree` for spec-required child_plans/decision_ids fields;
Three-Way Merge Workflow exercises `plan apply`
Blocker 2 (temp dir leaks): All tests now use `Create Temp Git Repo`
(creates inside SUITE_HOME, cleaned by E2E Suite Teardown) instead of
`Create Temp Directory` (tempfile.mkdtemp outside SUITE_HOME, leaked).
The unused `Set Up E2E Project Test` local keyword (which created an
orphaned suite-variable temp dir) is removed from all three files.
Each file gains a proper suite setup keyword that registers the
local/code-review action needed by plan lifecycle tests, following
the pattern established in m6_acceptance.robot.
Address PR #10614 review findings:
- Added [Timeout] 30 minutes to all 9 test cases to prevent CI hangs
- Removed duplicate Create Temp Directory keyword from each file (moved to common_e2e.resource)
- Added Set Up E2E Project Test keyword for consistent temp dir creation via TEST NAME variable
- Added msg= parameters to Should Not Be Empty assertions for better debugging
Signed-off-by: HAL9000 <hal9000@noreply.git.cleverthis.com>
- Add test_project_plan_workflow.robot for project creation and plan execution workflows
- Add test_correction_workflow.robot for revert and append mode correction workflows
- Add test_subplan_workflow.robot for subplan spawning and three-way merge workflows
- All tests use Robot Framework with real CLI execution (no mocking)
- Tests validate spec-required output formats
- Tests skip gracefully if LLM API keys are not configured
Closes#5259
Restore the two behaviours that master had but were lost in this branch:
1. Convert hyphens to underscores in named-option keys before forwarding
to the service layer (--coverage-threshold → coverage_threshold). This
matches Typer/Click's universal convention and the documented
attach_validation(args=...) contract, where keys must be Python-
identifier-style strings.
2. Detect a missing value when the next token starts with -- (e.g.
"--threshold --strict true" no longer silently sets threshold to the
literal string "--strict"; it errors with a clear "Missing value for
option" message).
Update the Behave step definitions and the Robot helper to assert the
underscore-normalised key (coverage_threshold), matching the restored
behaviour. The CLI-level option name (--coverage-threshold) is unchanged
in the feature file and Robot test — only the dict key the service
receives is normalised.
Refactors the 'agents validation attach' command to accept extra validation
arguments as named CLI options using '--key value' format (e.g.
'--coverage-threshold 90'), as required by the specification.
Changes:
- validation.py: Replace positional 'key=value' Argument with Typer context
settings (allow_extra_args=True, ignore_unknown_options=True) to capture
'--key value' named options from ctx.args. Strips '--' prefix and maps
tokens to {key: value} dict entries. Rejects bare tokens (not '--key value')
with a clear error message.
- features/tdd_validation_attach_named_options.feature: New TDD Behave
scenarios covering single/multiple named options, no-args case, and
rejection of old positional key=value format.
- features/steps/tdd_validation_attach_named_options_steps.py: Step
definitions for the new feature.
- robot/validation_attach_named_options.robot: Robot Framework integration
tests verifying spec-compliant '--key value' option format.
- robot/helper_validation_attach_named_options.py: Helper script for the
Robot Framework tests.
- features/steps/tdd_cli_incomplete_subcommand_registration_steps.py: Fix
pre-existing CliRunner(mix_stderr=False) incompatibility with current Typer.
- features/steps/tool_runtime_steps.py: Fix pre-existing AmbiguousStep error
by converting conflicting parse-based step definitions to regex matchers.
- features/consolidated_tool.feature: Update step text to match renamed step.
Closes#3684
- features/steps/tdd_plan_generation_validate_steps.py: drop duplicate
@given/@then registrations (live in plan_generation_langgraph_coverage_
steps.py; redefinition caused AmbiguousStep errors crashing all 8
behave-parallel workers); have the @when step feed the docstring as the
FakeListLLM response so each scenario tests _validate()'s parsing of a
specific PASS/FAIL signal rather than the input code.
- features/tdd_plan_generation_validate_logic.feature: add the required
@tdd_issue tag alongside @tdd_issue_10746 (enforced by
features/environment.py); tighten scenario 4 wording to remove the
reference to the obsolete length guard.
- robot/plan_generation_graph.robot: drop assertion for handle_retry node
(retry is a conditional edge, not a fifth node) and update node-count
check from 5 to 4; update Should Retry test to assert _should_retry does
NOT mutate state (read-only contract for LangGraph conditional edges).
- src/cleveragents/agents/graphs/plan_generation.py:
* _validate: persist retry_count increment in return dict (FAIL path and
exception path) so LangGraph propagates it through the state graph.
* _should_retry: remove state mutation (conditional-edge functions are
read-only in LangGraph; mutations were silently dropped, causing
retry_count to remain 0 forever and the graph to loop infinitely).
Adjust comparison to retry_count <= max_retries because _validate has
already incremented before _should_retry runs.
* __init__: add max_context_files parameter (default 5, validated > 0)
and wire it into _format_context_summary in place of the hardcoded 5,
implementing the configurable-limits contract tested by
features/agent_configurable_limits.feature.
ISSUES CLOSED: #10746
- Remove misplaced pytest test files: tests/unit/a2a_test_http_transport.py,
tests/unit/__init__.py, and features/steps/test_a2a_http_transport_pytest.py.
Project layout uses Behave in features/ exclusively per CONTRIBUTING.md.
- Resolve AmbiguousStep crash in features/steps/a2a_facade_steps.py by
deduplicating step_transport_connect / step_transport_disconnect /
"the transport should not be connected" definitions left over from the
pre-implementation stub.
- Remove all `# type: ignore[arg-type]` comments (zero-tolerance policy).
- Fix ruff lint failures in src/cleveragents/a2a/transport.py: drop unused
imports (Any, map_domain_error, BaseHandler, OpenerDirector), wrap long
log lines (E501), and switch ssl.VerifyMode literal 0 to CERT_NONE for
pyright compliance.
- Update Robot helpers (robot/helper_a2a_facade.py,
robot/helper_m6_autonomy_acceptance.py) and the m6 / consolidated Behave
scenarios to verify the new server-mode lifecycle (connect succeeds with
valid URL, send-before-connect raises RuntimeError, invalid scheme raises
ValueError) instead of the obsolete "stub raises A2aNotAvailableError"
contract.
- Broaden the "I try to connect via the transport to ..." regex so the
invalid-URL scenario outline matches the empty-string / quoted / None
example cells; alias "I disconnect the transport" with @then so it is
reachable from `And` after a `Then` keyword.
Fix JSON syntax errors in .devcontainer/devcontainer.json (removed
invalid JS-style // comments) and .devcontainer/opencode.json (removed
90+ trailing commas). Apply auto-fixes for end-of-file and trailing
whitespace issues across 100+ files. Fix SIM105 ruff violations in
benchmarks/core_circuit_breaker_bench.py (use contextlib.suppress).
Note: The security fix from issue #7478 (validate_path startswith bypass)
was already delivered to master in commit e18ac5f2. This PR as currently
structured is non-atomic (35 commits across 10+ issues) and needs
significant restructure before merge. This commit only addresses the
CI/pre-commit failures.
ISSUES CLOSED: #7478
This PR implements the Invariant data model and database schema for the
v3.2.0 milestone. The Invariant feature enables the system to define, store,
and manage invariant rules that can be evaluated against system state.
- Alembic migration m3_001_invariants_table creates the invariants table
with columns: id (UUID), description (text), created_at (timestamp),
is_active (bool, default True), with index on is_active for efficiency
- SQLAlchemy ORM InvariantModel in
cleveragents.infrastructure.database.models.InvariantModel
- M3 merge migration to resolve Alembic head conflict
- BDD Behave scenarios (10 test cases) in features/invariant_model.feature
- Robot Framework integration tests in robot/invariant_model.robot
- Updated CHANGELOG.md and CONTRIBUTORS.md
- Restored status-check CI aggregation job
ISSUES CLOSED: #8524
Robot Framework requires ≥2 spaces (or a tab) to separate multiple
values in a [Tags] setting. The WF18 Suite Setup keyword had a single
space between tdd_issue and tdd_issue_4188, causing RF to parse them
as a single tag with a space in its name rather than two distinct tags.
The tdd_expected_fail_listener validates that tdd_issue_N requires a
standalone tdd_issue tag — the single-space bug was silently breaking
that validation.
Fix: change `tdd_issue tdd_issue_4188` to `tdd_issue tdd_issue_4188`
(four-space separator, matching the rest of the file's style).
ISSUES CLOSED: #10815
The wf18_container_clone.robot E2E test had an empty test case body —
after Skip If No LLM Keys the test contained no steps, but when LLM
keys are present the container clone workflow caused the CLI process to
be killed by SIGKILL (rc=-9, OOM) in the memory-constrained CI
environment.
Added tdd_expected_fail (with tdd_issue_10815) so CI correctly inverts
the OOM failure to a pass until the container execution environment is
tuned to operate within CI memory limits.
Also added the full WF18 test body implementing all acceptance criteria:
- container-instance resource registration with --clone-into flag
- two-step project creation and resource linking
- action creation with trusted automation profile
- full plan lifecycle: plan use → plan execute → plan apply
- WF18 Test Teardown keyword for diagnostic logging on failure
The fixture repo (Create Remote Clone Repo) creates a local git repo
using file:// URI so the --clone-into clone can operate without
requiring an external network host.
ISSUES CLOSED: #10815
The robot/helper_plan_explain.py integration test helper was still
asserting the old field name alternatives_considered in the explain
dict output. Since _build_explain_dict() now outputs alternatives
(structured objects with index/description/chosen fields per spec),
the assertion was failing the CI integration_tests job.
Updated the assertion to check for alternatives and also verify
it is a list, matching the new structured output format.
- Fix asgi_app.py: use a2a_request.method instead of a2a_request.operation
(A2aRequest model was updated in master to use JSON-RPC 2.0 field names)
- Fix server_lifecycle_steps.py: send JSON-RPC 2.0 wire format with
"method" field; check result.status instead of top-level status
- Fix server_lifecycle.feature: update step name to match new step
definition (A2A response result status)
- Fix helper_server_lifecycle.py: use "method" field in JSON-RPC 2.0
payload; check result.status in response
- Fix malformed JSON parse error: wrap request.json() in try/except,
return -32700 Parse error instead of unhandled HTTP 500
- Fix JSON-RPC error responses: add required 'id' field to all error
responses per JSON-RPC 2.0 Section 5
- Fix HTTP status codes: return HTTP 200 for all JSON-RPC responses
(error codes expressed in JSON body per JSON-RPC 2.0 over HTTP)
- Fix error message leakage: return generic messages instead of raw
Pydantic ValidationError internals (CWE-209)
- Add catch-all exception handler returning -32603 Internal error
- Fix Agent Card url field: use base server URL without /a2a suffix;
interfaces[0].url correctly uses endpoint URL with /a2a suffix
- Fix 0.0.0.0 host: substitute 127.0.0.1 for Agent Card URL
- Fix context typing: replace context: Any with context: Context in
all step files per project convention
- Fix inline imports: move all imports to top of step files
- Fix _COMMANDS typing: use dict[str, Callable[[], None]] to avoid
type: ignore suppression in helper files
- Add BDD scenarios for entity-sync and namespace-mgmt skill enumeration
- Update server_lifecycle.feature: correct HTTP status assertions to 200
ISSUES CLOSED: #867
Implement A2A Agent Card discovery per ADR-047 and issue #867:
- AgentCard Pydantic model (agent_card.py) with nested models for
skills, capabilities, extensions, security schemes, and interfaces.
- Factory function build_agent_card() enumerates supported operations
from the facade and maps them to A2A skills (plan-lifecycle,
registry-crud, context-mgmt, entity-sync, namespace-mgmt,
health-diagnostics).
- Version negotiation: supportedVersions and version fields from
A2aVersion constants.
- A2A conformance validation (validate_agent_card_conformance) checks
required fields, version support, and structural integrity.
- Updated ASGI app to build the Agent Card from the facade model
instead of a raw dict, with conformance validation at startup.
- Behave BDD tests: 34 scenarios covering model construction, field
validation, conformance checks, serialization, endpoint responses,
and skill enumeration from facade operations.
- Robot Framework integration tests: 6 test cases for build, conformance,
endpoint, serialization, skill enumeration, and version info.
- Updated A2A package exports and CHANGELOG.
ISSUES CLOSED: #867
Align the resource and skill management showcase with review feedback: consistent resource type counts (101), explicit save-to-disk instructions before each skill registration command, metadata callouts for non-obvious behaviors (Config: unknown, capability summary zeros, local/linear-tracker 0-tool count), and README framing to acknowledge platform feature walkthroughs.
Remove obsolete tdd_issue tags from coverage threshold Robot tests now that the noxfile enforces COVERAGE_THRESHOLD = 97.
Harden the Skip If No LLM Keys E2E helper with per-key regex validation and log-level suppression to prevent credential leakage in CI logs. Restore the Resolve LLM Actor keyword that was inadvertently removed from common_e2e.resource.
Update CHANGELOG.md and CONTRIBUTORS.md per project requirements.
ISSUES CLOSED: #4470
The shared `format_data` serializer introduced for the CLI→Application
A2A boundary returns raw payloads without the `{"data": ...}` envelope
that the legacy CLI `format_output` wraps around. Two test-step
definitions (`step_artifacts_json_validation`,
`step_artifacts_json_apply_summary`) still unwrapped that envelope and
crashed with `KeyError: 'data'`, errrring the Behave scenarios
`Plan artifacts shows validation results when available` and
`Artifacts include apply summary from metadata`.
Also remove the stale `@tdd_expected_fail` tag from the Robot scenario
`WF02 Mocked Generation Produces Test Artifacts Only`: the scenario
exercises the `_cleveragents/plan/artifacts` A2A dispatch path that this
PR added and now passes naturally; the `tdd_expected_fail_listener`
inverts the passing result to a failure with "Bug appears to be fixed.
Remove the tdd_expected_fail tag".
Adds a CHANGELOG entry covering both the boundary refactor and these
test alignments.
Refs: #9962
Refs: #4253
Applied ruff format auto-fix to resolve line-length formatting violations in:
- features/steps/langgraph_platform_remote_graph_steps.py
- robot/helper_langgraph_platform_integration.py
These files had multi-line assert statements that ruff format collapses to
single lines when they fit within the line length limit.
ISSUES CLOSED: #693
Three issues causing CI failures in advanced-context-strategies tests:
1. AmbiguousStep: `@then("the strategy should be {strategy_type}")` in
advanced_context_strategies_steps.py conflicted with the existing
`@then('the strategy should be "{expected_strategy}"')` in
plan_merge_strategy_steps.py:122. Renamed to
`@then("the loaded strategy type should be {strategy_type}")` and
updated all four matching lines in the feature file.
2. Wrong fragment count assertion: scenario "Semantic search strategy
ranks by embedding similarity" expected 3 fragments but
SemanticEmbeddingStrategy (word-overlap Jaccard, min_similarity=0.05)
correctly filters "File input output handler" (0 overlap with
"database connection"). Fixed assertion from 3 to 2.
3. Robot helper import failure: `features.mocks` is not importable when
Robot Framework imports the library because it adds robot/ to
sys.path but not the project root. Added explicit project-root
sys.path.insert before the features.mocks import (same pattern as
helper_lsp_stub.py), with # noqa: E402 on the post-path imports.
ISSUES CLOSED: #7574
- Extract FakeEmbeddings, RelevanceScoringStrategy, AdaptiveContextSelector,
ContextFusionStrategy, and _pack_budget from features/steps/ into new
features/mocks/advanced_context_strategies_mocks.py per mock-placement rules
- Remove sys.path manipulation from robot/helper_advanced_context_strategies.py;
import directly from features.mocks instead of features/steps
- Add None guard before selected.assemble() in step_assemble_context_query
- Add explicit ValueError for unknown strategy types in step_load_yaml_strategy
and load_strategy_from_yaml_impl
ISSUES CLOSED: #7574
- Add Behave feature file with 30+ scenarios for semantic search, relevance scoring, adaptive selection, and context fusion strategies
- Implement step definitions for all advanced context strategy tests
- Add FakeEmbeddings mock for deterministic testing without real API calls
- Create Robot Framework integration tests for E2E validation
- Implement helper functions for Robot Framework test execution
- All tests use proper type annotations and follow CONTRIBUTING.md guidelines
- Tests verify strategy selection, budget handling, deduplication, and YAML configuration
- Integration tests validate ContextAssembler compatibility and strategy priority handling
- Replace non-existent 'session create --name' with 'session create --format json'
- Replace non-existent 'plan create --session --description' with 'plan list --format json'
- Replace 'session delete <name>' with 'session delete <ULID> --yes' using extracted session ID
- Remove invalid '--format json' from context list/show commands that don't support it
- Use Safe Parse Json Field keyword to extract session_id from JSON output
- Align all test commands with actual CLI interface
- Add test_a2a_local_facade.robot with session and plan lifecycle tests
- Add test_context_workflow.robot with context configuration and execution tests
- Tests validate output format matches specification
- Tests run against real CLI without mocking
- Covers A2A session initialization, plan creation, listing, and deletion
- Covers context loading, validation, and plan execution workflows
- Replace hardcoded gpt-4/openai/gpt-4 references with Resolve LLM Actor
keyword so the test falls back to Anthropic when OpenAI is unavailable
- Add explicit return-code check (rc==0) for actor registration in Step 2
- Update CHANGELOG.md with entry for PR #11191
The M2 acceptance test was incomplete (truncated at line 48).
Restore the full test case that exercises the complete M2 milestone:
- Actor YAML compilation and registration
- Resource registration and project creation
- Action creation with custom actor configuration
- Full plan lifecycle: use, strategize, execute, diff, apply
- Verification of plan status and integrity
Exercises real LLM API integration using OpenAI GPT-4 model.
ISSUES CLOSED: #10812
- Remove unused `import ast` and fix `set_function_registry` to store
callable values directly instead of calling eval() on a function object
- Replace try/except/pass with contextlib.suppress (SIM105)
- Add strict=False to zip() call (B905)
- Wrap long line in execute_graph (E501)
- Use list unpacking in assert_topo_order_equals (RUF005)
- Fix keyword name: Remove hyphen from 'Non-Functional' (Python method
has no hyphen so Robot generates 'Non Functional')
- Rewrite Set Double And Increment Registry to evaluate lambdas directly
rather than iterating a list of tuples (which paired whole tuples as
loop variables instead of unpacking them)
- Pass node/function name lists via Robot list variables instead of
space-delimited positional args
ISSUES CLOSED: #9531
- Remove features/pure_graph_coverage.feature to resolve duplicate BDD scenarios
conflict with existing consolidated_langgraph.feature (lines 440-474) that was
introduced by prior consolidation commit 60887308. Duplicate scenario execution
causes unit_tests CI failure.
- Replace Robot Framework stub tests in robot/langraph/pure_graph.robot with real
PureGraph integration tests:
* Topological order verifies start/end boundaries and node sequence
* Function execution validates sequential transformation (double=1->2, increment=2->3)
* Missing function test confirms graceful skip behavior without exceptions
* Non-functional nodes verify pass-through semantics
- Create pure_graph_lib.py Robot Framework library module with proper keywords
for graph construction, topo order computation, and execution under test.
ISSUES CLOSED: #9531
Add comprehensive test coverage for PureGraph module:
- Created features/pure_graph_coverage.feature with BDD scenarios for topological ordering, function execution, missing function handling, and non-functional nodes
- Added robot/langgraph/pure_graph.robot with Robot Framework integration tests
- Created benchmarks/pure_graph_bench.py with ASV benchmarks for execution throughput and ordering performance
This addresses the test infrastructure gap identified in issue #9531 where PureGraph had orphaned step definitions but no feature file, and lacked integration and performance test coverage.
ISSUES CLOSED: #9531
Extends the budget utilization summary in `context show` to display
hot/warm/cold tier utilization percentages individually, satisfying
the spec requirement for a per-tier breakdown. Previously only hot
tier utilization was shown.
- Hot tier: tokens used vs. max_tokens_hot budget
- Warm tier: fragment count vs. max_decisions_warm budget
- Cold tier: fragment count vs. max_decisions_cold budget
Also updates Robot Framework helper to verify per-tier breakdown
is present in output, and updates CHANGELOG/CONTRIBUTORS.
ISSUES CLOSED: #9586
- Fix integration test failure: Context Show Validates Empty View Name
- typer.Exit is click.Exit (RuntimeError subclass), not SystemExit
- Robot helper now catches typer.Exit using exit_code attribute
- Helper path insertion now always places clone src at sys.path[0]
to prevent /app/src from shadowing the PR branch source
- Fix information disclosure: CleverAgentsError handler now logs
exception internally via _logger.exception() and shows generic
user-facing message instead of str(e)
- Fix budget utilization: use actual per-tier token counts instead
of hot_count * 100 (fragment count * arbitrary factor)
- Fix type safety: _remove_fragments now uses _TierServiceProtocol
instead of object, enabling proper static type checking
- Fix overly broad except: cancellation handled with early return
instead of catching typer.Exit(0) in the except block
- Add broad glob pattern warning when --path matches > 50 entries
- Remove duplicate HAL 9000 entry from CONTRIBUTORS.md
- Fix Behave steps to catch typer.Exit in addition to SystemExit
ISSUES CLOSED: #9586
The ACMS context CLI commands ('context show' / 'context clear') were fully
implemented in 'acms_context.py' with comprehensive tests, mocks, benchmarks,
and documentation — but the module was never imported or registered in
'cli/main.py'. This commit wires up the 'acms_context.app' Typer sub-app
so that 'agents acms context show' and 'agents acms context clear' are
actually accessible from the CLI.
Changes:
- Import acms_context in _register_subcommands()
- Register acms_context.app as the 'acms' sub-app on the main Typer app
- Add 'acms' to valid_cmds list in main() for fast-path validation
- Add 'acms context' entry to _print_basic_help() output
- Minor formatting cleanup applied by ruff
ISSUES CLOSED: #9586
Refs: #9675
- Rewrote production CLI to use real ContextTierService (get_scoped_view, get_all_fragments, evict_lru) instead of non-existent ACMSService
- Removed unused imports (Path, Panel, ScopedView) from production code
- Fixed all lint issues: trailing whitespace, import ordering, nested with statements
- Replaced typer.Abort() with typer.Exit(code=1) for error exits
- Added input validation for empty/whitespace view parameter
- Fixed error handling to use str(e) instead of e.message
- Added guards against negative budget values in _format_budget_utilization
- Added warning when clearing context with no filters (clear ALL)
- Removed module-level console side effect
- Moved mocks to features/mocks/acms_context_mocks.py per CONTRIBUTING.md
- Fixed test assertions to capture real CLI output (not placeholder)
- Fixed duplicate step definitions (AmbiguousStep errors)
- Fixed feature file step mismatch for tier count parameter
- Added Robot Framework integration tests in robot/acms_context_cli.robot
- Added performance benchmarks in benchmarks/acms_context_cli_bench.py
- Updated CHANGELOG.md with ACMS context CLI feature entry
- Updated CONTRIBUTORS.md with ACMS context CLI contribution
ISSUES CLOSED: #9586
HAL9000
brent.edwards
HAL9000
freemo
Repository Isolator