2746 Commits

This Branch

This Branch

All Branches

Author	SHA1	Message	Date
HAL9000	e6878c2c30	fix(audit): protect AuditService._ensure_session() with threading.Lock	2026-05-02 21:54:17 +00:00
HAL9000	3e85ff797d	chore(deps): remove duplicate langchain-anthropic dependency and clean up stale backup file ... - Remove duplicate langchain-anthropic>=0.2.0 from pyproject.toml dependencies - Remove stale robot/core_cli_commands.robot.backup file (not covered by gitignore) This cleanup eliminates a duplicate dependency declaration and removes an untracked backup file from the testing directory. ISSUES CLOSED: #0	2026-05-02 21:21:01 +00:00
freemo	bfdf946776	build: fixed permission to script access for health checks	2026-05-02 15:38:08 -04:00
freemo	ce396d2b43	build: reordered agent perms	2026-05-02 14:33:45 -04:00
freemo	6ee703fef5	script: disabled sequential thinking mcp	2026-05-02 14:11:55 -04:00
freemo	97ea5a26d8	script: reinforced auto-agent scripts	2026-05-02 14:02:26 -04:00
freemo	0f08f63b17	build: fixed minor duplicate perms	2026-05-02 14:02:26 -04:00
HAL9000	c3752e6dd3	fix(ci): add unit_tests to coverage job needs to prevent misleading parallel results ... The coverage job in ci.yml previously only depended on [lint, typecheck, security, quality], allowing it to run in parallel with unit_tests. This meant coverage could report a pass even when unit tests were still running or had already failed, wasting CI resources and producing misleading results. Adding unit_tests to the coverage job's needs list ensures coverage only starts after tests have passed, eliminating the redundant parallel test execution and making coverage results meaningful. ISSUES CLOSED: #10714	2026-05-02 01:36:49 +00:00
HAL9000	83acee552e	chore: close stale automation tracking issues ... Closes #10040 Closes #10041 Closes #10049 Closes #10055	2026-05-02 01:36:46 +00:00
HAL9000	9b9bb80e05	fix(container): remove devcontainer-file from CONTAINER_RESOURCE_TYPES ... devcontainer-file is a read-only config file resource, not a running container. Including it in CONTAINER_RESOURCE_TYPES causes validate_container_available() to return True when only a config file is linked, even though no actual container is available. Closes #10598	2026-05-02 01:36:45 +00:00
freemo	9632ea55dd	build: trying new qwen instruct model instead	2026-05-01 20:03:27 -04:00
freemo	bdcc44cb09	build: read and write permissions set seperate edit since read seems to be getting denied as does write	2026-05-01 17:58:29 -04:00
freemo	3a6d42ee79	build: fixed some bad permissions and no longer require prompt to be written to a file for supervisors	2026-05-01 17:45:27 -04:00
freemo	9b34d47371	build: new models	2026-05-01 16:32:39 -04:00
HAL9000	0767e55bd3	fix(acms): make large-project hydration timeout CI-environment-aware ... Replace the hard-coded 60-second wall-clock limit with an environment- variable-controlled value (LARGE_IDX_TIMEOUT, default 120 s). On CI runners with many parallel Behave workers the runner is under heavy load and legitimate indexing of 1,000 files (the CI-reduced fixture count) can exceed the old 60-second limit, causing false timeout failures in the unit_tests job while the sequential coverage_report job passes. ISSUES CLOSED: #8726	2026-05-01 09:10:48 +00:00
HAL9000	b55900e818	format(acms): apply ruff formatting to large-project index steps ... Run nox -s format which reformatted the BDD step definitions to conform to the project ruff style rules. ISSUES CLOSED: #10018	2026-05-01 09:10:48 +00:00
HAL9000	93324e4d91	perf(acms): make large-project fixtures CI-friendly by reducing file count when CI=true ... The 10,000-file fixture per scenario was causing CI timeouts when running in parallel with 32 workers. This adds CI-aware fixture creation that reduces the actual file count to 1,000 when the CI env var is set, while keeping the logical test assertions against 10,000 files. The fix also adds _NUM_DIRS constant for cleaner subdirectory calculation, imports os for environment variable access, and makes the mixed fixture CI-aware. Changes: - features/steps/acms_large_project_index_steps.py: CI-aware file count, os import, _NUM_DIRS constant - CHANGELOG.md: already updated in previous commit Closes #8726	2026-05-01 09:10:48 +00:00
HAL9000	c38ff6bbc4	test(acms): add BDD coverage for 10,000+ file project indexing without timeout	2026-05-01 09:10:48 +00:00
HAL9000	739f7a17ad	test(acms): add BDD coverage for 10,000+ file project indexing without timeout ... Added a Behave feature file and complete step definitions that validate the context tier hydrator can index projects with 10,000+ files without timing out. Covers both the git ls-files (30-second timeout) path and the os.walk fallback path, as well as binary file filtering and oversized file skipping. Satisfies the v3.4.0 milestone acceptance criterion: "Projects with 10,000+ files index without timeout." ISSUES CLOSED: #8726	2026-05-01 09:10:48 +00:00
hurui200320	5580d07419	fix(ci): fix uv install syntax	2026-05-01 03:04:09 +00:00
freemo	b81c296a2b	build: fixed model settings	2026-04-30 21:25:47 -04:00
HAL9000	80bc9c552d	test: restore and enhance e2e test coverage ... Fix malformed imports in helper_m1_e2e_verification.py and helper_m4_e2e_cli.py where 'from helpers_common import reset_global_state' was incorrectly inserted inside a parenthesized import block, causing Python syntax errors and breaking the lint and unit_tests CI gates. Also fix import ordering in helper_m2_e2e_verification.py, helper_m5_e2e_context.py, helper_m5_e2e_support.py, and helper_m5_e2e_verification.py to satisfy ruff I001 import-sort rules by placing helpers_common imports in the correct group alongside other local robot/ helper imports. ISSUES CLOSED: #8459	2026-05-01 00:59:02 +00:00
HAL9000	7aa50ac489	fix(e2e): restore M5/WF14 tests broken by JSON envelope and stale config ... - Add NO_COLOR=1 to E2E Suite Setup and Test Environment to prevent Rich from injecting ANSI escape codes into JSON output, which breaks Extract JSON From Stdout and JSON assertions in M5/WF14 acceptance tests. - Add reset_global_state() calls to all M1/M2/M4/M5 E2E verification helpers to clear Settings singleton, DI container, provider registry, and SQLAlchemy engine cache between parallel pabot worker runs. - Propagate NO_COLOR=1 at suite-setup level in E2E and integration test resource files so all Run Process subprocesses inherit clean terminal output mode. Root causes: 1. Missing NO_COLOR=1 caused Rich ANSI codes in CLI JSON output, making json.loads() failures in robot Extract JSON From Stdout 2. Stale Settings singleton carried provider keys and DB paths between pabot workers, causing UNIQUE constraint violations and stale config lookups in context policy and server mode E2E tests. Related: PR #9912	2026-05-01 00:59:02 +00:00
freemo	816c16901b	build: fixed uncensored model	2026-04-30 20:02:13 -04:00
freemo	516c600c0e	build: updated and rename hosted models	2026-04-30 19:47:54 -04:00
freemo	8a2e7cda10	build: Updated availible endpoints	2026-04-30 18:28:38 -04:00
HAL9000	4351848c51	fix(tui): extract _FALLBACK_BLOCK_WIDTH constant in LoadingThrobber ... Replace magic number 30 with class constant _FALLBACK_BLOCK_WIDTH per reviewer recommendation. No functional change. ISSUES CLOSED: #6357	2026-04-30 20:52:27 +00:00
HAL9000	90b6b2a43f	fix(tui): fix Throbber Rejects Invalid Styles test indentation and add CHANGELOG entry ... Use Fix Python Indentation + temp file in robot/tui_throbber.robot to correctly reconstruct indentation stripped by Robot Framework's Catenate keyword in the Throbber Rejects Invalid Styles test case. Add indentation_library.py to the suite's Library imports. Add CHANGELOG.md fix entry for #6357. ISSUES CLOSED: #6357	2026-04-30 20:52:27 +00:00
HAL9000	7be0078963	fix(tui): narrow exception handling and add test tags to throbber widget	2026-04-30 20:52:19 +00:00
HAL9000	f3ba86a520	fix(tui): restore LoadingThrobber widget and tui_throbber robot tests ... The LoadingThrobber widget and its associated Robot Framework integration tests were developed on the feat/issue-6357-tui-loading-states branch but were never merged to master. This commit restores: - robot/tui_throbber.robot: Integration tests for the LoadingThrobber widget covering show/hide cycle, style switching, and invalid style rejection - src/cleveragents/tui/widgets/throbber.py: The LoadingThrobber implementation with rainbow and quotes animation styles - src/cleveragents/tui/quotes.py: Quote loader module for the throbber - src/cleveragents/tui/data/throbber_quotes.txt: Curated quote collection The failing test 'Throbber Rejects Invalid Styles' in robot/tui_throbber.robot was identified by UAT testing [AUTO-UAT-3] as failing because the production code (LoadingThrobber) was missing from master while the test file was expected to be present. ISSUES CLOSED: #6357	2026-04-30 20:52:19 +00:00
freemo	1691def164	build: Moved to using new default qwen instance	2026-04-30 16:12:38 -04:00
HAL9000	b747f1aab1	style: reformat cli_main_cov3_steps.py for ruff ... The get_err_console patch.object call was being split across lines in a way ruff did not approve; format it the way ruff expects.	2026-04-30 19:40:33 +00:00
HAL9000	7db9fd1ab2	fix(test): evict sys.modules cache in _register_subcommands import error test	2026-04-30 19:40:33 +00:00
HAL9000	f27a21d0bb	fix(correction): implement actual undo logic in _rollback_completed_actions ... The _rollback_completed_actions method was a no-op that only logged actions without actually performing any undo operations. This breaks the atomic cascade guarantee described in its docstring. When a cascade fails mid-way, _rollback_completed_actions is now called in reverse order. For actions that rolled back a sandbox (sandbox_rolled_back=True), the sandbox is re-rolled-back to ensure it's left in a clean state before logging. This call is idempotent since sandbox rollback is designed to be safe to call on already clean sandboxes. This restores the atomicity guarantee: all completed actions are properly undone on failure, not just logged.	2026-04-30 19:16:01 +00:00
HAL9000	902a86723f	fix(cross-plan-correction): implement actual undo logic in _rollback_completed_actions to restore atomic cascade guarantee ... The _rollback_completed_actions method was only logging rollback intent but never actually performing undo operations. On cascade failure, completed actions were left in an applied state, violating the atomic cascade guarantee documented in the service docstring. For each completed action in reverse order, the rollback handler now: - Re-cancels the child plan (idempotent: cancelling an already-cancelled plan is a safe no-op). - If sandbox_rolled_back is true, also rolls back the sandbox. Individual rollback step failures are logged and do not prevent other rollback steps from being attempted (best-effort). ISSUES CLOSED: #9435	2026-04-30 19:16:01 +00:00
HAL9000	7ece6f1530	docs(spec): rename checkpoint triggers on_tool_write → before/after_tool_execute ... Update the Automatic Checkpoint Triggers table and configuration reference in docs/specification.md to use the trigger names that match the actual implementation in ToolRunner and config_service.py: - on_tool_write → before_tool_execute - on_tool_write_complete → after_tool_execute The implementation (PR #3474) chose before_/after_ prefix pattern for consistency with event naming conventions and because _execute is more precise than _write. The spec was not updated at that time. ISSUES CLOSED: #4745	2026-04-30 17:48:19 +00:00
HAL9000	66bd3bf0cf	fix(tui): set default THEME to dracula on TUI app class ... The _TextualCleverAgentsTuiApp class was missing the THEME class variable, causing Textual to use its default textual-dark theme instead of the Dracula theme required by the spec (docs/specification.md §TUI Theme). Added THEME: ClassVar[str] = "dracula" to the class and a corresponding BDD scenario tagged @tdd_issue @tdd_issue_4742 to verify the fix. ISSUES CLOSED: #4742	2026-04-30 15:36:26 +00:00
hamza.khyari	435d63c64b	Merge pull request 'fix(plan): preserve strategy_decisions_json in error_details during execute and report actual actor mode' (#10945) from bugfix/executor-error-details-overwrite into master ... Reviewed-on: #10945 Reviewed-by: HAL9001 <hal9001@cleverthis.com> Reviewed-by: HAL 9000 <HAL9000@cleverthis.com>	2026-04-30 15:13:28 +00:00
HAL9001	86e1cdf6ae	fix(plan): apply merge pattern to _run_execute_with_runtime and improve docstring ... - Apply error_details merge pattern to _run_execute_with_runtime for consistency with _run_execute_with_actor (preserves strategy_decisions_json in runtime mode too) - Expand _run_execute_with_actor docstring to clarify retry is controlled by ErrorRecoveryService.max_retries Addresses remaining review findings from PR #10945.	2026-04-30 14:56:33 +00:00
hamza.khyari	a740d9c15a	fix: address PR review findings - narrow exception scope and fix test mocks ... Address CoreRasurae's review comments: 1. Narrow exception scope in _build_decisions (line 846) to catch only json.JSONDecodeError and ValidationError instead of bare Exception. This prevents swallowing unintended errors like memory issues. 2. Update feature file section header and scenario titles from _run_execute_with_stub to _run_execute_with_actor for consistency. 3. Add spec to MagicMock in failing execute scenario (line 138) to match the pattern used in succeeding scenario (line 119). Note: Master feature entry point - Behave auto-discovers all .feature files, no explicit entry point needed. Tests run successfully. ISSUES CLOSED: #10874	2026-04-30 14:56:33 +00:00
HAL9001	9e3d7c6622	fix(plan): preserve strategy_decisions_json in error_details during execute and report actual actor mode ... Merge error_details instead of replacing them in _run_execute_with_actor (formerly _run_execute_with_stub), preserving strategy_decisions_json stored by run_strategize. On execute retry, _build_decisions now finds the full decision hierarchy instead of falling back to definition_of_done parsing. - Merge error_details on both success and failure paths - Report type(self._execute_actor).__name__ instead of hardcoded 'stub' - Rename _run_execute_with_stub to _run_execute_with_actor - Add 4 Behave scenarios verifying preservation and mode reporting ISSUES CLOSED: #10874	2026-04-30 14:56:33 +00:00
HAL9000	d7f03ee0a6	docs: add CHANGELOG.md and CONTRIBUTING.md to docs tree ... Add mirrored versions of root CHANGELOG.md and CONTRIBUTING.md to the docs tree. Add migration headers noting these are mirrors of the authoritative root files. Update mkdocs.yml navigation to include both new pages between FAQ and Reference.	2026-04-30 14:26:39 +00:00
hurui200320	8dc55655e9	feat(actor): make built-in actors virtual, resolved on-demand from provider registry ... Replace the DB-persistence approach for built-in actors with in-memory virtual resolution. Built-in actors (e.g. openai/gpt-4o, anthropic/claude-sonnet) are now resolved on-demand from ProviderRegistry at query time and merged with persisted custom actors — no database writes occur for built-in actors. Key changes: - Add ActorRegistry._resolve_virtual_builtin_actors(): generates virtual Actor objects in-memory from configured providers (is_built_in=True, id=None) - ActorRegistry.list()/list_actors(): merges virtual built-ins with custom DB actors; custom actors win on name collision; result sorted alphabetically - ActorRegistry.get()/get_actor(): DB-first, virtual built-in fallback, NotFoundError if neither - ActorRegistry.remove()/remove_actor(): rejects virtual built-in names with ValidationError - ActorRegistry.set_default_actor(): stores only the actor name string via new actor_preferences singleton table; no actor row created for virtual built-ins - ActorRegistry.get_default_actor(): reads preference name, resolves via DB→virtual chain, returns actor with is_default=True - Remove ensure_built_in_actors() entirely — 20+ call sites cleaned up including plan.py - Remove ActorRepository.upsert_built_in() — no longer needed - Remove is_built_in from ActorModel DB column (kept on Actor domain model for virtual actors) - New Alembic migration m10_001_virtual_builtin_actors: drops is_built_in column, adds actor_preferences singleton table - Add ActorService.set_default_actor_name() and get_default_actor_name() for preference storage without requiring a DB actor row - Update 15+ Behave step files and 5 feature files; add new features/virtual_builtin_actors.feature with 8 scenarios covering list, show, remove, set-default, get-default, no-DB-writes guarantees - Rewrite tests/actor/test_registry_builtin_yaml.py: TestEnsureBuiltInActorsWithYaml → TestResolveVirtualBuiltinActors plus new TestListActors, TestGetActor, TestRemoveActor, TestDefaultActor test classes Quality gates: lint ✓, typecheck ✓, unit_tests ✓ (15674 scenarios), coverage ✓ (97.10%), integration_tests ✓ (1997 tests) ISSUES CLOSED: #10923	2026-04-30 10:56:21 +00:00
hamza.khyari	b04b9ba56e	Merge pull request 'fix(plan): only cleanup worktree sandbox on execute failure, not success' (#10873) from bugfix/sandbox-cleanup-on-failure-only into master ... Reviewed-on: #10873 Reviewed-by: HAL 9000 <HAL9000@cleverthis.com>	2026-04-30 10:21:38 +00:00
HAL9001	1789f6323b	fix(plan): only cleanup worktree sandbox on execute failure, not success ... Replace unconditional sandbox cleanup in execute_plan's finally block with conditional cleanup gated on an explicit execute_succeeded flag. On success the worktree branch survives until plan apply merges it into the project (spec §13256-13260). - Add execute_succeeded flag set after successful execution - Guard finally-block cleanup with 'if not execute_succeeded' - Remove unused _commit_exc variable in _commit_worktree_changes - Add BDD test scenarios (sandbox_cleanup_conditional.feature) ISSUES CLOSED: #10872	2026-04-30 10:03:08 +00:00
HAL9000	87f44e556a	chore(agents): fix ca-test-infra-improver health comment spam ... Replace fragile cycle-modulo health posting guard with timestamp-based approach and state-change-only posting. The inner monitoring loop no longer posts health comments — posting is gated by a 10-minute timer OR meaningful state changes (worker completion, dispatch events). Approved proposal: #3385 Pattern: workflow_fix Evidence: Agent posted 44 of 52 session comments in 20 minutes, all identical, drowning out other agent signals. Fix: Timestamp-based health posting with state-change triggers.	2026-04-30 08:15:32 +00:00
freemo	602d56f347	chore(agents): fix ca-test-infra-improver health comment spam ... Approved proposal: #3385 Pattern: workflow_fix Evidence: Agent posted 44 of 52 comments in 20 minutes, drowning out all other agent signals. The cycle % 60 guard was ambiguous and ignored by the model. Fix: Replace fragile modulo guard with explicit timestamp-based rate limiting (10-minute minimum between health posts). Add prominent CRITICAL warning about rate limiting. Clarify that health posting runs in the outer loop, not the inner monitoring loop. ISSUES CLOSED: #3385	2026-04-30 08:15:32 +00:00
HAL9000	3222fab6a4	feat(invariants): implement agents invariant remove CLI command ... Implements the agents invariant remove CLI command with full specification compliance. The command allows users to remove invariants from agents with a confirmation prompt displaying the invariant ID before removal. The implementation includes support for format options (JSON/YAML) and a --yes flag to bypass confirmation. The invariant remove command: - Soft-deletes an invariant by ID via InvariantService.remove_invariant() - Displays confirmation prompt before removal (bypassable with --yes/-y) - Outputs the removed invariant ID on success - Shows clear error message for unknown invariant IDs (NotFoundError) - Supports --format flag for JSON and YAML output Full BDD test coverage in features/invariant_cli_new_coverage.feature and Robot Framework integration tests in robot/invariant_cli.robot verify all acceptance criteria from issue #8530. ISSUES CLOSED: #8530	2026-04-30 06:26:48 +00:00
hurui200320	caf146e132	fix(actor): resolve provider from explicit field in v3 YAML before inferring from model ... Two bugs prevented built-in LLM actors from working with models that lack a '/' separator (e.g. claude-sonnet-4-20250514): 1. _generate_builtin_actor_yaml (actor/registry.py) was constructing the model field as '{provider}/{model}' (e.g. 'anthropic/claude-sonnet-4-20250514'). The Anthropic API expects just the bare model ID, causing 404 errors. Fixed by using the bare model identifier and lowercasing the provider field to match ProviderType enum values. 2. _build_from_v3 (reactive/config_parser.py) always inferred the provider from the model string via infer_provider_from_model(). For models without a '/' separator this returned 'custom', an invalid ProviderType, causing 'Unknown provider type: custom' at runtime. Fixed by checking for an explicit top-level 'provider' field in the v3 YAML data (per spec resolution order step 2) before falling back to inference. As a side effect, these fixes also resolve issue #10861: agents actor run now successfully invokes the LLM when using built-in actors. The @tdd_expected_fail tag has been removed from features/tdd_actor_run_response.feature accordingly. New BDD scenarios added to features/builtin_actor_v3_yaml.feature and features/actor_v3_route_synthesis.feature validate both fixes and the fallback inference behaviour for models with '/' separators. All quality gates pass: lint, typecheck, 671 feature files (15673 scenarios), 1997 Robot integration tests, coverage 97.12%. ISSUES CLOSED: #10926	2026-04-30 02:05:12 +00:00
HAL9000	0ade2526eb	docs(cli): update agents validation attach synopsis to use --key value named option format ... Update docs/specification.md to clarify that agents validation attach extra arguments use --key value named option format (not positional [<ARGS>...] format). Updates synopsis, argument description, and all inline references across the specification. ISSUES CLOSED: #4747	2026-04-29 17:08:17 +00:00