394 Commits

Author	SHA1	Message	Date
HAL9000	6a4a49158c	fix(cli): address review feedback on docstring example validator ... - Fix error suppression in validate_all_commands: log at DEBUG level instead of silently swallowing exceptions - Fix multi-word command name parsing bug: use command_token_count to skip the full command prefix when extracting positional values - Add @cli tag to features/cli_docstring_example_validation.feature - Update CONTRIBUTING.md with CLI docstring example style guide - Update CHANGELOG.md with entry for automated docstring validation - Update CONTRIBUTORS.md with contribution entry - Fix test design flaws: separate Given/When/Then steps per scenario - Add validate_all_commands test coverage via new Behave scenario - Fix _extract_positional_args to only count required positional args	2026-06-02 14:01:59 -04:00
HAL9000	ab18e81e4a	refactor(actor): add return type to _get_services and remove bare except clauses ... - Add return type annotation tuple[Any, Any | None] to _get_services() - Fix _load_config_text() to catch yaml.YAMLError and TypeError instead of ValueError/AttributeError around yaml.safe_load(), preserving the user-friendly typer.BadParameter message for malformed YAML input - Fix _compute_actor_impact() defensive guards to also catch CleverAgentsError, OperationalError, and ValidationError in addition to AttributeError/RuntimeError, keeping actor removal resilient when the database layer is unavailable - Update CHANGELOG.md with entry under Changed section for issue #8567 - Add features/actor_exception_handling.feature with four Behave scenarios covering the exception handling contract changes - Add features/steps/actor_exception_handling_steps.py with step definitions ISSUES CLOSED: #8567	2026-06-02 08:44:47 -04:00
HAL9000	bf6326b715	test(plan-correct): remove @tdd_expected_fail now bug #8584 is fixed ... The plan correct --format json output already nests correction fields under data.correction and sets command to "plan correct" via format_output, so the three BDD scenarios now pass against the current implementation. Remove the @tdd_expected_fail inversion tag so CI reports them as passing, not as unexpected-pass failures. Updated CHANGELOG.md and CONTRIBUTORS.md. ISSUES CLOSED: #8584	2026-06-02 07:19:20 -04:00
HAL9000	d54ed1440c	fix(engine_cache): guard MEMORY_ENGINES with lock to prevent TOCTOU race ... Add MEMORY_ENGINES_LOCK to engine_cache.py and wrap the check-and-set in UnitOfWork.engine with it to prevent concurrent threads from creating duplicate in-memory SQLite engines. Also fix cache-hit bug where self._engine was never assigned on a cache hit. Closes #7566	2026-06-02 05:51:55 -04:00
HAL9000	0dcf7bf152	fix(plan-lifecycle): gate Apply phase on Definition-of-Done evaluation ... Before transitioning to the Apply phase, PlanLifecycleService.apply_plan now evaluates the plan's definition_of_done criteria using DoDEvaluator (TextMatchEvaluator). If any required criteria fail, a DoDGatingError is raised and the plan remains in Execute/COMPLETE state. The evaluation result is stored in plan.validation_summary with dod_evaluated=True and dod_all_passed reflecting the outcome. Plans with no DoD text skip evaluation and proceed normally. Adds DoDGatingError exception class and _evaluate_dod() helper method. Adds BDD feature file and step definitions for DoD gating scenarios. ISSUES CLOSED: #7927	2026-06-02 05:14:43 -04:00
HAL9000	f7901c404f	fix(actor): move namespace filter inside lock in ActorLoader.list_actors ... Fixes a race condition (TOCTOU) in ActorLoader.list_actors() where the namespace filter was applied outside the threading lock, creating a window for concurrent dictionary modifications. Moving the filter inside the with self._lock: block ensures atomic reads and filtering. - Move namespace filtering inside the RLock in list_actors() - Add concurrency BDD test (threading.Barrier) for list_actors + clear race condition - Update CHANGELOG.md with fix entry (closes #8588) - Update CONTRIBUTORS.md with contribution details ISSUES CLOSED: #8588	2026-06-02 04:52:51 -04:00
HAL9000	2609787d35	fix(concurrency): fix ValidationPipeline.run() sys.stdout replacement #7623 ... Introduce a reference-counted shared stream wrapper manager so concurrent ValidationPipeline.run() calls correctly restore the true sys.stdout/stderr after all pipelines finish. - Add _install_thread_local_streams() / _release_thread_local_streams() protected by threading.Lock; first caller saves originals and installs wrappers, last caller restores them - Remove io.TextIOBase inheritance from _ThreadLocalStream to avoid Python 3.13 read-only slot conflict; use cast(TextIO, ...) at assignment sites - encoding property returns str | None matching io.TextIOBase signature - Replace assert guards with explicit RuntimeError fail-fast checks - Add Behave scenario: Concurrent pipelines restore global streams after execution - Split validation_pipeline_steps.py (547→428 lines) by extracting MockValidationExecutor to _validation_pipeline_mock.py and edge-case steps to validation_pipeline_edge_steps.py - Update CHANGELOG.md and CONTRIBUTORS.md ISSUES CLOSED: #7623	2026-06-02 04:29:20 -04:00
HAL9000	8ebd922e77	docs(specification): add deleted_at field to agents project delete JSON/YAML output ... Updated docs/specification.md to document the correct JSON/YAML output structure for the project delete command, replacing the legacy deletion_summary object with the deleted, success, and deleted_at fields that match the actual implementation introduced in PR #6639. Added BDD feature file and step definitions to validate the output format. ISSUES CLOSED: #7872	2026-06-02 04:09:01 -04:00
HAL9000	7859a6c05b	fix(alembic): handle fileConfig parsing errors with user-friendly diagnostic (#7874) ... Wrapped the `fileConfig()` call in `src/cleveragents/infrastructure/database/migrations/env.py` with a `try/except` block that catches malformed INI logging configuration and emits a clear, user-actionable error message to stderr before exiting with code 1. Includes: - Error handling guard around fileConfig() in env.py (fileConfig can raise configparser.Error, KeyError, ValueError on malformed logging config) - BDD/Behave feature file with 4 scenarios under `features/` - Step definitions in `features/steps/` for isolated test coverage - CHANGELOG.md entry under [Unreleased] Fixed section - CONTRIBUTORS.md update for HAL 9000 ISSUES CLOSED: #7874 Signed-off-by: CleverThis <hal9000@cleverthis.com>	2026-06-02 03:39:50 -04:00
HAL9000	3577bf95ba	feat: implement automation profile precedence chain plan action global ... Implementation of the four-level automation profile precedence chain (plan > action > project > global) as defined in the v3.5.0 specification. Core implementation (src/): - PrecedenceSource StrEnum with PLAN, ACTION, PROJECT, GLOBAL levels - PrecedenceResolution frozen dataclass capturing full resolution state - resolve_precedence_chain() with plan > action > project > global logic - _resolve_global_profile() with explicit > env var > default fallback - Comprehensive debug logging for observability BDD tests (features/): - automation_profile_precedence_chain.feature: 30 scenarios covering all 16 combinations of plan/action/project/global configurations plus edge cases, logging verification, enum values, env var override, and custom registry - step definitions with proper log handler cleanup via context._cleanup_handlers CI compliance fixes (bd8b6748): - ruff format applied to step definitions (fixes CI lint gate) - CHANGELOG.md updated with accurate 4-level chain description - test_reports/ artifacts removed; directory added to .gitignore - tdd_a2a_sdk_dependency.feature reverted to use correct Client import ISSUES CLOSED: #8234	2026-06-02 01:25:33 -04:00
HAL9000	9854b2c7cc	chore: add CHANGELOG.md and CONTRIBUTORS.md entries for tracking prefix fix (#7891) ... Added missing CHANGELOG.md entry under [Unreleased] > Fixed section documenting the AUTO-REV-POOL to AUTO-REV-SUP tracking prefix alignment for the pr-review-pool-supervisor agent. Added CONTRIBUTORS.md entry crediting HAL 9000 for the tracking prefix documentation fix (#7891). ISSUES CLOSED: #7891	2026-06-02 00:58:16 -04:00
HAL9000	a38cb5c317	fix(uat-tester): remove one-shot script and batch examples.json update ... - Delete scripts/fix_uat_tester.py: one-off patch script with a hardcoded /tmp path that no longer exists. Per CONTRIBUTING.md, scripts/ is for ongoing-purpose utilities, not development artifacts. - Remove update_examples_json() from create_documentation_pr(): each per-PR call was modifying examples.json inside the git clone, causing merge conflicts when parallel UAT workers created docs PRs simultaneously. Option A from reviewer: move the call outside the PR creation function entirely. - Add batch update_examples_json(documented_examples) call after the inner docs-PR creation loop completes, guarded by `if documented_examples`. This runs once per cycle instead of once per PR, eliminating the examples.json conflict surface for parallel workers. - Expand CHANGELOG entry to reflect the examples.json fix. ISSUES CLOSED: #4374	2026-06-01 01:07:53 -04:00
HAL9000	6116236c71	fix(agents): resolve PR lint failures and changelog for #5768 ... Fixed lint errors in fix_uat_tester.py (unused import, string concatenation). Added CHANGELOG entry per CONTRIBUTING.md requirements. Closes #5768	2026-06-01 01:07:53 -04:00
HAL9000	c9b274a925	fix(cli): emit JSON envelope messages for session list/show/delete/export/import ... The session create command already emitted a spec-compliant JSON envelope with messages[].text populated, but list, show, delete, export, and import did not — they either passed no `messages` to `format_output()` (producing an envelope with an empty messages array) or short-circuited to a Rich-styled `console.print(...)` line that breaks JSON parsing entirely. Failing scenarios in features/session_cli.feature (unit_tests gate) asserted `messages[0].text == "<command-specific success>"`. Wire each command's machine-readable path to emit a structured envelope with the expected message: - list (empty) → "0 sessions listed" - list (populated) → "<N> sessions listed" - show → "Session details loaded" - delete --format json|yaml|plain → "Session deleted" - export --output-format json|yaml|plain → "Export completed" - import --format json|yaml|plain → "Import completed" The export command gains a new `--output-format` flag distinct from the existing `--format` (which selects export content format: json or md). When the new flag is non-rich, the raw export content is suppressed from stdout so the envelope remains the only thing emitted, and Rich panels are skipped. The import command gains a `--format` flag. The delete command already had a `--format` option but its non-rich branch emitted Rich-styled text instead of an envelope; that branch now splits cleanly: `--format color` keeps the human-readable line, and json/yaml/plain emit an envelope. Also addresses the `Session create initializes MCP logger` and `Session list initializes MCP logger` scenarios in features/session_cli_mcp_logger_simple_execution.feature, which inspect the create()/list_sessions() source via inspect.getsource() and assert the literal string `logging.getLogger(_MCP_LOGGER_NAME)` appears. Both functions held the inlined literal `"cleveragents.mcp"` instead of the module-level `_MCP_LOGGER_NAME` constant; substitute the constant reference in both call sites. CHANGELOG entry extended to document the envelope coverage across all session commands. ISSUES CLOSED: #6441	2026-06-01 00:40:59 -04:00
HAL9000	fba9cbf8d1	fix(cli): resolve session export test assertion and move get_container to top-level import ... - Fix `security_template_coverage_boost.feature` assertion for "Session export to stdout outputs JSON": the export path outputs raw JSON with a `session_id` key, not a `data` envelope, so revert the erroneous `"data"` assertion back to `"session_id"`. - Move all deferred `from cleveragents.application.container import get_container` imports in session.py to the module-level import block, consistent with every other CLI command file (action.py, actor.py, config.py, plan.py, etc.). No circular import exists. - Update `session_cli_uncovered_branches_steps.py` to patch `cleveragents.cli.commands.session.get_container` directly (the correct target after a top-level import) instead of replacing `sys.modules["cleveragents.application.container"]`. - Add CHANGELOG.md entry for the session create JSON envelope fix. ISSUES CLOSED: #6441	2026-06-01 00:40:59 -04:00
HAL9000	565263ab24	fix(cli): fix project context show test mock for tier service ... Add ContextTierService mock to step_m5_invoke_project_context_show so the CLI command can call _get_context_tier_service() without failing. Also patch _load_policy_json to prevent JSON decode errors from MagicMock session objects. Update CHANGELOG.md and CONTRIBUTORS.md. ISSUES CLOSED: #6323	2026-05-31 20:45:10 -04:00
HAL9000	b1bfaf032e	fix(cli): fix JSON/YAML envelope messages[].text for delete/export/import ... Extend the JSON/YAML envelope messages[].text fix to cover the remaining three session subcommands that were still producing plain Rich output instead of structured envelopes for non-rich format paths: - session delete: route non-rich formats through format_output() with messages=[{"level": "ok", "text": "Session deleted"}] - session export: add --output-format/-f option; emit structured envelope with session_export/contents/integrity data and "Export completed" message - session import: add --format/-f option; emit structured envelope with session_import/validation/merge data and "Import completed" message Also add BDD scenarios to features/session_cli.feature for each new envelope path, add corresponding step definitions, add CHANGELOG entry under [Unreleased] Fixed, and assign milestone v3.2.0 to the PR. ISSUES CLOSED: #6457	2026-05-31 19:27:43 -04:00
HAL9000	d95873b446	docs: update CHANGELOG for --url flag support	2026-05-31 15:39:36 -04:00
HAL9000	e884dce240	Add CHANGELOG entry for resource removal guard fix (bug #6886) ... The PR was missing the required changelog documentation under [Unreleased] ### Fixed Signed-off-by: CleverThis <hal9000@cleverthis.com>	2026-05-31 13:33:31 -04:00
HAL9000	bc64074036	docs: add tool and validation management showcase ... - document the CLI workflow for registering tools, wrapping validations, and querying registry metadata - index the new example in docs/showcase/examples.json - re-enable coverage threshold regression checks by removing obsolete tdd_expected_fail tags ISSUES CLOSED: #4565 Refs: #4305 Refs: #4227	2026-05-30 17:21:55 -04:00
HAL9000	b8eab7c032	fix(resources): delete executable.yaml, fix resource list columns, update docs ... - Delete examples/resource-types/executable.yaml (orphaned artifact referencing non-existent ExecutableHandler; flagged in 4 prior reviews as blocking) - Update agents resource list CLI columns from [ID, Name, Type, Status, Kind, Location, Description] to spec-required [Name, ID, Type, Phys/Virt, Children, Projects] per specification line 11051 - Lifecycle state for container resources now shown as a note below the table - Update resource_list_lifecycle_state.feature to remove Status column header assertions; add spec-column header scenario - Add BDD scenario in resource_cli.feature verifying new column headers - Update CHANGELOG.md and CONTRIBUTORS.md ISSUES CLOSED: #3077	2026-05-30 15:43:56 -04:00
HAL9000	b65f0db8d0	fix(cli): add Read-Only and Writes columns to tool list output ... - Apply ruff format to tool.py (flatten single-line namespaces.add call) - Add Behave BDD tests verifying 5-column table, capability rendering (checkmark/dash), and Summary panel presence - Add CHANGELOG.md entry ISSUES CLOSED: #1476	2026-05-30 03:33:08 -04:00
HAL9000	30f8c81a33	fix(actor): add changelog, contributors and benchmark fix for issue #1429 ... ISSUES CLOSED: #1429	2026-05-30 02:07:41 -04:00
HAL9000	02e51b9298	fix(actor): fix lint errors and add regression tests for lsp_binding field (#1432) ... - Remove trailing whitespace from blank lines in _extract_lsp_bindings() (W293 at lines 160, 164, 167, 172, 183, 188, 203) - Simplify over-long line 180 (E501): auto_detect=node.lsp_binding.auto - Add Behave scenario verifying NodeLspBinding typed field populates CompilationMetadata.lsp_bindings (features/actor_lsp_binding_field.feature) - Add corresponding @given step using NodeLspBinding in actor_compiler_steps.py - Add Robot Framework regression test case and lsp-binding-field helper command confirming node.lsp_binding is read by compile_actor() - Update CHANGELOG.md and CONTRIBUTORS.md ISSUES CLOSED: #1432	2026-05-30 00:36:20 -04:00
HAL9000	6a76ea894d	test(cli): add TDD regression tests for automation_profile._get_service() DI bypass ... Three BDD scenarios and two Robot Framework integration tests verifying that _get_service() in automation_profile.py resolves AutomationProfileService through the DI container rather than manually calling create_engine or sessionmaker (bug #990). Bug #990 was fixed by PR #1181 before this TDD test PR merged; the @tdd_expected_fail tag is therefore absent and these tests serve as permanent regression guards confirming the fix remains in place. ISSUES CLOSED: #1031	2026-05-29 15:26:47 -04:00
freemo	b5f56a6fb8	feat(server): team collaboration features ... Implemented multi-user connection handling with user identity tracking (TeamMember with owner/admin/member/viewer roles), role-based access control (TeamPermission with read/write/admin/manage_members), concurrent session support (SessionRegistry with thread-safe locking and per-user/ per-project queries), and optimistic-locking conflict resolution (VersionStamp with last-writer-wins, reject, and merge strategies). Added TeamCollaborationService as the central orchestrator for all collaboration operations: team membership management, permission enforcement, session lifecycle, and version-stamp conflict detection/ resolution. The service cleans up user sessions when members are removed. Domain models follow existing patterns: Pydantic BaseModel with ConfigDict, StrEnum enums, ULID identifiers, and an error hierarchy rooted in TeamCollaborationError. Includes 48 Behave BDD scenarios (178 steps) covering all models, service operations, and edge cases, plus 15 Robot Framework integration tests for end-to-end workflow validation. ISSUES CLOSED: #863	2026-05-29 05:08:08 -04:00
freemo	c6ccb85bb8	feat(server): ASGI endpoint via uvicorn ... Implement FastAPI-based ASGI application served by uvicorn for the CleverAgents server mode. Add health check endpoint, A2A JSON-RPC routing, configurable host:port binding, and graceful shutdown handling. Server launches via `agents server start`. - Add FastAPI ASGI app factory at infrastructure/server/asgi_app.py with /.well-known/agent.json (Agent Card), /health (liveness), and /a2a (A2A JSON-RPC 2.0 dispatch via A2aLocalFacade) - Add ServerLifecycle class at infrastructure/server/server_lifecycle.py wrapping uvicorn.Server with SIGTERM/SIGINT graceful shutdown - Add `agents server start` CLI command with --host, --port, --log-level options, resolving defaults from Settings - Add fastapi>=0.115.0 dependency to pyproject.toml (uvicorn already present) - Add Behave BDD tests (features/server_lifecycle.feature, 20 scenarios) - Add Robot Framework integration tests (robot/server_lifecycle.robot) - Update CHANGELOG.md and vulture_whitelist.py ISSUES CLOSED: #862	2026-05-29 05:08:08 -04:00
freemo	7b91b66b28	Fix actor add --config crash with combined-format config.actor (#11189) ... When users register actors via `agents actor add --config` using the spec-compliant combined config.actor YAML format — either as a compact string (config:\n actor: "<provider>/<model>") or as a nested dict (config:\n actor:\n type: llm\n provider: aws) — the CLI crashed with click.BadParameter: "Invalid value: 'provider' is required" because the parser did not detect or flatten the nested structure. Added: - _detect_nested_config_actor() in schema.py to recognise both compact-string and nested-dict forms of config-actor format. - _flatten_config_actor() in schema.py to merge config["actor"] fields into the dict top-level (removing the wrapper). - Flattening logic in ActorConfiguration.from_blob() to handle both string ("<provider>/<model>") and nested-dict forms of config.actor. - CLI flattening step at the start of `agents actor add` command. - New BDD scenarios for combined-format registration. - Unit tests for detection, flattening, schema-v3 detection, and full from_blob() flow. ISSUES CLOSED: #11189	2026-05-28 20:25:17 -04:00
CoreRasurae	3e13411fcf	fix(actors): distinguish namespace/name from provider/model in actor name parsing ... When action YAML references actors using namespace/name format (e.g. `strategy_actor: local/my-strategist`), `_parse_actor_name()` incorrectly treated the namespace prefix as a provider name, causing `ValueError: Unknown provider type: local`. Changes: - `_is_known_provider()`: New utility function (strategy_resolution.py) that checks whether a slash-separated first segment matches a known `ProviderType` value (openai, anthropic, etc.). Consolidated into a single implementation; llm_actors.py now imports from strategy_resolution.py. - `_parse_actor_name()`: When the first segment IS a known provider, preserves existing behaviour (provider/model). When it is NOT a known provider, treats the input as namespace/name and returns the full name as the model identifier with the default provider. Callers SHOULD pre-resolve namespace/name references via the actor registry before calling this function. Both implementations (strategy_resolution.py and llm_actors.py) updated; ProviderType import moved to top level. - `PlanLifecycleService.resolve_actor_provider_model()`: New method that resolves a namespaced actor name (e.g. local/my-strategist) to provider/model format by looking up the actor record and extracting its provider and model fields. - `LifecycleService` Protocol (strategy_resolution.py): Added `resolve_actor_provider_model` to the protocol, eliminating the need for `# type: ignore[union-attr]` at call sites. - `PlanLifecycleProtocol` (llm_actors.py): Added `resolve_actor_provider_model` to the protocol. - Caller pre-resolution: StrategyActor, LLMStrategizeActor, LLMExecuteActor, SessionWorkflow._resolve_llm(), and CLI session commands now pre-resolve actor names through the lifecycle service or via injected actor_resolver callables before calling `_parse_actor_name()`, ensuring namespace/name references are correctly mapped to their underlying LLM providers. - `_build_actor_resolver()` (cli/commands/session.py) and `_build_actor_resolver_for_session_workflow()` (a2a/facade.py): Moved `_is_known_provider` imports to top level; removed redundant `except (NotFoundError, Exception)`; added warning logging for outer exception handlers. - `make_mock_lifecycle()` (mock_strategy_llm.py) and `_make_mock_lifecycle()` (llm_actors_coverage_steps.py): Added `resolve_actor_provider_model` to mock lifecycle services for test compatibility. - Added `@tdd_issue @tdd_issue_11254` tags to all new BDD scenarios related to namespace/name disambiguation in llm_actors_coverage, strategy_actor_llm, and plan_lifecycle_service_coverage_boost_r4 feature files. - Updated docs/CHANGELOG.md with the fix entry. ISSUES CLOSED: #11254	2026-05-22 20:42:25 +01:00
CoreRasurae	8548644819	fix(cli): wire SubplanExecutionService in _get_plan_executor() to enable child plan execution ... Wire subplan_service from the DI container into _get_plan_executor() so PlanExecutor can spawn child plans during the Execute phase. When SubplanService is available but SubplanExecutionService is not explicitly injected, _execute_subplans() now lazily creates a SubplanExecutionService on-the-fly using the parent plan's subplan_config and the new _execute_child_plan callback. - _get_plan_executor(): retrieve subplan_service from container, pass to PlanExecutor constructor - _execute_subplans(): lazily build SubplanExecutionService when only SubplanService is wired (Forgejo #10268) - _execute_child_plan(): new PlanExecutor method that runs a child plan's strategize + execute phases, registered as executor_fn callback ISSUES CLOSED: #10268	2026-05-19 19:28:35 +01:00
HAL9000	20ad9a46c4	fix(data-integrity): remove silent argument swap in ValidationAttachmentRepository.attach ... Fixes a critical data integrity bug where validation_name and resource_id arguments were being silently swapped based on a fragile heuristic when resource_id contained '/'. This caused silent data corruption without any error being raised. The 3-line conditional swap block has been removed from ValidationAttachmentRepository.attach(), ensuring arguments flow directly from caller to the persistence layer in the correct order.	2026-05-16 17:43:47 +00:00
hamza.khyari	e2167ab8e7	fix(acms): use project-level hot_max_tokens in execute phase context assembly ... Fixed _resolve_hot_max_tokens() to read hot_max_tokens from the correct sub-key in context_policy_json. The value is stored under context_policy_json["acms_config"]["hot_max_tokens"] by 'agents project context set --hot-max-tokens', not at the top level. The previous read (config_dict.get("hot_max_tokens")) always returned None, causing the assembler to silently use the global 16K default even when a project-level override was configured. Also adds two Behave regression scenarios with @tdd_issue @tdd_issue_11035 tags that exercise the real DB query code path via a mocked NamespacedProjectModel row, verifying: 1. hot_max_tokens=32000 in acms_config is applied to CoreContextBudget and ContextRequest (override path). 2. Missing hot_max_tokens falls back to the constructor-injected global default of 4096 (fallback path). Module-level import json added to steps file; redundant inline MagicMock import removed. ISSUES CLOSED: #11035 ISSUES CLOSED: #11215	2026-05-16 16:40:54 +00:00
freemo	bf52a9c648	fix(invariant): restore ACTION scope in merge_invariants and InvariantSet.merge precedence chain ... The 4-tier invariant precedence chain (plan > action > project > global) was broken at the domain layer — merge_invariants() and InvariantSet.merge() only accepted 3 parameters (plan, project, global), silently dropping all action- scoped invariants. Added action_invariants as a fourth parameter with proper backward compatibility (default to empty list). Updated module docstrings, InvariantScope docstring, and InvariantService.get_effective_invariants() to reflect the correct precedence chain. Added comprehensive BDD test scenarios covering four-tier merge precedence, action-before-project ordering, and effective invariant computation with all four scopes. ISSUES CLOSED: #9126	2026-05-16 04:14:17 +00:00
CoreRasurae	97c1007bb5	feat(events): wire domain services to emit missing EventBus events ... Add TokenAuthMiddleware to emit AUTH_SUCCESS/AUTH_FAILURE with spec-aligned audit details and wire it through the DI container using server.token resolution. Add Behave and Robot coverage for auth event emission and end-to-end audit persistence, and update audit subscriber producer notes and changelog. ISSUES CLOSED: #714	2026-05-15 22:19:57 +01:00
hamza.khyari	b4351ca78d	Revert "Merge pull request 'fix(acms): use project-level hot_max_tokens in execute phase context assembly' (#11216) from bugfix/m5-acms-project-budget-override into master" ... This reverts commit 94622f467c, reversing changes made to 1196c726f2.	2026-05-15 11:15:41 +00:00
hamza.khyari	1baa888659	fix(acms): use project-level hot_max_tokens in execute phase context assembly ... Added _resolve_effective_budget() method to ACMSExecutePhaseContextAssembler that reads each linked project's settings.hot_max_tokens and uses the maximum override value as the pipeline budget instead of the hardcoded global default. Updated assemble() to use the resolved effective budget for both CoreContextBudget and ContextRequest. Added Behave regression scenario with @tdd_issue @tdd_issue_11035 tags verifying the pipeline receives the project-level budget. Removed test artifact ANALYSIS.md left over from scenario 20. Fixes: #11035 Fixes: #11215	2026-05-15 10:27:57 +00:00
HAL9000	655cd7ebc2	fix: persist strategy decisions via DecisionService during strategize (#10813) ... The plan tree command reported zero decision nodes after strategize because PlanExecutor.run_strategize() never persisted strategy decisions as domain Decision objects. Added _persist_strategy_decisions() to the PlanExecutor, wired decision_service from the DI container in _get_plan_executor(), and ensure each strategy decision is recorded with correct DecisionType mapping. ISSUES CLOSED: #10813	2026-05-15 03:41:13 +00:00
HAL9000	fa95c518d5	fix(tui): rename ActorSelectionOverlay._render to avoid shadowing Textual Widget._render ... Rename ActorSelectionOverlay._render() to _refresh_display() to avoid shadowing Textual's Widget._render(), fixing a crash in textual >=1.0 where get_content_height() would receive None and raise AttributeError. ISSUES CLOSED: #11039	2026-05-15 00:56:08 +00:00
CoreRasurae	b41f536da6	fix(automation): respect automation profile gates in lifecycle service and async jobs ... Add BDD regression tests for issue #4328 automation profile gates Tests verify that complete_strategize() and complete_execute() respect automation profile thresholds and do NOT unconditionally call auto_progress(). Covers 8 built-in profiles: manual, full-auto, supervised, auto, review_before_apply, ci, trusted ISSUES CLOSED: #4328	2026-05-14 22:57:11 +00:00
HAL9000	2f29f8352f	chore: resolve merge conflicts and apply cosmetic fixes ... - Resolve CHANGELOG.md conflict to include both entries, referencing issue #8164 instead of PR #11161 - Resolve CONTRIBUTORS.md conflict, fix leading space in new entry - Remove duplicate create_sequence_node function (dead code) Merges master into feat/structural-output-validation branch	2026-05-14 18:14:48 +00:00
hurui200320	cc8e013f9b	fix(actor): handle nested actor type and combined config.actor field in v3 YAML ... Two defects in ActorConfiguration._extract_v3_actor() prevented YAML files using the spec-canonical nested actors map format from being registered: Defect A: The method looked for the 'type' field inside the 'config:' block (config_block.get('type')) instead of at the actor-entry level (first_entry.get('type')). Because the spec places 'type' at actors.<name>.type — a sibling of 'config:', not a child of it — the v3 detection branch never fired for nested-actors-map YAMLs, causing _extract_v3_actor() to return (None, None, None, False) immediately. Defect B: Even if the type was found, the method only consulted separate config.provider and config.model keys; it never parsed the combined config.actor: 'provider/model' shorthand. Without the combined-field fallback, provider and model remained None for all spec-canonical YAMLs that use the shorthand, causing from_blob() to raise 'BadParameter: provider is required'. Both defects had to be fixed together because Defect A blocked the code from ever reaching the path where Defect B would otherwise have been encountered. The combined-format parser (config.actor split on first '/') is inserted after the explicit config.provider / config.model lookups so that explicit separate fields always take precedence over the shorthand when both are present. Parsing logic extracted into _parse_combined_actor_field() helper to eliminate DRY violation. Both provider and model halves validated consistently (empty provider half was previously silently inferred). Adds Behave scenarios covering: nested actors map + combined config.actor (success), explicit config.provider precedence over config.actor, explicit config.model precedence over config.actor, genuinely missing provider/model raising validation error, and malformed combined values (empty model half, empty provider half, missing delimiter). Adds a Robot integration test for the combined-actor YAML path with provider/model assertions via show. Restores accidentally deleted TOOL and GRAPH Robot integration tests. Mirrors provider/model extraction in step_run_actor_update for assertion step compatibility. ISSUES CLOSED: #11189	2026-05-14 08:10:58 +00:00
freemo	80d27df9cc	fix(changelog): correct PR #11161 references in CHANGELOG.md and CONTRIBUTORS.md ... ISSUES CLOSED: #11147	2026-05-14 06:46:27 +00:00
HAL9000	f8e4f4a579	feat: implement structural component output validation ... Replace exact character matching with structural component checking for output validation. Implements three validators covering plan tree output, decision CLI dicts, and structured session snapshots. - validate_plan_tree: validates node dicts for required keys (decision_id, type, sequence, question, children), ULID format, correct types, and sibling ordering - validate_decision_dict: validates decision CLI output against Decision.as_cli_dict() schema with field presence, type, ULID, confidence range [0..1], bool fields - validate_structured_output: validates StructuredOutput envelope for command, session_id (ULID), status membership, exit_code, elements integrity - validate_structured_component_output: unified dispatcher by target_type BDD tests in features/structural_validation.feature. ISSUES CLOSED: #11147	2026-05-14 06:46:27 +00:00
brent.edwards	d31d9226f9	test(wf10_batch.robot): request that LLM not create files (#11133) ... Closes: #11007 ## Description Asks LLM to not create files. ## Type of Change - [ X ] Bug fix (non-breaking change which fixes an issue) - [ X ] Test improvements ## Quality Checklist - [ ] Code follows the project's coding standards (see CONTRIBUTING.md) - [ ] All public/protected methods have argument validation - [ ] Static typing is complete (no `Any` unless justified) - [ ] `nox -s typecheck` passes with no errors - [ ] `nox -s lint` passes with no errors - [ ] Unit tests written/updated (Behave scenarios in `features/`) - [ ] Integration tests written/updated (Robot suites in `robot/`) if applicable - [ ] Coverage remains above 85% (`nox -s coverage_report`) - [ ] No security issues introduced (`nox -s security_scan`) - [ ] No dead code introduced (`nox -s dead_code`) - [ ] Documentation updated if behavior changed ## Testing Running in git.cleverthis.com is the only real test possible. ### Test Commands Run ```bash nox -s unit_tests # Behave tests nox -s typecheck # Type checking nox -s lint # Linting nox -s coverage_report # Coverage ``` ## Related Issues Closes #11007 Reviewed-on: #11133 Reviewed-by: Hamza Khyari <hamza.khyari@cleverthis.com>	2026-05-13 23:39:15 +00:00
HAL9000	3368cba38f	refactor(a2a): execute ACP to A2A module rename and symbol standardization (#10583) ... Executes the systematic ACP -> A2A module rename per ADR-047. - Renamed all legacy ACP references to A2A throughout cleveragents.a2a module - Standardized all 22 exported symbols to A2A naming conventions - Added BDD test suite validating export completeness, zero ACP remnants, and documentation accuracy Closes #10583 Parent Epic: #8569 (A2A Standard Adoption)	2026-05-13 06:49:40 +00:00
freemo	9cfa1dd1d7	fix(subplan): propagate invariant_enforced decisions to child plans on spawn ... SubplanService.spawn() now re-records all invariant_enforced decisions from the parent plan decision tree onto each child plan decision tree. This satisfies the spec requirement: 'recorded as invariant_enforced decisions that propagate to child plans.' (Glossary → Invariant) Previously, child plans started Strategize with a completely empty invariant set, violating the spec's propagation requirement. non_overridable global invariants enforced on the parent were not guaranteed to be enforced on child plans. The fix adds _propagate_invariant_decisions() to SubplanService which queries the parent plan's invariant_enforced decisions and re-records each one on the child plan using DecisionService.record_decision(). The DecisionService is already injected into SubplanService, so no new dependencies are required. BDD regression coverage added in features/tdd_invariant_propagation_subplan.feature with 4 scenarios covering: single invariant propagation, multiple invariant propagation, non_overridable invariant propagation, and clean spawn with no parent invariants. ISSUES CLOSED: #9131	2026-05-12 16:45:59 +00:00
CoreRasurae	3b83438e7d	test(actor): add regression test for issue 4321 nested config extraction ... Add BDD regression test for Forgejo issue 4321: ActorRegistry.add() fails to extract provider and model from nested actor config. The test verifies that when type is only at the nested actors map level (not at top level), provider and model are correctly extracted from the nested config block. This scenario is already handled correctly by the _extract_nested_v3_config() function added in commit 78be0887 (issue #4300). The test confirms the fix works as expected and prevents future regressions. Tags: @tdd_issue @tdd_issue_4321 ISSUES CLOSED: #4321	2026-05-12 13:02:59 +00:00
hamza.khyari	f37bfa01fe	feat(agents): add review-started notification to pr-review-worker ... Add Step 0 to both first_review and re_review modes — posts a comment on the PR immediately after parameter validation, before any reading or cloning. Gives the PR author instant visibility that a review is in progress. CI flag mode is unchanged (too lightweight to warrant a notification). ISSUES CLOSED: #11028	2026-05-12 12:11:12 +00:00
CoreRasurae	39bbff0849	feat(agents): add work-started notification to task-implementor ... Add Step 2 (notification) to issue_impl and pr_fix procedures — posts a comment on the issue/PR after reading it but before cloning, giving authors instant visibility that implementation work has started. Also update CHANGELOG.md with entry for #11031. ISSUES CLOSED: #11031	2026-05-12 11:47:15 +00:00
hurui200320	52830971f2	fix(plan): guard cleanup_stale against execute/complete plans awaiting apply ... Bug #11121: _create_sandbox_for_plan() called GitWorktreeSandbox.cleanup_stale() unconditionally, destroying the cleveragents/plan-<id> git branch when agents plan execute was re-invoked on a plan already in execute/complete state (awaiting apply). This caused plan apply to find zero artifacts. Fix: Add a phase/state guard inside _create_sandbox_for_plan() that returns the flat fallback early when the plan is execute/complete, preserving the worktree branch intact for plan apply to merge. - TDD regression test from issue #11120 (without @tdd_expected_fail) - Verified sandbox lifecycle tests still pass ISSUES CLOSED: #11121	2026-05-12 10:17:39 +00:00