4 Commits

Author	SHA1	Message	Date
hurui200320	2005b8ef82	feat(tests): replace all @skip tags with proper @tdd_expected_fail tags or remove them across the entire codebase (#7221) ... ## Summary Replaces all 234 bare `@skip` occurrences across 82 Behave feature files with the correct TDD issue-capture tagging system described in CONTRIBUTING.md § Bug Fix Workflow. Previously, the noxfile ran Behave with `--tags=not @skip`, silently excluding all `@skip`-tagged scenarios from every CI run. These tests never ran, never inverted results via the `@tdd_expected_fail` mechanism, and never contributed to coverage — defeating the purpose of TDD issue-capture testing. Every `@skip` occurrence had a commented-out hint line immediately above it showing the intended proper tags (e.g., `# @tdd_issue @tdd_issue_4272 @tdd_expected_fail @skip`), confirming they were all intended for conversion. ## Changes ### Mechanical conversion (234 replacements across 82 files) - Extracted the proper TDD tags from the comment hint above each `@skip` line, removed `@skip` from the tag set, and replaced the `@skip` line with those tags. - Removed the now-redundant comment hint lines alongside each replacement. ### Bug-fixed scenarios — `@tdd_expected_fail` removed (84 scenarios) - After conversion, ran `nox -s unit_tests` to identify which newly-enabled `@tdd_expected_fail` scenarios now **pass** (their referenced bugs have already been fixed). Removed `@tdd_expected_fail` from those 84 scenarios and their corresponding feature-level tags, leaving only the permanent `@tdd_issue @tdd_issue_<N>` regression-guard tags. - Affected features include: `tdd_tool_runner_env_precedence`, `tdd_automation_profile_session_leak`, `tls_certificate_check`, `project_create_persist`, `resource_type_bootstrap_*`, and 18 others. ### Noxfile cleanup - Removed all four `--tags=not @skip` arguments from `noxfile.py` (unit_tests and coverage sessions). With zero `@skip` tags remaining in the codebase, this filter was dead code and its presence would mislead future maintainers into thinking `@skip` is still a supported escape mechanism. ### Regression guard files - Split the regression guards into two focused files: - `tdd_regression_guards_exec_env.feature` for bug #4281 (exec-env precedence) - `tdd_regression_guards_session_list.feature` for bug #4271 (session list summary) - Each file carries only its own `@tdd_issue` tags at the feature level, avoiding cross-contamination via Behave tag inheritance. The `Background` step (`session-list-summary mock`) only appears in the session-list file where it is actually needed. ### Duplicate tag cleanup - Removed duplicate `@tdd_issue @tdd_issue_4287` tag lines in `tdd_skill_add_regression.feature` (lines 20 and 29). ### Inline comment for retained `@tdd_expected_fail` - Added inline comment in `ci_workflow_validation.feature:134` explaining why this specific #4227 scenario retains `@tdd_expected_fail` despite #4227 being closed (CI YAML does not encode threshold as a machine-readable value). ### Known edge cases — `@tdd_expected_fail` retained (closed issues, fix on master, scenarios still fail) The following issues are **closed** and their fixes **are on master**, but the specific test assertions still fail because the fixes address other aspects of the bugs. The `@tdd_expected_fail` tags are functionally correct and must remain until the specific scenario assertions pass: - `tdd_exec_env_resolution_precedence.feature` — bug #1080 (closed 2026-03-31). The precedence-level-2-vs-4 scenario still fails. - `session_list_summary_dedup.feature` — bug #3046 (closed 2026-04-05). The dedup-consistency scenarios still fail. - `actor_add_update_enforcement.feature` — bug #2609 (closed 2026-04-05). The enforcement scenarios still fail. - `ci_workflow_validation.feature:134` — #4227 (closed 2026-04-08). The CI YAML threshold assertion still fails. ## Verification - `grep -r "@skip" features/ --include="*.feature"` → **zero results** ✓ - `grep -n "tags=not @skip" noxfile.py` → **zero results** ✓ - `nox -s unit_tests` → **629 features passed, 0 failed** ✓ (up from ~545 before this PR) - CI all green (coverage ≥ 97%) ✓ - Integration tests (Robot Framework) do not use `@skip` — confirmed no action needed ✓ - E2E tests (Robot Framework) do not use `@skip` — confirmed no action needed ✓ - `CHANGELOG.md` updated with entry for this change ✓ - `CONTRIBUTORS.md` — Rui Hu already listed ✓ ## Issues Addressed Closes #7025 Co-authored-by: CleverThis <hal9000@cleverthis.com> Reviewed-on: #7221 Reviewed-by: HAL 9000 <HAL9000@cleverthis.com> Reviewed-by: HAL9001 <hal9001@cleverthis.com> Co-authored-by: Rui Hu <rui.hu@cleverthis.com> Co-committed-by: Rui Hu <rui.hu@cleverthis.com>	2026-04-13 04:56:01 +00:00
freemo	8ea00f5185	fix: restore CI quality tests to passing state (#4175) ... Co-authored-by: Jeffrey Phillips Freeman <the@jeffreyfreeman.me> Co-committed-by: Jeffrey Phillips Freeman <the@jeffreyfreeman.me>	2026-04-08 11:02:14 +00:00
brent.edwards	7e9a45044b	fix(session): session create does not persist session for subsequent list ... The CLI `session create` command created the session via SessionService.create() (which commits via auto_commit=True), then called _facade_dispatch("session.create") for A2A protocol bookkeeping. The facade handler unconditionally called svc.create() on a second PersistentSessionService instance (a new Factory resolution from the DI container with its own engine), creating a duplicate session in the database. The fix makes A2aLocalFacade._handle_session_create() idempotent: when a session_id is already present in the params, it acknowledges the existing session without creating a new one. The CLI dispatch params were also fixed to use the correct key name (actor_name instead of actor). Changes: - src/cleveragents/a2a/facade.py: Early return in _handle_session_create when session_id is already supplied, preventing duplicate session creation. - src/cleveragents/cli/commands/session.py: Fixed param key from "actor" to "actor_name" for consistency with the facade handler. - features/a2a_facade_wiring.feature: Added idempotency scenario verifying that session.create with an existing session_id does not call svc.create(). - features/steps/a2a_facade_wiring_steps.py: Added step asserting mock SessionService.create was not called. - features/tdd_session_create_persist.feature: Removed @tdd_expected_fail tag now that the bug is fixed. - robot/e2e/e2e_session_create_persist.robot: Removed tdd_expected_fail tag, updated documentation. - .semgrep.yml: Excluded wrapping.py from no-exec/no-compile-exec rules (pre-existing sandboxed exec usage for tool transforms). ISSUES CLOSED: #1141 Co-authored-by: Brent E. Edwards <brent.edwards@cleverthis.com> Co-committed-by: Brent E. Edwards <brent.edwards@cleverthis.com>	2026-04-02 16:51:04 +00:00
brent.edwards	b59100cc6c	test: add TDD bug-capture test for #1141 — session create persistence (#1144) ... ## Summary Adds TDD bug-capture coverage for bug #1141 (`session create` -> `session list` lifecycle) on metadata branch `tdd/m3-session-create-persist`. ### What changed - Added Behave bug-capture feature: `features/tdd_session_create_persist.feature` - Required tags: `@tdd_bug @tdd_bug_1141 @tdd_expected_fail` - Scenario path: `init --force --yes` -> `session list --format json` -> `session create` -> `session list --format json` - Added Behave step definitions: `features/steps/tdd_session_create_persist_steps.py` - Uses root CLI app (`cleveragents.cli.main:app`) for realistic command routing - Asserts expected list totals; underlying assertion intentionally fails while bug is present - Added Robot E2E bug-capture test: `robot/e2e/e2e_session_create_persist.robot` - Required tags: `E2E`, `tdd_expected_fail`, `tdd_bug`, `tdd_bug_1141` - Includes explicit in-file note to remove `tdd_expected_fail` when #1141 is fixed - Updated changelog (`CHANGELOG.md`, Unreleased) ### Notes - The issue subtask referenced `robot/e2e/e2e_session_lifecycle.robot`, which is not present on current `master`; equivalent E2E coverage is implemented in `robot/e2e/e2e_session_create_persist.robot`. - The branch was force-updated to remove stale merge-based history and keep an atomic, rebase-clean commit for this issue. ## Quality gates | Gate | Result | |---|---| | `nox -s lint` | ✅ pass | | `nox -s typecheck` | ✅ pass | | `nox -s unit_tests -- features/tdd_session_create_persist.feature` | ✅ pass (TDD inversion active; underlying assert fails) | | `nox -s integration_tests -- robot/e2e/e2e_session_create_persist.robot` | ✅ pass | | `nox -s e2e_tests` | ✅ pass | | `nox -s coverage_report` | ✅ pass (97.66173849218832%) | | `nox` (full default suite) | ✅ pass | ## Related issue Closes #1142 Reviewed-on: #1144 Reviewed-by: Jeffrey Phillips Freeman <jeffrey.freeman@cleverthis.com> Co-authored-by: Brent Edwards <brent.edwards@cleverthis.com> Co-committed-by: Brent Edwards <brent.edwards@cleverthis.com>	2026-03-28 04:34:47 +00:00