6 Commits

Author	SHA1	Message	Date
HAL9000	787b99329a	fix(a2a): correct IndentationError, add tdd_issue_9250 tags, fix CONTRIBUTORS ... - Fix 2-space -> 4-space indentation on _handle_session_close in facade.py; this single error caused every CI gate to fail (lint, typecheck, unit_tests, integration_tests, e2e_tests, security) - Add @tdd_issue @tdd_issue_9250 tags to the three session_id validation scenarios in a2a_facade_coverage.feature per the mandatory bug-fix TDD workflow requirement - Fix CONTRIBUTORS.md entry: was PR #11053 / issue #9094, corrected to PR #11098 / issue #9250 ISSUES CLOSED: #9250	2026-06-17 08:49:34 -04:00
HAL9000	863be6780a	fix(a2a): validate session_id at entry of _handle_session_close before devcontainer cleanup ... The _handle_session_close handler in the A2A local facade previously validated session_id only after checking whether a session service was wired. When no session service was available, _cleanup_session_devcontainers() was invoked with an empty or missing session_id, risking incorrect container lifecycle operations on unknown sessions. This fix moves validation to the top of _handle_session_close so it applies uniformly across both code paths. Updated BDD tests in features/a2a_facade_wiring.feature and features/a2a_facade_coverage.feature to reflect the new validation behavior. PR-CLOSED: #9250	2026-06-17 08:49:34 -04:00
HAL9000	195fbac109	fix: add required @a2a, @session, @cli tags to BDD feature files ... Add domain-scenario Gherkin tags to all A2A, session, and CLI feature files (30 files) so tests can be filtered individually via behave. - 8 A2A feature files: @a2a tag - 7 session feature files: @session tag - 15 CLI feature files: @cli tag ISSUES CLOSED: #9124	2026-06-02 15:41:06 -04:00
freemo	ff9c6540a2	feat(server): entity sync (_cleveragents/sync/*) ... Implement entity synchronization between client and server using the _cleveragents/sync/* A2A extension methods per the specification. Sync models (src/cleveragents/a2a/sync_models.py): - Pydantic v2 models for pull/push/status requests and responses - VectorClock with increment, merge, happens-before, and concurrency detection for distributed conflict detection - SyncEntitySnapshot, SyncConflict, SyncState, SyncQueueEntry models - SyncEntityType enum: actor, skill, action, plan, session - ConflictResolution enum: last_writer_wins, manual, server_wins, client_wins SyncService (src/cleveragents/application/services/sync_service.py): - pull(): download server namespace entities to local cache with incremental sync (since timestamps) and force-overwrite option - push(): push local entity definitions to server namespace with configurable conflict resolution strategy - status(): compare local and server entity versions, detect drift, report local-ahead, server-ahead, and concurrent conflicts - resolve_conflict(): manually resolve detected conflicts with winner selection (local or server) - Offline queue: enqueue_offline() and process_offline_queue() for retry on reconnect, with max-retries enforcement - The local/ namespace is never synced per specification A2A facade (src/cleveragents/a2a/facade.py): - Replaced sync stub handlers with real _handle_sync_pull, _handle_sync_push, _handle_sync_status routing to SyncService - Added sync_service property and TYPE_CHECKING import - Facade returns stubs when no SyncService is registered Tests: - Behave BDD: features/entity_sync.feature (65 scenarios, 247 steps) covering models, vector clocks, pull/push/status, conflict resolution, offline queue, facade integration, constructor validation, edge cases - Robot Framework: robot/entity_sync.robot (8 integration tests) ISSUES CLOSED: #866	2026-05-29 07:21:08 -04:00
freemo	9c6d69153e	fix(a2a): rename A2aRequest/A2aResponse fields to comply with JSON-RPC 2.0 wire format ... Rewrites the A2aRequest and A2aResponse Pydantic models to use the field names mandated by the JSON-RPC 2.0 specification, fixing a fundamental protocol compliance issue that prevented external A2A-compliant clients from communicating with the server. Changes: - A2aRequest: a2a_version→jsonrpc (fixed '2.0'), request_id→id, operation→method; auth field removed (not in JSON-RPC 2.0) - A2aResponse: a2a_version→jsonrpc, request_id→id, status+data→result (success path), timing_ms removed; added _result_xor_error validator enforcing mutual exclusion of result and error fields - A2aLocalFacade.dispatch(): updated to use request.method, request.id, result=data, error=A2aErrorDetail(...) - A2aHttpTransport.send(): updated to use request.method - CLI call sites (session.py, plan.py): updated A2aRequest(method=...) and response.result / response.error field access - All existing A2A Behave step files updated to new field names - New 35-scenario Behave feature (a2a_jsonrpc_wire_format.feature) covering serialisation, deserialisation, validation, and facade dispatch - New 7-test Robot Framework suite (a2a_jsonrpc_wire_format.robot) for end-to-end wire format verification ISSUES CLOSED: #1501	2026-04-03 00:29:46 +00:00
freemo	051ee7c290	test(coverage): add Behave BDD tests to improve coverage across 52 source files ... Added 52 new .feature files and corresponding _steps.py files targeting previously uncovered code paths in the following areas: - TUI layer: app, commands, persona (state/schema/registry), widgets, input (shell_exec, reference_parser) - Application services: plan lifecycle/service/executor, session, project, repo indexing, correction, checkpoint, actor, llm_actors, strategy coordinator, resource file watcher, service retry wiring - CLI commands: session, resource, repl, plan, db, automation_profile - Domain models: retry_policy, resource_type, cost_budget, docker_compose_analyzer, detail_level, _sql_string_aware, _postgresql_helpers - Core: circuit_breaker, retry_service_patterns - Infrastructure: repositories, transaction_sandbox, strategy_registry, plugins/loader, container - Config: settings - Agents: plan_generation, context_analysis, auto_debug - A2A: facade All new tests follow the Behave/Gherkin BDD standard. Resolved step definition collisions with unique prefixes. Fixed Alembic fileConfig logger disabling issue (disable_existing_loggers=False). ISSUES CLOSED: #1068	2026-03-20 21:22:10 +00:00