2517 Commits

This Branch

This Branch

All Branches

Author	SHA1	Message	Date
HAL9000	291f6c286f	chore(coverage): omit tui/materializer.py from coverage measurement ... The TuiMaterializer added in this PR depends on the optional `textual` package gated behind the `[tui]` extra. The `[tests]` extra used by the coverage_report nox session does not install `textual`, so the textual-protected code paths inside materializer.py are unreachable in the coverage venv and report as uncovered, dropping project coverage below the 96.5% threshold. Add the file to the slipcover omit list in noxfile.py and to the matching [tool.coverage.run].omit list in pyproject.toml, mirroring the existing exclusion of `src/cleveragents/discovery/*`. Proper textual-aware test infrastructure (e.g. promoting `textual` into the tests extra together with BDD feature coverage) is left to a future PR — this change unblocks the coverage gate so the materializer implementation itself can land.	2026-05-28 08:35:32 -04:00
HAL9000	a70a6cf835	fix(tui): resolve lint and typecheck errors in materializer ... - Restructure imports: move models block to top (fixes E402), make textual optional via try/except ImportError (fixes architecture import test), remove unused A2aEventQueue import (F401) - Add contextlib import; replace 8x try/except/pass with contextlib.suppress (SIM105) - Sort __slots__ (RUF023), __all__ (RUF022) - Annotate _KIND_WIDGET_MAP with ClassVar (RUF012) - Fix _add_node type annotation: list[Tree] -> list[TreeNode]; TreeNode has .collapsed/.children, Tree does not (pyright errors at lines 189/191/196) - Add # type: ignore[import-untyped] on from-textual-widgets import lines so pyright suppresses reportMissingImports - Use DiffLine(type=...) alias instead of line_type= (pyright only sees the Field alias as valid constructor parameter) - Combine nested if statements (SIM102), fix 4x long lines (E501), rename 3x unused loop variables handle_id -> _handle_id (B007), remove unused `as exc` (F841), sort _build_progress imports (I001)	2026-05-28 08:06:55 -04:00
controller-ci-rerun	1b2b225dbd	chore: re-trigger CI [controller]	2026-05-28 08:06:55 -04:00
HAL9000	6cadceba10	feat(tui): implement TuiMaterializer bridging A2A event queue to Output Rendering Framework	2026-05-28 08:06:55 -04:00
HAL9000	a0d7a7f307	Merge pull request 'test(integration): add BDD scenarios for full hierarchical plan 4-phase lifecycle execution' (#11253) from test/hierarchical-plan-4phase-lifecycle into master	2026-05-28 11:43:13 +00:00
controller-ci-rerun	018ec4df57	chore: re-trigger CI [controller]	2026-05-28 07:07:04 -04:00
CoreRasurae	b98c99d93e	test(integration): add BDD scenarios for full hierarchical plan 4-phase lifecycle execution ... Adds BDD integration tests (Forgejo #10270) verifying that child plans independently complete all four lifecycle phases: Strategize, Decompose, Execute, and Validate. Scenarios covered: - Happy path: 2-level parent-child hierarchy with full phase execution - Checkpoint: on_subplan_spawn checkpoint creation verification - Max-child-depth: decomposition respects depth limits - Aggregation: parent plan aggregates child results - Failure handling: parent captures child plan failures - Nested: 3-level grandchild hierarchy cascading Uses real (non-mocked) service implementations in in-memory mode. ISSUES CLOSED: #10270	2026-05-28 00:05:08 -04:00
HAL9000	e4186508b8	Merge pull request 'fix(tui): subclass Input to override _watch_value and eliminate layout=True per keystroke' (#11251) from bugfix/m8-tui-input-live-refresh into master	2026-05-28 03:36:23 +00:00
HAL9000	153502feca	fix(tui): suppress textual import errors for optional dependency in typecheck ... Pyright evaluates `if _TEXTUAL_AVAILABLE:` blocks statically and raises reportMissingImports for textual.geometry, textual.reactive, and textual.widgets. Add `# type: ignore[import]` to the three conditional imports so typecheck passes when textual is not installed in the check environment.	2026-05-27 23:17:15 -04:00
drew	2537c5704f	Revert "fix(typecheck): install tui optional dep in typecheck nox session" ... This reverts commit fc66708231.	2026-05-27 23:17:15 -04:00
HAL9000	16baa60cb2	fix(typecheck): install tui optional dep in typecheck nox session ... The typecheck session was installing only the base package (-e .) without the tui optional dependency, so pyright could not resolve the textual.geometry, textual.reactive, and textual.widgets imports that prompt.py conditionally loads when _TEXTUAL_AVAILABLE is True. Changing to -e .[tui] ensures textual is present in the typecheck venv so pyright reports no reportMissingImports errors.	2026-05-27 23:17:15 -04:00
controller-ci-rerun	19c81ac388	chore: re-trigger CI [controller]	2026-05-27 23:17:15 -04:00
hamza.khyari	6bda792d2b	fix(tui): subclass Input to override _watch_value and eliminate layout=True per keystroke ... Input._watch_value sets self.virtual_size (Reactive layout=True) on every keystroke, keeping Textual's WriterThread write queue permanently non-empty. The queue never reaches qsize()==0 so flush() is never called and typed characters are invisible until Enter drains the queue. Two fixes applied: 1. _PromptTextInput subclasses textual.widgets.Input and overrides virtual_size with Reactive(layout=False). Setting virtual_size in _watch_value no longer triggers refresh(layout=True). Zero type:ignore suppressions — uses proper Textual reactive types. 2. CSS #prompt and #prompt > Input changed from height:auto to fixed heights (3 and 1). This prevents the auto_dimensions guard in _watch_value from adding a second refresh(layout=True) per keystroke. 3 BDD regression scenarios added covering: virtual_size layout=False, _PromptInputBase usage in _TextualPromptInput, and fixed CSS height. ISSUES CLOSED: #11249	2026-05-27 23:17:15 -04:00
hamza.khyari	412c338f4e	fix(tui): subclass Input to override _watch_value and eliminate layout=True per keystroke ... Input._watch_value sets self.virtual_size (Reactive layout=True) on every keystroke, keeping Textual's WriterThread write queue permanently non-empty. The queue never reaches qsize()==0 so flush() is never called and typed characters are invisible until Enter drains the queue via conversation.update(). _PromptTextInput subclasses Input and overrides _watch_value to skip the virtual_size update while preserving Changed event, _suggestion reset and initial cursor positioning. The prompt is single-line and never scrolls horizontally so omitting virtual_size is safe. ISSUES CLOSED: #11249	2026-05-27 23:17:15 -04:00
HAL9000	56338db205	Merge pull request 'fix(reactive): forward actor options block in ToolCallingLLMCaller._resolve_llm' (#11244) from bugfix/m7-tool-calling-llm-options into master	2026-05-28 03:08:32 +00:00
controller-ci-rerun	38aa457841	chore: re-trigger CI [controller]	2026-05-27 22:28:21 -04:00
hurui200320	91691750ed	fix(reactive): forward actor options block in ToolCallingLLMCaller._resolve_llm ... Port the options-block merging logic from SimpleLLMAgent._resolve_llm() (stream_router.py, added in PR #11225 / commit b3851693) to the parallel resolution path ToolCallingLLMCaller._resolve_llm() in tool_caller.py. Without this fix, running an actor with --skill would ignore the options block in the actor YAML, causing openai_api_base and openai_api_key to be silently dropped. The provider registry then fell back to OPENAI_API_KEY from the environment, routing requests to api.openai.com instead of the configured local llama-swap/llama.cpp backend (HTTP 401). Changes: - tool_caller.ToolCallingLLMCaller._resolve_llm: read actor_config.options; extract openai_api_key -> __api_key_sentinel; forward allowed keys (openai_api_base, timeout, top_p, frequency_penalty, presence_penalty); reject reserved keys (provider_type, model_id) and unknown keys with logger.warning, matching SimpleLLMAgent behaviour exactly. - features/actor_run_tool_calling.feature: add five BDD regression scenarios (section V, tagged @tdd_issue @tdd_issue_11243) covering api_base+key forwarding, allowed extra keys, reserved key rejection, unknown key rejection, and top-level precedence over options. - features/steps/actor_run_tool_calling_steps.py: add corresponding step definitions for all five scenarios. All nox quality gates pass (lint, typecheck, unit_tests 15822/0 fail, integration_tests 1999/0 fail, coverage_report 97%). ISSUES CLOSED: #11243	2026-05-27 12:14:04 -04:00
HAL9000	d0136e941a	Merge pull request 'fix(tui): correct Anthropic model name in default claude persona to claude-sonnet-4-20250514' (#11252) from bugfix/m8-tui-anthropic-model-name into master	2026-05-27 05:18:01 +00:00
drew	0bde46f0ff	fix(tui): update tests for renamed Anthropic model names and fix typer.Exit propagation	2026-05-27 00:46:19 -04:00
HAL9000	ca331ea187	fix(tui): correct Anthropic model name in default claude persona to claude-sonnet-4-20250514	2026-05-26 23:45:08 -04:00
HAL9000	f1a4858a29	fix(memory): use **kwargs to avoid Pyright param name mismatch ... langchain-community renamed connection_string → connection, but the locally installed stubs only know connection_string while CI has the newer API. Build kwargs dict dynamically to satisfy both environments without # type: ignore annotations.	2026-05-23 13:14:21 +00:00
HAL9000	190606d7e6	fix(memory): handle langchain-community SQLChatMessageHistory API rename ... langchain-community >= 0.3 renamed connection_string to connection in SQLChatMessageHistory.__init__(). Use the new 'connection' kwarg first and fall back to 'connection_string' for older versions. Also updates the test assertion in memory_service_coverage_steps.py to accept either parameter name. Fixes CI errors in: - plan_service_coverage.feature:128,141 - consolidated_misc.feature:1531	2026-05-23 12:22:51 +00:00
CoreRasurae	cdbe504b2c	fix(test): use shared in-memory SQLite URI in _ensure_memory_database_url ... Replace sqlite:///:memory: with sqlite:///file::memory:?cache=shared to ensure all SQLAlchemy connections within the same process share a single in-memory database. This prevents isolation issues where SQLChatMessageHistory and EntityStore would each create separate in-memory databases, avoiding unexpected errors in CI parallel execution.	2026-05-23 12:20:11 +01:00
HAL9000	73d3bed2da	test(persistence): remove stale @tdd_issue tags from EntityStore persistence tests ... The _load_from_persistence() and _persist_if_needed() stubs have been replaced with real SQLite persistence implementations, fixing bug #10455. All five scenarios now pass as regular regression tests. Refs: #10455	2026-05-23 00:01:44 +00:00
CoreRasurae	3e13411fcf	fix(actors): distinguish namespace/name from provider/model in actor name parsing ... When action YAML references actors using namespace/name format (e.g. `strategy_actor: local/my-strategist`), `_parse_actor_name()` incorrectly treated the namespace prefix as a provider name, causing `ValueError: Unknown provider type: local`. Changes: - `_is_known_provider()`: New utility function (strategy_resolution.py) that checks whether a slash-separated first segment matches a known `ProviderType` value (openai, anthropic, etc.). Consolidated into a single implementation; llm_actors.py now imports from strategy_resolution.py. - `_parse_actor_name()`: When the first segment IS a known provider, preserves existing behaviour (provider/model). When it is NOT a known provider, treats the input as namespace/name and returns the full name as the model identifier with the default provider. Callers SHOULD pre-resolve namespace/name references via the actor registry before calling this function. Both implementations (strategy_resolution.py and llm_actors.py) updated; ProviderType import moved to top level. - `PlanLifecycleService.resolve_actor_provider_model()`: New method that resolves a namespaced actor name (e.g. local/my-strategist) to provider/model format by looking up the actor record and extracting its provider and model fields. - `LifecycleService` Protocol (strategy_resolution.py): Added `resolve_actor_provider_model` to the protocol, eliminating the need for `# type: ignore[union-attr]` at call sites. - `PlanLifecycleProtocol` (llm_actors.py): Added `resolve_actor_provider_model` to the protocol. - Caller pre-resolution: StrategyActor, LLMStrategizeActor, LLMExecuteActor, SessionWorkflow._resolve_llm(), and CLI session commands now pre-resolve actor names through the lifecycle service or via injected actor_resolver callables before calling `_parse_actor_name()`, ensuring namespace/name references are correctly mapped to their underlying LLM providers. - `_build_actor_resolver()` (cli/commands/session.py) and `_build_actor_resolver_for_session_workflow()` (a2a/facade.py): Moved `_is_known_provider` imports to top level; removed redundant `except (NotFoundError, Exception)`; added warning logging for outer exception handlers. - `make_mock_lifecycle()` (mock_strategy_llm.py) and `_make_mock_lifecycle()` (llm_actors_coverage_steps.py): Added `resolve_actor_provider_model` to mock lifecycle services for test compatibility. - Added `@tdd_issue @tdd_issue_11254` tags to all new BDD scenarios related to namespace/name disambiguation in llm_actors_coverage, strategy_actor_llm, and plan_lifecycle_service_coverage_boost_r4 feature files. - Updated docs/CHANGELOG.md with the fix entry. ISSUES CLOSED: #11254	2026-05-22 20:42:25 +01:00
hamza.khyari	ad60b1da59	Merge pull request 'feat(tui): wire normal text input to LLM via A2A facade' (#11231) from feature/m8-tui-llm-dispatch into master ... Reviewed-on: #11231 Reviewed-by: Luis Mendes <luis.mendes@cleverthis.com>	2026-05-22 15:30:45 +00:00
hamza.khyari	652769c46c	feat(tui): wire normal text input to LLM via A2A facade ... Wires the TUI normal text input path to the LLM via A2aLocalFacade, closing the gap where typing a message produced no LLM call. All infrastructure (facade, SessionWorkflow, ProviderRegistry) already existed in the CLI; this PR adds the TUI wiring on top. Key changes: - _run_llm_dispatch(): module-level, Textual-free dispatch function covering all domain exception paths with user-friendly messages - _format_worker_outcome(): testable worker result/error translator - _create_tui_session(): DB-backed session with persona actor binding - _build_tui_facade(): wired A2aLocalFacade + SessionWorkflow singleton - run_worker(thread=True, exclusive=True): non-blocking, serialised - _dispatch_gen counter: prevents cancelled worker callbacks from corrupting the multi-turn transcript - SessionView.transcript: accumulated conversation history, pre-escaped - Markup escaping: _escape() applied before transcript storage - on_mount focus: prompt.focus() so keyboard input is received Tests: 18 BDD scenarios + 6 Robot Framework integration tests with FakeListLLM (no real API keys required). ISSUES CLOSED: #11230	2026-05-22 15:12:04 +00:00
CoreRasurae	3a95701d9a	fix(decomposition): enforce plan.max-child-depth recursion limit to prevent unbounded hierarchy growth ... Add max_child_depth field to DecompositionConfig (default: 5, matching plan.max-child-depth config) with validation in __post_init__. Update _build_hierarchy() in DecompositionService to stop recursion and emit a warning when the depth limit is reached. BDD tests verify: max_child_depth guards trigger before max_depth when more restrictive, warnings are logged, default config value is correct, and invalid values are rejected. ISSUES CLOSED: #10269	2026-05-19 21:56:28 +01:00
CoreRasurae	8548644819	fix(cli): wire SubplanExecutionService in _get_plan_executor() to enable child plan execution ... Wire subplan_service from the DI container into _get_plan_executor() so PlanExecutor can spawn child plans during the Execute phase. When SubplanService is available but SubplanExecutionService is not explicitly injected, _execute_subplans() now lazily creates a SubplanExecutionService on-the-fly using the parent plan's subplan_config and the new _execute_child_plan callback. - _get_plan_executor(): retrieve subplan_service from container, pass to PlanExecutor constructor - _execute_subplans(): lazily build SubplanExecutionService when only SubplanService is wired (Forgejo #10268) - _execute_child_plan(): new PlanExecutor method that runs a child plan's strategize + execute phases, registered as executor_fn callback ISSUES CLOSED: #10268	2026-05-19 19:28:35 +01:00
brent.edwards	eb46f0ff54	fix(plan): add tier hydration and improve architecture review output (#10938) ... ## Summary This PR fixes issue #10878 where architecture reviews were truncated because the regex pattern for parsing file output would stop at the first ``` encountered in the Markdown report. ## Changes - Change file delimiters from ``` to >>>>>>>/<<<<<<< to avoid Markdown conflicts - Add tier hydration before strategize phase in plan_executor.py - Increase max_tokens to 16384 in llm_actors.py for longer outputs - Increase context_max_tokens_hot from 16000 to 32000 in settings.py - Fix get_hot_view → get_hot_fragments in strategy_actor.py and plan_executor.py - Add opencode to skip directories in context_tier_hydrator.py - Change sandbox output location to plan-output/ directory in plan.py - Add get_context_summary stub method to acms_service.py ## Testing Run architecture review action and verify the output report is complete with all sections. Reviewed-on: #10938	2026-05-19 12:43:34 +00:00
hurui200320	0c5724c2f6	feat(actor-run): wire ToolCallingRuntime into actor run for skill-based tool calling ... Implements the full tool-calling path for `agents actor run --skill` so that LLM actors can actually invoke tools through the ToolCallingRuntime loop when a skill is attached. Core changes: - reactive/tool_caller.py (new): ToolCallingLLMCaller implements the LLMCaller protocol; binds tool schemas via bind_tools(), threads SystemMessage+HumanMessage on first call and AIMessage+ToolMessages on subsequent calls, extracts tool calls from LangChain responses following the LangChainSessionCaller pattern. - reactive/tool_caller.py: bidirectional tool name encoding via uppercase sentinels (_encode_tool_name / _decode_tool_name) to make CleverAgents namespaced tool names ("builtin/file-read", "server:local/tool") compatible with Anthropic's tool name pattern ^[a-zA-Z0-9_-]{1,128}$. Uses _C_ for ":" and _S_ for "/" — uppercase sentinels are safe because valid CleverAgents tool names forbid uppercase letters. Encoding applied in _resolve_llm() before bind_tools(); decoding applied in invoke() when extracting tool calls from the LLM response. - reactive/tool_agent.py (new): ToolCallingAgent builds a per-run local ToolRegistry from resolved skill tool entries by looking up names in the shared builtin_registry; drives ToolCallingRuntime.run_tool_loop(); exposes last_result for tool_calls surfacing. - reactive/application.py: (ST-1) _make_agent_instance() now always merges skill tools instead of silently dropping them when actor has no base tools list; routes tools+llm→ToolCallingAgent, tools+non-llm→SimpleToolAgent, no-tools+llm→SimpleLLMAgent; (ST-4) _builtin_registry created at startup with register_file_tools/git/subplan; (ST-6) _tally_tool_calls() + last_run_tool_calls property. - reactive/graph_executor.py: (ST-5) ToolCallingAgent added to isinstance check in _invoke_agent() so context dict is forwarded for Jinja2 rendering. - cli/commands/actor_run.py: prints "Tool Calls: {n}" when > 0. Test fixes: - features/steps/actor_cli_run_steps.py: _make_app() sets last_run_tool_calls=0 to avoid MagicMock>int TypeError in Python 3.13. - features/steps/actor_run_signature_resolve_steps.py: same fix. - robot/helper_actor_run_signature.py: same fix. - features/reactive_application_coverage_boost.feature: updated scenario to verify new correct behavior (LLM+skills → ToolCallingAgent, not silently kept as SimpleLLMAgent). BDD coverage: 34 scenarios in features/actor_run_tool_calling.feature covering tool call success, multi-turn loop, no-skill regression, silent-drop fix, LLMCaller internals, _build_tool_registry edge cases, last_run_tool_calls tallying, tool name encoding/decoding, and LLM response decoding. ISSUES CLOSED: #11211	2026-05-18 06:05:54 +00:00
HAL9000	20ad9a46c4	fix(data-integrity): remove silent argument swap in ValidationAttachmentRepository.attach ... Fixes a critical data integrity bug where validation_name and resource_id arguments were being silently swapped based on a fragile heuristic when resource_id contained '/'. This caused silent data corruption without any error being raised. The 3-line conditional swap block has been removed from ValidationAttachmentRepository.attach(), ensuring arguments flow directly from caller to the persistence layer in the correct order.	2026-05-16 17:43:47 +00:00
hamza.khyari	e2167ab8e7	fix(acms): use project-level hot_max_tokens in execute phase context assembly ... Fixed _resolve_hot_max_tokens() to read hot_max_tokens from the correct sub-key in context_policy_json. The value is stored under context_policy_json["acms_config"]["hot_max_tokens"] by 'agents project context set --hot-max-tokens', not at the top level. The previous read (config_dict.get("hot_max_tokens")) always returned None, causing the assembler to silently use the global 16K default even when a project-level override was configured. Also adds two Behave regression scenarios with @tdd_issue @tdd_issue_11035 tags that exercise the real DB query code path via a mocked NamespacedProjectModel row, verifying: 1. hot_max_tokens=32000 in acms_config is applied to CoreContextBudget and ContextRequest (override path). 2. Missing hot_max_tokens falls back to the constructor-injected global default of 4096 (fallback path). Module-level import json added to steps file; redundant inline MagicMock import removed. ISSUES CLOSED: #11035 ISSUES CLOSED: #11215	2026-05-16 16:40:54 +00:00
hurui200320	b3851693c8	fix(reactive): forward actor options block to LLM constructor for custom backend support ... Two code paths in the reactive actor run pipeline silently discarded the options: block from v3 actor YAML, preventing custom OpenAI-compatible backends (llama.cpp, Ollama, etc.) from being used. Review fixes applied: - Fix 1: Relabeled issue #11223 from Type/Task to Type/Bug; added @tdd_issue/@tdd_issue_11223 tags to all 5 Behave scenarios. - Fix 2: openai_api_key in options now routes through the registry's __api_key_sentinel mechanism so user-provided keys correctly override environment defaults. (stream_router.py) - Fix 3: type: graph actors now propagate actor-level options to individual node configs via setdefault. (config_parser.py) - Fix 4: Options keys are validated against an explicit allowlist; reserved keys (provider_type, model_id) are excluded; unrecognized keys log a WARNING instead of being silently forwarded. (stream_router.py) - Fix 5: Updated _build_from_v3 docstring to list options as a propagated field. (config_parser.py) - Fix 6: Removed inconsistent and options_raw emptiness guard; empty options dicts are now preserved consistently. (config_parser.py) - Fix 7: Reserved keys provider_type and model_id are excluded from the options merge loop to prevent TypeError. (stream_router.py) - Fix 8: Added Behave scenario verifying top-level temperature takes precedence over options duplicate. (consolidated_routing.feature + steps) - Fix 9: Strengthened "no extra kwargs" assertion to assert kwargs == {} directly instead of using an allow-list filter. (stream_router steps) - Fix 10: Strengthened options assertion to exact dict equality. (actor_v3_schema_extended_steps.py) - N1: Comment style aligned to M5: prefix convention. - N2: Type annotations changed from Any to Context (behave.runner). - N3: Added Behave scenario for empty options: {} dict behavior. Tests: 5 new Behave scenarios (3 in actor_v3_schema.feature, 2 in consolidated_routing.feature) with @tdd_issue/@tdd_issue_11223 tags. ISSUES CLOSED: #11223	2026-05-16 13:38:54 +00:00
freemo	23d73e7fb2	chore: Fix ruff format violations in db_url_sanitisation_steps.py ... Fix formatting issues detected by CI lint check: - Simplify multi-line decorator arguments to single line - Simplify multi-line assertion error messages to single line This resolves the format --check failure blocking CI.	2026-05-16 06:04:01 +00:00
HAL9000	86f96f299e	fix(cli): Mask database URL credentials in agents info CLI output (#8395)	2026-05-16 06:04:01 +00:00
HAL9000	5c5309f35d	fix(ci): add missing effective set count step definition ... The Behave scenario at line 671 of consolidated_domain_models.feature asserts 'the effective set should have {count:d} invariants' but no step handler existed, causing UndefinedStepError and CI failure. Adds the missing step: @then('the effective set should have {count:d} invariants') to step_invariant_models_steps.py, mirroring the existing invariant-set count pattern.	2026-05-16 04:14:17 +00:00
HAL9000	f4cea72248	fix(ci): update all merge_invariants callers to use 4-param signature ... The PR #11143 adds action_invariants as a 4th parameter to merge_invariants() and InvariantSet.merge(), but two call sites were not updated: - benchmarks/invariant_merge_bench.py: 5 calls with 3 positional args - robot/helper_m3_e2e_verification.py: 2 calls using keyword args All call sites now pass action_invariants=[] for backward-compatible empty-action behavior.	2026-05-16 04:14:17 +00:00
HAL9000	761622f746	fix(invariant): pass action_name in list_invariants when scope is ACTION ... Fixes list_invariants(effective=True) to forward action_name to get_effective_invariants when scope is ACTION, ensuring action-scoped invariants are included in effective invariant lists. Also applies ruff formatting to the return statement in get_effective_invariants. Addresses reviewer observation about list_invariants gap. Refs: #9126	2026-05-16 04:14:17 +00:00
freemo	bf52a9c648	fix(invariant): restore ACTION scope in merge_invariants and InvariantSet.merge precedence chain ... The 4-tier invariant precedence chain (plan > action > project > global) was broken at the domain layer — merge_invariants() and InvariantSet.merge() only accepted 3 parameters (plan, project, global), silently dropping all action- scoped invariants. Added action_invariants as a fourth parameter with proper backward compatibility (default to empty list). Updated module docstrings, InvariantScope docstring, and InvariantService.get_effective_invariants() to reflect the correct precedence chain. Added comprehensive BDD test scenarios covering four-tier merge precedence, action-before-project ordering, and effective invariant computation with all four scopes. ISSUES CLOSED: #9126	2026-05-16 04:14:17 +00:00
CoreRasurae	97c1007bb5	feat(events): wire domain services to emit missing EventBus events ... Add TokenAuthMiddleware to emit AUTH_SUCCESS/AUTH_FAILURE with spec-aligned audit details and wire it through the DI container using server.token resolution. Add Behave and Robot coverage for auth event emission and end-to-end audit persistence, and update audit subscriber producer notes and changelog. ISSUES CLOSED: #714	2026-05-15 22:19:57 +01:00
hamza.khyari	b0b28623a1	Merge pull request 'revert(acms): revert PR #11216 — _resolve_effective_budget reads wrong attribute' (#11228) from bugfix/m5-revert-acms-budget-assembler into master ... Reviewed-on: #11228 Reviewed-by: Rui Hu <rui.hu@cleverthis.com>	2026-05-15 11:47:30 +00:00
hamza.khyari	b4351ca78d	Revert "Merge pull request 'fix(acms): use project-level hot_max_tokens in execute phase context assembly' (#11216) from bugfix/m5-acms-project-budget-override into master" ... This reverts commit 94622f467c, reversing changes made to 1196c726f2.	2026-05-15 11:15:41 +00:00
hamza.khyari	94622f467c	Merge pull request 'fix(acms): use project-level hot_max_tokens in execute phase context assembly' (#11216) from bugfix/m5-acms-project-budget-override into master ... Reviewed-on: #11216 Reviewed-by: HAL9001 <hal9001@cleverthis.com>	2026-05-15 10:49:48 +00:00
hamza.khyari	1baa888659	fix(acms): use project-level hot_max_tokens in execute phase context assembly ... Added _resolve_effective_budget() method to ACMSExecutePhaseContextAssembler that reads each linked project's settings.hot_max_tokens and uses the maximum override value as the pipeline budget instead of the hardcoded global default. Updated assemble() to use the resolved effective budget for both CoreContextBudget and ContextRequest. Added Behave regression scenario with @tdd_issue @tdd_issue_11035 tags verifying the pipeline receives the project-level budget. Removed test artifact ANALYSIS.md left over from scenario 20. Fixes: #11035 Fixes: #11215	2026-05-15 10:27:57 +00:00
HAL9000	1196c726f2	fix(lint): remove broken step file and fix line-length violation ... - Removed features/steps/plan_status_json_envelope_steps.py which contained invalid Python syntax (dummy content, not referenced by any feature) - Fixed line-length violation in execute_phase_context_assembler.py (CoreContextBudget constructor call exceeded 88-char limit)	2026-05-15 03:41:13 +00:00
HAL9000	655cd7ebc2	fix: persist strategy decisions via DecisionService during strategize (#10813) ... The plan tree command reported zero decision nodes after strategize because PlanExecutor.run_strategize() never persisted strategy decisions as domain Decision objects. Added _persist_strategy_decisions() to the PlanExecutor, wired decision_service from the DI container in _get_plan_executor(), and ensure each strategy decision is recorded with correct DecisionType mapping. ISSUES CLOSED: #10813	2026-05-15 03:41:13 +00:00
HAL9000	dbc382f3d9	Fix TypeError in infer_resource_slots() when properties is null ... Fixed MCPToolAdapter.infer_resource_slots() to handle null values in JSON Schema by using instead of which returned None when the key exists with a null value. The @tdd_expected_fail tag was removed from TDD issue #10470 since the fix is now applied.	2026-05-15 02:41:37 +00:00
HAL9000	fa95c518d5	fix(tui): rename ActorSelectionOverlay._render to avoid shadowing Textual Widget._render ... Rename ActorSelectionOverlay._render() to _refresh_display() to avoid shadowing Textual's Widget._render(), fixing a crash in textual >=1.0 where get_content_height() would receive None and raise AttributeError. ISSUES CLOSED: #11039	2026-05-15 00:56:08 +00:00
HAL9000	ef6829b6f8	chore(lint): remove unused pathlib.Path import in llm_actors.py	2026-05-15 00:34:30 +00:00