Commit Graph

1928 Commits

Author SHA1 Message Date
HAL9000 59ce94cd27 docs(timeline): update schedule adherence Day 99 (2026-04-09)
CI / lint (pull_request) Successful in 27s
CI / quality (pull_request) Successful in 33s
CI / build (pull_request) Successful in 23s
CI / helm (pull_request) Successful in 24s
CI / typecheck (pull_request) Successful in 54s
CI / security (pull_request) Successful in 54s
CI / push-validation (pull_request) Successful in 30s
CI / e2e_tests (pull_request) Successful in 3m14s
CI / integration_tests (pull_request) Successful in 4m43s
CI / unit_tests (pull_request) Successful in 6m5s
CI / docker (pull_request) Successful in 23s
CI / coverage (pull_request) Successful in 12m34s
CI / status-check (pull_request) Successful in 3s
CI / benchmark-publish (pull_request) Has been skipped
CI / benchmark-regression (pull_request) Successful in 57m53s
Refresh timeline for Day 99 with updated gantt charts, status summary, and schedule adherence tables covering bug surge and milestone scope changes.

ISSUES CLOSED: #5780
2026-04-10 22:24:17 +00:00
clever-agent 7e66e57c21 docs(spec): final pass — structural integrity audit
CI / benchmark-publish (push) Waiting to run
CI / helm (push) Successful in 23s
CI / lint (push) Successful in 28s
CI / build (push) Successful in 32s
CI / push-validation (push) Successful in 35s
CI / quality (push) Successful in 40s
CI / security (push) Successful in 59s
CI / typecheck (push) Successful in 1m0s
CI / benchmark-regression (push) Waiting to run
CI / e2e_tests (push) Successful in 3m18s
CI / integration_tests (push) Successful in 4m14s
CI / unit_tests (push) Successful in 5m41s
CI / docker (push) Successful in 10s
CI / coverage (push) Successful in 11m28s
CI / status-check (push) Successful in 1s
- Fixed duplicate section number: two §2.4 -> renamed first to §2.3.1
- Verified all section cross-references valid
- Verified Appendix A model/mode data matches frontmatter (10 samples)
- Verified mkdocs.yml navigation entry
- Comprehensive stale-name sweep: zero hits across all files
- Added v1.36.0 revision entry with final statistics
2026-04-10 21:07:30 +00:00
clever-agent 3a69aef505 docs(spec): twentieth pass achieving spec-wide dual-account coherence
- Fixed Glossary: HAL9000 definition updated for dual-account architecture
- Fixed Section 6.17.2: "two-step" -> "dual-account" in protocol text
- Fixed Section 12.1.2: PR Reviewer table, description, and permissions
  rationale all updated for curl-based dual-account review protocol
- Fixed Section 19.5: Security Model rewritten from "single bot account"
  to dual-account with separate permission scopes per account
- Fixed 2 remaining "Two-Step Review Protocol" references
- Added v1.35.0 revision entry
2026-04-10 20:59:08 +00:00
clever-agent 05e5b26f2a docs(spec): nineteenth pass fixing diagram, MCP tool refs, and edit:deny count
- Fixed Section 6.17.2 diagram: removed orphaned single-account nodes,
  updated to show curl with FORGEJO_REVIEWER_PAT
- Fixed Section 6.17.2 step text: forgejo_create_pull_review -> curl
- Fixed edit:deny count from 41 to 42
- Added missing separator after diagram
- Added v1.34.0 revision entry
2026-04-10 20:51:37 +00:00
clever-agent c558972933 fix(agents): fix stale PR Self-Reviewer references in pr-ci-test-fixer
Renamed 3 "PR Self-Reviewer"/"self-reviewer" references to "PR Reviewer"
and updated coordination section for dual-account architecture.
2026-04-10 20:51:28 +00:00
clever-agent edbb3471b0 docs(spec): eighteenth pass fixing review template gaps and credential completeness
- Updated Section 6.17 introduction to include FORGEJO_REVIEWER_PASSWORD
- Updated Section 6.17 env table descriptions for clarity
- Added v1.33.0 revision entry for template and credential fixes
2026-04-10 20:43:55 +00:00
clever-agent 858afa19d3 fix(agents): rewrite review templates to use curl, fix stuck-PR creds, rename title
- pr-reviewer.md: renamed "PR Self-Reviewer" to "PR Reviewer", rewrote
  APPROVE and REQUEST_CHANGES templates to use curl with FORGEJO_REVIEWER_PAT
  instead of denied MCP tools, corrected step ordering (formal review first,
  backup comment second)
- pr-review-pool-supervisor.md: added all 3 reviewer credentials to stuck-PR
  prompt which was missing them entirely
2026-04-10 20:43:44 +00:00
clever-agent 5dda3a2c43 docs(spec): seventeenth pass documenting MCP token limitation and curl workaround
- Added Section 6.17.0: MCP Token Limitation — single server-level token,
  no per-call override, PR Reviewer must use curl for writes
- Rewrote Section 21.22: "Total Bash Lockdown" -> "Restricted Bash with curl"
- Added READ-via-MCP/WRITE-via-curl operation table
- Added v1.32.0 revision entry
2026-04-10 20:37:33 +00:00
clever-agent bdfd4dd042 fix(agents): implement curl-based reviewer auth for MCP token limitation
The Forgejo MCP tools authenticate with a single server-level token that
cannot be overridden per-call. The PR Reviewer must use curl with
FORGEJO_REVIEWER_PAT for write operations (reviews, comments) to
authenticate as the reviewer account.

- pr-reviewer.md: added curl allow, denied MCP write tools, added
  curl-based review/comment API patterns with FORGEJO_REVIEWER_PAT
- pr-review-pool-supervisor.md: passes all 3 reviewer creds, documents
  READ-via-MCP/WRITE-via-curl split
- product-builder.md: passes FORGEJO_REVIEWER_PASSWORD to review pool
2026-04-10 20:37:21 +00:00
clever-agent 6baf921b52 docs(spec): sixteenth pass adding FORGEJO_REVIEWER_PASSWORD and purging stale language
- Added FORGEJO_REVIEWER_PASSWORD to Section 6.17 env table and Appendix C
- Purged all remaining "self-approval"/"shared bot account" language from spec
- Updated Sections 8.3.2 and 8.3.3 for dual-account architecture
- Added v1.31.0 revision entry
2026-04-10 20:31:25 +00:00
clever-agent edd87d4847 fix(agents): add FORGEJO_REVIEWER_PASSWORD and purge stale self-approval language
- shared/credential_security.md: added FORGEJO_REVIEWER_PASSWORD, fixed comment
- shared/merge_safety.md: updated approval docstring + comment for dual-account
- implementation-worker.md: updated 2 approval function docstrings
- pr-merge-pool-supervisor.md: removed 2 stale self-approval references
- pr-reviewer.md: removed stale self-approval error handling text
- project-bootstrapper.md: updated branch protection notes for dual-account
2026-04-10 20:31:14 +00:00
clever-agent fcff61e1b5 docs(spec): fifteenth pass introducing dual-account architecture
- Rewrote Section 6.17: "Shared Bot Account Problem" -> "Dual-Account Architecture"
- New env vars: FORGEJO_REVIEWER_PAT, FORGEJO_REVIEWER_USERNAME
- Formal APPROVED reviews are now the primary approval path
- Updated Section 6.17.2: "Two-Step" -> "Dual-Account Review Protocol"
- Updated Appendix C environment variable table
- Added v1.30.0 revision entry
2026-04-10 20:23:55 +00:00
clever-agent 17fbcbeb6e feat(agents): introduce dual-account architecture for PR reviews
Solves the "shared bot account problem" by introducing a separate Forgejo
reviewer account (FORGEJO_REVIEWER_PAT / FORGEJO_REVIEWER_USERNAME).

- pr-reviewer.md: rewrote review protocol to use reviewer credentials,
  formal APPROVED reviews are now the primary path (not a workaround)
- pr-review-pool-supervisor.md: passes reviewer credentials to dispatched reviewers
- pr-merge-pool-supervisor.md: updated approval detection to recognize
  reviewer account as primary approver
- product-builder.md: passes reviewer creds when launching review pool
- shared/credential_security.md: added FORGEJO_REVIEWER_PAT and
  FORGEJO_REVIEWER_USERNAME to required credentials
2026-04-10 20:23:43 +00:00
clever-agent 4029a3331a docs(spec): fourteenth pass adding subagent specialization principle
CI / benchmark-publish (push) Waiting to run
CI / lint (push) Successful in 32s
CI / push-validation (push) Successful in 23s
CI / helm (push) Successful in 34s
CI / quality (push) Successful in 36s
CI / build (push) Successful in 36s
CI / security (push) Successful in 1m4s
CI / typecheck (push) Successful in 1m8s
CI / benchmark-regression (push) Waiting to run
CI / integration_tests (push) Successful in 4m7s
CI / e2e_tests (push) Successful in 4m15s
CI / unit_tests (push) Successful in 5m21s
CI / docker (push) Successful in 1m20s
CI / coverage (push) Successful in 11m8s
CI / status-check (push) Successful in 2s
- Added Section 6.0: Subagent Specialization Principle (centralize, dont duplicate)
- Updated Section 5.3.4: interval calculation now ATM-centralized
- Updated Section 5.4: 11 operations (added CYCLE_ANNOUNCEMENT_REVIEW)
- Added v1.29.0 revision entry: 17 duplicated blocks removed
2026-04-10 16:15:44 -04:00
clever-agent cd49434c0d fix(agents): centralize interval calculation in ATM, eliminate duplication
Per Subagent Specialization Principle: removed 17 duplicated rolling
average calculation blocks from all supervisors. The ATM now handles
interval calculation internally via --sleep-interval-default parameter.

- automation-tracking-manager.md: added sleep_interval_default to CREATE_TRACKING_ISSUE,
  added CYCLE_ANNOUNCEMENT_REVIEW operation (#11)
- All 17 supervisor agents: replaced 7-line interval calc with --sleep-interval-default param
- shared/tracking_discovery_guide.md: updated to reference ATM-handled interval
2026-04-10 16:15:44 -04:00
clever-agent c29975de8f docs(spec): thirteenth pass documenting body template field enforcement
- Added v1.28.0: all 18 status-creating agents now have Estimated Cycle Interval
  in their actual body templates, not just in reference notes
2026-04-10 16:15:44 -04:00
clever-agent e3a9114ae3 fix(agents): add Estimated Cycle Interval to all tracking body templates
Added the **Estimated Cycle Interval** field to the actual tracking body
template strings in all 14 agents that had inline body strings without it.
Fixed 2 non-standard body formats (project-owner had [HEALTH] header,
bug-hunt had no header). All 18 status-creating agents now produce tracking
issues with the standardized header including the interval field.
2026-04-10 16:15:44 -04:00
clever-agent c70adfbbe5 docs(spec): twelfth pass documenting tracking reference reorder across all agents
- Added v1.27.0 entry: all 17 agents fixed with correct READ-before-CREATE order
- All agents now include rolling average interval defaults and Estimated Cycle Interval requirement
2026-04-10 16:15:44 -04:00
clever-agent 0a74cb6a70 fix(agents): reorder tracking operations to READ-before-CREATE in all 17 agents
All 17 supervisor/orchestrator agents had CREATE_TRACKING_ISSUE before
READ_TRACKING_STATE in their tracking operations reference. This wrong
ordering causes agents to destroy state before recovering it. Fixed all
to: READ (recover state) -> calculate rolling interval -> CREATE (new issue).

Each agent now includes:
- Startup recovery with READ_TRACKING_STATE as step 1
- Rolling average interval calculation with agent-specific defaults
- Note that tracking body MUST include Estimated Cycle Interval field
2026-04-10 16:15:44 -04:00
clever-agent 8443facae2 docs(spec): eleventh pass adding cycle interval, dual cleanup, and continuity
- Added Section 5.3.4: Estimated Cycle Interval (rolling average 90/10)
- Added Section 5.3.5: Dual Status Issue Cleanup (agent-side + groomer-side)
- Added Section 5.3.6: Cycle Number Continuity Across Sessions
- Updated Section 5.6 body template with mandatory Estimated Cycle Interval field
- Added v1.26.0 revision entry
2026-04-10 16:15:44 -04:00
clever-agent 1119dbb6a4 fix(agents): add estimated cycle interval, dual cleanup, and cycle continuity
- automation-tracking-manager.md: added estimated_cycle_interval to READ_TRACKING_STATE return
- system-watchdog-pool-supervisor.md: replaced hardcoded interval lookup with parsing from
  status issue body, changed staleness threshold from 1.2x to 2x
- backlog-grooming-pool-supervisor.md: added Pass 20 for duplicate status issue deduplication
- shared/tracking_discovery_guide.md: added rolling average calculation pattern
2026-04-10 16:15:44 -04:00
clever-agent 276ce39908 docs(spec): tenth pass adding startup state recovery protocol
- Added Section 5.3.3: Startup State Recovery Protocol with mandatory
  read-then-delete-then-create sequence
- Agent-specific recovery table for IPS, PR pools, watchdog, product-builder
- Offline duration behavior rules (5min = normal, 2h+ = full re-scan)
- Enhanced READ_TRACKING_STATE return schema in Section 5.4
- Added v1.25.0 revision entry
2026-04-10 16:15:44 -04:00
clever-agent 4e9ff33430 fix(agents): add startup state recovery protocol to tracking system
- automation-tracking-manager.md: enhanced READ_TRACKING_STATE to return full
  comments, creation timestamp, and offline duration for crash recovery
- implementation-pool-supervisor.md: added state recovery as mandatory first
  action (before PR analysis), with branch/PR target extraction and resume logic
- product-builder.md: replaced manual curl state detection with ATM
  READ_TRACKING_STATE for consistent crash recovery
- shared/tracking_discovery_guide.md: added mandatory startup recovery protocol
  documenting the correct read-then-delete-then-create sequence
2026-04-10 16:15:43 -04:00
clever-agent 5615468303 docs(spec): ninth pass completing tracking protocol rollout documentation
- Added v1.24.0 entry documenting 12 agent fixes across 13 files
- All 19 supervisor/orchestrator agents now have complete tracking protocol
2026-04-10 16:15:43 -04:00
clever-agent 1c64230845 fix(agents): complete rollout of tracking protocol to all supervisors
- 5 supervisors missing automation-tracking-manager task permission (silent failures)
- 5 more announcement creators now review own announcements
- 6 supervisors added READ_ANNOUNCEMENTS for watchdog critical
- pr-fix-pool-supervisor added pre-dispatch announcement check + ATM perm
- product-builder fixed stale [AUTO-SYS-WATCH] -> [AUTO-WATCHDOG], added READ_ANNOUNCEMENTS + REVIEW_OWN
- All 19 agents now have complete tracking create/read/review cycle
2026-04-10 16:15:43 -04:00
clever-agent d3165fcb37 docs(spec): eighth pass comprehensive automation tracking system rewrite
- Rewrote Section 5.2 (Status Issues): one-at-a-time invariant, close-ALL-then-create protocol
- Added Section 5.3.1 (Announcement Lifecycle): mandatory self-review every 3 cycles
- Added Section 5.3.2 (Consumption Protocol): per-agent triage table with 3 read depth levels
- Status issues now use explicit "Status:" prefix to distinguish from announcements
- Announcements require Priority/* labels for triage
- Added v1.23.0 revision entry
2026-04-10 16:15:43 -04:00
clever-agent c92b108cb0 fix(agents): add announcement review/consumption protocol to supervisors
- automation-tracking-manager.md: strengthened close-ALL-then-create invariant
- backlog-grooming-pool-supervisor.md: added READ_ANNOUNCEMENTS + REVIEW_OWN
- pr-review-pool-supervisor.md: added READ_ANNOUNCEMENTS + REVIEW_OWN
- agent-evolution-pool-supervisor.md: added READ_ANNOUNCEMENTS + REVIEW_OWN
- shared/tracking_discovery_guide.md: added mandatory review + consumption protocols
2026-04-10 16:15:43 -04:00
clever-agent 93eb5d8e95 docs(spec): seventh pass adding directory layout and subsystem verification
- Added Section 2.4 (Directory Layout) documenting full .opencode/ structure
- Verified 3-Tier Approval Detection matches implementation exactly
- Verified Mandatory Merge Verification matches merge_safety.md exactly
- Confirmed zero remaining stale names/labels/prefixes across all files
- Added v1.22.0 revision entry
2026-04-10 16:15:43 -04:00
clever-agent 44cb197124 fix(agents): add missing bash deny and edit deny to forgejo-signature-appender
The forgejo-signature-appender was the only active agent without any
bash restriction — it could run arbitrary commands despite being a
text-formatting agent that only needs Forgejo API access.
2026-04-10 16:15:43 -04:00
clever-agent dd68f47b0e docs(spec): sixth pass documenting universal label deny rule and permission audit
- Expanded Section 6.19 to document universal forgejo_add_issue_labels deny rule with 2 exceptions
- Added v1.21.0 revision entry documenting 6 agent fixes
- Verified 41 edit:deny and 3 webfetch:allow match spec claims exactly
2026-04-10 16:15:43 -04:00
clever-agent 8c7143e5ca fix(agents): add missing forgejo_add_issue_labels deny and fix YAML bug
- pr-editor.md: added missing forgejo_add_issue_labels: deny
- pr-manager.md: added missing forgejo_add_issue_labels: deny
- pr-merge-pool-supervisor.md: added missing forgejo_add_issue_labels: deny
- async-agent-manager.md: added missing forgejo_add_issue_labels: deny
- forgejo-signature-appender.md: fixed broken YAML (permission: {} -> permission:), added missing forgejo_add_issue_labels: deny
2026-04-10 16:15:43 -04:00
clever-agent d4bf789989 docs(spec): fifth pass adding permission audit results to revision history
- Added v1.20.0 documenting 3 agent permission bugs fixed
- All 79 agents task permissions verified against spec subagent claims
2026-04-10 16:15:43 -04:00
clever-agent 446c6d2a67 fix(agents): fix misplaced permissions and deprecated subagent reference
- implementation-worker.md: moved pr-creator and pr-ci-test-fixer from forgejo: to task: block (IW could not invoke them as subagents), added missing hidden: true
- pr-ci-test-fixer.md: fixed coverage-checker -> coverage-improver (coverage-checker is deprecated)
2026-04-10 16:15:43 -04:00
clever-agent dbd90975c0 docs(spec): fourth pass fixing broken cross-references and stale work types
- Fixed broken Section 20.4 reference (section was removed in v1.16.0)
- Fixed wrong Section 13.2 reference (should be Section 11.2 for escalation)
- Replaced stale stale-check work type with awaiting-review in Section 10.1
- Added v1.19.0 revision entry
2026-04-10 16:15:43 -04:00
clever-agent 22f0a6fa2c fix(agents): clean config files of deprecated entries and missing allocations
- models.yaml: removed deprecated quality-gate-escalator, added runtime model comments for ref-reader and spec-reader
- resources.yaml: added missing pr-fix-pool-supervisor (0.25 allocation), added missing pr-merge-pool-supervisor (singleton)
2026-04-10 16:15:43 -04:00
clever-agent 0902a4508d docs(spec): third pass fixing Appendix A model and adding revision history
- Fixed build-opencode model in Appendix A from (not specified) to claude-sonnet-4-6
- Added v1.18.0 revision entry documenting 6 functional bugs fixed in agent definitions
2026-04-10 16:15:43 -04:00
clever-agent 49739c52ed fix(agents): fix functional bugs in task permissions and worker launch names
- implementation-pool-supervisor.md: task permission timeline-updater -> timeline-update-pool-supervisor, fixed 2 stale invocation references
- test-infra-pool-supervisor.md: worker launch agent_name was stale (workers were failing async-agent-manager validation)
- uat-test-pool-supervisor.md: worker launch agent_name was stale (workers were failing async-agent-manager validation)
- human-liaison-pool-supervisor.md: fixed stale task invocation to use Forgejo issue creation, fixed backtick-quoted project-owner reference
- async-agent-manager.md: updated documentation agent name list to current names
2026-04-10 16:15:43 -04:00
clever-agent 2488a34bc8 docs(spec): second pass adding pagination, PR ownership, and reviewer lockdown
- Added Section 6.20: Forgejo API Pagination Requirement
- Added Section 6.21: PR Ownership Detection rules
- Expanded Section 8.1.2: three mandatory PR dispatch rules, updated scoring table
- Added Section 21.22: PR Reviewer total bash lockdown permissions
- Fixed Appendix A note: ASV Benchmarker is subagent not primary
- Added revision history entry v1.17.0
2026-04-10 16:15:43 -04:00
clever-agent e43ca83984 fix(agents): update remaining stale agent name references
- product-builder.md: implementation-orchestrator -> implementation-pool-supervisor
- async-agent-manager.md: updated entire valid_agents list (15+ stale names)
- async-agent-monitor.md: implementation-orchestrator -> implementation-pool-supervisor
- shared/logging.md: pr-self-reviewer -> pr-reviewer
- agent-evolution-pool-supervisor.md: continuous-pr-reviewer -> pr-review-pool-supervisor
- shared/tracking_discovery_guide.md: implementation-orchestrator -> implementation-pool-supervisor
2026-04-10 16:15:43 -04:00
HAL9000 a12c42bf3e Merge pull request 'fix(cli): add deleted_at field to project delete JSON/YAML output' (#6639) from fix/issue-6314-project-delete-output into master
CI / benchmark-publish (push) Waiting to run
CI / lint (push) Successful in 44s
CI / typecheck (push) Successful in 1m15s
CI / security (push) Successful in 1m0s
CI / quality (push) Successful in 57s
CI / benchmark-regression (push) Waiting to run
CI / build (push) Successful in 20s
CI / helm (push) Successful in 23s
CI / push-validation (push) Successful in 32s
CI / e2e_tests (push) Successful in 4m8s
CI / integration_tests (push) Successful in 4m47s
CI / unit_tests (push) Successful in 6m5s
CI / docker (push) Successful in 1m34s
CI / coverage (push) Successful in 12m55s
CI / status-check (push) Successful in 1s
2026-04-10 19:45:43 +00:00
HAL9000 e19c6a203c fix(cli): add deleted_at field to project delete JSON/YAML output (#6314)
CI / lint (pull_request) Successful in 50s
CI / quality (pull_request) Successful in 35s
CI / security (pull_request) Successful in 55s
CI / typecheck (pull_request) Successful in 58s
CI / push-validation (pull_request) Successful in 19s
CI / helm (pull_request) Successful in 23s
CI / build (pull_request) Successful in 39s
CI / e2e_tests (pull_request) Successful in 4m12s
CI / integration_tests (pull_request) Successful in 5m18s
CI / unit_tests (pull_request) Successful in 5m33s
CI / docker (pull_request) Successful in 1m35s
CI / coverage (pull_request) Successful in 14m36s
CI / status-check (pull_request) Successful in 1s
CI / benchmark-publish (pull_request) Has been skipped
CI / benchmark-regression (pull_request) Successful in 58m28s
ISSUES CLOSED: #6314
2026-04-10 18:59:10 +00:00
clever-agent d8a31527f3 feat(docs): create agent system specification
CI / push-validation (push) Successful in 17s
CI / helm (push) Successful in 23s
CI / build (push) Successful in 28s
CI / lint (push) Successful in 32s
CI / quality (push) Successful in 33s
CI / typecheck (push) Successful in 54s
CI / security (push) Successful in 1m11s
CI / benchmark-regression (push) Has been skipped
CI / e2e_tests (push) Successful in 3m20s
CI / integration_tests (push) Successful in 4m1s
CI / unit_tests (push) Successful in 5m16s
CI / docker (push) Successful in 1m55s
CI / coverage (push) Successful in 10m19s
CI / status-check (push) Successful in 1s
CI / benchmark-publish (push) Successful in 1h13m44s
- Adds a comprehensive specification for the autonomous agent system.
- Details the intended behavior, interactions, and design of all agents.
- Includes Kroki-based diagrams for workflows and interactions.
- Serves as the source of truth for agent implementation.
2026-04-10 14:28:41 -04:00
clever-agent 26636b5551 fix(agents): align agent definitions with intended behavior
- Corrects stale agent names in config files.
- Removes duplicate supervisor from product-builder.
- Updates session naming conventions for consistency.
- Aligns label usage with .
- Implements mandatory merge verification protocol.
2026-04-10 14:28:41 -04:00
HAL9000 c98d97d90c build: ensure when implementor searches for PRs it finds them correctly
CI / build (push) Successful in 20s
CI / push-validation (push) Successful in 20s
CI / helm (push) Successful in 23s
CI / quality (push) Successful in 35s
CI / lint (push) Successful in 36s
CI / typecheck (push) Successful in 49s
CI / security (push) Successful in 59s
CI / benchmark-regression (push) Has been skipped
CI / e2e_tests (push) Successful in 3m13s
CI / integration_tests (push) Successful in 3m57s
CI / unit_tests (push) Successful in 5m28s
CI / docker (push) Successful in 1m19s
CI / coverage (push) Has been cancelled
CI / benchmark-publish (push) Has been cancelled
CI / status-check (push) Has been cancelled
2026-04-10 14:16:30 -04:00
CoreRasurae 527c5903a0 fix(cli): display full ULIDs in plan tree output for CLI usability
CI / benchmark-publish (pull_request) Has been skipped
CI / push-validation (pull_request) Successful in 16s
CI / build (pull_request) Successful in 19s
CI / helm (pull_request) Successful in 33s
CI / lint (pull_request) Successful in 39s
CI / quality (pull_request) Successful in 43s
CI / security (pull_request) Successful in 51s
CI / typecheck (pull_request) Successful in 58s
CI / e2e_tests (pull_request) Successful in 3m21s
CI / integration_tests (pull_request) Successful in 4m12s
CI / unit_tests (pull_request) Successful in 5m3s
CI / docker (pull_request) Successful in 1m18s
CI / coverage (pull_request) Successful in 11m40s
CI / status-check (pull_request) Successful in 1s
CI / build (push) Successful in 22s
CI / helm (push) Successful in 27s
CI / push-validation (push) Successful in 27s
CI / quality (push) Successful in 31s
CI / lint (push) Successful in 40s
CI / typecheck (push) Successful in 47s
CI / security (push) Successful in 1m17s
CI / benchmark-regression (push) Has been skipped
CI / e2e_tests (push) Successful in 3m8s
CI / integration_tests (push) Successful in 3m54s
CI / unit_tests (push) Successful in 4m53s
CI / docker (push) Has been cancelled
CI / coverage (push) Has been cancelled
CI / benchmark-publish (push) Has been cancelled
CI / status-check (push) Has been cancelled
CI / benchmark-regression (pull_request) Successful in 58m47s
Modified the agents plan tree command to display full 26-character ULIDs
instead of truncating them to 8 characters. This enables users to copy
decision IDs directly from the tree output and use them in follow-up
CLI commands without manual ID reconstruction.

Key changes:
- Removed [:8] truncation from all decision ID displays (table, tree)
- Updated table column width from 8 to 26 characters for full ULID display
- Removed [...] truncation from plan ID in tree title
- Added 'Decision IDs (for correction)' section listing all decision ULIDs
  with human-readable labels for easy reference
- Supports both rich (with panel) and plain text formatting
- Helper function _get_decision_label() generates appropriate labels
  based on decision type
- Updated CHANGELOG.md per CONTRIBUTING.md requirements

ISSUES CLOSED: #5825
2026-04-10 18:57:41 +01:00
HAL9000 67617f6a6e fix(agents): add mandatory merge verification and pre-merge rebase to prevent false merge reports
CI / build (push) Successful in 24s
CI / lint (push) Successful in 25s
CI / helm (push) Successful in 31s
CI / quality (push) Successful in 33s
CI / typecheck (push) Successful in 47s
CI / security (push) Successful in 1m3s
CI / benchmark-regression (push) Has been skipped
CI / push-validation (push) Successful in 46s
CI / e2e_tests (push) Successful in 4m25s
CI / integration_tests (push) Successful in 4m26s
CI / unit_tests (push) Successful in 4m55s
CI / docker (push) Successful in 10s
CI / coverage (push) Successful in 10m10s
CI / status-check (push) Successful in 1s
CI / benchmark-publish (push) Has been cancelled
The forgejo_merge_pull_request MCP tool returns 'Pull request merged
successfully' even when the merge silently fails (e.g. branch behind
base). This caused the PR merge supervisor to post false 'Automatically
merged' comments on PRs that were never actually merged (e.g. #6726,
#6695, #5276, #6571).

Three interconnected fixes:

- pr-merge-pool-supervisor: Always verify merge via
  forgejo_get_pull_request_by_index (merged==true, state==closed) before
  posting success comments. Check merge_base vs base.sha before merge
  and auto-rebase when branch is behind. Handle silent merge failures
  with rebase-and-retry on next cycle.

- shared/merge_safety: safe_merge_pr() now verifies merge completed by
  checking PR state after the API call. Returns failure when PR is still
  open despite the tool claiming success.

- implementation-worker: Add rebase-before-merge check and verification
  rules to the ready-to-merge workflow.

ISSUES CLOSED: #6726
2026-04-10 13:44:50 -04:00
HAL9000 51807d9431 build: Fixed implementor sometimes not going into PR first mode
CI / push-validation (push) Successful in 17s
CI / helm (push) Successful in 24s
CI / build (push) Successful in 25s
CI / lint (push) Successful in 26s
CI / quality (push) Successful in 32s
CI / typecheck (push) Successful in 53s
CI / security (push) Successful in 1m0s
CI / benchmark-regression (push) Has been skipped
CI / e2e_tests (push) Successful in 3m13s
CI / integration_tests (push) Successful in 6m17s
CI / unit_tests (push) Successful in 7m29s
CI / docker (push) Successful in 1m20s
CI / coverage (push) Successful in 10m23s
CI / status-check (push) Successful in 2s
CI / benchmark-publish (push) Has been cancelled
2026-04-10 12:51:04 -04:00
HAL9000 6e8cdcc1a1 fix(agents): unblock PR merging by adding 3-tier approval detection and two-step review protocol
CI / push-validation (push) Successful in 22s
CI / helm (push) Successful in 27s
CI / build (push) Successful in 28s
CI / quality (push) Successful in 36s
CI / lint (push) Successful in 37s
CI / typecheck (push) Successful in 50s
CI / security (push) Successful in 56s
CI / benchmark-regression (push) Has been skipped
CI / e2e_tests (push) Successful in 3m1s
CI / integration_tests (push) Successful in 3m58s
CI / unit_tests (push) Successful in 5m2s
CI / docker (push) Successful in 21s
CI / coverage (push) Successful in 10m24s
CI / status-check (push) Successful in 1s
CI / benchmark-publish (push) Has been cancelled
Root cause: Forgejo rejects formal APPROVED reviews when the reviewer is
the same user who created the PR ("approve your own pull is not allowed").
Since all agents share a single bot account (HAL9000), every PR is both
authored and reviewed by the same user, making formal APPROVED reviews
impossible. All merge agents only checked for formal APPROVED reviews or
issue comments, but the pr-reviewer posted approval language in review
bodies (state=COMMENT) — a source no merge agent inspected.

This created a deadlock: PRs had passing CI, were mergeable, and had been
reviewed with approval language, but no agent could detect the approval.

Changes:

- shared/merge_safety.md: Add review-body scanning to check_flexible_approval
  so COMMENT/PENDING reviews containing approval keywords (lgtm, approved,
  decision: approved, etc.) count as valid approvals alongside formal
  reviews and issue comments.

- pr-merge-pool-supervisor.md: Update check_pr_approval() with the same
  3-tier detection (formal review → review body → issue comment). Update
  has_blocking_reviews() to compare REQUEST_CHANGES timestamps against
  approval signals from all three sources.

- implementation-worker.md: Update both has_required_approvals() functions
  with 3-tier approval detection matching the shared utilities.

- pr-reviewer.md: Replace single-step review with two-step protocol:
  (1) Always post an issue comment with clear approval keywords — this is
  the durable signal merge automation detects. (2) Also attempt a formal
  APPROVED review — succeeds for non-self PRs, gracefully fails for self
  PRs. The comment from step 1 is sufficient on its own.

- devcontainer configs: Add explicit -url and -token flags to forgejo-mcp
  command; update deprecated GITEA_ env vars to FORGEJO_ equivalents.
2026-04-10 12:21:05 -04:00
HAL9000 d6ded8e2e9 Docker: fixed forgejo MCP in docker which wasnt working 2026-04-10 12:21:05 -04:00
HAL9000 90b15d802a Merge pull request #6942 from docs/auto-docs-cycle-1-updates
CI / push-validation (push) Successful in 20s
CI / helm (push) Successful in 24s
CI / lint (push) Successful in 28s
CI / build (push) Successful in 33s
CI / quality (push) Successful in 34s
CI / typecheck (push) Successful in 53s
CI / security (push) Successful in 1m1s
CI / benchmark-regression (push) Has been skipped
CI / e2e_tests (push) Successful in 3m13s
CI / integration_tests (push) Successful in 3m56s
CI / unit_tests (push) Successful in 5m3s
CI / docker (push) Successful in 1m19s
CI / coverage (push) Successful in 10m15s
CI / status-check (push) Successful in 1s
CI / benchmark-publish (push) Successful in 1h13m58s
docs: update CHANGELOG and automation-tracking for recent agent changes

Closes #7116
2026-04-10 11:44:42 +00:00