cleveragents/cleveragents-core
4
0
Fork 3
Code Issues 6.0k Pull Requests 115 Packages Projects Releases Wiki Activity

fix(tui): replace # type: ignore with cast() in TDD step file
CI / push-validation (pull_request) Successful in 37s
CI / helm (pull_request) Successful in 43s
CI / lint (pull_request) Successful in 1m18s
CI / typecheck (pull_request) Successful in 1m23s
CI / build (pull_request) Successful in 59s
CI / security (pull_request) Successful in 1m32s
CI / quality (pull_request) Successful in 1m32s
CI / integration_tests (pull_request) Successful in 5m8s
CI / unit_tests (pull_request) Successful in 6m15s
CI / docker (pull_request) Successful in 2m28s
CI / coverage (pull_request) Successful in 11m40s
CI / status-check (pull_request) Successful in 4s

Browse Source 
Remove the prohibited # type: ignore[attr-defined] suppression from
overlay._text access and replace with cast(str, ...).  Update
docstrings to explain the TDD workflow deviation.

Refs: #11039
This commit is contained in:
CoreRasurae
2026-05-12 14:05:41 +00:00
parent 2409b49319
commit fe8906e227
2 changed files with 14 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
features/steps/tdd_tui_actor_overlay_render_shadow_steps.py
+10 -4
View File
@@ -5,15 +5,21 @@ This test captures bug #11039: ``ActorSelectionOverlay`` defined its own
that must return a ``Strip``. The fix (PR #11042) renames the internal
method to ``_refresh_display()``.
Since the fix is already in place on this branch, the scenarios verify
the correct behaviour directly (no ``@tdd_expected_fail`` tag).
The TDD ``@tdd_expected_fail`` workflow phase (separate ``tdd/m5-*``
branch merged to master before the bugfix branch) was not feasible here
because the fix and the regression test were developed on the same PR
branch. The scenarios directly verify the corrected state: no local
``_render`` shadow, ``_refresh_display`` is properly defined, and the
display content renders correctly. This provides equivalent regression
protection; a future re-introduction of a local ``_render`` method would
be caught by the first scenario.
See CONTRIBUTING.md > Bug Fix Workflow > TDD Issue Test Tags.
"""
from __future__ import annotations
from typing import Any
from typing import Any, cast
from behave import given, then, when
@@ -87,7 +93,7 @@ def step_assert_refresh_display_produces_content(context: Any) -> None:
"""
overlay: ActorSelectionOverlay = ActorSelectionOverlay()
overlay.show()
content: str = overlay._text # type: ignore[attr-defined]
content: str = cast(str, overlay._text)
assert content, (
"_refresh_display must render non-empty overlay content, but "
"the widget text was empty."
features/tdd_tui_actor_overlay_render_shadow.feature
+4 -2
View File
@@ -12,8 +12,10 @@ Feature: TDD Issue #11039 — ActorSelectionOverlay._render shadowed Textual Wid
``self._render()`` and received ``None`` instead of a renderable.
The fix (PR #11042) renames the internal method to ``_refresh_display()``.
Since the fix is already in place on this branch, the scenarios verify
the correct behaviour directly (no ``@tdd_expected_fail`` tag).
The TDD ``@tdd_expected_fail`` workflow phase was not feasible on a
separate branch here; the scenarios directly verify the corrected state.
A re-introduction of a local ``_render`` method would be caught by the
first scenario, providing equivalent regression protection.
See CONTRIBUTING.md > Bug Fix Workflow > TDD Issue Test Tags.