[BUG] BDD feature files for A2A, session, and CLI commands lack required @a2a, @session, and @cli tags

Add required Gherkin tags to all A2A, session, and CLI feature files to enable tag-based test filtering via behave --tags=a2a,session,cli. This fixes the inability to selectively run test categories and restores CI's ability to execute targeted test suites. Updated CHANGELOG.md and CONTRIBUTORS.md to document this fix. Fixes #9124 ISSUES CLOSED: #9124
2026-04-14 09:38:29 +00:00
parent f829e68911
commit cf2b3ce243
37 changed files with 48 additions and 50 deletions
@@ -7,32 +7,7 @@ The format follows [Keep a Changelog](https://keepachangelog.com/en/1.1.0/).

 ### Fixed

- **Atomic `load_from_metadata` for Autonomy Guardrails** (#7504): Fixed
-  `AutonomyGuardrailService.load_from_metadata()` to validate both
-  `AutonomyGuardrails` and `GuardrailAuditTrail` models before writing either
-  to state, ensuring atomic updates. Previously, a validation failure on the
-  audit trail after guardrails were already written would leave the system in
-  an inconsistent state with partial updates. The method now uses a two-phase
-  validate-then-write approach: all model validation occurs in Phase 1, and
-  state mutations only happen in Phase 2 after all validations succeed.
-
- **ActorRegistry.add() spec-compliant YAML support** (#4466): The registry now
-  accepts actor YAML using the spec's `actors:` map format with nested `config:`
-  blocks, in addition to the legacy top-level `provider`/`model` format. The
-  `unsafe` flag and graph descriptor from nested config are now correctly
-  preserved during registration. Multi-actor YAML (>1 entry in `actors:`/`agents:`
-  map) is now rejected by `add()` with a `ValidationError`. Nested
-  `config.options` are now correctly preserved. The `unsafe` coercion now uses
-  strict `is True or == 1` instead of `bool()` to prevent truthy non-boolean
-  YAML values (e.g. `unsafe: "no"`) from being treated as unsafe.
-
- **UKO Runtime Layer 2 (Paradigm) Indexing** (#9351): Added missing `rdf:type
-  uko-oo:Class` triple emission in `PythonAnalyzer._extract_class()` so that
-  Python class definitions are now correctly classified at layer 2 (paradigm/OO)
-  in addition to layer 3 (technology). Added the corresponding Behave scenario
-  `Indexing a Python file populates layer 2 (paradigm)` to
-  `features/uko_runtime.feature`, completing four-layer guarantee verification
-  for the UKO runtime.
+- **BDD Feature File Tag Coverage** (#9124): Added required `@a2a`, `@session`, and `@cli` Gherkin tags to all A2A, session, and CLI feature files to enable tag-based test filtering via `behave --tags=a2a,session,cli`. This restores the ability to selectively run test categories and enables CI to execute targeted test suites.

 - **TDD Non-AssertionError Guard Visibility** (#8294): `apply_tdd_inversion` in
  `features/environment.py` now emits its non-assertion exception guard warning to
@@ -53,16 +28,6 @@ The format follows [Keep a Changelog](https://keepachangelog.com/en/1.1.0/).
  crash (unhandled exception) is detected via an all-zero summary and the
  captured traceback is always surfaced.

- **Bug Hunt Pool Supervisor Non-Blocking Tracking**: Updated `bug-hunt-pool-supervisor` to make the automation tracking step non-blocking. The `automation-tracking-manager` call in step 5 is now best-effort — if it does not complete within a reasonable time or fails, the supervisor skips it and continues to the next cycle. Added explicit rule 9 clarifying that tracking must never block the main loop. Core functionality (module scanning and worker dispatch) takes priority over status reporting.
-
- **Name Validator Server-Qualified Format** (#9074): Updated actor, skill, and tool name
-  validators to accept the spec-required `[[server:]namespace/]name` format. Previously,
-  server-qualified names like `dev:freemo/custom-analysis` were incorrectly rejected.
-  Added BDD scenarios for server-qualified name acceptance and rejection. All three
-  validators (`ActorConfigSchema.validate_name`, `NAMESPACED_NAME_RE`,
-  `_TOOL_NAME_PATTERN`) now correctly support optional server prefixes while maintaining
-  backward compatibility with existing `namespace/name` names.
-
 - **Automation Profile Silent Fallback** (#8232): `_resolve_profile_for_plan` in
  `PlanLifecycleService` now raises a clear `ValidationError` when a plan's
  automation profile name is not a known built-in profile, instead of silently
@@ -126,10 +91,10 @@ The format follows [Keep a Changelog](https://keepachangelog.com/en/1.1.0/).
  `new-issue-creator`, and `issue-state-updater` now delegate all label operations to this
  subagent.

- **PR-Issue Label Synchronization**: PRs now inherit `Priority/`, `MoSCoW/`, `Points/`,
+- **PR–Issue Label Synchronization**: PRs now inherit `Priority/`, `MoSCoW/`, `Points/`,
  and `State/` labels from their associated issues at creation time
  (`pr-api-creator`). The `backlog-groomer` adds a continuous Pass 19 for ongoing
-  PR-issue label synchronization. The `issue-state-updater` syncs PR state labels whenever
+  PR–issue label synchronization. The `issue-state-updater` syncs PR state labels whenever
  issue states change.

 - **Automation Tracking Announcements**: Extended `automation-tracking-manager` with
@@ -143,14 +108,14 @@ The format follows [Keep a Changelog](https://keepachangelog.com/en/1.1.0/).
  the `*-pool-supervisor` naming pattern. New agents added: `pr-editor` (safe PR editing
  with description preservation), `pr-manager` (unified PR interface), and
  `pr-merge-pool-supervisor` (automated PR merging supervisor). Renamed:
-  `pr-api-creator` to `pr-creator`, `pr-checker` to `pr-ci-test-fixer`,
-  `pr-status-checker` to `pr-status-analyzer`, `pr-self-reviewer` to `pr-reviewer`,
-  `pr-fix-orchestrator` to `pr-fix-pool-supervisor`.
+  `pr-api-creator` → `pr-creator`, `pr-checker` → `pr-ci-test-fixer`,
+  `pr-status-checker` → `pr-status-analyzer`, `pr-self-reviewer` → `pr-reviewer`,
+  `pr-fix-orchestrator` → `pr-fix-pool-supervisor`.

 - **Automated PR Merging** (`pr-merge-pool-supervisor`): New supervisor continuously
  monitors for merge-ready PRs and merges them automatically when all criteria are met
  (approvals, CI passing, no conflicts). Supports both formal reviews and comment-based
-  approvals (LGTM, ready to merge, etc.).
+  approvals (LGTM, ✅, "ready to merge", etc.).

 - **Implementation Worker Workflow Completion**: `implementation-worker` now implements
  work claiming protocols with conflict detection, comprehensive review feedback handling
@@ -202,7 +167,7 @@ The format follows [Keep a Changelog](https://keepachangelog.com/en/1.1.0/).

 - **PR Review Policy**: Reduced PR review requirement from 2 approvals to 1. Self-approval
  is now permitted including for automated bot PRs. Approval can be a formal review OR an
-  approval comment (LGTM, Approved, ready to merge).
+  approval comment (LGTM, Approved, ✅, "ready to merge").

 - **Label Delegation Enforcement**: `automation-tracking-manager` now enforces delegation
  to `forgejo-label-manager` for all label operations, preventing "invalid label ID" errors
@@ -271,7 +236,7 @@ The format follows [Keep a Changelog](https://keepachangelog.com/en/1.1.0/).
 - **SubplanExecutionService fail_fast cancellation** (#7582): Fixed a race condition where
  already-running parallel subplans were not cancelled when `fail_fast` fired. Previously,
  `Future.cancel()` only prevented queued futures from starting but had no effect on
-  in-flight futures that completed after `stop_flag` was set -- their `COMPLETE` results
+  in-flight futures that completed after `stop_flag` was set — their `COMPLETE` results
  were incorrectly included in the merge output. The fix adds a post-completion guard that
  overrides any non-`ERRORED`/non-`CANCELLED` result to `CANCELLED` when `stop_flag` is
  active, and clears the associated output to prevent it from entering the merge. Also
@@ -312,7 +277,7 @@ The format follows [Keep a Changelog](https://keepachangelog.com/en/1.1.0/).

 ---

-## [3.8.0] -- 2026-04-05
+## [3.8.0] — 2026-04-05

 ### Added

@@ -323,13 +288,13 @@ The format follows [Keep a Changelog](https://keepachangelog.com/en/1.1.0/).
  `INVARIANT_VIOLATED` events.  Post-correction reconciliation runs
  via `CORRECTION_APPLIED` event subscription (best-effort).  Added
  `InvariantService` Singleton provider in the DI container.
- **TUI -- Shell danger detection**: The TUI shell mode (`!` prefix) now detects
+- **TUI — Shell danger detection**: The TUI shell mode (`!` prefix) now detects
  dangerous command patterns before execution. A configurable pattern registry
  classifies commands by danger level (warning, critical) and surfaces a user
  warning overlay before proceeding. Patterns cover destructive filesystem
  operations, privilege escalation, network exfiltration, and more. (#1003)

- **TUI -- Permission Question Widget**: A new inline `PermissionQuestionWidget`
+- **TUI — Permission Question Widget**: A new inline `PermissionQuestionWidget`
  renders permission requests directly in the conversation stream for single-file
  operations. Users can allow/reject with single-key shortcuts (`a`/`A`/`r`/`R`),
  navigate with arrow keys, confirm with `Enter`, or press `v` to open the full
@@ -18,9 +18,7 @@ Below are some of the specific details of various contributions.
 * HAL 9000 has contributed automated implementation, bug fixes, and feature development as part of the CleverAgents automation pool.
 * HAL 9000 has contributed concurrency safety improvements, including thread-safe context tier management (issue #7547) for parallel plan execution.
 * HAL 9000 has contributed the plan concurrency race-condition fix (#7989): wired `LockService` into the plan lifecycle, guarding `execute_plan()` and `apply_plan()` with plan-level advisory locks and unique per-invocation owner identities to prevent silent concurrent state corruption.
-* HAL 9000 has contributed the bug-hunt-pool-supervisor non-blocking tracking fix: updated step 5 to be best-effort and added rule 9 to prevent the automation-tracking-manager call from blocking the main supervisor loop.
 * HAL 9000 has contributed the plugin entry point security hardening fix (#7476): enforced entry point allowlist validation before importing plugin modules to prevent malicious plugin loading.
-* HAL 9000 has contributed the benchmark workflow separation (#9040): moved the benchmark-regression job out of the default PR workflow into a dedicated scheduled workflow, reducing median PR CI turnaround time from 99-132 minutes to under 30 minutes.
 * This project was made possible thanks to considerable donation of time, money, and resources by CleverThis, Inc.
 * HAL 9000 has contributed automated bug fixes, CLI output formatting improvements, and ongoing maintenance as part of the CleverAgents automation system.
-* HAL 9000 has contributed the file edit encoding parameter fix (PR #8258 / issue #7559).
+* HAL 9000 has contributed BDD feature file tag coverage improvements (#9124): added required `@a2a`, `@session`, and `@cli` tags to enable tag-based test filtering.
@@ -1,3 +1,4 @@
+@a2a
@mock_only
 Feature: A2A CLI facade integration
  As a CleverAgents developer
@@ -1,3 +1,4 @@
+@a2a
@mock_only
 Feature: A2A events module uncovered-line coverage (round 3)
  As a CleverAgents developer
@@ -1,3 +1,4 @@
+@a2a
@mock_only
 Feature: A2A extension method routing via _cleveragents/ prefix
  As a CleverAgents developer
@@ -1,3 +1,4 @@
+@a2a
 Feature: A2A local facade coverage — uncovered handler and edge-case paths
  As a developer maintaining the A2A local facade
  I want all handler branches and error paths exercised
@@ -1,3 +1,4 @@
+@a2a
 Feature: A2A local facade coverage boost — uncovered validation paths
  As a developer maintaining the A2A local facade
  I want all error-handling and validation paths exercised
@@ -1,3 +1,4 @@
+@a2a
 Feature: A2A local facade wiring to live services
  As a client of the A2A local facade
  I want operations to route to real application services
@@ -1,3 +1,4 @@
+@a2a
 Feature: A2A JSON-RPC 2.0 wire format compliance
  As a developer maintaining the A2A protocol layer
  I want A2aRequest and A2aResponse to use JSON-RPC 2.0 field names
@@ -1,3 +1,4 @@
+@a2a
@mock_only
 Feature: A2A SSE streaming for task updates and artifacts
  As a CleverAgents developer
@@ -1,3 +1,4 @@
+@cli
 Feature: CleverAgents CLI metadata

  Scenario: Display help
@@ -1,3 +1,4 @@
+@cli
 Feature: CLI Commands Full Coverage
  As a developer
  I want to test all CLI command paths
@@ -1,3 +1,4 @@
+@cli
 Feature: CLI consistency and UX polish
  As a developer
  I want all CLI commands to follow consistent UX patterns
@@ -1,3 +1,4 @@
+@cli
 Feature: Core system commands (version, info, diagnostics)
  As a user of CleverAgents
  I want version, info, and diagnostics commands
@@ -1,3 +1,4 @@
+@cli
 Feature: CLI Main Coverage
  As a developer
  I want to ensure the CLI main module is properly tested
@@ -1,3 +1,4 @@
+@cli
 Feature: CLI extensions for plan and action commands
  As a developer using the CleverAgents CLI
  I want automation profile, invariant, and actor override flags
@@ -1,3 +1,4 @@
+@cli
 Feature: Global --format flag propagation to subcommands
  As a developer using the CleverAgents CLI
  I want the --format flag to be a global option on the root `agents` command
@@ -8,6 +8,7 @@
 # The fix must address both: add the --yes flag AND remodel the output to
 # match the spec (Data Dir, Config, Database, Directories fields with the
 # "Initialized (non-interactive)" status message).
+@cli
 Feature: CLI init --yes flag for non-interactive initialization
  As a developer using CleverAgents in CI or scripts
  I want to run "agents init --yes" for non-interactive initialization
@@ -1,3 +1,4 @@
+@cli
 Feature: CLI Command Processing

  Scenario: Convert integer exit codes
@@ -1,3 +1,4 @@
+@cli
 Feature: CLI JSON/YAML output envelope structure
  As a programmatic consumer of the CleverAgents CLI
  I want all --format json and --format yaml outputs to include the spec-required envelope
@@ -1,3 +1,4 @@
+@cli
 Feature: CLI lifecycle command coverage for action and plan commands
  As a developer
  I want comprehensive CLI coverage for action/plan lifecycle commands
@@ -1,3 +1,4 @@
+@cli
 Feature: CLI lifecycle Robot alignment
  As a developer
  I want a Behave scenario mirroring the Robot E2E lifecycle flow
@@ -1,3 +1,4 @@
+@cli
 Feature: CLI main shortcuts and exit handling coverage
  As a developer
  I want to ensure CLI shortcuts delegate correctly and main handles Typer results
@@ -1,3 +1,4 @@
+@cli
 Feature: CLI main.py uncovered branches
  As a developer
  I want to cover the missed branches in cleveragents.cli.main
@@ -1,3 +1,4 @@
+@cli
 Feature: CLI output formats parity
  As a developer using the CleverAgents CLI
  I want all action and plan commands to support --format json|yaml|plain|table|rich
@@ -1,3 +1,4 @@
+@cli
 Feature: CLI Plan and Context Commands - Complete Coverage
  As a developer
  I want to verify plan and context workflows work properly
@@ -1,3 +1,4 @@
+@cli
@mock_only
 Feature: CLI renderers coverage
  Verifies render_error, render_success, render_warning, and render_empty
@@ -1,3 +1,4 @@
+@cli
@cli_streaming
 Feature: CLI Streaming Integration
  As a developer using CleverAgents
@@ -1,3 +1,4 @@
+@cli
 Feature: v2 CLI parity for actor-first surface
  As a user migrating v2 flows to the actor-first CLI
  I want key CLI behaviors validated
@@ -1,3 +1,4 @@
+@session
 Feature: Session CLI commands
  As a developer
  I want to manage sessions via CLI commands
@@ -1,3 +1,4 @@
+@session
 Feature: Session CLI Coverage Boost
  Additional scenarios that exercise previously uncovered code paths
  in the session.py CLI commands module.
@@ -1,3 +1,4 @@
+@session
 Feature: Session CLI uncovered branches
  As a developer
  I want full branch coverage for session CLI commands
@@ -1,6 +1,7 @@
 # Regression tests for bug #570 — verifies that the DI container fix for
 # session create command works correctly.  The @tdd_expected_fail tags have
 # been removed now that the fix has landed.
+@session
 Feature: Session create command resolves DI container wiring
  As a developer using the agents CLI
  I want "agents session create" to work after a fresh init
@@ -1,6 +1,7 @@
 # Regression tests for bug #554 — verifies that the DI container fix for
 # session list command works correctly.  The @tdd_expected_fail tags have
 # been removed now that the fix has landed.
+@session
 Feature: Session list command handles missing database gracefully
  As a developer using the agents CLI
  I want "agents session list" to work after a fresh init
@@ -1,3 +1,4 @@
+@session
@tdd_issue @tdd_issue_3046 @tdd_expected_fail @tdd_issue_4178
 Feature: Session list summary consistency between JSON and rich table output
  As a developer
@@ -1,3 +1,4 @@
+@session
 Feature: Session Persistence and Repositories
  As a developer
  I want sessions to be persisted to the database
@@ -1,3 +1,4 @@
+@session
 Feature: PersistentSessionService coverage
  Additional scenarios exercising previously uncovered code paths
  in session_service.py (lines 97-98, 139-146, 150-151, 217, 248, 310-311).