cleveragents/cleveragents-core
4
0
Fork 3
Code Issues 6.0k Pull Requests 115 Actions Packages Projects Releases Wiki Activity

chore(agents): improve pr-self-reviewer — add blocking vs non-blocking severity classification
CI / lint (pull_request) Successful in 38s
Details
CI / quality (pull_request) Successful in 1m1s
Details
CI / typecheck (pull_request) Successful in 1m12s
Details
CI / security (pull_request) Successful in 1m25s
Details
CI / helm (pull_request) Successful in 30s
Details
CI / build (pull_request) Successful in 38s
Details
CI / push-validation (pull_request) Successful in 40s
Details
CI / unit_tests (pull_request) Successful in 5m36s
Details
CI / docker (pull_request) Successful in 1m37s
Details
CI / integration_tests (pull_request) Successful in 9m30s
Details
CI / coverage (pull_request) Successful in 9m33s
Details
CI / status-check (pull_request) Successful in 3s
Details

Browse Source
This commit is contained in:
HAL 9000
2026-04-22 10:21:45 +00:00
committed by drew
parent 3eb49e4afe
commit 8eebe5734f
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.opencode/agents/pr-self-reviewer.md
+4 -4
View File
@@ -81,8 +81,8 @@ If these are not provided in your reference summary, invoke `ref-reader` IMMEDIA
- **Dependencies**: PR must block linked issue
**YOUR REVIEW AUTHORITY:**
- REQUEST CHANGES for **BLOCKING** CONTRIBUTING.md violations (code quality, testing framework, type safety, file organization, correctness)
- APPROVE with comments for **NON-BLOCKING** issues only (missing PR metadata like closing keywords, labels, milestone)
- REQUEST CHANGES for **BLOCKING** CONTRIBUTING.md violations (code quality, testing framework, type safety, file organization, correctness, PR metadata requirements)
- APPROVE with comments for **NON-BLOCKING** issues only (minor style suggestions, documentation improvements)
- Be specific about which rule is violated
- Quote the relevant CONTRIBUTING.md section
- Suggest how to fix the violation
@@ -411,12 +411,12 @@ These issues MUST be fixed before merge:
- **Flaky test patterns**: Non-deterministic tests (time dependencies, unseeded randomness, shared state)
- **TDD tag violations**: `@tdd_expected_fail` not removed for fixed bugs
- **File size violations**: Files over 500 lines
- **Missing PR metadata**: Closing keywords (`Closes #N`), milestone assignment, labels, dependency links
#### NON-BLOCKING Issues (→ APPROVE with comments)
These issues should be noted but do NOT block merge:
- **Missing PR metadata**: Closing keywords (`Closes #N`), milestone assignment, labels
- **Minor style suggestions**: Naming improvements, comment clarity, formatting
- **Documentation improvements**: Better docstrings, additional examples
- **Merge conflicts**: These are resolved separately by implementation workers
@@ -431,7 +431,7 @@ If ONLY non-blocking issues exist → APPROVE with comments listing the non-bloc
If no issues at all → APPROVE
```
**IMPORTANT**: A PR with only missing metadata (no `Closes #N`, no milestone, no label) but correct code should be **APPROVED with comments** — not rejected. Metadata can be fixed post-merge or by the implementation worker.
**IMPORTANT**: PR metadata requirements (closing keywords, milestone, labels, dependency links) are MANDATORY per CONTRIBUTING.md and must be present before merge. These are BLOCKING issues.
### 6. Make a Decision