diff --git a/.opencode/agents/pr-self-reviewer.md b/.opencode/agents/pr-self-reviewer.md index 1350070aa..0ccb19044 100644 --- a/.opencode/agents/pr-self-reviewer.md +++ b/.opencode/agents/pr-self-reviewer.md @@ -81,8 +81,8 @@ If these are not provided in your reference summary, invoke `ref-reader` IMMEDIA - **Dependencies**: PR must block linked issue **YOUR REVIEW AUTHORITY:** -- REQUEST CHANGES for **BLOCKING** CONTRIBUTING.md violations (code quality, testing framework, type safety, file organization, correctness) -- APPROVE with comments for **NON-BLOCKING** issues only (missing PR metadata like closing keywords, labels, milestone) +- REQUEST CHANGES for **BLOCKING** CONTRIBUTING.md violations (code quality, testing framework, type safety, file organization, correctness, PR metadata requirements) +- APPROVE with comments for **NON-BLOCKING** issues only (minor style suggestions, documentation improvements) - Be specific about which rule is violated - Quote the relevant CONTRIBUTING.md section - Suggest how to fix the violation @@ -411,12 +411,12 @@ These issues MUST be fixed before merge: - **Flaky test patterns**: Non-deterministic tests (time dependencies, unseeded randomness, shared state) - **TDD tag violations**: `@tdd_expected_fail` not removed for fixed bugs - **File size violations**: Files over 500 lines +- **Missing PR metadata**: Closing keywords (`Closes #N`), milestone assignment, labels, dependency links #### NON-BLOCKING Issues (→ APPROVE with comments) These issues should be noted but do NOT block merge: -- **Missing PR metadata**: Closing keywords (`Closes #N`), milestone assignment, labels - **Minor style suggestions**: Naming improvements, comment clarity, formatting - **Documentation improvements**: Better docstrings, additional examples - **Merge conflicts**: These are resolved separately by implementation workers @@ -431,7 +431,7 @@ If ONLY non-blocking issues exist → APPROVE with comments listing the non-bloc If no issues at all → APPROVE ``` -**IMPORTANT**: A PR with only missing metadata (no `Closes #N`, no milestone, no label) but correct code should be **APPROVED with comments** — not rejected. Metadata can be fixed post-merge or by the implementation worker. +**IMPORTANT**: PR metadata requirements (closing keywords, milestone, labels, dependency links) are MANDATORY per CONTRIBUTING.md and must be present before merge. These are BLOCKING issues. ### 6. Make a Decision