fix(data-integrity): Remove duplicate @when decorator, fix feature file indentation, update CONTRIBUTORS.md
CI / benchmark-publish (pull_request) Has been skipped
CI / lint (pull_request) Successful in 1m0s
CI / typecheck (pull_request) Successful in 1m17s
CI / quality (pull_request) Successful in 1m8s
CI / security (pull_request) Successful in 1m24s
CI / build (pull_request) Successful in 39s
CI / push-validation (pull_request) Successful in 22s
CI / helm (pull_request) Successful in 30s
CI / e2e_tests (pull_request) Successful in 3m13s
CI / integration_tests (pull_request) Successful in 4m5s
CI / unit_tests (pull_request) Failing after 4m36s
CI / docker (pull_request) Has been skipped
CI / coverage (pull_request) Successful in 9m52s
CI / status-check (pull_request) Failing after 4s
CI / benchmark-regression (pull_request) Successful in 57m26s

- Remove duplicate @when decorator in llm_trace_steps.py that caused lint failure

- Fix 3-space indentation to 2-space in last two scenarios of llm_trace.feature

- Add HAL 9000 contribution detail to CONTRIBUTORS.md as required by CONTRIBUTING.md §8

Closes #7505
This commit is contained in:
2026-04-24 16:35:19 +00:00
parent 187afc20d5
commit 64e9831bde
3 changed files with 12 additions and 13 deletions
+1
View File
@@ -14,4 +14,5 @@ Below are some of the specific details of various contributions.
* Jeffrey Phillips Freeman has acted as Lead Developer, daily contributor, and Project Owner.
* Brent E. Edwards has contributed quality assurance, test coverage, and CI pipeline improvements.
* HAL 9000 has contributed automated bug fixes, infrastructure improvements, and data integrity fixes including the LLMTraceRepository UnitOfWork alignment.
* This project was made possible thanks to considerable donation of time, money, and resources by CleverThis, Inc.
+11 -11
View File
@@ -270,19 +270,19 @@ Feature: LLM trace observability
Then the langsmith_enabled check should return True
Scenario: Repository save trace with no tool calls stores null
Given a SQLAlchemy in-memory repository
And a valid LLM trace
When I save the trace via the repository
Then the raw tool_calls_json in the database should be null
Given a SQLAlchemy in-memory repository
And a valid LLM trace
When I save the trace via the repository
Then the raw tool_calls_json in the database should be null
# --- UnitOfWork transaction boundary (Issue #7505) ----------------------
@tdd_issue_7505
Scenario: Repository save uses flush not commit within UnitOfWork
Given a SQLAlchemy in-memory repository
And a valid LLM trace
When I save the trace via the repository within a UnitOfWork transaction
Then the trace should be visible within the transaction
And the transaction should not be committed yet
And I should be able to rollback the transaction
And the trace should not exist after rollback
Given a SQLAlchemy in-memory repository
And a valid LLM trace
When I save the trace via the repository within a UnitOfWork transaction
Then the trace should be visible within the transaction
And the transaction should not be committed yet
And I should be able to rollback the transaction
And the trace should not exist after rollback
-2
View File
@@ -953,8 +953,6 @@ def step_raw_tool_calls_null(context: Context) -> None:
# ---------------------------------------------------------------------------
@when("I save the trace via the repository within a UnitOfWork transaction")
@when("I save the trace via the repository within a UnitOfWork transaction")
def step_save_within_uow(context: Context) -> None:
"""Save a trace within a UnitOfWork transaction to verify flush behavior."""