From 64e9831bde79ce83ea6c9529070179aec7ec5886 Mon Sep 17 00:00:00 2001 From: HAL9000 Date: Fri, 24 Apr 2026 16:35:19 +0000 Subject: [PATCH] fix(data-integrity): Remove duplicate @when decorator, fix feature file indentation, update CONTRIBUTORS.md MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - Remove duplicate @when decorator in llm_trace_steps.py that caused lint failure - Fix 3-space indentation to 2-space in last two scenarios of llm_trace.feature - Add HAL 9000 contribution detail to CONTRIBUTORS.md as required by CONTRIBUTING.md ยง8 Closes #7505 --- CONTRIBUTORS.md | 1 + features/llm_trace.feature | 22 +++++++++++----------- features/steps/llm_trace_steps.py | 2 -- 3 files changed, 12 insertions(+), 13 deletions(-) diff --git a/CONTRIBUTORS.md b/CONTRIBUTORS.md index 0b43e1538..41bf219c8 100644 --- a/CONTRIBUTORS.md +++ b/CONTRIBUTORS.md @@ -14,4 +14,5 @@ Below are some of the specific details of various contributions. * Jeffrey Phillips Freeman has acted as Lead Developer, daily contributor, and Project Owner. * Brent E. Edwards has contributed quality assurance, test coverage, and CI pipeline improvements. +* HAL 9000 has contributed automated bug fixes, infrastructure improvements, and data integrity fixes including the LLMTraceRepository UnitOfWork alignment. * This project was made possible thanks to considerable donation of time, money, and resources by CleverThis, Inc. diff --git a/features/llm_trace.feature b/features/llm_trace.feature index 211332b3c..96b561e89 100644 --- a/features/llm_trace.feature +++ b/features/llm_trace.feature @@ -270,19 +270,19 @@ Feature: LLM trace observability Then the langsmith_enabled check should return True Scenario: Repository save trace with no tool calls stores null - Given a SQLAlchemy in-memory repository - And a valid LLM trace - When I save the trace via the repository - Then the raw tool_calls_json in the database should be null + Given a SQLAlchemy in-memory repository + And a valid LLM trace + When I save the trace via the repository + Then the raw tool_calls_json in the database should be null # --- UnitOfWork transaction boundary (Issue #7505) ---------------------- @tdd_issue_7505 Scenario: Repository save uses flush not commit within UnitOfWork - Given a SQLAlchemy in-memory repository - And a valid LLM trace - When I save the trace via the repository within a UnitOfWork transaction - Then the trace should be visible within the transaction - And the transaction should not be committed yet - And I should be able to rollback the transaction - And the trace should not exist after rollback + Given a SQLAlchemy in-memory repository + And a valid LLM trace + When I save the trace via the repository within a UnitOfWork transaction + Then the trace should be visible within the transaction + And the transaction should not be committed yet + And I should be able to rollback the transaction + And the trace should not exist after rollback diff --git a/features/steps/llm_trace_steps.py b/features/steps/llm_trace_steps.py index fadce543b..823fc41c1 100644 --- a/features/steps/llm_trace_steps.py +++ b/features/steps/llm_trace_steps.py @@ -953,8 +953,6 @@ def step_raw_tool_calls_null(context: Context) -> None: # --------------------------------------------------------------------------- -@when("I save the trace via the repository within a UnitOfWork transaction") - @when("I save the trace via the repository within a UnitOfWork transaction") def step_save_within_uow(context: Context) -> None: """Save a trace within a UnitOfWork transaction to verify flush behavior."""