fix: update M4.1 scenarios for M4.2 allowing empty/whitespace guidance in request_correction
CI / benchmark-publish (pull_request) Has been skipped
CI / lint (pull_request) Failing after 14s
CI / build (pull_request) Successful in 17s
CI / quality (pull_request) Successful in 19s
CI / security (pull_request) Successful in 29s
CI / typecheck (pull_request) Failing after 31s
CI / coverage (pull_request) Has been skipped
CI / benchmark-regression (pull_request) Has been skipped
CI / integration_tests (pull_request) Failing after 3m41s
CI / unit_tests (pull_request) Successful in 6m31s
CI / docker (pull_request) Has been skipped
CI / benchmark-publish (pull_request) Has been skipped
CI / lint (pull_request) Failing after 14s
CI / build (pull_request) Successful in 17s
CI / quality (pull_request) Successful in 19s
CI / security (pull_request) Successful in 29s
CI / typecheck (pull_request) Failing after 31s
CI / coverage (pull_request) Has been skipped
CI / benchmark-regression (pull_request) Has been skipped
CI / integration_tests (pull_request) Failing after 3m41s
CI / unit_tests (pull_request) Successful in 6m31s
CI / docker (pull_request) Has been skipped
This commit is contained in:
@@ -98,15 +98,15 @@ Feature: Correction Model
|
||||
When I try to request a correction with empty plan ID
|
||||
Then a validation error should be raised with message containing "plan_id"
|
||||
|
||||
Scenario: Empty guidance rejection
|
||||
Scenario: Empty guidance is accepted
|
||||
Given a correction service
|
||||
When I try to request a correction with empty guidance
|
||||
Then a validation error should be raised with message containing "guidance"
|
||||
Then the correction should be created
|
||||
|
||||
Scenario: Whitespace-only guidance rejection
|
||||
Scenario: Whitespace-only guidance is accepted
|
||||
Given a correction service
|
||||
When I try to request a correction with whitespace-only guidance
|
||||
Then a validation error should be raised with message containing "guidance"
|
||||
Then the correction should be created
|
||||
|
||||
# ── Status Transitions ───────────────────────────────────────
|
||||
|
||||
|
||||
@@ -205,30 +205,24 @@ def step_when_empty_plan(context):
|
||||
def step_when_empty_guidance(context):
|
||||
svc = context.correction_service
|
||||
context.error = None
|
||||
try:
|
||||
svc.request_correction(
|
||||
plan_id="plan-1",
|
||||
target_decision_id="DEC-001",
|
||||
mode=CorrectionMode.REVERT,
|
||||
guidance="",
|
||||
)
|
||||
except ValidationError as exc:
|
||||
context.error = exc
|
||||
context.correction = svc.request_correction(
|
||||
plan_id="plan-1",
|
||||
target_decision_id="DEC-001",
|
||||
mode=CorrectionMode.REVERT,
|
||||
guidance="",
|
||||
)
|
||||
|
||||
|
||||
@when("I try to request a correction with whitespace-only guidance")
|
||||
def step_when_whitespace_guidance(context):
|
||||
svc = context.correction_service
|
||||
context.error = None
|
||||
try:
|
||||
svc.request_correction(
|
||||
plan_id="plan-1",
|
||||
target_decision_id="DEC-001",
|
||||
mode=CorrectionMode.REVERT,
|
||||
guidance=" ",
|
||||
)
|
||||
except ValidationError as exc:
|
||||
context.error = exc
|
||||
context.correction = svc.request_correction(
|
||||
plan_id="plan-1",
|
||||
target_decision_id="DEC-001",
|
||||
mode=CorrectionMode.REVERT,
|
||||
guidance=" ",
|
||||
)
|
||||
|
||||
|
||||
@when("I try to create a CorrectionRequest with empty plan_id")
|
||||
|
||||
Reference in New Issue
Block a user