fix(runtime): add input validation, credential safety, and proper error propagation #40

Merged

CoreRasurae merged 2 commits from fix/master-borked into master 2026-06-09 15:20:55 +00:00

Conversation 1 Commits 2 Files changed 17 +1942 -25

CoreRasurae commented 2026-06-09 14:51:30 +00:00

Member

Copy link

Summary

Fix critical bugs in the runtime Executor: missing input validation, incorrect error types, resource leaks, and missing credential propagation in graph execution.

Changes

• Executor constructor: Add type validation for config_dict, credentials, limits, pricing parameters
• _execute_llm: Raise ExecutionError (not ConfigurationError) for agent failures; add finally block with agent cleanup
• _execute_llm: Guard credential access with None check before .get() calls
• _execute_graph: Pass credentials to AgentFactory for proper agent creation
• _execute_graph: Allow ConfigurationError/ExecutionError/AgentCreationError to propagate naturally
• nodes.py: Remove hardcoded default workflow_controller routing in message router nodes

Commits

• 728630c fix(runtime): add input validation, credential safety, and proper error propagation

Closes #39

## Summary Fix critical bugs in the runtime Executor: missing input validation, incorrect error types, resource leaks, and missing credential propagation in graph execution. ## Changes - **Executor constructor**: Add type validation for `config_dict`, `credentials`, `limits`, `pricing` parameters - **`_execute_llm`**: Raise `ExecutionError` (not `ConfigurationError`) for agent failures; add `finally` block with agent cleanup - **`_execute_llm`**: Guard credential access with `None` check before `.get()` calls - **`_execute_graph`**: Pass `credentials` to `AgentFactory` for proper agent creation - **`_execute_graph`**: Allow `ConfigurationError`/`ExecutionError`/`AgentCreationError` to propagate naturally - **`nodes.py`**: Remove hardcoded default `workflow_controller` routing in message router nodes ## Commits - `728630c` fix(runtime): add input validation, credential safety, and proper error propagation Closes #39

CoreRasurae force-pushed fix/master-borked from 0e38052efa to 126fb22fab 2026-06-09 14:55:00 +00:00 Compare

CoreRasurae force-pushed fix/master-borked from 126fb22fab to 3f8c3dfad6 2026-06-09 14:57:07 +00:00 Compare

CoreRasurae force-pushed fix/master-borked from 3f8c3dfad6 to f8aebaf948 2026-06-09 15:03:33 +00:00 Compare

CoreRasurae force-pushed fix/master-borked from f8aebaf948 to 3fc0a3fa57 2026-06-09 15:06:42 +00:00 Compare

hurui200320 approved these changes 2026-06-09 15:14:55 +00:00

hurui200320 left a comment

Copy link

PR Review — fix(runtime): add input validation, credential safety, and proper error propagation

Production Code Changes (2 files)

src/cleveractors/langgraph/nodes.py — 1 line changed

✅ Correct. Removing the hardcoded {"next_node": "workflow_controller"} fallback is the right call — routing to a node that may not exist in the graph was dangerous. Returning {} correctly hands routing back to the graph's own edge logic.

---

src/cleveractors/runtime.py — 52 additions, 13 deletions

1. Constructor validation ✅
Silently accepting garbage inputs was broken before. All four parameter guards are correct. Note that credentials is explicitly allowed to be None.

2. Credential safety in _execute_llm ✅
The old code called .get() unconditionally on self.credentials, which would crash with AttributeError when credentials=None. Now correctly guarded.

3. ExecutionError instead of ConfigurationError for agent failures ✅
Correct across _execute_llm, _execute_graph, and _execute_tool. Agent failures at runtime are execution errors, not configuration errors.

4. Agent cleanup finally blocks ✅
Resource leaks fixed in both _execute_llm and _execute_graph. The nested try/except in finally correctly ensures cleanup failures are silent and don't swallow the original exception.

5. Credentials passed to AgentFactory in _execute_graph ✅
This was the core bug breaking graph execution. Fixed.

6. Proper exception propagation ✅
Known typed exceptions (ConfigurationError, ExecutionError, AgentCreationError) are re-raised cleanly in all three execution paths; all others are wrapped in ExecutionError.

7. _estimate_tokens logging ✅
except Exception: pass → logger.debug(...). Better operability, no behaviour change.

---

Issues Found

🔶 Minor — _build_factory_config() unguarded .items() on None credentials

# _build_factory_config(), not changed in this PR
for provider, creds in self.credentials.items():

The constructor now explicitly allows credentials=None, but _build_factory_config() (unchanged) calls .items() unconditionally. If a caller passes credentials=None and the actor type resolves to "graph", this will raise AttributeError. This is pre-existing — the old code had the same issue. Non-blocking for this fix; recommend a follow-up: (self.credentials or {}).items().

🔵 Nit — Dead mock in runtime_coverage_steps.py

patch("cleveractors.runtime_tokens.estimate_graph_tokens", return_value=(100, 50)),

runtime.py no longer calls estimate_graph_tokens from runtime_tokens — it uses the private _estimate_tokens defined locally (which is correctly patched on the line above). This mock is now a no-op. Harmless but vestigial.

🔵 Nit — Inconsistent exception chaining

_execute_llm uses from None (chain suppressed); _execute_graph uses from exc (chain preserved). The suppression in _execute_llm appears intentional per the PR description. Minor — worth aligning in a follow-up.

---

Test Changes

Change	Assessment
return_value="Mock graph response" → return_value=("Mock graph response", {}) in 3 step files	✅ Required — _execute_graph now unpacks response, final_state = await graph.execute(...)
Patch paths updated from cleveractors.runtime.X to actual module paths	✅ Required — runtime.py now uses lazy (local) imports; the old names no longer exist in the module namespace
New feature files + step definitions	✅ Additive — exercises new code paths introduced by this fix

---

Verdict

✅ Approved — safe to merge.

All five critical bugs from issue #39 are correctly addressed. The test fixes are consistent with the runtime behaviour changes. The two nits and the pre-existing _build_factory_config(None) edge case are non-blocking and can be addressed in a follow-up ticket.

## PR Review — `fix(runtime): add input validation, credential safety, and proper error propagation` ### Production Code Changes (2 files) #### `src/cleveractors/langgraph/nodes.py` — 1 line changed ✅ **Correct.** Removing the hardcoded `{"next_node": "workflow_controller"}` fallback is the right call — routing to a node that may not exist in the graph was dangerous. Returning `{}` correctly hands routing back to the graph's own edge logic. --- #### `src/cleveractors/runtime.py` — 52 additions, 13 deletions **1. Constructor validation** ✅ Silently accepting garbage inputs was broken before. All four parameter guards are correct. Note that `credentials` is explicitly allowed to be `None`. **2. Credential safety in `_execute_llm`** ✅ The old code called `.get()` unconditionally on `self.credentials`, which would crash with `AttributeError` when `credentials=None`. Now correctly guarded. **3. `ExecutionError` instead of `ConfigurationError` for agent failures** ✅ Correct across `_execute_llm`, `_execute_graph`, and `_execute_tool`. Agent failures at runtime are execution errors, not configuration errors. **4. Agent cleanup `finally` blocks** ✅ Resource leaks fixed in both `_execute_llm` and `_execute_graph`. The nested `try/except` in `finally` correctly ensures cleanup failures are silent and don't swallow the original exception. **5. Credentials passed to `AgentFactory` in `_execute_graph`** ✅ This was the core bug breaking graph execution. Fixed. **6. Proper exception propagation** ✅ Known typed exceptions (`ConfigurationError`, `ExecutionError`, `AgentCreationError`) are re-raised cleanly in all three execution paths; all others are wrapped in `ExecutionError`. **7. `_estimate_tokens` logging** ✅ `except Exception: pass` → `logger.debug(...)`. Better operability, no behaviour change. --- ### Issues Found #### 🔶 Minor — `_build_factory_config()` unguarded `.items()` on `None` credentials ```python # _build_factory_config(), not changed in this PR for provider, creds in self.credentials.items(): ``` The constructor now explicitly allows `credentials=None`, but `_build_factory_config()` (unchanged) calls `.items()` unconditionally. If a caller passes `credentials=None` and the actor type resolves to `"graph"`, this will raise `AttributeError`. **This is pre-existing** — the old code had the same issue. Non-blocking for this fix; recommend a follow-up: `(self.credentials or {}).items()`. #### 🔵 Nit — Dead mock in `runtime_coverage_steps.py` ```python patch("cleveractors.runtime_tokens.estimate_graph_tokens", return_value=(100, 50)), ``` `runtime.py` no longer calls `estimate_graph_tokens` from `runtime_tokens` — it uses the private `_estimate_tokens` defined locally (which is correctly patched on the line above). This mock is now a no-op. Harmless but vestigial. #### 🔵 Nit — Inconsistent exception chaining `_execute_llm` uses `from None` (chain suppressed); `_execute_graph` uses `from exc` (chain preserved). The suppression in `_execute_llm` appears intentional per the PR description. Minor — worth aligning in a follow-up. --- ### Test Changes | Change | Assessment | |---|---| | `return_value="Mock graph response"` → `return_value=("Mock graph response", {})` in 3 step files | ✅ Required — `_execute_graph` now unpacks `response, final_state = await graph.execute(...)` | | Patch paths updated from `cleveractors.runtime.X` to actual module paths | ✅ Required — `runtime.py` now uses lazy (local) imports; the old names no longer exist in the module namespace | | New feature files + step definitions | ✅ Additive — exercises new code paths introduced by this fix | --- ### Verdict **✅ Approved — safe to merge.** All five critical bugs from issue #39 are correctly addressed. The test fixes are consistent with the runtime behaviour changes. The two nits and the pre-existing `_build_factory_config(None)` edge case are non-blocking and can be addressed in a follow-up ticket.

CoreRasurae merged commit 3fc0a3fa57 into master 2026-06-09 15:20:55 +00:00

CoreRasurae deleted branch fix/master-borked 2026-06-09 15:20:55 +00:00

Sign in to join this conversation.

Reviewers

No reviewers

hurui200320

Labels

Clear labels

  

auto/blocked-by-deps

PR blocked by an open issue dependency. Operator must close the dep (or remove the dependency link) before the merge driver can act. Auto-cleared by merge_drive when no open deps remain.

  

auto/ci-timeout

Most recent merge cycle hit CI timeout. Driver excludes this PR while last merge_cycle row is < 30 min old; label persists thereafter as visible history.

  

auto/claimed-implementer

Currently being processed by an implementer worker.

  

auto/claimed-merge

Currently being processed by the merge driver.

  

auto/claimed-reviewer

Currently being processed by a reviewer worker.

  

auto/driver-down

Merge driver heartbeat stale; pipeline halted. Closed automatically on next clean tick.

  

auto/invariant-violation

Detected master commit violating the strict merge invariant. Tracked as an issue (not a PR label); kept here for label completeness.

  

auto/last-attempt-tier-0

In-cycle escalation: most recent attempt ran at the Tier 0 slot (`tier-0`). Slot's model defined in .opencode/models/tiers.yaml.

  

auto/last-attempt-tier-1

In-cycle escalation: most recent attempt ran at the Tier 1 slot (`tier-1`). Slot's model defined in .opencode/models/tiers.yaml.

  

auto/last-attempt-tier-2

In-cycle escalation: most recent attempt ran at the Tier 2 slot (`tier-2`). Slot's model defined in .opencode/models/tiers.yaml. Gated behind IMPLEMENTER_ESCALATION_TIER2_ENABLED.

  

auto/last-attempt-tier-min

In-cycle escalation: most recent attempt ran at the Tier -1 slot (`tier-min`). Slot's model defined in .opencode/models/tiers.yaml. Suffix is ``-min`` (not ``--1``) so the Forgejo UI reads naturally.

  

Automation Tracking

Tracking issues used by the AI Automation system for agents to communicate and report.

  

auto/needs-conflict-resolution

Rebase conflict needs LLM conflict-resolver.

  

auto/needs-implementer

Failing CI needs implementer attention.

  

auto/postmortem

Documenting a driver incident or rollback.

  

auto/ready-to-merge

Reviewer has APPROVED this PR and no later REQUEST_CHANGES is outstanding. The merge driver requires this label to even consider a PR for merging. Set by the reviewer worker on APPROVE; cleared on REQUEST_CHANGES.

  

auto/restart-throttled

Train repeatedly lost master-tempo races. Driver excludes via merge_cycle until cooldown elapses; label persists as visible history.

  

auto/revert

Revert PR backing out an invariant violation. Fast-tracked through the merge driver.

  

auto/sentinel

Sentinel PR duplicated from upstream into a personal fork by tools/duplicate_prs_to_fork.py for pipeline testing. Lives only in the fork; the canonical pipeline never sees it.

  

auto/stale-inactivity

No implementer activity for N days. Flagged for human review. Auto-cleared on next push to head branch.

  

auto/unstable

Repeatedly fails on current master (>= 3 ci-fail-on-rebased-sha releases in 12 h). Excluded from driver until human triage.

  

Blocked

A ticket in a blocked state and unable to complete until some other task is completed first.

  

Bounty

$100

A bounty of $100 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$1000

A bounty of $1000 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$10000

A bounty of $10000 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$20

A bounty of $20 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$2000

A bounty of $2000 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$250

A bounty of $250 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$50

A bounty of $50 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$500

A bounty of $500 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$5000

A bounty of $5000 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$750

A bounty of $750 for any open-source contributor who provides a MR that solves this issue

  

MoSCoW

Could have

Could have feature in order to satisfy the epic/legendary.

  

MoSCoW

Must have

Must have feature in order to satisfy the epic/legendary.

  

MoSCoW

Should have

Should have feature in order to satisfy the epic/legendary.

  

Needs Feedback

There are questions in the ticket that can not be completed until the project owner provides clarity.

  

Points

1

1 man-hours worth of work for an expert with no learning curve.

  

Points

13

13 man-hours worth of work for an expert with no learning curve.

  

Points

2

2 man-hours worth of work for an expert with no learning curve.

  

Points

21

21 man-hours worth of work for an expert with no learning curve.

  

Points

3

3 man-hours worth of work for an expert with no learning curve.

  

Points

34

34 man-hours worth of work for an expert with no learning curve.

  

Points

5

5 man-hours worth of work for an expert with no learning curve.

  

Points

55

55 man-hours worth of work for an expert with no learning curve.

  

Points

8

8 man-hours worth of work for an expert with no learning curve.

  

Points

88

88 man-hours worth of work for an expert with no learning curve.

  

Priority

Backlog

This ticket has backlogged priority and is not to be worked on yet

  

Priority

CI Blocker

Critical priority issue that blocks CI/CD pipeline and prevents PR merges

  

Priority

Critical

The priority is critical

  

Priority

High

The priority is high

  

Priority

Low

The priority is low

  

Priority

Medium

The priority is medium

  

Signed-off: Owner

When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

  

Signed-off: Scrum Master

When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

  

Signed-off: Tech Lead

When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

  

Spike

A ticket for learning a tool or technology that is needed to be able to do future planning and design.

  

State

Completed

The ticket has been fully implemented, completed, and merged with the source code. This label should only be applied once a ticket is closed.

  

State

Duplicate

A ticket that represents the same content as an existing ticket.

  

State

In Progress

A ticket that is actively being developed.

  

State

In Review

A ticket that has had some code completed to implement but is waiting to pass peer review and is not yet merged in.

  

State

Paused

This ticket's work started but wasn't finished. It's on hold (likely in a feature branch) and will be resumed later, either due to a blocker or a delay.

  

State

Unverified

All new tickets start in this state. A developer may set it to show the ticket is unverified. This means we haven't agreed to work on it. It will either move to a verified state or be closed as wontdo.

  

State

Verified

The issue has been verified by a developer as legitimate. It will be worked on and verified tickets are now considered part of the backlog.

  

State

Wont Do

This ticket has been decided it wont be done. This may mean the bug has been determined to not be real (cant verify) or the feature is one we have decided we dont want to adopt.

  

Type

Automation

Any edits or discussion about the AI automated coding system.

  

Type

Bug

Something that doesnt work as intended.

  

Type

Discussion

Anytime a ticket represents a discussion about a subject and doesnt fall into one of the other categories.

  

Type

Documentation

An error or improvement needed in the documentation.

  

Type

Epic

Any first tier epic. That is, an epic which contains only issues as children and will not have sub-epics.

  

Type

Feature

Some new functionality not present.

  

Type

Legendary

A type of Epic which will contain other Epics.

  

Type

Refactor

A code change that restructures existing code without changing its external behavior.

  

Type

Support

Someone needs help using the project.

  

Type

Task

A generic task that doesnt fit into the other type categories.

  

Type

Testing

Work exclusively focusing on fixing or expanding testing.

No labels

auto/blocked-by-deps

auto/ci-timeout

auto/claimed-implementer

auto/claimed-merge

auto/claimed-reviewer

auto/driver-down

auto/invariant-violation

auto/last-attempt-tier-0

auto/last-attempt-tier-1

auto/last-attempt-tier-2

auto/last-attempt-tier-min

Automation Tracking

auto/needs-conflict-resolution

auto/needs-implementer

auto/postmortem

auto/ready-to-merge

auto/restart-throttled

auto/revert

auto/sentinel

auto/stale-inactivity

auto/unstable

Blocked

Bounty

$100

Bounty

$1000

Bounty

$10000

Bounty

$20

Bounty

$2000

Bounty

$250

Bounty

$50

Bounty

$500

Bounty

$5000

Bounty

$750

MoSCoW

Could have

MoSCoW

Must have

MoSCoW

Should have

Needs Feedback

Points

1

Points

13

Points

2

Points

21

Points

3

Points

34

Points

5

Points

55

Points

8

Points

88

Priority

Backlog

Priority

CI Blocker

Priority

Critical

Priority

High

Priority

Low

Priority

Medium

Signed-off: Owner

Signed-off: Scrum Master

Signed-off: Tech Lead

Spike

State

Completed

State

Duplicate

State

In Progress

State

In Review

State

Paused

State

Unverified

State

Verified

State

Wont Do

Type

Automation

Type

Bug

Type

Discussion

Type

Documentation

Type

Epic

Type

Feature

Type

Legendary

Type

Refactor

Type

Support

Type

Task

Type

Testing

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

cleveragents/cleveractors-core!40

No description provided.