feat(agents): resolve agent- and route-type registry package references in agents.<name> and routes.<name> #125

Merged

CoreRasurae merged 1 commit from feature/agent-package-references into master 2026-08-10 10:12:39 +00:00

Conversation 3 Commits 1 Files changed 17 +2552 -19

CoreRasurae commented 2026-08-09 17:30:19 +00:00

Member

Copy link

Summary

An agents.<name> entry, and likewise a routes.<name> entry, may now be a bare package-reference string (local:<path>, a host:namespace/name[@version] registry reference, or an ID:pkg_<type>_<sha1> identifier — Package Registry Standard §5.3/§7.3) instead of a mapping, resolved to an agent-type or graph-type package's content and used exactly as if that content had been written inline.

Previously, a bare-string agents.<name> value crashed create_executor/AgentFactory.create_agent/acreate_agent with a raw AttributeError: 'str' object has no attribute 'get' instead of resolving through the registry. During implementation, the identical defect was confirmed in routes.main (_execute_graph/_execute_graph_stream) — the Package Registry Standard defines graph/stream packages the same way it defines agent packages, so both gaps share one root cause and one fix shape. Per maintainer direction they are addressed together in this PR — see the updated issue #121 description and docs/adr/ADR-2037-agent-and-route-package-reference-resolution.md for the full decision record.

• New AgentReferenceResolver / RouteReferenceResolver classes mirror the existing SkillReferenceResolver pattern (reused PackageContentResolver/LocalPackageStore/RegistryClient, same two-tier cache, same local:/registry:/ID: parsing).
• AgentFactory gained an optional agent_reference_resolver constructor argument (mirrors skill_loader); every runtime_dispatch dispatch function shares the same PackageContentResolver/local_store/registry_api_key already used for skills: resolution.
• An unresolvable agent reference fails with AgentCreationError naming the reference; an unresolvable route reference fails with ConfigurationError naming the reference — neither surfaces as an AttributeError.
• A route reference resolves only for routes.main, fixed to package_type="graph" (create_executor never dispatches a "stream"-type route).
• docs/index.md gains §4.1.1 and §5.1.1 (Version 1.5.0), documented generically since the Actor Configuration Standard is not scoped to this implementation.
• Fixes a pre-existing test-isolation gap in features/environment.py (a mocked resolver leaking between scenarios) and an agent_modules_steps.py fixture that assumed any non-dict agent value was invalid — both surfaced by this change.

Closes #121

Test plan

• nox -s lint / nox -s format -- --check — clean
• nox -s typecheck — 0 errors (Pyright strict)
• nox -s security_scan / nox -s dead_code — clean
• nox -s complexity — clean
• nox -s unit_tests — all Behave scenarios pass, including new features/agent_package_references.feature and features/route_package_references.feature
• nox -s coverage_report — 96.6% (≥ 96.5% threshold)
• nox -s integration_tests — all 351 Robot Framework tests pass, including new robot/agent_package_references.robot and robot/route_package_references.robot
• nox -s build — wheel builds successfully
• Manually verified the exact issue repro (bare-string agents.<name> via create_executor) now resolves correctly instead of raising AttributeError, via the new BDD/Robot scenarios exercising that exact code path end-to-end with a real LocalPackageStore

🤖 Generated with Claude Code

## Summary An `agents.<name>` entry, and likewise a `routes.<name>` entry, may now be a bare package-reference string (`local:<path>`, a `host:namespace/name[@version]` registry reference, or an `ID:pkg_<type>_<sha1>` identifier — Package Registry Standard §5.3/§7.3) instead of a mapping, resolved to an `agent`-type or `graph`-type package's content and used exactly as if that content had been written inline. Previously, a bare-string `agents.<name>` value crashed `create_executor`/`AgentFactory.create_agent`/`acreate_agent` with a raw `AttributeError: 'str' object has no attribute 'get'` instead of resolving through the registry. During implementation, the identical defect was confirmed in `routes.main` (`_execute_graph`/`_execute_graph_stream`) — the Package Registry Standard defines `graph`/`stream` packages the same way it defines `agent` packages, so both gaps share one root cause and one fix shape. Per maintainer direction they are addressed together in this PR — see the updated issue #121 description and `docs/adr/ADR-2037-agent-and-route-package-reference-resolution.md` for the full decision record. - New `AgentReferenceResolver` / `RouteReferenceResolver` classes mirror the existing `SkillReferenceResolver` pattern (reused `PackageContentResolver`/`LocalPackageStore`/`RegistryClient`, same two-tier cache, same `local:`/`registry:`/`ID:` parsing). - `AgentFactory` gained an optional `agent_reference_resolver` constructor argument (mirrors `skill_loader`); every `runtime_dispatch` dispatch function shares the same `PackageContentResolver`/`local_store`/`registry_api_key` already used for `skills:` resolution. - An unresolvable agent reference fails with `AgentCreationError` naming the reference; an unresolvable route reference fails with `ConfigurationError` naming the reference — neither surfaces as an `AttributeError`. - A route reference resolves only for `routes.main`, fixed to `package_type="graph"` (`create_executor` never dispatches a `"stream"`-type route). - `docs/index.md` gains §4.1.1 and §5.1.1 (Version 1.5.0), documented generically since the Actor Configuration Standard is not scoped to this implementation. - Fixes a pre-existing test-isolation gap in `features/environment.py` (a mocked resolver leaking between scenarios) and an `agent_modules_steps.py` fixture that assumed any non-dict agent value was invalid — both surfaced by this change. Closes #121 ## Test plan - [x] `nox -s lint` / `nox -s format -- --check` — clean - [x] `nox -s typecheck` — 0 errors (Pyright strict) - [x] `nox -s security_scan` / `nox -s dead_code` — clean - [x] `nox -s complexity` — clean - [x] `nox -s unit_tests` — all Behave scenarios pass, including new `features/agent_package_references.feature` and `features/route_package_references.feature` - [x] `nox -s coverage_report` — 96.6% (≥ 96.5% threshold) - [x] `nox -s integration_tests` — all 351 Robot Framework tests pass, including new `robot/agent_package_references.robot` and `robot/route_package_references.robot` - [x] `nox -s build` — wheel builds successfully - [x] Manually verified the exact issue repro (bare-string `agents.<name>` via `create_executor`) now resolves correctly instead of raising `AttributeError`, via the new BDD/Robot scenarios exercising that exact code path end-to-end with a real `LocalPackageStore` 🤖 Generated with [Claude Code](https://claude.com/claude-code)

CoreRasurae added the

Type

Feature

label 2026-08-09 17:30:20 +00:00

CoreRasurae added a new dependency 2026-08-09 17:31:33 +00:00

#121 Add support for resolving agent-type registry package references in agents.<name>

hurui200320 requested changes 2026-08-10 06:54:15 +00:00

Dismissed

hurui200320 left a comment

Copy link

PR Review: !125 (Ticket #121)

Verdict: Request Changes

The intended implementation for agent- and route-type package reference resolution is sound and well-tested, but the branch is currently based on an outdated master and would revert a recently-merged security fix and regression test if merged. This must be fixed before approval.

Known follow-ups documented in the ADR (ReactiveConfigParser support, stream-type route packages, registry_api_key for route references, and package-reference template/agent_template values) are treated as out-of-scope per the issue/ADR and are not repeated below.

Critical Issues

1. Branch not rebased on current master; merge would revert security fixes.

   • feature/agent-package-references currently branches from 00e5482, while master has advanced to b98bcf7. The PR diff therefore shows the two intervening master commits as deletions:
     • bb3e750 — "symlink-safe sandbox file access closing TOCTOU window" (issue #105).
     • b98bcf7 — "capture LLM-agent file_write unsafe-mode regression" (issue #115).
   • Merging this PR would remove the SymlinkSafeOpener hardening, the associated BDD/Robot tests, the ADR-2035 D-9 decision, and the issue #115 regression test.
   • Recommendation: Rebase the branch onto origin/master and force-push; do not merge until the diff against master contains only the intended agent/route reference changes.

2. src/cleveractors/agents/file_access.py reverts to plain open(), reintroducing CWE-367.

   • Lines 193–372+ (and the deleted SymlinkSafeOpener class) replace the component-wise O_NOFOLLOW walk with ordinary open(resolved, ...) calls.
   • This reopens the time-of-check/time-of-use race between path resolution and opening that issue #105 fixed: a symlink swapped into any path component after admission is silently followed.
   • Recommendation: Restore the SymlinkSafeOpener implementation and _secure_open usage from master after rebasing.

Major Issues

1. CHANGELOG and ADR-2035 security documentation removed.

   • CHANGELOG.md: the entire "### Security" entry for issue #105 is deleted.
   • docs/adr/ADR-2035-inline-code-sandboxed-file-access.md: the D-9 decision, Revision History, and consequences bullet about closing the TOCTOU window are deleted.
   • Recommendation: Restore these sections from master after rebasing.

2. AgentFactory.get_agent_metadata does not handle bare-string agents.<name> references.

   • File: src/cleveractors/agents/factory.py, lines 650–651.
   • agent_config = agents_config[agent_name] may now be a str. The next line calls agent_config.get("type", "llm"), which will raise AttributeError: 'str' object has no attribute 'get' — the exact failure mode the acceptance criteria say must not happen.
   • Recommendation: Add a string-handling branch that either resolves the reference via self._agent_reference_resolver (sync) or raises AgentCreationError naming the reference, consistent with create_agent/acreate_agent.

3. Tests for unrelated security fixes deleted.

   • Files removed or truncated: features/symlink_safe_open.feature, features/steps/symlink_safe_open_steps.py, robot/symlink_safe_open.robot, robot/SymlinkSafeOpenTestLib.py, robot/inline_code_file_helpers.robot, robot/InlineFileHelperTestLib.py, features/llm_agent_tool_loop.feature, features/steps/llm_agent_tool_loop_steps.py.
   • These deletions are a side effect of the missing rebase, not an intentional scope change.
   • Recommendation: Restore the test files from master after rebasing.

Minor Issues

None.

Nits

None.

Summary

The agent- and route-reference resolver design mirrors the existing SkillReferenceResolver pattern appropriately, the acceptance criteria for create_agent/acreate_agent and _execute_graph/_execute_graph_stream are addressed, and the new BDD/Robot coverage for the reference forms is comprehensive. However, the branch is currently unsafe to merge because it would revert the issue #105 symlink-safe hardening and the issue #115 regression test. Rebase onto current master, restore the deleted security content, and fix the get_agent_metadata AttributeError before re-requesting review.

## PR Review: !125 (Ticket #121) ### Verdict: Request Changes The intended implementation for agent- and route-type package reference resolution is sound and well-tested, but the branch is currently based on an outdated `master` and would revert a recently-merged security fix and regression test if merged. This must be fixed before approval. Known follow-ups documented in the ADR (ReactiveConfigParser support, `stream`-type route packages, `registry_api_key` for route references, and package-reference `template`/`agent_template` values) are treated as out-of-scope per the issue/ADR and are not repeated below. ### Critical Issues 1. **Branch not rebased on current `master`; merge would revert security fixes.** - `feature/agent-package-references` currently branches from `00e5482`, while `master` has advanced to `b98bcf7`. The PR diff therefore shows the two intervening master commits as deletions: - `bb3e750` — "symlink-safe sandbox file access closing TOCTOU window" (issue #105). - `b98bcf7` — "capture LLM-agent file_write unsafe-mode regression" (issue #115). - Merging this PR would remove the `SymlinkSafeOpener` hardening, the associated BDD/Robot tests, the ADR-2035 D-9 decision, and the issue #115 regression test. - **Recommendation:** Rebase the branch onto `origin/master` and force-push; do not merge until the diff against `master` contains only the intended agent/route reference changes. 2. **`src/cleveractors/agents/file_access.py` reverts to plain `open()`, reintroducing CWE-367.** - Lines 193–372+ (and the deleted `SymlinkSafeOpener` class) replace the component-wise `O_NOFOLLOW` walk with ordinary `open(resolved, ...)` calls. - This reopens the time-of-check/time-of-use race between path resolution and opening that issue #105 fixed: a symlink swapped into any path component after admission is silently followed. - **Recommendation:** Restore the `SymlinkSafeOpener` implementation and `_secure_open` usage from `master` after rebasing. ### Major Issues 1. **CHANGELOG and ADR-2035 security documentation removed.** - `CHANGELOG.md`: the entire "### Security" entry for issue #105 is deleted. - `docs/adr/ADR-2035-inline-code-sandboxed-file-access.md`: the D-9 decision, Revision History, and consequences bullet about closing the TOCTOU window are deleted. - **Recommendation:** Restore these sections from `master` after rebasing. 2. **`AgentFactory.get_agent_metadata` does not handle bare-string `agents.<name>` references.** - File: `src/cleveractors/agents/factory.py`, lines 650–651. - `agent_config = agents_config[agent_name]` may now be a `str`. The next line calls `agent_config.get("type", "llm")`, which will raise `AttributeError: 'str' object has no attribute 'get'` — the exact failure mode the acceptance criteria say must not happen. - **Recommendation:** Add a string-handling branch that either resolves the reference via `self._agent_reference_resolver` (sync) or raises `AgentCreationError` naming the reference, consistent with `create_agent`/`acreate_agent`. 3. **Tests for unrelated security fixes deleted.** - Files removed or truncated: `features/symlink_safe_open.feature`, `features/steps/symlink_safe_open_steps.py`, `robot/symlink_safe_open.robot`, `robot/SymlinkSafeOpenTestLib.py`, `robot/inline_code_file_helpers.robot`, `robot/InlineFileHelperTestLib.py`, `features/llm_agent_tool_loop.feature`, `features/steps/llm_agent_tool_loop_steps.py`. - These deletions are a side effect of the missing rebase, not an intentional scope change. - **Recommendation:** Restore the test files from `master` after rebasing. ### Minor Issues None. ### Nits None. ### Summary The agent- and route-reference resolver design mirrors the existing `SkillReferenceResolver` pattern appropriately, the acceptance criteria for `create_agent`/`acreate_agent` and `_execute_graph`/`_execute_graph_stream` are addressed, and the new BDD/Robot coverage for the reference forms is comprehensive. However, the branch is currently unsafe to merge because it would revert the issue #105 symlink-safe hardening and the issue #115 regression test. Rebase onto current `master`, restore the deleted security content, and fix the `get_agent_metadata` AttributeError before re-requesting review.

CoreRasurae force-pushed feature/agent-package-references from 7420b011ac to f01c08f859 2026-08-10 08:10:17 +00:00 Compare

CoreRasurae commented 2026-08-10 08:14:08 +00:00

Author

Member

Copy link

Response to @hurui200320's review (2026-08-10)

Thanks for the thorough review. I re-verified each point against docs/index.md, docs/actor-registry-standard.md, issue #121, and docs/adr/ADR-2037-agent-and-route-package-reference-resolution.md before acting on any of it. Summary: 1 of 5 points was a real, confirmed defect and is now fixed; the other 4 were already resolved by the rebase you correctly called for, and are verified below rather than just asserted.

Critical Issues

1. "Branch not rebased on current master; merge would revert security fixes."

✅ Confirmed and already fixed (branch has been rebased). feature/agent-package-references now sits on top of b98bcf7 (issue #115) with bb3e750 (issue #105) in its ancestry — git log on the branch shows both commits below the feature commit. git diff master...HEAD --stat for the new head (f01c08f) touches only the 17 files this feature introduces/modifies (CHANGELOG.md, docs/index.md, docs/adr/ADR-2037-*.md, the new resolver modules, and the new/updated BDD+Robot test files) — src/cleveractors/agents/file_access.py does not appear in the diff at all, i.e. it is untouched and identical to master.

2. "src/cleveractors/agents/file_access.py reverts to plain open(), reintroducing CWE-367."

✅ Confirmed and already fixed (side effect of the rebase). grep -n "SymlinkSafeOpener\|_secure_open\|O_NOFOLLOW" src/cleveractors/agents/file_access.py on the current head shows the class and all _secure_open call sites intact and unchanged from master. As noted above, this file isn't part of the feature's diff at all now.

Major Issues

1. "CHANGELOG and ADR-2035 security documentation removed."

✅ Confirmed and already fixed. CHANGELOG.md's ### Security entry for issue #105 (the SymlinkSafeOpener/TOCTOU writeup) is present and unmodified. docs/adr/ADR-2035-inline-code-sandboxed-file-access.md still contains D-9, its Revision History entry, and the TOCTOU-closing consequence bullet — verified by grep, not just diff-stat absence.

2. "AgentFactory.get_agent_metadata does not handle bare-string agents.<name> references."

✅ Confirmed as a real defect — fixed in this push, not by the rebase. You were right: get_agent_metadata (src/cleveractors/agents/factory.py) still did agent_config = agents_config[agent_name]; agent_config.get("type", "llm") unconditionally, so a bare-string reference would raise the exact AttributeError the rest of this PR exists to eliminate — this one just wasn't caught because none of the original scenarios called get_agent_metadata on a reference-valued agent.

Fix mirrors create_agent's existing pattern exactly (docs/adr/ADR-2037 D-2/D-5): get_agent_metadata now calls self._resolve_agent_reference(agent_name, agent_config) when agent_config is a str, before reading .get("type", ...). An unresolvable reference now raises AgentCreationError naming the reference, consistent with every other call site in AgentFactory.

Added two new Behave scenarios to features/agent_package_references.feature (get_agent_metadata resolves a local: agent reference into metadata, and the unresolvable-reference/AgentCreationError counterpart), with step definitions in features/steps/agent_package_references_steps.py. Both pass, and I confirmed via a coverage run scoped to this feature's two .feature files that the new isinstance(agent_config, str) branch in get_agent_metadata is exercised (lines 651-652 no longer appear in Slipcover's missing_lines for factory.py).

3. "Tests for unrelated security fixes deleted."

✅ Confirmed and already fixed (side effect of the rebase). All eight files you listed (features/symlink_safe_open.feature, features/steps/symlink_safe_open_steps.py, robot/symlink_safe_open.robot, robot/SymlinkSafeOpenTestLib.py, robot/inline_code_file_helpers.robot, robot/InlineFileHelperTestLib.py, features/llm_agent_tool_loop.feature, features/steps/llm_agent_tool_loop_steps.py) are present on disk at the current head — checked individually, not just inferred from the diff.

Minor Issues / Nits

None reported — nothing to address.

Verification performed before pushing

• nox -s lint, nox -s format -- --check, nox -s typecheck, nox -s security_scan, nox -s dead_code — all clean.
• nox -s unit_tests (full suite): 153 features / 3057 scenarios / 14152 steps, 0 failed — confirms the get_agent_metadata fix doesn't regress any other caller (robot/EmailGraphLib.py, robot/lib/app_lib.py, features/steps/agent_modules_steps.py all call it with dict-valued configs, which take the unchanged branch).
• nox -s coverage_report scoped to features/agent_package_references.feature and features/route_package_references.feature (per this project's convention of measuring the coverage delta for the feature under review rather than re-running the whole-suite 97% gate on every iteration): confirms the new get_agent_metadata branch is covered.

Pushed as an amendment to the same commit (f01c08f, force-pushed with --force-with-lease) rather than a new commit, since the issue's ## Definition of Done calls for one commit for this issue and the PR was not yet merged.

Re-requesting review — please let me know if anything above needs a second look.

## Response to @hurui200320's review (2026-08-10) Thanks for the thorough review. I re-verified each point against `docs/index.md`, `docs/actor-registry-standard.md`, issue #121, and `docs/adr/ADR-2037-agent-and-route-package-reference-resolution.md` before acting on any of it. Summary: **1 of 5 points was a real, confirmed defect and is now fixed; the other 4 were already resolved by the rebase you correctly called for**, and are verified below rather than just asserted. ### Critical Issues **1. "Branch not rebased on current `master`; merge would revert security fixes."** ✅ **Confirmed and already fixed** (branch has been rebased). `feature/agent-package-references` now sits on top of `b98bcf7` (issue #115) with `bb3e750` (issue #105) in its ancestry — `git log` on the branch shows both commits below the feature commit. `git diff master...HEAD --stat` for the new head (`f01c08f`) touches only the 17 files this feature introduces/modifies (`CHANGELOG.md`, `docs/index.md`, `docs/adr/ADR-2037-*.md`, the new resolver modules, and the new/updated BDD+Robot test files) — `src/cleveractors/agents/file_access.py` does not appear in the diff at all, i.e. it is untouched and identical to `master`. **2. "`src/cleveractors/agents/file_access.py` reverts to plain `open()`, reintroducing CWE-367."** ✅ **Confirmed and already fixed** (side effect of the rebase). `grep -n "SymlinkSafeOpener\|_secure_open\|O_NOFOLLOW" src/cleveractors/agents/file_access.py` on the current head shows the class and all `_secure_open` call sites intact and unchanged from `master`. As noted above, this file isn't part of the feature's diff at all now. ### Major Issues **1. "CHANGELOG and ADR-2035 security documentation removed."** ✅ **Confirmed and already fixed.** `CHANGELOG.md`'s `### Security` entry for issue #105 (the `SymlinkSafeOpener`/TOCTOU writeup) is present and unmodified. `docs/adr/ADR-2035-inline-code-sandboxed-file-access.md` still contains D-9, its Revision History entry, and the TOCTOU-closing consequence bullet — verified by grep, not just diff-stat absence. **2. "`AgentFactory.get_agent_metadata` does not handle bare-string `agents.<name>` references."** ✅ **Confirmed as a real defect — fixed in this push, not by the rebase.** You were right: `get_agent_metadata` (`src/cleveractors/agents/factory.py`) still did `agent_config = agents_config[agent_name]; agent_config.get("type", "llm")` unconditionally, so a bare-string reference would raise the exact `AttributeError` the rest of this PR exists to eliminate — this one just wasn't caught because none of the original scenarios called `get_agent_metadata` on a reference-valued agent. Fix mirrors `create_agent`'s existing pattern exactly (`docs/adr/ADR-2037` D-2/D-5): `get_agent_metadata` now calls `self._resolve_agent_reference(agent_name, agent_config)` when `agent_config` is a `str`, before reading `.get("type", ...)`. An unresolvable reference now raises `AgentCreationError` naming the reference, consistent with every other call site in `AgentFactory`. Added two new Behave scenarios to `features/agent_package_references.feature` (`get_agent_metadata resolves a local: agent reference into metadata`, and the unresolvable-reference/`AgentCreationError` counterpart), with step definitions in `features/steps/agent_package_references_steps.py`. Both pass, and I confirmed via a coverage run scoped to this feature's two `.feature` files that the new `isinstance(agent_config, str)` branch in `get_agent_metadata` is exercised (lines 651-652 no longer appear in Slipcover's `missing_lines` for `factory.py`). **3. "Tests for unrelated security fixes deleted."** ✅ **Confirmed and already fixed** (side effect of the rebase). All eight files you listed (`features/symlink_safe_open.feature`, `features/steps/symlink_safe_open_steps.py`, `robot/symlink_safe_open.robot`, `robot/SymlinkSafeOpenTestLib.py`, `robot/inline_code_file_helpers.robot`, `robot/InlineFileHelperTestLib.py`, `features/llm_agent_tool_loop.feature`, `features/steps/llm_agent_tool_loop_steps.py`) are present on disk at the current head — checked individually, not just inferred from the diff. ### Minor Issues / Nits None reported — nothing to address. ### Verification performed before pushing - `nox -s lint`, `nox -s format -- --check`, `nox -s typecheck`, `nox -s security_scan`, `nox -s dead_code` — all clean. - `nox -s unit_tests` (full suite): 153 features / 3057 scenarios / 14152 steps, 0 failed — confirms the `get_agent_metadata` fix doesn't regress any other caller (`robot/EmailGraphLib.py`, `robot/lib/app_lib.py`, `features/steps/agent_modules_steps.py` all call it with dict-valued configs, which take the unchanged branch). - `nox -s coverage_report` scoped to `features/agent_package_references.feature` and `features/route_package_references.feature` (per this project's convention of measuring the coverage *delta* for the feature under review rather than re-running the whole-suite 97% gate on every iteration): confirms the new `get_agent_metadata` branch is covered. Pushed as an amendment to the same commit (`f01c08f`, force-pushed with `--force-with-lease`) rather than a new commit, since the issue's `## Definition of Done` calls for one commit for this issue and the PR was not yet merged. Re-requesting review — please let me know if anything above needs a second look.

hurui200320 approved these changes 2026-08-10 08:41:09 +00:00

hurui200320 left a comment

Copy link

PR Review: !125 (Ticket #121)

Verdict: Approve

The branch has been correctly rebased on current master (HEAD now sits on b98bcf7 with the issue #105 and #115 security commits intact), and all items from the previous review cycle have been addressed. The implementation satisfies every acceptance criterion in issue #121, mirrors the established SkillReferenceResolver pattern appropriately, and includes comprehensive Behave and Robot coverage. No critical or major issues remain.

Out-of-scope/deferred items documented in ADR-2037 (ReactiveConfigParser support, stream-type route packages, registry_api_key authentication for route references, and package-reference template/agent_template values) are respected and not repeated below.

Critical Issues

None.

Major Issues

None.

Minor Issues

None.

Nits

1. Missing dedicated streaming-path scenario for route references. features/route_package_references.feature and robot/route_package_references.robot exercise the new routes.main reference branch through Executor.execute() (_execute_graph), but there is no corresponding scenario for Executor.execute_stream() (_execute_graph_stream). The two branches are structurally identical, but a single streaming scenario would close the coverage gap and guard against future divergence. Not a blocker.

Summary

Agent reference resolution: AgentReferenceResolver correctly parses local:, registry:, and ID: references with package_type="agent", handles the unresolved/placeholder edge cases, and provides the required sync and async entry points. AgentFactory.create_agent/acreate_agent/validate_configuration/get_agent_metadata all now tolerate a bare-string agents.<name> value and raise AgentCreationError (never AttributeError) on unresolvable references. The runtime_dispatch functions share the same PackageContentResolver already built for skills: resolution, so local_store/registry_api_key flow through as intended.

Route reference resolution: RouteReferenceResolver mirrors the agent resolver with package_type="graph", and _execute_graph/_execute_graph_stream now detect a bare-string routes.main, resolve it, and reuse the resolved main mapping for parallel_execution — fixing the latent duplicate routes.main lookup identified in ADR-2037 D-9. Unresolvable route references raise ConfigurationError naming the reference.

Tests and docs: The new Behave scenarios cover resolver schemes, malformed/empty/unresolved references, ID placeholders, AgentFactory sync/async creation, get_agent_metadata, and end-to-end runtime execution. The Robot suites exercise the real LocalPackageStore → PackageContentResolver → resolver → Executor pipeline for both agent and route references. docs/index.md is updated to Version 1.5.0 with new §4.1.1 and §5.1.1 sections, and the CHANGELOG entry accurately summarizes the change.

Approved for merge.

## PR Review: !125 (Ticket #121) ### Verdict: Approve The branch has been correctly rebased on current `master` (HEAD now sits on `b98bcf7` with the issue #105 and #115 security commits intact), and all items from the previous review cycle have been addressed. The implementation satisfies every acceptance criterion in issue #121, mirrors the established `SkillReferenceResolver` pattern appropriately, and includes comprehensive Behave and Robot coverage. No critical or major issues remain. Out-of-scope/deferred items documented in ADR-2037 (ReactiveConfigParser support, `stream`-type route packages, `registry_api_key` authentication for route references, and package-reference `template`/`agent_template` values) are respected and not repeated below. ### Critical Issues None. ### Major Issues None. ### Minor Issues None. ### Nits 1. **Missing dedicated streaming-path scenario for route references.** `features/route_package_references.feature` and `robot/route_package_references.robot` exercise the new `routes.main` reference branch through `Executor.execute()` (`_execute_graph`), but there is no corresponding scenario for `Executor.execute_stream()` (`_execute_graph_stream`). The two branches are structurally identical, but a single streaming scenario would close the coverage gap and guard against future divergence. Not a blocker. ### Summary *Agent reference resolution:* `AgentReferenceResolver` correctly parses `local:`, `registry:`, and `ID:` references with `package_type="agent"`, handles the unresolved/placeholder edge cases, and provides the required sync and async entry points. `AgentFactory.create_agent`/`acreate_agent`/`validate_configuration`/`get_agent_metadata` all now tolerate a bare-string `agents.<name>` value and raise `AgentCreationError` (never `AttributeError`) on unresolvable references. The `runtime_dispatch` functions share the same `PackageContentResolver` already built for `skills:` resolution, so `local_store`/`registry_api_key` flow through as intended. *Route reference resolution:* `RouteReferenceResolver` mirrors the agent resolver with `package_type="graph"`, and `_execute_graph`/`_execute_graph_stream` now detect a bare-string `routes.main`, resolve it, and reuse the resolved `main` mapping for `parallel_execution` — fixing the latent duplicate `routes.main` lookup identified in ADR-2037 D-9. Unresolvable route references raise `ConfigurationError` naming the reference. *Tests and docs:* The new Behave scenarios cover resolver schemes, malformed/empty/unresolved references, ID placeholders, `AgentFactory` sync/async creation, `get_agent_metadata`, and end-to-end runtime execution. The Robot suites exercise the real `LocalPackageStore` → `PackageContentResolver` → resolver → `Executor` pipeline for both agent and route references. `docs/index.md` is updated to Version 1.5.0 with new §4.1.1 and §5.1.1 sections, and the CHANGELOG entry accurately summarizes the change. Approved for merge.

CoreRasurae force-pushed feature/agent-package-references from f01c08f859 to 2bb2f7064f 2026-08-10 09:34:59 +00:00 Compare

CoreRasurae force-pushed feature/agent-package-references from 2bb2f7064f to b9ee1c2b26 2026-08-10 09:49:12 +00:00 Compare

CoreRasurae force-pushed feature/agent-package-references from b9ee1c2b26 to a02ecfa088 2026-08-10 09:52:28 +00:00 Compare

CoreRasurae added 1 commit 2026-08-10 09:57:25 +00:00

feat(agents): resolve agent- and route-type registry package references in agents.<name> and routes.<name> ... afef7d5f9b

An agents.<name> entry, and likewise a routes.<name> entry, may now be a
bare package-reference string (local:<path>, a host:namespace/name[@version]
registry reference, or an ID:pkg_<type>_<sha1> identifier - Package Registry
Standard §5.3/§7.3) instead of a mapping, resolved to an agent-type or
graph-type package's content and used exactly as if that content had been
written inline.

Previously, a bare-string agents.<name> value crashed create_executor/
AgentFactory.create_agent/acreate_agent with a raw
"AttributeError: 'str' object has no attribute 'get'" instead of resolving
through the registry. During implementation, the identical defect was
confirmed in routes.main (_execute_graph/_execute_graph_stream), since the
Package Registry Standard defines graph/stream packages the same way it
defines agent packages - both gaps share one root cause and one fix shape,
so they are addressed together per maintainer direction (see the updated
issue #121 description and docs/adr/ADR-2037-agent-and-route-package-reference-resolution.md).

Both are resolved via new resolver classes (AgentReferenceResolver,
RouteReferenceResolver) mirroring the existing SkillReferenceResolver
pattern already used for an LLM agent's skills: list - reusing the same
PackageContentResolver/LocalPackageStore/RegistryClient machinery, the same
two-tier cache, and the same local:/registry:/ID: reference parsing.
AgentFactory gained an optional agent_reference_resolver constructor
argument (mirroring skill_loader), wired by every runtime_dispatch dispatch
function to share the same PackageContentResolver, local_store, and
registry_api_key already used for skills: resolution. AgentFactory
.validate_configuration() no longer rejects a bare-string agents.<name>
value outright, and AgentFactory.get_agent_metadata() resolves the same
bare-string reference before reading its type/config, exactly like
create_agent/acreate_agent, so a metadata lookup on a reference-valued
agent no longer hits the same AttributeError. A route reference resolves
only for routes.main (the sole route entry the graph-actor dispatch path
reads) via an ad-hoc resolver, fixed to package_type="graph" since
create_executor never dispatches a "stream"-type route; fixing the
pre-existing duplicate routes.main re-fetch this required also closes a
latent bug where that second, independent lookup would have re-read the
unresolved string and crashed again.

An unresolvable agent reference fails agent creation with
AgentCreationError naming the reference; an unresolvable route reference
fails with ConfigurationError naming the reference - neither ever surfaces
as an AttributeError.

docs/index.md gains §4.1.1 and §5.1.1 (Version 1.5.0) documenting both
extensions generically, since the Actor Configuration Standard is not
scoped to this implementation.

Also fixes a pre-existing test-isolation gap in features/environment.py
(a mocked PackageContentResolver injected by one scenario could leak into a
later scenario expecting a real, unmocked resolver) and updates an existing
agent_modules_steps.py fixture that assumed any non-dict agent value was
invalid - both surfaced by, and required for, this change.

ISSUES CLOSED: #121

CoreRasurae force-pushed feature/agent-package-references from a02ecfa088 to afef7d5f9b 2026-08-10 09:57:25 +00:00 Compare

CoreRasurae merged commit afef7d5f9b into master 2026-08-10 10:12:39 +00:00

CoreRasurae deleted branch feature/agent-package-references 2026-08-10 10:12:45 +00:00

Sign in to join this conversation.

Reviewers

No reviewers

hurui200320

Labels

Clear labels

  

auto/blocked-by-deps

PR blocked by an open issue dependency. Operator must close the dep (or remove the dependency link) before the merge driver can act. Auto-cleared by merge_drive when no open deps remain.

  

auto/ci-timeout

Most recent merge cycle hit CI timeout. Driver excludes this PR while last merge_cycle row is < 30 min old; label persists thereafter as visible history.

  

auto/claimed-implementer

Currently being processed by an implementer worker.

  

auto/claimed-merge

Currently being processed by the merge driver.

  

auto/claimed-reviewer

Currently being processed by a reviewer worker.

  

auto/driver-down

Merge driver heartbeat stale; pipeline halted. Closed automatically on next clean tick.

  

auto/invariant-violation

Detected master commit violating the strict merge invariant. Tracked as an issue (not a PR label); kept here for label completeness.

  

auto/last-attempt-tier-0

In-cycle escalation: most recent attempt ran at the Tier 0 slot (`tier-0`). Slot's model defined in .opencode/models/tiers.yaml.

  

auto/last-attempt-tier-1

In-cycle escalation: most recent attempt ran at the Tier 1 slot (`tier-1`). Slot's model defined in .opencode/models/tiers.yaml.

  

auto/last-attempt-tier-2

In-cycle escalation: most recent attempt ran at the Tier 2 slot (`tier-2`). Slot's model defined in .opencode/models/tiers.yaml. Gated behind IMPLEMENTER_ESCALATION_TIER2_ENABLED.

  

auto/last-attempt-tier-min

In-cycle escalation: most recent attempt ran at the Tier -1 slot (`tier-min`). Slot's model defined in .opencode/models/tiers.yaml. Suffix is ``-min`` (not ``--1``) so the Forgejo UI reads naturally.

  

Automation Tracking

Tracking issues used by the AI Automation system for agents to communicate and report.

  

auto/needs-conflict-resolution

Rebase conflict needs LLM conflict-resolver.

  

auto/needs-implementer

Failing CI needs implementer attention.

  

auto/postmortem

Documenting a driver incident or rollback.

  

auto/ready-to-merge

Reviewer has APPROVED this PR and no later REQUEST_CHANGES is outstanding. The merge driver requires this label to even consider a PR for merging. Set by the reviewer worker on APPROVE; cleared on REQUEST_CHANGES.

  

auto/restart-throttled

Train repeatedly lost master-tempo races. Driver excludes via merge_cycle until cooldown elapses; label persists as visible history.

  

auto/revert

Revert PR backing out an invariant violation. Fast-tracked through the merge driver.

  

auto/sentinel

Sentinel PR duplicated from upstream into a personal fork by tools/duplicate_prs_to_fork.py for pipeline testing. Lives only in the fork; the canonical pipeline never sees it.

  

auto/stale-inactivity

No implementer activity for N days. Flagged for human review. Auto-cleared on next push to head branch.

  

auto/unstable

Repeatedly fails on current master (>= 3 ci-fail-on-rebased-sha releases in 12 h). Excluded from driver until human triage.

  

Blocked

A ticket in a blocked state and unable to complete until some other task is completed first.

  

Bounty

$100

A bounty of $100 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$1000

A bounty of $1000 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$10000

A bounty of $10000 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$20

A bounty of $20 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$2000

A bounty of $2000 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$250

A bounty of $250 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$50

A bounty of $50 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$500

A bounty of $500 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$5000

A bounty of $5000 for any open-source contributor who provides a MR that solves this issue

  

Bounty

$750

A bounty of $750 for any open-source contributor who provides a MR that solves this issue

  

MoSCoW

Could have

Could have feature in order to satisfy the epic/legendary.

  

MoSCoW

Must have

Must have feature in order to satisfy the epic/legendary.

  

MoSCoW

Should have

Should have feature in order to satisfy the epic/legendary.

  

Needs Feedback

There are questions in the ticket that can not be completed until the project owner provides clarity.

  

Points

1

1 man-hours worth of work for an expert with no learning curve.

  

Points

13

13 man-hours worth of work for an expert with no learning curve.

  

Points

2

2 man-hours worth of work for an expert with no learning curve.

  

Points

21

21 man-hours worth of work for an expert with no learning curve.

  

Points

3

3 man-hours worth of work for an expert with no learning curve.

  

Points

34

34 man-hours worth of work for an expert with no learning curve.

  

Points

5

5 man-hours worth of work for an expert with no learning curve.

  

Points

55

55 man-hours worth of work for an expert with no learning curve.

  

Points

8

8 man-hours worth of work for an expert with no learning curve.

  

Points

88

88 man-hours worth of work for an expert with no learning curve.

  

Priority

Backlog

This ticket has backlogged priority and is not to be worked on yet

  

Priority

CI Blocker

Critical priority issue that blocks CI/CD pipeline and prevents PR merges

  

Priority

Critical

The priority is critical

  

Priority

High

The priority is high

  

Priority

Low

The priority is low

  

Priority

Medium

The priority is medium

  

Signed-off: Owner

When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

  

Signed-off: Scrum Master

When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

  

Signed-off: Tech Lead

When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.

  

Spike

A ticket for learning a tool or technology that is needed to be able to do future planning and design.

  

State

Completed

The ticket has been fully implemented, completed, and merged with the source code. This label should only be applied once a ticket is closed.

  

State

Duplicate

A ticket that represents the same content as an existing ticket.

  

State

In Progress

A ticket that is actively being developed.

  

State

In Review

A ticket that has had some code completed to implement but is waiting to pass peer review and is not yet merged in.

  

State

Paused

This ticket's work started but wasn't finished. It's on hold (likely in a feature branch) and will be resumed later, either due to a blocker or a delay.

  

State

Unverified

All new tickets start in this state. A developer may set it to show the ticket is unverified. This means we haven't agreed to work on it. It will either move to a verified state or be closed as wontdo.

  

State

Verified

The issue has been verified by a developer as legitimate. It will be worked on and verified tickets are now considered part of the backlog.

  

State

Wont Do

This ticket has been decided it wont be done. This may mean the bug has been determined to not be real (cant verify) or the feature is one we have decided we dont want to adopt.

  

Type

Automation

Any edits or discussion about the AI automated coding system.

  

Type

Bug

Something that doesnt work as intended.

  

Type

Discussion

Anytime a ticket represents a discussion about a subject and doesnt fall into one of the other categories.

  

Type

Documentation

An error or improvement needed in the documentation.

  

Type

Epic

Any first tier epic. That is, an epic which contains only issues as children and will not have sub-epics.

  

Type

Feature

Some new functionality not present.

  

Type

Legendary

A type of Epic which will contain other Epics.

  

Type

Refactor

A code change that restructures existing code without changing its external behavior.

  

Type

Support

Someone needs help using the project.

  

Type

Task

A generic task that doesnt fit into the other type categories.

  

Type

Testing

Work exclusively focusing on fixing or expanding testing.

No labels

auto/blocked-by-deps

auto/ci-timeout

auto/claimed-implementer

auto/claimed-merge

auto/claimed-reviewer

auto/driver-down

auto/invariant-violation

auto/last-attempt-tier-0

auto/last-attempt-tier-1

auto/last-attempt-tier-2

auto/last-attempt-tier-min

Automation Tracking

auto/needs-conflict-resolution

auto/needs-implementer

auto/postmortem

auto/ready-to-merge

auto/restart-throttled

auto/revert

auto/sentinel

auto/stale-inactivity

auto/unstable

Blocked

Bounty

$100

Bounty

$1000

Bounty

$10000

Bounty

$20

Bounty

$2000

Bounty

$250

Bounty

$50

Bounty

$500

Bounty

$5000

Bounty

$750

MoSCoW

Could have

MoSCoW

Must have

MoSCoW

Should have

Needs Feedback

Points

1

Points

13

Points

2

Points

21

Points

3

Points

34

Points

5

Points

55

Points

8

Points

88

Priority

Backlog

Priority

CI Blocker

Priority

Critical

Priority

High

Priority

Low

Priority

Medium

Signed-off: Owner

Signed-off: Scrum Master

Signed-off: Tech Lead

Spike

State

Completed

State

Duplicate

State

In Progress

State

In Review

State

Paused

State

Unverified

State

Verified

State

Wont Do

Type

Automation

Type

Bug

Type

Discussion

Type

Documentation

Type

Epic

Type

Feature

Type

Legendary

Type

Refactor

Type

Support

Type

Task

Type

Testing

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Blocks

#121 Add support for resolving agent-type registry package references in agents.<name>

cleveragents/cleveractors-core

Reference

cleveragents/cleveractors-core!125

No description provided.