feat(agents): allow per-invocation timeout override on shell/http tools #113
Merged
CoreRasurae
merged 1 commits from 2026-08-05 12:40:43 +00:00
feature/m1-shell-timeout-override into master
Labels
Clear labels
auto/blocked-by-deps
auto/ci-timeout
auto/claimed-implementer
auto/claimed-merge
auto/claimed-reviewer
auto/driver-down
auto/invariant-violation
auto/last-attempt-tier-0
auto/last-attempt-tier-1
auto/last-attempt-tier-2
auto/last-attempt-tier-min
Automation Tracking
auto/needs-conflict-resolution
auto/needs-implementer
auto/postmortem
auto/ready-to-merge
auto/restart-throttled
auto/revert
auto/sentinel
auto/stale-inactivity
auto/unstable
Blocked
Needs Feedback
Signed-off: Owner
Signed-off: Scrum Master
Signed-off: Tech Lead
Spike
PR blocked by an open issue dependency. Operator must close the dep (or remove the dependency link) before the merge driver can act. Auto-cleared by merge_drive when no open deps remain.
Most recent merge cycle hit CI timeout. Driver excludes this PR while last merge_cycle row is < 30 min old; label persists thereafter as visible history.
Currently being processed by an implementer worker.
Currently being processed by the merge driver.
Currently being processed by a reviewer worker.
Merge driver heartbeat stale; pipeline halted. Closed automatically on next clean tick.
Detected master commit violating the strict merge invariant. Tracked as an issue (not a PR label); kept here for label completeness.
In-cycle escalation: most recent attempt ran at the Tier 0 slot (`tier-0`). Slot's model defined in .opencode/models/tiers.yaml.
In-cycle escalation: most recent attempt ran at the Tier 1 slot (`tier-1`). Slot's model defined in .opencode/models/tiers.yaml.
In-cycle escalation: most recent attempt ran at the Tier 2 slot (`tier-2`). Slot's model defined in .opencode/models/tiers.yaml. Gated behind IMPLEMENTER_ESCALATION_TIER2_ENABLED.
In-cycle escalation: most recent attempt ran at the Tier -1 slot (`tier-min`). Slot's model defined in .opencode/models/tiers.yaml. Suffix is ``-min`` (not ``--1``) so the Forgejo UI reads naturally.
Tracking issues used by the AI Automation system for agents to communicate and report.
Rebase conflict needs LLM conflict-resolver.
Failing CI needs implementer attention.
Documenting a driver incident or rollback.
Reviewer has APPROVED this PR and no later REQUEST_CHANGES is outstanding. The merge driver requires this label to even consider a PR for merging. Set by the reviewer worker on APPROVE; cleared on REQUEST_CHANGES.
Train repeatedly lost master-tempo races. Driver excludes via merge_cycle until cooldown elapses; label persists as visible history.
Revert PR backing out an invariant violation. Fast-tracked through the merge driver.
Sentinel PR duplicated from upstream into a personal fork by tools/duplicate_prs_to_fork.py for pipeline testing. Lives only in the fork; the canonical pipeline never sees it.
No implementer activity for N days. Flagged for human review. Auto-cleared on next push to head branch.
Repeatedly fails on current master (>= 3 ci-fail-on-rebased-sha releases in 12 h). Excluded from driver until human triage.
A ticket in a blocked state and unable to complete until some other task is completed first.
Bounty
$100
A bounty of $100 for any open-source contributor who provides a MR that solves this issue
Bounty
$1000
A bounty of $1000 for any open-source contributor who provides a MR that solves this issue
Bounty
$10000
A bounty of $10000 for any open-source contributor who provides a MR that solves this issue
Bounty
$20
A bounty of $20 for any open-source contributor who provides a MR that solves this issue
Bounty
$2000
A bounty of $2000 for any open-source contributor who provides a MR that solves this issue
Bounty
$250
A bounty of $250 for any open-source contributor who provides a MR that solves this issue
Bounty
$50
A bounty of $50 for any open-source contributor who provides a MR that solves this issue
Bounty
$500
A bounty of $500 for any open-source contributor who provides a MR that solves this issue
Bounty
$5000
A bounty of $5000 for any open-source contributor who provides a MR that solves this issue
Bounty
$750
A bounty of $750 for any open-source contributor who provides a MR that solves this issue
MoSCoW
Could have
Could have feature in order to satisfy the epic/legendary.
MoSCoW
Must have
Must have feature in order to satisfy the epic/legendary.
MoSCoW
Should have
Should have feature in order to satisfy the epic/legendary.
There are questions in the ticket that can not be completed until the project owner provides clarity.
Points
1
1 man-hours worth of work for an expert with no learning curve.
Points
13
13 man-hours worth of work for an expert with no learning curve.
Points
2
2 man-hours worth of work for an expert with no learning curve.
Points
21
21 man-hours worth of work for an expert with no learning curve.
Points
3
3 man-hours worth of work for an expert with no learning curve.
Points
34
34 man-hours worth of work for an expert with no learning curve.
Points
5
5 man-hours worth of work for an expert with no learning curve.
Points
55
55 man-hours worth of work for an expert with no learning curve.
Points
8
8 man-hours worth of work for an expert with no learning curve.
Points
88
88 man-hours worth of work for an expert with no learning curve.
Priority
Backlog
This ticket has backlogged priority and is not to be worked on yet
Priority
CI Blocker
Critical priority issue that blocks CI/CD pipeline and prevents PR merges
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.
A ticket for learning a tool or technology that is needed to be able to do future planning and design.
State
Completed
The ticket has been fully implemented, completed, and merged with the source code. This label should only be applied once a ticket is closed.
State
Duplicate
A ticket that represents the same content as an existing ticket.
State
In Progress
A ticket that is actively being developed.
State
In Review
A ticket that has had some code completed to implement but is waiting to pass peer review and is not yet merged in.
State
Paused
This ticket's work started but wasn't finished. It's on hold (likely in a feature branch) and will be resumed later, either due to a blocker or a delay.
State
Unverified
All new tickets start in this state. A developer may set it to show the ticket is unverified. This means we haven't agreed to work on it. It will either move to a verified state or be closed as wontdo.
State
Verified
The issue has been verified by a developer as legitimate. It will be worked on and verified tickets are now considered part of the backlog.
State
Wont Do
This ticket has been decided it wont be done. This may mean the bug has been determined to not be real (cant verify) or the feature is one we have decided we dont want to adopt.
Type
Automation
Any edits or discussion about the AI automated coding system.
Type
Bug
Something that doesnt work as intended.
Type
Discussion
Anytime a ticket represents a discussion about a subject and doesnt fall into one of the other categories.
Type
Documentation
An error or improvement needed in the documentation.
Type
Epic
Any first tier epic. That is, an epic which contains only issues as children and will not have sub-epics.
Type
Feature
Some new functionality not present.
Type
Legendary
A type of Epic which will contain other Epics.
Type
Refactor
A code change that restructures existing code without changing its external behavior.
Type
Support
Someone needs help using the project.
Type
Task
A generic task that doesnt fit into the other type categories.
Type
Testing
Work exclusively focusing on fixing or expanding testing.
No Label
Type
Feature
Projects
Clear projects
No project
Assignees
aditya (Aditya Chhabra)
aleenaumair (Aleena Umair)
brent.edwards (Brent Edwards)
CoreRasurae (Luis Mendes)
drew (Drew Morris)
eugen.thaci (Eugen Thaci)
freemo (Jeffrey Phillips Freeman)
HAL9000 (HAL 9000)
HAL9001 (HAL9001)
hamza.khyari (Hamza Khyari)
hurui200320 (Rui Hu)
justin.morris
khird (Kyle Hird)
org.cleveragents
Clear assignees
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: cleveragents/cleveractors-core#113
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Delete Branch "feature/m1-shell-timeout-override"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Summary
Adds an optional per-invocation
timeoutargument to theshellandhttp_requesttools so an LLM driving them can raise the execution limit for a single long-running call — instead of being told to "increase the timeout config value", which it cannot do at runtime. The model previously threadedtimeout Ninto the call, corrupting the command.TimeoutPolicyvalue object resolves the effective timeout.max_timeoutconfig field (default 120s) bounds any override; an optional shell-onlyshell_max_timeoutrefines the ceiling forshellalone and is never consulted byhttp_request.timeoutargument.Specification / ADR
docs/adr/ADR-2030-tool-calling-spec-extensions.mdD-9 (accepted revision).max_timeoutfield).Testing
features/shell_timeout_override.feature— 32 scenarios (shell + http, including one provingshell_max_timeoutdoes not leak intohttp_request). Full suite green (2943 scenarios, 0 failed).robot/shell_timeout_override.robot— 4 real-subprocess integration tests.benchmarks/timeout_policy_benchmark.py.timeout_policy.py100%,llm_tools.py100%,tool.py98%). lint / format / typecheck / security / dead_code all green.Closes #111
PR Review: !113 (Ticket #111)
Verdict: Approve
The implementation cleanly realizes ADR-2030 D-9 and the Actor Configuration Standard §4.5 / §21.1 (Version 1.2.0) changes. The
TimeoutPolicyvalue object is a good abstraction, validation happens before any subprocess/request, thetimeoutcontrol argument is never concatenated into the shell command, and the error messages now point the model at the actionable per-call lever. Tests (Behave, Robot, ASV) are comprehensive and the commit/branch hygiene matches the ticket metadata. Only minor gaps/note-level items remain.Critical Issues
None
Major Issues
None
Minor Issues
Missing regression scenario for the original bug shape (
timeout+ positionalargs)features/shell_timeout_override.featuretimeout Ninto the positionalargslist, which got concatenated onto the command line. The code now correctly readsargs.get("timeout")separately fromargs["args"], but there is no Behave/Robot scenario that supplies both a per-calltimeoutand a positionalargslist and asserts the output is uncorrupted. Adding one scenario would close the regression loop explicitly.TimeoutPolicymodule docstring is slightly stalesrc/cleveractors/agents/timeout_policy.py, lines 1–9shelltool's per-invocationtimeoutargument today … and is reusable by any future tool." Since_http_request_toolalso usesTimeoutPolicytoday, the wording implies onlyshellconsumes it. Rephrase to mention both current consumers or drop the "today / future" framing.Invalid timeout ceilings are validated lazily
src/cleveractors/agents/tool.py, lines 325–362max_timeoutorshell_max_timeoutis only detected when the first timeout-honouring tool is invoked, not atToolAgentconstruction. For faster failure of misconfigured agents, consider validating these config fields in__init__(or in the policy builders called from__init__).Coverage sits between two documented thresholds
noxfile.pyconstant (COVERAGE_THRESHOLD = 96.5), butCONTRIBUTING.mdstates the project-specific enforced merge gate is 97%. Please confirm the actualnox -s coverage_reportoutput; if it is below 97%, add targeted tests to meet the documented gate (the project may also need to reconcile the noxfile constant withCONTRIBUTING.md).Nits
ShellTimeoutLibexposes a rawValueErroron bad timeout stringsrobot/ShellTimeoutLib.py, line 36float(timeout)will raiseValueErrorif the Robot test passes a non-numeric string. Wrapping this in anExecutionError(or validating and raisingAssertionError) would give clearer Robot failure output.Empty benchmark
teardownbenchmarks/timeout_policy_benchmark.py, lines 32–33teardownmethod is a no-op. It is harmless, but can be removed or annotated with a comment if state cleanup is truly unnecessary.Summary
Solid, well-scoped change. The per-invocation
timeoutargument is implemented correctly for bothshellandhttp_request, the ceiling logic (max_timeout/shell_max_timeout) is clean and properly separated, and the schema/documentation/spec updates are all in place. The only substantive follow-ups are adding thetimeout+argsregression scenario and clarifying the coverage threshold situation; neither blocks approval.In the review issuecomment 321954, Minor, Issue 4, the coverage is a non-issue, since the 96.5% threshold rounds to the 97% threshold in the documentation and it is meant to be that way. The current coverage of 96.7% is within the specified range.
Thanks for the review, @hurui200320! Addressed the Minor issues; Nit 1 fixed, Nit 2 kept as-is (see below). Confirmed all four against §4.5/ADR-2030 before applying — none conflict with the spec.
Minor 1 (missing
timeout+argsregression scenario) — Added. Two new Behave scenarios infeatures/shell_timeout_override.featurereproduce the original bug shape directly: a positionalargslist containing the literal tokens"timeout"/"99"alongside a real per-calltimeoutcontrol argument, asserting the output is exactly the harmless concatenated text ("marker timeout 99") and that the override still functions (asleep 2succeeds undertimeout=4even withargspresent). Also added a matching Robot regression test.Minor 2 (stale
TimeoutPolicydocstring) — Fixed. Now states it backs the per-invocationtimeoutargument on bothshellandhttp_requesttoday, dropping the "today / future" framing.Minor 3 (lazy ceiling validation) — Fixed.
ToolAgent.__init__now eagerly builds both timeout policies and converts aValueErrorintoAgentCreationError, so a misconfiguredtools_max_timeout/shell_max_timeoutfails at construction, not on first call. As a consequence, the two call sites (_execute_shell_command,_http_request_tool) no longer need their owntry/except ValueError— the ceiling is guaranteed valid by the time they run, per ADR-2030 D-9 (updated in place with a bullet documenting this). The two existing "invalid ceiling" scenarios now assertAgentCreationErrorat construction time instead ofExecutionErrorat call time.Minor 4 (coverage 96.5% vs 97%) — No code change; per @CoreRasurae's earlier reply this is an intentional pre-existing project-wide threshold choice, outside this ticket's scope (not part of the Actor Configuration Standard or ADR-2030). Independently verified: a coverage run scoped to the feature-relevant BDD files shows
timeout_policy.pyandllm_tools.pyat 100%, and none of the changed/added lines intool.pyappear in that scoped run's missing-lines list — the new eager-validation code is fully exercised. Also confirmed the full 2945-scenario suite still passes with 0 failures after these changes (no regressions from touching the sharedToolAgent.__init__path).Nit 1 (
ShellTimeoutLibrawValueError) — Fixed. Added a_parse_timeouthelper that raises a clearAssertionErroron a non-numerictimeoutstring; added a Robot test case (Non Numeric Timeout Argument Fails With A Clear Message) exercising it.Nit 2 (empty benchmark
teardown) — Left as-is. It matches the establishedsetup/time_*/teardownlifecycle convention used by the other benchmarks in this repo (e.g.hello_benchmark.py), so removing it would make this benchmark inconsistent with house style for near-zero benefit.Ran
nox -s lint / format --check / typecheck / dead_code / security_scan(all green), the full Behave suite (146 features, 2945 scenarios, 0 failed), and the Robot integration suite for this feature (5/5 passed) after applying the above.e3b675b7d2tof19714a3daf19714a3dato0133520555