cleveragents/cleveractors-core
0
0
Fork 0
Code Issues 20 Pull Requests 6 Actions 6 Packages Projects Releases Wiki Activity

test(agents): capture inline sandbox __import__ escape regression (#107) #110

Open
CoreRasurae wants to merge 1 commits from tdd/m1-inline-sandbox-import-restriction into master
pull from: tdd/m1-inline-sandbox-import-restriction
merge into: cleveragents:master
Conversation 0 Commits 1 Files Changed 2
+98
CoreRasurae commented 2026-08-04 21:26:22 +00:00
Member
Copy Link
Copy Source

Summary

Adds a failing-first Behave regression test proving issue #107: ToolAgent._execute_python_code (cleveractors.agents.tool) builds the inline-code sandbox's __builtins__ dict per docs/index.md §13.2.1's "Restricted Built-ins for Inline Code" table, which lists a single module-shaped facility (json) and states that table is exhaustive. §13.2.3 additionally prohibits "dynamic import of modules other than those explicitly listed". Despite this, safe_globals["__builtins__"]["__import__"] is bound directly to the real, unrestricted __import__ builtin, so inline code can write import os and reach exactly the filesystem/network/process facilities the standard was written to keep out.

Two scenarios drive the two documented entry points that share _execute_python_code — a type: tool agent's inline code: body, and the exec_python-gated python_exec built-in tool — through the public ToolAgent.process_message() API with code that does import os; result = os.getcwd(), and assert an ExecutionError is raised instead of the import succeeding. Today it isn't: both return the real working directory path.

Both scenarios are tagged @tdd_issue, @tdd_issue_107, and @tdd_expected_fail per the TDD issue-capture workflow.

The actual fix (a restricted __import__ shim permitting only json) lands separately on bugfix/m1-inline-sandbox-import-restriction per issue #107.

Test plan

  • nox -s lint green
  • nox -s format -- --check green
  • nox -s typecheck green
  • nox -s security_scan green
  • nox -s dead_code green
  • nox -s unit_tests green — confirms both assertions fail via AssertionError without the @tdd_expected_fail tag (verified locally by temporarily removing it), and TddExpectedFailPolicy inverts them to a pass with the tag present
  • nox -s coverage_report — 96.7% (>= 96.5% threshold)
  • nox -s integration_tests — green
  • nox -s e2e_tests — green
  • nox -s complexity, nox -s benchmark_regression — informational, unaffected by this test-only change

Closes #108

## Summary Adds a failing-first Behave regression test proving issue #107: `ToolAgent._execute_python_code` (`cleveractors.agents.tool`) builds the inline-code sandbox's `__builtins__` dict per `docs/index.md` §13.2.1's "Restricted Built-ins for Inline Code" table, which lists a single module-shaped facility (`json`) and states that table is exhaustive. §13.2.3 additionally prohibits "dynamic import of modules other than those explicitly listed". Despite this, `safe_globals["__builtins__"]["__import__"]` is bound directly to the real, unrestricted `__import__` builtin, so inline code can write `import os` and reach exactly the filesystem/network/process facilities the standard was written to keep out. Two scenarios drive the two documented entry points that share `_execute_python_code` — a `type: tool` agent's inline `code:` body, and the `exec_python`-gated `python_exec` built-in tool — through the public `ToolAgent.process_message()` API with code that does `import os; result = os.getcwd()`, and assert an `ExecutionError` is raised instead of the import succeeding. Today it isn't: both return the real working directory path. Both scenarios are tagged `@tdd_issue`, `@tdd_issue_107`, and `@tdd_expected_fail` per the TDD issue-capture workflow. The actual fix (a restricted `__import__` shim permitting only `json`) lands separately on `bugfix/m1-inline-sandbox-import-restriction` per issue #107. ## Test plan - [x] `nox -s lint` green - [x] `nox -s format -- --check` green - [x] `nox -s typecheck` green - [x] `nox -s security_scan` green - [x] `nox -s dead_code` green - [x] `nox -s unit_tests` green — confirms both assertions fail via `AssertionError` without the `@tdd_expected_fail` tag (verified locally by temporarily removing it), and `TddExpectedFailPolicy` inverts them to a pass with the tag present - [x] `nox -s coverage_report` — 96.7% (>= 96.5% threshold) - [x] `nox -s integration_tests` — green - [x] `nox -s e2e_tests` — green - [x] `nox -s complexity`, `nox -s benchmark_regression` — informational, unaffected by this test-only change Closes #108
CoreRasurae added this to the v2.1.0 milestone 2026-08-04 21:26:22 +00:00
CoreRasurae added 1 commit 2026-08-04 21:26:27 +00:00
test(agents): capture inline sandbox __import__ escape regression (#107)
CI / lint (pull_request) Successful in 47s
Details
CI / typecheck (pull_request) Successful in 1m32s
Details
CI / security (pull_request) Successful in 1m16s
Details
CI / quality (pull_request) Successful in 1m34s
Details
CI / build (pull_request) Successful in 1m42s
Details
CI / integration_tests (pull_request) Successful in 3m38s
Details
CI / unit_tests (pull_request) Successful in 4m57s
Details
CI / coverage (pull_request) Successful in 4m2s
Details
CI / status-check (pull_request) Successful in 17s
Details
CI / benchmark (pull_request) Failing after 21m22s
Details
bac4868abd 
Adds a failing-first Behave regression test proving issue #107:
ToolAgent._execute_python_code (cleveractors.agents.tool) builds the
inline-code sandbox's __builtins__ dict per docs/index.md §13.2.1's
"Restricted Built-ins for Inline Code" table, which lists a single
module-shaped facility (json) and states the table is exhaustive. §13.2.3
additionally prohibits "dynamic import of modules other than those
explicitly listed". Despite this, safe_globals["__builtins__"] binds
"__import__" directly to the real, unrestricted __import__ builtin, so
inline code can write `import os` and reach exactly the filesystem/
network/process facilities the standard was written to keep out.

Two scenarios drive the two documented entry points that share
_execute_python_code -- a "type: tool" agent's inline `code:` body, and
the exec_python-gated `python_exec` built-in tool -- through the public
ToolAgent.process_message() API with code that does `import os; result =
os.getcwd()`, and assert an ExecutionError is raised instead of the
import succeeding. Confirmed both assertions fail via AssertionError when
@tdd_expected_fail is removed (os.getcwd() returns a real path today),
and pass via TddExpectedFailPolicy's inversion with the tag present.

Both scenarios are tagged @tdd_issue, @tdd_issue_107, and
@tdd_expected_fail per the TDD issue-capture workflow.

The actual fix (a restricted __import__ shim permitting only `json`)
lands separately on bugfix/m1-inline-sandbox-import-restriction per
issue #107.

Refs: #107, #108
CoreRasurae added the
Type
Testing
 label 2026-08-04 21:27:06 +00:00
hurui200320 approved these changes 2026-08-05 05:47:31 +00:00
hurui200320 left a comment
Member
Copy Link
Copy Source

PR Review: !110 (Ticket #108)

Verdict: Approve

The PR correctly implements the TDD regression test for issue #107 as specified in #108. The two Behave scenarios cover both documented entry points into ToolAgent._execute_python_code, carry the required @tdd_issue @tdd_issue_107 @tdd_expected_fail tags, and rely on AssertionError so the TddExpectedFailPolicy inversion works as intended. No critical or major technical issues were found.

Critical Issues

None

Major Issues

None

Minor Issues

  1. Coverage threshold discrepancy — noxfile.py:27 sets COVERAGE_THRESHOLD = 96.5, while CONTRIBUTING.md §"Project-Specific Guidelines" and .gitea/workflows/ci.yml state the enforced coverage gate is 97%. The PR test plan reports 96.7% and passes noxfile.py's threshold, but this inherited project-level inconsistency could mask a real coverage regression. Recommend aligning noxfile.py with the documented 97% gate (separate from this PR, or clarify if 96.5% is intentional).

Nits

  1. Import-form coverage gap — features/inline_sandbox_import_restriction.feature:44,56 only tests the import os form. Other dynamic-import forms (e.g., from os import getcwd or __import__('os')) share the same __import__ bypass and could be added in the fix PR (#107) to harden the restriction.

Summary

This is a clean, focused TDD capture PR. The scenarios correctly exercise the sandbox escape through both the python_exec built-in tool and a type: tool inline code: body, and they will flip from inverted-fail to outright pass once the fix in #107 replaces the raw __import__ reference. The code is statically typed, lint-clean, and follows the project's BDD/TDD conventions. Approving.

## PR Review: !110 (Ticket #108) ### Verdict: Approve The PR correctly implements the TDD regression test for issue #107 as specified in #108. The two Behave scenarios cover both documented entry points into `ToolAgent._execute_python_code`, carry the required `@tdd_issue @tdd_issue_107 @tdd_expected_fail` tags, and rely on `AssertionError` so the `TddExpectedFailPolicy` inversion works as intended. No critical or major technical issues were found. ### Critical Issues None ### Major Issues None ### Minor Issues 1. **Coverage threshold discrepancy** — `noxfile.py:27` sets `COVERAGE_THRESHOLD = 96.5`, while `CONTRIBUTING.md` §"Project-Specific Guidelines" and `.gitea/workflows/ci.yml` state the enforced coverage gate is **97%**. The PR test plan reports 96.7% and passes noxfile.py's threshold, but this inherited project-level inconsistency could mask a real coverage regression. Recommend aligning `noxfile.py` with the documented 97% gate (separate from this PR, or clarify if 96.5% is intentional). ### Nits 1. **Import-form coverage gap** — `features/inline_sandbox_import_restriction.feature:44,56` only tests the `import os` form. Other dynamic-import forms (e.g., `from os import getcwd` or `__import__('os')`) share the same `__import__` bypass and could be added in the fix PR (#107) to harden the restriction. ### Summary This is a clean, focused TDD capture PR. The scenarios correctly exercise the sandbox escape through both the `python_exec` built-in tool and a `type: tool` inline `code:` body, and they will flip from inverted-fail to outright pass once the fix in #107 replaces the raw `__import__` reference. The code is statically typed, lint-clean, and follows the project's BDD/TDD conventions. Approving.
Some checks are pending
CI / lint (pull_request) Successful in 47s
Details
CI / typecheck (pull_request) Successful in 1m32s
Details
CI / security (pull_request) Successful in 1m16s
Details
CI / quality (pull_request) Successful in 1m34s
Details
CI / build (pull_request) Successful in 1m42s
Details
CI / integration_tests (pull_request) Successful in 3m38s
Details
CI / unit_tests (pull_request) Successful in 4m57s
Details
CI / coverage (pull_request) Successful in 4m2s
Details
CI / status-check (pull_request) Successful in 17s
Details
CI / benchmark (pull_request) Failing after 21m22s
Details
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin tdd/m1-inline-sandbox-import-restriction:tdd/m1-inline-sandbox-import-restriction
git checkout tdd/m1-inline-sandbox-import-restriction
Sign in to join this conversation.
Reviewers
No Reviewers
hurui200320
Labels
Clear labels
auto/blocked-by-deps
PR blocked by an open issue dependency. Operator must close the dep (or remove the dependency link) before the merge driver can act. Auto-cleared by merge_drive when no open deps remain.
 auto/ci-timeout
Most recent merge cycle hit CI timeout. Driver excludes this PR while last merge_cycle row is < 30 min old; label persists thereafter as visible history.
 auto/claimed-implementer
Currently being processed by an implementer worker.
 auto/claimed-merge
Currently being processed by the merge driver.
 auto/claimed-reviewer
Currently being processed by a reviewer worker.
 auto/driver-down
Merge driver heartbeat stale; pipeline halted. Closed automatically on next clean tick.
 auto/invariant-violation
Detected master commit violating the strict merge invariant. Tracked as an issue (not a PR label); kept here for label completeness.
 auto/last-attempt-tier-0
In-cycle escalation: most recent attempt ran at the Tier 0 slot (`tier-0`). Slot's model defined in .opencode/models/tiers.yaml.
 auto/last-attempt-tier-1
In-cycle escalation: most recent attempt ran at the Tier 1 slot (`tier-1`). Slot's model defined in .opencode/models/tiers.yaml.
 auto/last-attempt-tier-2
In-cycle escalation: most recent attempt ran at the Tier 2 slot (`tier-2`). Slot's model defined in .opencode/models/tiers.yaml. Gated behind IMPLEMENTER_ESCALATION_TIER2_ENABLED.
 auto/last-attempt-tier-min
In-cycle escalation: most recent attempt ran at the Tier -1 slot (`tier-min`). Slot's model defined in .opencode/models/tiers.yaml. Suffix is ``-min`` (not ``--1``) so the Forgejo UI reads naturally.
 Automation Tracking
Tracking issues used by the AI Automation system for agents to communicate and report.
 auto/needs-conflict-resolution
Rebase conflict needs LLM conflict-resolver.
 auto/needs-implementer
Failing CI needs implementer attention.
 auto/postmortem
Documenting a driver incident or rollback.
 auto/ready-to-merge
Reviewer has APPROVED this PR and no later REQUEST_CHANGES is outstanding. The merge driver requires this label to even consider a PR for merging. Set by the reviewer worker on APPROVE; cleared on REQUEST_CHANGES.
 auto/restart-throttled
Train repeatedly lost master-tempo races. Driver excludes via merge_cycle until cooldown elapses; label persists as visible history.
 auto/revert
Revert PR backing out an invariant violation. Fast-tracked through the merge driver.
 auto/sentinel
Sentinel PR duplicated from upstream into a personal fork by tools/duplicate_prs_to_fork.py for pipeline testing. Lives only in the fork; the canonical pipeline never sees it.
 auto/stale-inactivity
No implementer activity for N days. Flagged for human review. Auto-cleared on next push to head branch.
 auto/unstable
Repeatedly fails on current master (>= 3 ci-fail-on-rebased-sha releases in 12 h). Excluded from driver until human triage.
 Blocked
A ticket in a blocked state and unable to complete until some other task is completed first.
Bounty
$100
A bounty of $100 for any open-source contributor who provides a MR that solves this issue
Bounty
$1000
A bounty of $1000 for any open-source contributor who provides a MR that solves this issue
Bounty
$10000
A bounty of $10000 for any open-source contributor who provides a MR that solves this issue
Bounty
$20
A bounty of $20 for any open-source contributor who provides a MR that solves this issue
Bounty
$2000
A bounty of $2000 for any open-source contributor who provides a MR that solves this issue
Bounty
$250
A bounty of $250 for any open-source contributor who provides a MR that solves this issue
Bounty
$50
A bounty of $50 for any open-source contributor who provides a MR that solves this issue
Bounty
$500
A bounty of $500 for any open-source contributor who provides a MR that solves this issue
Bounty
$5000
A bounty of $5000 for any open-source contributor who provides a MR that solves this issue
Bounty
$750
A bounty of $750 for any open-source contributor who provides a MR that solves this issue
MoSCoW
Could have
Could have feature in order to satisfy the epic/legendary.
MoSCoW
Must have
Must have feature in order to satisfy the epic/legendary.
MoSCoW
Should have
Should have feature in order to satisfy the epic/legendary.
Needs Feedback
There are questions in the ticket that can not be completed until the project owner provides clarity.
Points
1
1 man-hours worth of work for an expert with no learning curve.
Points
13
13 man-hours worth of work for an expert with no learning curve.
Points
2
2 man-hours worth of work for an expert with no learning curve.
Points
21
21 man-hours worth of work for an expert with no learning curve.
Points
3
3 man-hours worth of work for an expert with no learning curve.
Points
34
34 man-hours worth of work for an expert with no learning curve.
Points
5
5 man-hours worth of work for an expert with no learning curve.
Points
55
55 man-hours worth of work for an expert with no learning curve.
Points
8
8 man-hours worth of work for an expert with no learning curve.
Points
88
88 man-hours worth of work for an expert with no learning curve.
Priority
Backlog
This ticket has backlogged priority and is not to be worked on yet
Priority
CI Blocker
Critical priority issue that blocks CI/CD pipeline and prevents PR merges
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Signed-off: Owner
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.
 Signed-off: Scrum Master
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.
 Signed-off: Tech Lead
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.
 Spike
A ticket for learning a tool or technology that is needed to be able to do future planning and design.
State
Completed
The ticket has been fully implemented, completed, and merged with the source code. This label should only be applied once a ticket is closed.
State
Duplicate
A ticket that represents the same content as an existing ticket.
State
In Progress
A ticket that is actively being developed.
State
In Review
A ticket that has had some code completed to implement but is waiting to pass peer review and is not yet merged in.
State
Paused
This ticket's work started but wasn't finished. It's on hold (likely in a feature branch) and will be resumed later, either due to a blocker or a delay.
State
Unverified
All new tickets start in this state. A developer may set it to show the ticket is unverified. This means we haven't agreed to work on it. It will either move to a verified state or be closed as wontdo.
State
Verified
The issue has been verified by a developer as legitimate. It will be worked on and verified tickets are now considered part of the backlog.
State
Wont Do
This ticket has been decided it wont be done. This may mean the bug has been determined to not be real (cant verify) or the feature is one we have decided we dont want to adopt.
Type
Automation
Any edits or discussion about the AI automated coding system.
Type
Bug
Something that doesnt work as intended.
Type
Discussion
Anytime a ticket represents a discussion about a subject and doesnt fall into one of the other categories.
Type
Documentation
An error or improvement needed in the documentation.
Type
Epic
Any first tier epic. That is, an epic which contains only issues as children and will not have sub-epics.
Type
Feature
Some new functionality not present.
Type
Legendary
A type of Epic which will contain other Epics.
Type
Refactor
A code change that restructures existing code without changing its external behavior.
Type
Support
Someone needs help using the project.
Type
Task
A generic task that doesnt fit into the other type categories.
Type
Testing
Work exclusively focusing on fixing or expanding testing.
No Label
Type
Testing
Milestone
No items
No Milestone v2.1.0
Projects
Clear projects
No project
Assignees
Clear assignees
aditya (Aditya Chhabra) aleenaumair (Aleena Umair) brent.edwards (Brent Edwards) CoreRasurae (Luis Mendes) drew (Drew Morris) eugen.thaci (Eugen Thaci) freemo (Jeffrey Phillips Freeman) HAL9000 (HAL 9000) HAL9001 (HAL9001) hamza.khyari (Hamza Khyari) hurui200320 (Rui Hu) justin.morris khird (Kyle Hird) org.cleveragents
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Blocks
#108 TDD: Inline-code sandbox exposes __import__, letting code bypass the Restricted Built-ins set entirely (e.g. import os)
cleveragents/cleveractors-core
Reference: cleveragents/cleveractors-core#110
Delete Branch "tdd/m1-inline-sandbox-import-restriction"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?