HAL9000/temp
0
0
Fork 0
forked from HAL9000/cleveragents-core
Code Pull Requests Activity
1,662 Commits 550 Branches 3 Tags
fix/actor-add-cli-yaml-first-path
Commit Graph

1662 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
freemo 62ded31c24 fix(cli): route 'agents actor add' through ActorRegistry.add() YAML-first path 
Route the 'agents actor add' CLI command through ActorRegistry.add() instead
of the legacy registry.upsert_actor() path. This ensures the original YAML
text, schema_version, and compiled_metadata are preserved in the database.

Changes:
- src/cleveragents/cli/commands/actor.py: Add _load_config_text() helper that
  returns both raw text and parsed dict. Refactor add() to call registry.add()
  with the raw yaml_text and update=update_existing flag when a registry is
  available. The service fallback path (no registry) is unchanged.
- features/steps/actor_cli_steps.py: Update add command step definitions to
  mock registry.add() instead of registry.upsert_actor(). Update 'the actor
  add should pass the loaded config' assertion to verify registry.add() is
  called with a non-empty yaml_text string.
- features/steps/actor_cli_yaml_steps.py: Update add command steps to mock
  registry.add() instead of registry.upsert_actor().
- features/steps/actor_add_rich_output_steps.py: Update add command steps to
  mock registry.add() instead of registry.upsert_actor().
- robot/helper_actor_add_rich_output.py: Update helper to mock registry.add()
  instead of registry.upsert_actor().
- features/actor_add_yaml_first_path.feature: New Behave feature verifying
  the YAML-first persistence path is used by actor add.
- features/steps/actor_add_yaml_first_path_steps.py: Step definitions for
  the new YAML-first path feature.
- robot/actor_add_yaml_first_path.robot: New Robot integration tests verifying
  yaml_text is preserved and upsert_actor is not called.
- robot/helper_actor_add_yaml_first_path.py: Helper script for Robot tests.

Fixes #3426

ISSUES CLOSED: #3426
 2026-04-05 21:19:40 +00:00
freemo c3b2f59772 fix(sandbox): remove type: ignore in SandboxManager strategy assignment 
Reviewed and APPROVED. Closes #2828.
 2026-04-05 21:13:07 +00:00
freemo d747bfd7de chore(agents): improve ca-bug-hunter — prevent false positive infrastructure bug reports 
Reviewed and APPROVED. Closes #1595.
 2026-04-05 21:13:06 +00:00
freemo a3eb9ea9d1 fix(cli): add missing _log.debug call to session export/import/tell DatabaseError handlers 
Reviewed and APPROVED. Closes #2788.
 2026-04-05 21:13:04 +00:00
freemo 188ea031eb fix(resources): register fs-mount built-in resource type at startup 
Reviewed and APPROVED. Closes #2911.
 2026-04-05 21:13:02 +00:00
freemo b9c3ccee37 fix(robot): correct dedent logic for try...except...finally in indentation_library 
Reviewed and APPROVED. Closes #2845.
 2026-04-05 21:13:01 +00:00
freemo 24b34e6715 docs: update specification — fix invariant precedence chain (3-tier→4-tier) and document non_overridable flag 
Reviewed and APPROVED. Closes #3064.
 2026-04-05 21:12:59 +00:00
freemo 8f43352723 fix(resource-type): require letter-start for namespace/name in _NAMESPACED_RE 
Reviewed and APPROVED. Closes #2983.
 2026-04-05 21:12:17 +00:00
freemo 3d7f213527 fix(tdd): replace non-standard @tdd_bug tags with @tdd_issue per CONTRIBUTING.md 
Reviewed and APPROVED. Closes #2779.
 2026-04-05 21:12:14 +00:00
freemo 54285e0f33 fix(cli): correct session show rich output Session Summary panel field labels and fields 
Reviewed and APPROVED. Closes #3040.
 2026-04-05 21:12:13 +00:00
freemo 0b8152b9d0 fix(tui): show command descriptions in SlashCommandOverlay alongside command names 
Reviewed and APPROVED. Closes #3437.
 2026-04-05 21:12:09 +00:00
freemo b6959aeffe fix(actors): enforce --update flag in agents actor add to prevent silent overwrites 
Reviewed and APPROVED. Closes #2609.
 2026-04-05 21:11:55 +00:00
freemo c8b66c8294 fix(config): align Settings and alembic/env.py database_url defaults to spec-required ~/.cleveragents/cleveragents.db 
Reviewed and APPROVED. Closes #2871.
 2026-04-05 21:11:53 +00:00
freemo 6be538bd5c fix(resources): add overlay to ResourceTypeConfigSchema sandbox strategy validation 
Reviewed and APPROVED. Closes #2827.
 2026-04-05 21:11:50 +00:00
freemo cab263394c fix(resource-registry): implement get_parents() on ResourceDagMixin 
Reviewed and APPROVED. Closes #2844.
 2026-04-05 21:11:47 +00:00
freemo 1e3390f228 fix(a2a): update A2aVersionNegotiator to support JSON-RPC 2.0 
Reviewed and APPROVED. Closes #2747.
 2026-04-05 21:11:40 +00:00
freemo 31b8294f2d fix(tool): wire 6-level execution environment precedence chain in ToolRunner 
Reviewed and APPROVED. Closes #2592.
 2026-04-05 21:11:38 +00:00
freemo 2a541bb1e1 fix(cli): add Name and Updated columns to agents plan list table output 
Reviewed and APPROVED. Closes #2611.
 2026-04-05 21:11:36 +00:00
freemo 4aaf865420 fix(acms): implement real retrieval logic in all 6 spec-required context strategies 
Reviewed and APPROVED. Priority/Critical fix. Closes #3500.
 2026-04-05 21:11:34 +00:00
freemo 869777bb86 fix(tui): add plain text format support to session export command 
Reviewed and APPROVED. Closes #3036.
 2026-04-05 21:10:16 +00:00
freemo ef557a31a9 fix(a2a): change A2aErrorDetail.code to int and map error constants to JSON-RPC 2.0 integer codes 
Reviewed and APPROVED. Closes #2746.
 2026-04-05 21:10:14 +00:00
freemo e749513704 fix(persistence): persist reversion_count, last_completed_step, and last_checkpoint_id on LifecyclePlanModel 
Reviewed and APPROVED. Closes #2864.
 2026-04-05 21:10:10 +00:00
freemo 3470d3c061 chore(agents): improve ca-test-infra-improver — prevent massive duplicate issue creation 
Reviewed and APPROVED. Closes #1802.
 2026-04-05 21:09:53 +00:00
freemo 660a194012 fix(ci): update nightly workflow coverage minimum to 97% per project requirements 
Reviewed and APPROVED. Closes #2773.
 2026-04-05 21:09:50 +00:00
freemo 3acfe45b7b docs: add providers API reference, update index/architecture/changelog 
Reviewed and APPROVED. Documentation-only PR.
 2026-04-05 21:09:47 +00:00
freemo 86999ea959 fix(config): add server_url, server_token, format, and default_estimation_actor fields to Settings 
Reviewed and APPROVED. Closes #2870.
 2026-04-05 21:09:46 +00:00
freemo 920faa0dd8 fix(a2a): add A2A Python SDK as project dependency 
Reviewed and APPROVED. Closes #2858.
 2026-04-05 21:09:44 +00:00
freemo 63ea4d5279 fix(cli): align actor context CLI with robot test 
Reviewed and APPROVED. Closes #2793.
 2026-04-05 21:09:42 +00:00
freemo f4233fb3bd fix(config): correct Settings.data_dir default from Path("data") to Path.home() / ".cleveragents" 
Reviewed and APPROVED. Closes #2851.
 2026-04-05 21:09:36 +00:00
freemo 539f500abe fix(skills): add lowercase-only namespace/name pattern validation to SkillConfigSchema and ActionConfigSchema 
Reviewed and APPROVED. Closes #3029.
 2026-04-05 21:09:24 +00:00
freemo 2e2202e52f fix(tests): add missing Behave feature file for coverage threshold config 
Reviewed and APPROVED. Closes #2767.
 2026-04-05 21:09:17 +00:00
freemo eb4ccc819c fix(cli): add NAME positional argument to agents actor add command per spec 
Reviewed and APPROVED. Closes #2905.
 2026-04-05 21:09:13 +00:00
freemo e5380eabdf fix(acms): align DEFAULT_SKELETON_RATIO default value with spec 
Reviewed and APPROVED.
 2026-04-05 21:09:10 +00:00
freemo a145986df6 fix(cli): promote --format to global CLI callback option per spec 
Reviewed and APPROVED.
 2026-04-05 21:09:07 +00:00
freemo e1fbcf6345 fix(sandbox): use spec-required cleveragents/plan- branch naming in git worktree 
Reviewed and APPROVED. Closes #2601.
 2026-04-05 21:09:04 +00:00
freemo 5824e7c0aa fix(database): move get_all_for_project call outside loop in LegacyDataMigrator 
Reviewed and APPROVED. Closes #3047.
 2026-04-05 21:08:47 +00:00
freemo db61d66d80 fix(cli): remove --namespace/-n option from agents plan list command 
Reviewed and APPROVED. Closes #2986.
 2026-04-05 21:08:40 +00:00
freemo 62f90d4db2 fix(a2a): rename A2aErrorDetail.details to data per JSON-RPC 2.0 spec 
Reviewed and APPROVED. Closes #2745.
 2026-04-05 21:08:36 +00:00
freemo 6e168fe300 fix(skills): replace get_tool() calls with get() in SkillRegistry 
Reviewed and APPROVED. Closes #2914.
 2026-04-05 21:08:35 +00:00
freemo 98994e8b84 docs(lsp): document LspLifecycleManager restart_server deadlock fix 
Reviewed and APPROVED. Documentation-only PR.
 2026-04-05 21:08:33 +00:00
freemo acb90b812c fix(exceptions): replace Any with str | os.PathLike | None for FileSystemError.path 
Reviewed and APPROVED. Closes #3034.
 2026-04-05 21:08:31 +00:00
freemo 6a458e0dbb chore(agents): add mandatory labels to supervisor tracking issue creation 
Reviewed and APPROVED. Closes #3070.
 2026-04-05 21:08:29 +00:00
freemo 5cc50f5ca1 fix(cli): build spec-required execute output dict with sandbox, worker, and progress fields 
Reviewed and APPROVED. Closes #3435.
 2026-04-05 21:08:27 +00:00
freemo cdc93dc3cd fix(resources): support multiple named devcontainer configurations 
Reviewed and APPROVED. Closes #2615.
 2026-04-05 21:07:42 +00:00
freemo 367a272b60 feat(cli): add devcontainer lifecycle state column to agents resource list output 
Reviewed and APPROVED. Closes #2596.
 2026-04-05 21:07:40 +00:00
freemo 6c4bea1ba1 fix(tool): implement tool_type filter in ToolRegistry.list_tools() 
Reviewed and APPROVED. Closes #2974.
 2026-04-05 21:07:33 +00:00
freemo 13eb2a7c8c refactor(cli): deduplicate session list summary logic in list_sessions 
Reviewed and APPROVED. Closes #3046.
 2026-04-05 21:07:23 +00:00
freemo 63f5269f39 fix(cli): replace manual DI wiring in _get_tool_registry_service with container resolution 
Reviewed and APPROVED. Closes #3006.
 2026-04-05 21:07:14 +00:00
freemo 096cd79fbf fix(resource-registry): use full inheritance chain in type compatibility check 
Reviewed and APPROVED. Closes #2929.
 2026-04-05 21:07:11 +00:00
freemo 9bf6b2d7b0 fix(invariant): add frozen=True to Invariant domain models 
Reviewed and APPROVED. Closes #3116.
 2026-04-05 21:07:09 +00:00