Commit Graph

5 Commits

Author SHA1 Message Date
hurui200320 0bd8fbb296 fix(ci): resolve lint errors and remove stale tdd_expected_fail tag (#5264)
## Summary

The `lint` and `integration_tests` CI jobs on `master` are currently failing. This PR fixes both:

1. **Lint (`nox -e lint`)** — 51 ruff violations in `scripts/validate_automation_tracking.py`:
   - Sorted imports per isort convention
   - Replaced deprecated `typing.List`/`Dict`/`Tuple`/`Optional` with builtin equivalents (`list`, `dict`, `tuple`)
   - Removed unused `Optional` import and unused local variable `issues`
   - Fixed trailing whitespace, blank-line whitespace, and 6 lines exceeding 88-char limit
   - Replaced `dict.keys()` with `dict` in membership tests
   - Added return type annotation to `main()`

2. **Integration tests (`nox -e integration_tests`)** — 1 failure in `robot/coverage_threshold.robot`:
   - Removed `tdd_expected_fail`, `tdd_issue`, and `tdd_issue_4305` tags from the `Noxfile Contains Coverage Threshold Constant` test
   - The bug this TDD tag tracked (issue #4305) is now fixed — `COVERAGE_THRESHOLD = 97` exists in `noxfile.py`
   - The TDD expected-fail listener was inverting the passing result to a failure

### Local verification

- `nox -e lint` — All checks passed
- `nox -e integration_tests` — 1962 tests, 1962 passed, 0 failed, 0 skipped

### Files changed

| File | Change |
|------|--------|
| `scripts/validate_automation_tracking.py` | Fixed all 51 lint violations |
| `robot/coverage_threshold.robot` | Removed stale `tdd_expected_fail` tag |

Closes #5266

Reviewed-on: cleveragents/cleveragents-core#5264
Co-authored-by: Rui Hu <rui.hu@cleverthis.com>
Co-committed-by: Rui Hu <rui.hu@cleverthis.com>
2026-04-09 04:41:01 +00:00
freemo 8ea00f5185 fix: restore CI quality tests to passing state (#4175)
Co-authored-by: Jeffrey Phillips Freeman <the@jeffreyfreeman.me>
Co-committed-by: Jeffrey Phillips Freeman <the@jeffreyfreeman.me>
2026-04-08 11:02:14 +00:00
brent.edwards bb3c4ffaef fix(qa): resolve merge conflicts with master and fix coverage threshold test
Merged master into feature/q0-min-coverage. Resolved conflicts in:
- benchmarks/coverage_report_bench.py: combined AST and regex benchmarks
- docs/development/testing.md: merged both versions into comprehensive guide
- robot/coverage_threshold.robot: merged test cases from both branches
- implementation_plan.md: kept both Brent and Luis notes

Fixed coverage_threshold_config test that failed because it expected
a literal --fail-under=97 but our noxfile uses the COVERAGE_THRESHOLD
constant via f-string. Updated step to resolve the constant via AST.
2026-02-13 22:25:16 +00:00
brent.edwards 35c74d1a52 feat(qa): enforce coverage >=97% in CI 2026-02-13 18:54:15 +00:00
freemo 9b30421b34 feat(db): add spec-aligned action and plan tables with migrations, ORM models, and benchmarks 2026-02-13 13:05:20 -05:00