- Kunming, China, OL14KU
- https://skyblond.info
- Joined on
2025-03-18
Block a user
hurui200320
commented on pull request cleveragents/cleveractors-core#["70","Nit: `httpx.ConnectError`, `httpx.TimeoutException`, and `httpx.RemoteProtocolError` are all subclasses of `httpx.HTTPError`, so the explicit `isinstance` checks before the final `httpx.HTTPError`…"]
2026-07-03 14:07:24 +00:00
<Issue not found>
hurui200320
approved cleveragents/cleveractors-core#["70","## PR Review: !70 (Ticket #69)"]
2026-07-03 14:07:24 +00:00
<Issue not found>
hurui200320
commented on pull request cleveragents/cleveractors-core#["70","Nit: `prune_url` is computed inside the broad `try:` block of `_run_pruning_pass` but before any `ainvoke`; if `build_chat_model()` (called just above) raises, the work is wasted. Cosmetic."]
2026-07-03 14:07:24 +00:00
<Issue not found>
hurui200320
commented on pull request cleveragents/cleveractors-core#["70","Minor: `current_graph_name.set(graph_name)` returns a `Token` that is discarded, and the value persists for the lifetime of the current `asyncio.Task`. If a subsequent node in the same task does…"]
2026-07-03 14:07:24 +00:00
<Issue not found>
hurui200320
commented on pull request cleveragents/cleveractors-core#["70","Nit: the D-7 example message shows only `(max_retry_time was disabled)`, but the implementation also appends `(max_retries was disabled)` symmetrically. Pure documentation polish."]
2026-07-03 14:07:24 +00:00
<Issue not found>
hurui200320
commented on pull request cleveragents/cleveractors-core#["70","Minor: the no-tools streaming path calls `astream()` directly with no retry wrapping. ADR-2032 D-5 says \"every `ainvoke()` or equivalent call\" — `astream()` is functionally an LLM communication,…"]
2026-07-03 14:07:24 +00:00
<Issue not found>
hurui200320
commented on pull request cleveragents/cleveractors-core#["70","Minor: the spec specifies `-1` as the canonical sentinel for unbounded guards, but this code does not validate the range. A user who fat-fingers `max_retries=-7` or `max_retry_time=-0.5` gets the…"]
2026-07-03 14:07:24 +00:00
<Issue not found>
hurui200320
suggested changes for cleveragents/cleveractors-core#["70","## PR Review: !70 (Ticket #69)"]
2026-07-03 12:41:20 +00:00
<Issue not found>
hurui200320
suggested changes for cleveragents/cleveractors-core#["70","## PR Review: !70 (Ticket #69)"]
2026-07-03 06:07:57 +00:00
<Issue not found>
hurui200320
deleted branch feature/m2-llm-agent-stream-tool-calls from cleveragents/cleveractors-core
2026-07-03 05:51:32 +00:00
hurui200320
merged pull request cleveragents/cleveractors-core#["68","feat(agents): add tool-call support to LLMAgent.stream_message"]
2026-07-03 05:51:32 +00:00
<Issue not found>
hurui200320
pushed to feature/m2-llm-agent-stream-tool-calls at cleveragents/cleveractors-core
2026-07-03 05:48:51 +00:00
hurui200320
pushed to feature/m2-llm-agent-stream-tool-calls at cleveragents/cleveractors-core
2026-07-03 05:39:51 +00:00
hurui200320
pushed to feature/m2-llm-agent-stream-tool-calls at cleveragents/cleveractors-core
2026-07-03 05:19:52 +00:00
hurui200320
pushed to feature/m2-llm-agent-stream-tool-calls at cleveragents/cleveractors-core
2026-07-03 05:11:02 +00:00