hamza.khyari
23d8a53f6a
fix(resource): address review findings for resource type inheritance
Fix 25 of 27 review findings from PR #618 code review:
P1 (Must Fix):
- F3: Fix silent data corruption in _merge_collection for properties
dict fields (was falling through to string list merge)
- F1: Split 1023-line step file into 3 files + helper module (all <500)
- F4: Add SELECT FOR UPDATE lock on parent type in register_type to
prevent TOCTOU race in concurrent registrations
- F6: Fix docs claiming exceptions inherit from CleverAgentsError
(they inherit from ValueError)
- F7: Fix docs incorrectly describing validate_chain return type
P2 (Should Fix):
- F9: Replace dict[str, Any] with TypeRegistryMap type alias
- F10: Replace import logging with structlog in inheritance.py
- F11: Add __all__ to inheritance.py
- F13: Fix _load_type_registry to derive built_in from namespace column
- F14: Add warning log for unregistered types in resolve_inheritance_chain
- F15: Return defensive copies from resolve_fields
- F16: Add chain validation to bootstrap_builtin_types
- F17: Narrow except Exception to specific types in step files
- F18: Add side-effect verification scenarios after error cases
- F19: Always include inherits key in JSON output for consistent schema
- F20: Log actual exception instead of hardcoded string in CLI
P3 (Nit):
- F21: Reject whitespace-only inherits values in validate_chain
- F23: Wrap chain errors in HandlerResolutionError in resolver
- F24: Return defensive copies from as_cli_dict
- F25: Replace tautological assertion with ResourceHandler isinstance
- F26: Add whitespace inherits test scenario
- F27: Fix find_subtypes docstring to note it excludes ancestor_name
Deferred:
- F2: type: ignore in step files — pyright only checks src/, matches
existing project pattern (91 occurrences in resource_dag_steps.py)
- F5: CLI integration tests require full DI container setup
- F8: resource_registry_service.py size is pre-existing (971 on master)
- F12: Coverage boost file changes are test adaptations, not scope creep
- F22: FK constraint intentionally omitted per docs (SQLite compat)
2026-03-10 03:39:32 +00:00
..
2026-03-02 22:05:53 +00:00
2026-03-06 18:16:47 +00:00
2026-03-10 03:39:32 +00:00
2025-11-13 18:25:24 -05:00
2026-03-09 13:01:58 -04:00
2026-03-03 03:29:31 +00:00
2026-03-05 15:13:19 +00:00
2026-03-05 10:27:36 -05:00
2026-03-07 14:53:18 +00:00
2026-03-05 01:28:50 +00:00
2026-03-09 13:01:58 -04:00
2026-03-09 13:01:58 -04:00
2026-03-09 13:01:58 -04:00
2026-03-02 22:45:55 -05:00
2026-02-14 12:16:39 -05:00
2026-02-14 12:16:39 -05:00
2026-02-14 12:16:39 -05:00
2026-02-14 12:16:39 -05:00
2026-02-17 20:25:12 +00:00
2026-02-13 09:41:28 -05:00
2026-02-12 20:19:42 +00:00
2026-03-09 13:01:58 -04:00
2026-02-08 11:33:30 -05:00
2026-02-24 19:12:01 +00:00
2026-03-09 13:01:58 -04:00
2026-02-12 22:58:15 -05:00
2026-03-02 08:17:21 +00:00
2026-02-20 20:24:10 +00:00
2026-02-12 22:01:51 +00:00
2026-02-08 11:33:30 -05:00
2026-02-25 10:30:42 +00:00
2025-12-19 12:35:56 -05:00
2026-02-26 09:10:35 +00:00
2026-03-09 13:01:58 -04:00
2025-12-10 16:46:55 -05:00
2026-02-25 10:01:57 +00:00
2026-02-12 20:19:42 +00:00
2026-03-04 23:47:20 +00:00
2026-03-09 13:01:58 -04:00
2025-11-26 23:24:46 -05:00
2025-12-22 11:18:57 -05:00
2025-12-23 20:57:14 -05:00
2026-02-12 20:19:42 +00:00
2026-03-09 13:01:58 -04:00
2026-02-20 08:50:06 -05:00
2026-02-20 15:57:21 +00:00
2026-03-09 13:01:58 -04:00
2026-02-28 22:06:57 +00:00
2026-03-09 13:01:58 -04:00
2026-03-01 03:09:51 +00:00
2026-03-09 13:01:58 -04:00
2026-02-26 02:47:14 +00:00
2026-02-27 13:47:42 -05:00
2026-03-01 03:09:51 +00:00
2026-03-02 10:18:14 +00:00
2026-02-12 22:01:51 +00:00
2026-02-22 00:43:08 -05:00
2026-02-22 00:43:08 -05:00
2025-11-16 20:38:02 -05:00
2026-03-03 14:55:58 -05:00
2026-02-16 23:50:59 -05:00
2026-02-24 20:11:42 +00:00
2026-03-07 19:36:09 +00:00
2025-11-16 20:38:02 -05:00
2026-02-20 15:57:21 +00:00
2026-02-19 22:44:34 +00:00
2025-11-22 15:23:39 -05:00
2026-02-22 00:43:08 -05:00
2026-02-14 13:51:12 -05:00
2025-12-23 17:12:16 -05:00
2026-03-02 02:01:27 +00:00
2026-01-17 12:54:03 -05:00
2026-02-18 12:18:03 +00:00
2026-03-07 11:49:14 -05:00
2026-02-25 10:48:05 -05:00
2026-03-09 13:01:58 -04:00
2026-03-01 04:38:30 +00:00
2026-03-01 04:38:30 +00:00
2026-03-01 04:38:30 +00:00
2026-03-02 15:05:20 +00:00
2026-03-09 13:01:58 -04:00
2026-03-02 14:56:13 +00:00
2026-03-02 14:56:13 +00:00
2026-03-02 14:56:13 +00:00
2026-03-02 17:44:18 +00:00
2026-03-02 14:56:13 +00:00
2026-03-02 14:56:13 +00:00
2026-03-02 14:56:13 +00:00
2026-03-09 13:01:58 -04:00
2026-03-02 14:56:13 +00:00
2026-03-02 14:56:13 +00:00
2026-03-02 14:56:13 +00:00
2026-03-02 14:56:13 +00:00
2026-03-02 14:56:13 +00:00
2026-03-02 14:56:13 +00:00
2026-03-02 14:56:13 +00:00
2026-03-02 14:56:13 +00:00
2026-03-02 14:56:13 +00:00
2026-03-02 14:56:13 +00:00
2026-03-02 14:56:13 +00:00
2026-03-02 14:56:13 +00:00
2026-03-02 14:56:13 +00:00
2026-03-02 14:56:13 +00:00
2026-03-02 14:56:13 +00:00
2026-03-02 14:56:13 +00:00
2026-03-02 14:56:13 +00:00
2026-02-12 22:58:15 -05:00
2026-02-12 22:01:51 +00:00
2026-03-03 23:36:15 +00:00
2026-03-05 14:11:23 +00:00
2026-03-09 13:01:58 -04:00
2026-02-12 22:58:15 -05:00
2026-02-12 22:01:51 +00:00
2025-12-16 17:20:37 -05:00
2025-11-16 20:38:02 -05:00
2026-03-05 12:58:57 +00:00
2026-03-05 22:00:15 +00:00
2026-03-03 17:01:57 +00:00
2026-02-08 11:33:30 -05:00
2025-11-16 20:38:02 -05:00
2026-02-24 12:19:04 -05:00
2026-02-25 12:08:01 -05:00
2026-02-16 16:46:54 -05:00
2025-12-23 17:12:16 -05:00
2025-11-05 15:11:03 -05:00
2026-02-13 18:54:15 +00:00
2026-03-09 13:01:58 -04:00
2026-03-04 21:20:47 +00:00
2026-03-02 14:32:31 +00:00
2025-11-07 17:54:15 -05:00
2025-12-19 12:35:56 -05:00
2026-02-16 21:35:54 +00:00
2026-03-09 13:01:58 -04:00
2026-02-13 20:34:57 +00:00
2026-02-24 12:19:04 -05:00
2026-02-22 15:29:41 -05:00
2026-02-22 00:43:08 -05:00
2025-11-07 17:54:15 -05:00
2025-12-19 12:35:56 -05:00
2026-02-27 02:33:42 +00:00
2026-02-26 16:13:44 +00:00
2026-03-03 12:53:28 +00:00
2026-03-09 13:01:58 -04:00
2026-03-03 12:53:28 +00:00
2026-03-09 13:01:58 -04:00
2026-03-09 13:01:58 -04:00
2026-03-06 23:14:30 +00:00
2026-03-02 22:09:37 -05:00
2026-03-09 13:01:58 -04:00
2026-03-06 20:07:03 +00:00
2026-03-06 20:07:03 +00:00
2026-02-13 20:34:57 +00:00
2026-03-05 01:28:50 +00:00
2026-02-25 10:05:10 +00:00
2026-02-25 10:07:09 +00:00
2026-03-02 11:54:53 +00:00
2026-03-03 14:48:55 -05:00
2026-02-19 13:46:48 +00:00
2026-02-21 16:30:33 +00:00
2026-02-16 21:35:54 +00:00
2026-02-14 04:01:20 +00:00
2026-03-04 15:36:34 +00:00
2026-02-22 15:29:41 -05:00
2026-03-04 20:26:42 +00:00
2026-03-09 13:01:58 -04:00
2025-12-10 12:39:07 -05:00
2026-03-09 13:01:58 -04:00
2026-03-03 21:44:20 +00:00
2025-11-13 18:25:24 -05:00
2026-02-17 00:38:33 +00:00
2026-03-03 17:04:17 -05:00
2026-02-27 13:47:42 -05:00
2026-02-22 15:29:41 -05:00
2026-03-06 18:16:47 +00:00
2026-02-25 04:50:43 +00:00
2026-02-25 22:09:26 +00:00
2026-02-26 02:01:47 +00:00
2026-03-03 23:36:15 +00:00
2025-11-06 23:51:03 -05:00
2026-03-09 13:01:58 -04:00
2026-02-25 13:17:26 +00:00
2026-02-25 19:38:43 -05:00
2026-02-25 19:38:43 -05:00
2026-02-25 19:38:43 -05:00
2025-11-06 23:51:03 -05:00
2026-03-09 13:01:58 -04:00
2026-03-03 14:55:58 -05:00
2025-12-10 12:39:07 -05:00
2026-02-21 10:23:33 -05:00
2026-02-28 20:21:18 +00:00
2026-02-20 00:28:15 +00:00
2026-02-23 10:45:01 +00:00
2026-02-21 10:18:26 -05:00
2026-03-01 03:09:51 +00:00
2026-03-09 13:01:58 -04:00
2026-02-24 12:19:04 -05:00
2026-02-25 19:38:43 -05:00
2026-02-16 21:35:54 +00:00
2026-03-09 13:01:58 -04:00
2026-02-27 13:47:42 -05:00
2026-02-14 13:42:02 -05:00
2026-02-12 22:58:15 -05:00
2026-03-01 03:09:51 +00:00
2026-03-02 02:01:27 +00:00
2026-02-22 15:29:41 -05:00
2026-02-08 11:33:30 -05:00
2026-03-08 23:28:05 +00:00
2026-02-22 00:43:08 -05:00
2026-02-21 10:23:33 -05:00
2026-02-27 13:47:42 -05:00
2026-03-01 03:09:51 +00:00
2026-03-09 13:01:58 -04:00
2026-03-03 12:10:25 +00:00
2026-03-03 12:10:25 +00:00
2025-12-10 20:25:11 -05:00
2025-12-16 17:20:37 -05:00
2026-02-12 20:19:42 +00:00
2026-02-20 15:57:21 +00:00
2026-03-01 03:09:51 +00:00
2026-02-25 19:38:43 -05:00
2026-02-17 00:37:53 +00:00
2026-02-25 14:00:04 -05:00
2026-03-09 13:01:58 -04:00
2026-02-15 00:12:07 -05:00
2026-03-09 13:01:58 -04:00
2026-03-02 02:01:27 +00:00
2026-02-15 06:16:19 +00:00
2026-03-09 13:01:58 -04:00
2026-03-08 22:31:40 +00:00
2026-02-15 08:29:31 +00:00
2026-03-09 13:01:58 -04:00
2026-02-25 14:00:04 -05:00
2026-03-09 13:01:58 -04:00
2025-11-28 23:52:23 -05:00
2026-01-14 17:35:09 -05:00
2026-03-02 02:01:27 +00:00
2026-03-02 08:17:21 +00:00
2026-03-09 13:01:58 -04:00
2026-03-06 20:07:03 +00:00
2026-03-08 21:53:21 -04:00
2026-02-17 16:40:18 +00:00
2026-02-18 03:27:00 +00:00
2026-03-09 13:01:58 -04:00
2026-02-16 23:56:55 -05:00
2026-02-17 14:40:16 +00:00
2026-03-09 13:01:58 -04:00
2026-03-03 23:36:15 +00:00
2026-03-09 06:59:15 +00:00
2026-02-16 16:46:54 -05:00
2025-11-16 20:38:02 -05:00
2025-11-19 22:40:53 -05:00
2026-03-09 07:56:38 +00:00
2026-02-15 11:04:18 -05:00
2026-03-08 22:19:40 +00:00
2026-02-27 09:47:10 -05:00
2026-03-09 13:01:58 -04:00
2025-12-09 19:28:24 -05:00
2026-03-09 13:01:58 -04:00
2026-02-08 11:33:30 -05:00
2026-03-09 13:01:58 -04:00
2026-02-24 12:19:04 -05:00
2026-02-23 03:11:12 +00:00
2026-03-09 23:55:33 +00:00
2026-02-17 00:37:53 +00:00
2026-03-09 13:01:58 -04:00
2026-02-27 13:47:42 -05:00
2026-02-17 22:59:16 -05:00
2026-03-01 03:09:51 +00:00
2026-02-22 00:43:08 -05:00
2026-02-18 03:27:00 +00:00
2026-02-18 00:10:15 +00:00
2026-03-09 13:01:58 -04:00
2026-03-10 03:39:32 +00:00
2026-02-16 16:46:54 -05:00
2026-02-20 08:48:33 -05:00
2026-03-07 19:36:09 +00:00
2026-02-18 03:27:00 +00:00
2026-02-16 16:46:54 -05:00
2026-03-09 13:01:58 -04:00
2026-02-18 03:27:00 +00:00
2026-02-17 21:07:54 +00:00
2026-02-16 21:35:54 +00:00
2026-03-07 19:36:09 +00:00
2026-03-07 19:36:09 +00:00
2026-02-18 03:27:00 +00:00
2026-02-18 03:27:00 +00:00
2026-03-10 03:39:32 +00:00
2026-03-09 13:01:58 -04:00
2026-03-09 13:01:58 -04:00
2025-11-19 22:40:53 -05:00
2026-03-03 22:21:14 +00:00
2026-03-03 22:21:14 +00:00
2026-03-04 15:59:15 +00:00
2026-03-09 13:01:58 -04:00
2026-02-12 20:19:42 +00:00
2026-03-09 13:01:58 -04:00
2026-03-06 00:49:33 +00:00
2026-02-26 14:30:43 +00:00
2026-02-19 20:10:56 +00:00
2026-02-13 19:24:24 +00:00
2026-02-25 10:06:59 +00:00
2026-03-04 12:18:51 -05:00
2026-03-02 22:05:53 +00:00
2026-02-28 17:46:54 +00:00
2026-03-09 13:01:58 -04:00
2026-03-02 09:47:40 -05:00
2025-12-16 17:20:37 -05:00
2026-02-22 00:43:08 -05:00
2026-02-20 01:10:19 +00:00
2026-02-18 00:10:15 +00:00
2025-12-10 12:39:07 -05:00
2026-03-05 21:38:55 +00:00
2026-03-08 02:57:44 +00:00
2026-03-09 13:01:58 -04:00
2026-02-25 19:38:43 -05:00
2026-02-27 13:47:42 -05:00
2026-02-24 12:19:04 -05:00
2026-02-26 10:57:07 +00:00
2026-02-21 10:23:33 -05:00
2026-02-20 08:50:08 -05:00
2026-03-02 14:56:13 +00:00
2026-02-27 20:09:26 +00:00
2026-02-21 16:30:40 +00:00
2026-02-21 16:30:40 +00:00
2026-02-16 19:52:47 +05:30
2026-02-21 10:23:33 -05:00
2026-03-09 13:01:58 -04:00
2026-03-09 13:01:58 -04:00
2026-03-09 13:01:58 -04:00
2026-03-01 09:07:06 +00:00
2026-03-09 13:01:58 -04:00
2026-03-02 09:41:25 -05:00
2026-03-09 13:01:58 -04:00
2026-03-08 21:53:21 -04:00
2026-03-08 22:11:49 +00:00
2026-02-14 14:03:28 -05:00
2026-02-20 08:49:30 -05:00
2026-02-22 00:43:08 -05:00
2026-02-20 08:49:30 -05:00
2026-02-14 18:55:48 +00:00
2026-02-17 20:28:20 +00:00
2026-02-21 10:23:33 -05:00
2026-03-04 18:21:19 +00:00
2026-03-05 19:20:39 +00:00
2026-03-09 13:01:58 -04:00
2026-03-06 23:14:30 +00:00
2026-03-06 23:14:30 +00:00
2026-03-05 21:38:55 +00:00
2026-03-09 13:01:58 -04:00
2026-02-15 09:04:17 +00:00
2026-02-22 00:43:08 -05:00
2026-02-25 10:03:57 +00:00
2026-02-12 20:19:42 +00:00
2025-12-06 00:23:48 -05:00
2026-03-09 13:01:58 -04:00
2026-02-12 22:58:15 -05:00