forked from cleveragents/cleveragents-core
freemo
02250473ad
Fix all failing CI quality gates (lint, unit_tests, format) without suppressing any quality enforcement. Root causes and fixes: 1. Format: features/steps/plan_namespaced_name_tdd_steps.py had trailing whitespace; fixed by running ruff format. 2. Unit tests - A2A JSON-RPC 2.0 migration (commit9c6d6915) renamed A2aRequest fields (operation→method, request_id→id, a2a_version→jsonrpc) and A2aResponse fields (status+data→result, request_id→id) but did not update all step files and feature files: - a2a_jsonrpc_wire_format_steps.py: added use_step_matcher('re') and reset to 'parse' at end to prevent parallel test interference - a2a_facade_wiring_steps.py: updated operation= to method=, .status/.data to .result - a2a_facade_steps.py: updated request_id→id, a2a_version→jsonrpc, A2aResponse(request_id=..., status=...) to new API - m6_facade_steps.py: updated all old API usage - devcontainer_cleanup_steps.py: updated A2aRequest(operation=...) - plan_prompt_command_steps.py: updated A2aRequest(operation=...) - wf03_plan_prompt_confidence_steps.py: updated A2aRequest(operation=...) - consolidated_misc.feature: updated old A2aRequest/A2aResponse scenarios 3. Unit tests - Session CLI output changed (commit0d5d9cf0and others): - 'Session Created' → 'Session created' (lowercase) - 'Session Details' → 'Session Summary' - 'Sessions (N total)' → 'Sessions' - session list JSON: top-level 'total' → nested 'summary.total' - Fixed in: session_cli.feature, session_cli_coverage_boost.feature, session_cli_uncovered_branches.feature, session_list_error.feature, tdd_session_create_persist_steps.py 4. Unit tests - Plan list output changed (commit1a07a891): - 'V3 Lifecycle Plans' → 'Plans' - 'Lifecycle Plans' → 'Plans' - Name column removed (restored in source) - Invariants column removed (restored in source) - Project truncation removed (restored in source) - Fixed in: plan_cli_cancel_revert_coverage.feature, plan_lifecycle_cli_coverage.feature, plan_cli_coverage_boost_steps.py, plan.py (source code restored) 5. Unit tests - Plan apply command now requires ULID (commit300a5d6d): - plan_cli_coverage_r3.feature: updated 'PLAN-001' to valid ULID - plan_cli_coverage_r3_steps.py: added --yes flag, added new step for no-eligible-plans path 6. Unit tests - Various source code bugs: - ThoughtBlock: converted from @dataclass to Pydantic BaseModel (architecture test requires all dataclasses to use Pydantic) - session.py: added DatabaseError handling to export, import, tell commands - database.py: fixed rollback_to() to reuse checkpoint connection for writes - database.py: added _get_checkpoint_conn() helper - check-tls-cert.py: fixed SSLCertVerificationError.reason AttributeError 7. Unit tests - Test step bugs: - error_recovery_coverage_boost_steps.py: fixed invalid ULID _PLAN_ID - session_service_coverage_steps.py: fixed 'sha256:' prefix bug in checksum - database_models_new_coverage_steps.py: added 'name' field to session mock - async_audit_recording_steps.py: fixed Settings(audit_async=False) via env var - coverage_threshold_config_steps.py: added --coverage-min pattern support - m5_acms_smoke_steps.py: updated usage hint text - actor_cli_yaml_steps.py: updated 'Removed actor' → 'Actor removed' - aimodelscredentials_steps.py: set context.imported_class in import step - domain_base_model.feature: added missing 'When I examine model_config' step - tui_first_run_steps.py: fixed module reload to restore cleveragents.tui.* modules after test (prevented patch interference in subsequent tests) - tui_first_run_steps.py: added set_search('') step for empty string - resource_handler_base_coverage_r3_steps.py: use _MinimalHandler instead of DatabaseResourceHandler for NotImplementedError tests - resource_handler_crud.feature: updated to test new DatabaseHandler behavior - resource_handler_sandbox.feature: updated to test new DatabaseHandler behavior - tdd_json_decode_crash_persistence.feature: fixed @tdd_bug → @tdd_issue tags 8. Parallel test interference: - All step files using use_step_matcher('re') now reset to 'parse' at end to prevent global matcher state leaking to subsequent step files
57 lines
3.1 KiB
Gherkin
57 lines
3.1 KiB
Gherkin
Feature: Session CLI uncovered branches
|
|
As a developer
|
|
I want full branch coverage for session CLI commands
|
|
So that edge cases are tested
|
|
|
|
Scenario: session cli branch - _get_session_service constructs service when _service is None
|
|
Given session cli branch the module-level _service is None
|
|
When session cli branch I call _get_session_service with mocked container
|
|
Then session cli branch a PersistentSessionService is returned
|
|
|
|
Scenario: session cli branch - _reset_session_service sets _service to None
|
|
Given session cli branch the module-level _service holds a mock
|
|
When session cli branch I call _reset_session_service
|
|
Then session cli branch the module-level _service is None again
|
|
|
|
Scenario: session cli branch - create command catches SessionNotFoundError
|
|
Given session cli branch a mock session service that raises SessionNotFoundError on create
|
|
When session cli branch I invoke the create command
|
|
Then session cli branch the exit code is 1
|
|
And session cli branch the output contains "Error:"
|
|
|
|
Scenario: session cli branch - show command with no messages
|
|
Given session cli branch a mock session service returning a session with no messages
|
|
When session cli branch I invoke the show command for that session
|
|
Then session cli branch the exit code is 0
|
|
And session cli branch the output contains "Session Summary"
|
|
And session cli branch the output does not contain "Recent Messages"
|
|
|
|
Scenario: session cli branch - show command with linked plan ids
|
|
Given session cli branch a mock session service returning a session with linked plans
|
|
When session cli branch I invoke the show command for the linked-plans session
|
|
Then session cli branch the exit code is 0
|
|
And session cli branch the output contains "Linked Plans"
|
|
|
|
Scenario: session cli branch - show command with long message content truncated
|
|
Given session cli branch a mock session service returning a session with a long message
|
|
When session cli branch I invoke the show command for the long-message session
|
|
Then session cli branch the exit code is 0
|
|
And session cli branch the output contains "Recent Messages"
|
|
|
|
Scenario: session cli branch - delete command aborted via confirmation prompt
|
|
Given session cli branch a mock session service for delete
|
|
When session cli branch I invoke the delete command without --yes and answer no
|
|
Then session cli branch the delete is aborted
|
|
|
|
Scenario: session cli branch - export command catches SessionExportError
|
|
Given session cli branch a mock session service that raises SessionExportError on export
|
|
When session cli branch I invoke the export command
|
|
Then session cli branch the export exit code is 1
|
|
And session cli branch the export output contains "Export error:"
|
|
|
|
Scenario: session cli branch - tell command with stream=True
|
|
Given session cli branch a mock session service for tell
|
|
When session cli branch I invoke the tell command with --stream
|
|
Then session cli branch the exit code is 0
|
|
And session cli branch the streamed output contains the assistant response
|