forked from cleveragents/cleveragents-core
82 lines
3.7 KiB
Gherkin
82 lines
3.7 KiB
Gherkin
Feature: Review playbook documentation validation
|
|
As a developer
|
|
I want to ensure the review playbook exists and contains required sections
|
|
So that code reviews follow a consistent and thorough process
|
|
|
|
Scenario: Review playbook file exists
|
|
Given the review playbook file at "docs/development/review_playbook.md"
|
|
Then the review playbook file should exist
|
|
|
|
Scenario: Review playbook contains priority matrix
|
|
Given the review playbook file at "docs/development/review_playbook.md"
|
|
When I read the review playbook content
|
|
Then the playbook should contain the section "Priority Matrix"
|
|
|
|
Scenario: Review playbook contains routing table
|
|
Given the review playbook file at "docs/development/review_playbook.md"
|
|
When I read the review playbook content
|
|
Then the playbook should contain the section "PR Review Routing Table"
|
|
|
|
Scenario: Review playbook contains focus areas
|
|
Given the review playbook file at "docs/development/review_playbook.md"
|
|
When I read the review playbook content
|
|
Then the playbook should contain the section "Focus Areas and Skip Rules"
|
|
|
|
Scenario: Review playbook contains review SLA guidance
|
|
Given the review playbook file at "docs/development/review_playbook.md"
|
|
When I read the review playbook content
|
|
Then the playbook should contain the section "Review SLA Guidance"
|
|
|
|
Scenario: Review playbook contains architecture checklist
|
|
Given the review playbook file at "docs/development/review_playbook.md"
|
|
When I read the review playbook content
|
|
Then the playbook should contain the section "Architecture Review Checklist"
|
|
|
|
Scenario: Review playbook contains CLI checklist
|
|
Given the review playbook file at "docs/development/review_playbook.md"
|
|
When I read the review playbook content
|
|
Then the playbook should contain the section "CLI Review Checklist"
|
|
|
|
Scenario: Review playbook contains DB migration checklist
|
|
Given the review playbook file at "docs/development/review_playbook.md"
|
|
When I read the review playbook content
|
|
Then the playbook should contain the section "DB Migration Review Checklist"
|
|
|
|
Scenario: Review playbook contains security checklists
|
|
Given the review playbook file at "docs/development/review_playbook.md"
|
|
When I read the review playbook content
|
|
Then the playbook should contain the section "Security-Sensitive Change Checklists"
|
|
|
|
Scenario: Review playbook contains test matrix
|
|
Given the review playbook file at "docs/development/review_playbook.md"
|
|
When I read the review playbook content
|
|
Then the playbook should contain the section "Required Test Matrix for Reviewers"
|
|
|
|
Scenario: Review playbook contains acceptable vs blocking examples
|
|
Given the review playbook file at "docs/development/review_playbook.md"
|
|
When I read the review playbook content
|
|
Then the playbook should contain the section "Acceptable vs Blocking Findings"
|
|
|
|
Scenario: Review playbook references required nox sessions
|
|
Given the review playbook file at "docs/development/review_playbook.md"
|
|
When I read the review playbook content
|
|
Then the playbook should reference these nox sessions:
|
|
| session |
|
|
| lint |
|
|
| typecheck |
|
|
| unit_tests |
|
|
| integration_tests |
|
|
| coverage_report |
|
|
| security_scan |
|
|
| dead_code |
|
|
| complexity |
|
|
| benchmark |
|
|
|
|
Scenario: Review playbook defines all severity levels
|
|
Given the review playbook file at "docs/development/review_playbook.md"
|
|
When I read the review playbook content
|
|
Then the playbook should contain the text "P0"
|
|
And the playbook should contain the text "P1"
|
|
And the playbook should contain the text "P2"
|
|
And the playbook should contain the text "P3"
|