Commit Graph

151 Commits

Author SHA1 Message Date
CoreRasurae f528d6c3a8 feat(domain): align plan model with spec
Step A2.beta
2026-02-13 20:34:57 +00:00
freemo 9b30421b34 feat(db): add spec-aligned action and plan tables with migrations, ORM models, and benchmarks 2026-02-13 13:05:20 -05:00
freemo fd6d41b371 feat(domain): align action model with spec 2026-02-13 09:41:28 -05:00
freemo a9d3672e8a docs: updated imp plan, improved format 2026-02-13 01:41:12 -05:00
brent.edwards 5da6de97ac Merge branch 'master' into feature/q0-min-ci 2026-02-13 04:46:07 +00:00
brent.edwards da3d0dfd06 chore(ci): re-enable pabot, add discovery resource stub
- Restore pabot-based integration_tests with conservative parallelism
  (<=2 processes by default) and support PABOT_PROCESSES/--processes
- Remove the temporary CI debug dump from noxfile.py
- Add robot/discovery_common.resource to silence non-fatal warning
- Document the change in implementation_plan.md
2026-02-13 04:32:45 +00:00
brent.edwards 6ffba3e2ba fix(ci): guard scientific_paper_basic cleanup when OpenAI key missing
- Avoid deleting the workspace when OPENAI_API_KEY is unset
  by guarding cleanup and initializing CONTEXT_DIR
- Prevents downstream Robot suites from losing .nox venv and
  resource files after the basic scientific paper suite is skipped
2026-02-13 04:15:14 +00:00
freemo 36b4ec2b8d feat(domain): align plan model with spec 2026-02-12 22:58:15 -05:00
brent.edwards 51a6e76e9e fix(ci): merge duplicate Settings blocks, inject venv Python, add CI debug
Three fixes targeting CI integration_tests failures (18 failures on e8aa5ac):

1. Merge duplicate *** Settings *** blocks in 14 robot files into single
   blocks. Multiple Settings sections are non-standard RF practice and
   may cause resource import failures in certain Robot Framework versions
   or CI environments.

2. Replace bare 'python' with ${PYTHON} variable in all Run Process
   calls (14 files). Noxfile now passes --variable PYTHON:<venv-path>
   to robot so tests use the venv interpreter regardless of PATH. This
   fixes '/usr/local/bin/python: No module named cleveragents' on CI.

3. Add comprehensive CI debug output in noxfile.py: file existence
   checks for .resource files, PATH/Python resolution, fixture dir
   checks, and RF version. This will diagnose any remaining resource
   import issues.

Also: remove hardcoded '/app/src' sys.path.insert in
system_prompt_template_rendering.robot (not portable to CI), and
add trailing newline to common.resource.

All 204 tests pass locally (4 excluded: 2 slow, 2 discovery).
2026-02-13 03:43:44 +00:00
brent.edwards e8aa5ac268 fix(ci): restore venv PATH, use absolute resource paths, and add timeouts in robot tests
- Restore session.env["PATH"] in integration_tests nox session to ensure
  Run Process uses venv Python instead of system Python
- Convert bare Resource references to ${CURDIR}/ absolute paths across
  30 robot files to fix CI resolution failures
- Add timeout=30s to all Run Process calls in rxpy_route_validation.robot
  to prevent hanging tests
- Tag 2 rxpy tests as slow (require running actors unavailable on CI)
- Fix LangGraph test to use correct config file (LANGGRAPH_CONFIG)
- All 204 tests pass (4 excluded: 2 slow + 2 discovery)
2026-02-13 02:42:57 +00:00
brent.edwards 0059050836 fix(ci): replace pabot with robot for reliable CI execution
- integration_tests: replace pabot with sequential robot execution to
  eliminate FileNotFoundError caused by subprocess/FD exhaustion in
  constrained CI containers (pabot spawns a robot subprocess per suite;
  after ~24 suites the container cannot execve new processes)

- integration_tests: add resource debug output (open FD count, ulimit
  values) to help diagnose future CI container issues

- integration_tests: remove _pabot_parallel_args (no longer needed);
  slow_integration_tests session still available for parallel runs

- load_context_test: add env:TERM=dumb alongside NO_COLOR=1 to disable
  all Rich terminal styling (NO_COLOR only disables color, not bold/
  reset ANSI codes that may split substrings)

- load_context_test: add repr() debug logging around the --load-context
  match to reveal any invisible characters on CI
2026-02-13 01:37:32 +00:00
brent.edwards 25e6f95eb9 fix(ci): resolve security_scan and integration_tests CI failures
- security_scan: create build/ directory before bandit writes its JSON
  report (fails on fresh CI checkout where directory does not exist)

- integration_tests: cap pabot parallelism to 2 processes and explicitly
  propagate venv bin/ to PATH, preventing FileNotFoundError for the
  robot binary under CI resource constraints

- integration_tests: add env:NO_COLOR=1 to load_context_test.robot help
  text assertions so Rich ANSI escape codes do not break substring
  matching on CI

- integration_tests: tag initial_next_command_test as slow (requires
  OPENAI_API_KEY for LLM agent invocation, unavailable on CI)
2026-02-13 01:04:22 +00:00
brent.edwards 321ab18a37 fix(ci): resolve unit_tests and integration_tests CI failures
- Fix Rich Console line-wrapping breaking assertions in
  context_unit_tests_steps.py: collapse newlines before checking for
  filenames and overflow summaries (CI temp paths exceed 80 columns)
- Fix features.mocks import failure in database_integration.robot:
  replace hardcoded sys.path '/app' with portable ${CURDIR}/..
- Fix --load-context help text assertions in load_context_test.robot:
  merge stderr into stdout via stderr=STDOUT and remove duplicate test
- Add standalone dead_code nox session running vulture directly
- Rename security nox session to security_scan to match CI references
- Restore --exclude discovery to integration_tests nox session (lost
  during merge conflict resolution)
2026-02-13 00:15:58 +00:00
brent.edwards 3e3530de48 ci(git-merge): Merging from master 2026-02-12 23:01:35 +00:00
brent.edwards e5b1b04ec6 test(integration_tests-3.13): fix nox tests
`integration_tests-3.13` was failing; it is now passing.
2026-02-12 22:48:19 +00:00
CoreRasurae 3adc9c1f47 chore: Fix conflicts in the implementation plan 2026-02-12 22:17:32 +00:00
brent.edwards e801eb1ee8 feat(ci): add nox-based PR validation workflow
- Rewrite .forgejo/workflows/ci.yml to route all jobs through nox sessions
- Fix coverage_report nox session: serial behave mode replaces broken parallel
  mode (22% -> 97% accuracy), raise fail-under from 85% to 97%
- Pass posargs through format nox session for CI --check support
- Add 11 CI workflow validation scenarios (Behave) + Robot smoke test + ASV bench
- Add 108 new Behave scenarios covering 6 largest coverage gaps to reach 97%:
  yaml_template_engine, actor/config, actor/registry, message_router,
  context_analysis, context_service
- Update docs/development/ci-cd.md with nox-based CI docs and 97% threshold
- Restore implementation_plan.md verbose style, check off completed CI tasks

Verified: 1673 scenarios pass, 97% coverage, lint clean, typecheck clean
2026-02-12 22:01:51 +00:00
CoreRasurae f2f7aa5dc9 feat(core): add v3 lifecycle models, automation levels, subplan support, and security hardening
Implement multiple Stage A/B/E/SEC milestones for the v3 lifecycle system:
- Stage A5.3+A5.4: Add LifecycleActionModel and LifecyclePlanModel SQLAlchemy
  models with to_domain()/from_domain() conversion methods
- Stage A5.6: Implement ActionRepository with full CRUD, namespace/state
  queries, referential integrity checks, and retry decorator
- Stage E1: Add subplan domain models (ExecutionMode, SubplanMergeStrategy,
  SubplanConfig, SubplanStatus, SubplanAttempt, SubplanFailureHandler) with
  computed properties on Plan (is_subplan, is_root_plan, depth, has_subplans)
- Stage A6: Add AutomationLevel enum (MANUAL, REVIEW_BEFORE_APPLY,
  FULL_AUTOMATION), settings integration, PlanLifecycleService auto-progression,
  pause/resume, and CLI commands (--automation-level, set-automation-level)
- Stage SEC1: Remove eval()/exec() from stream_router.py, replace with named
  operation and transform registries; code blocks and unregistered transforms
  now raise StreamRoutingError
- Add langchain-anthropic dependency
- Update BDD tests for security changes and relax ADR directory requirement
2026-02-12 20:19:42 +00:00
freemo a1c1540a00 Docs: updated plan 2026-02-12 15:01:51 -05:00
freemo 578bfbf102 Docs: updated implementation plan to remove discrepencies between it and the specification 2026-02-12 13:24:44 -05:00
freemo 31fd332c7b Docs: Updated implementation plan to eliminate indescrepencies with specification 2026-02-12 13:11:38 -05:00
freemo dc2fa53942 Docs: Updated the implementation plan, included more schedule adherance data as well 2026-02-12 13:08:01 -05:00
brent.edwards 04070ca3ff Merge branch 'master' into Q0-quality-automation
# Conflicts:
#	implementation_plan.md
2026-02-12 06:05:43 +00:00
freemo 2bceddeed3 Docs: revampted implementation plan again 2026-02-11 23:24:18 -05:00
freemo 395ae04539 Docs: updated the implementation plan again 2026-02-11 21:04:11 -05:00
freemo 736da7799c Docs: Updated implementation plan with new plan plus added asv requirements to commits 2026-02-11 20:30:59 -05:00
freemo 43b8e985f0 Docs: Explicitly added ASV to implementation rules 2026-02-11 13:07:51 -05:00
freemo f9d7b778a4 Docs: Updated implementation plan with the new specification 2026-02-11 10:16:47 -05:00
brent.edwards 7caac2714e refactor: changes requested by Rui
Removed `run-semgrep.sh` and automatically run setup-dev.sh
2026-02-11 00:59:58 +00:00
brent.edwards 395df78b94 test(qa): add validation fixtures, edge-case scenarios, and quality baseline
Complete Brent QA tasks Q1.5, 10B.4, 10C.1, and 10C.4 on the Q0-quality-automation branch.

- Add edge_case_plan_scenarios.feature (26 scenarios) covering concurrent
  plan execution, resource conflicts, validation failure chains, and
  rollback edge cases
- Add validation_test_fixtures.feature (34 scenarios) covering AST
  security, lambda validation, content sanitization, project model
  validation, change-list coercion, and ActionArgument parsing
- Add branch protection rules documentation in docs/development/ci-cd.md
- Establish quality metrics baseline (96% coverage, 0 lint/type/security
  findings)
- Fix missing langchain-anthropic dependency in pyproject.toml
- Fix Rich table column wrapping in plan_lifecycle_cli_steps.py by
  patching console width during tests

Suite: 107 features, 1673 scenarios, 7777 steps — all passing.
2026-02-10 22:19:21 +00:00
brent.edwards 7ef5ebb695 feat: Add Q0: Pre-commit hooks setup.
This should automatically check for problems on build.
2026-02-10 16:04:17 +00:00
freemo 684996eea9 Docs: moved specification over to the MkDocs for better rendering 2026-02-08 14:33:43 -05:00
freemo b679fdaf33 Docs: Added extensive CLI details and usage examples 2026-02-08 14:23:10 -05:00
freemo d9b5491efc docs: updated brents timeline so he focuses on automated testing the first 3 days 2026-02-06 17:40:16 -05:00
freemo 2b4eb845bc docs: clarified the fact that the server will not be the same executable 2026-02-06 16:43:01 -05:00
freemo 4e5144e225 docs: no longer reference plandex 2026-02-06 15:49:50 -05:00
freemo 78c273a747 docs: improved contention plan for tasks 2026-02-06 15:42:20 -05:00
freemo 81170778ea docs: Further refinement of timeline and tasks 2026-02-06 15:24:44 -05:00
freemo 4c9ad5faf5 docs: highly expanded the implementation checklist and better defined duties 2026-02-06 14:31:55 -05:00
freemo e360734c2e docs: Added some overview information to implementation plan 2026-02-06 13:42:35 -05:00
freemo 426db31557 docs: Added significant details and finalized (hopefully) task assignments 2026-02-06 12:45:48 -05:00
freemo f6035c9e15 Cleaned up and improved the specification and plan slightly 2026-02-06 09:53:49 -05:00
freemo 61cd406fbf feat: implemented new plan CLI commands 2026-02-05 10:33:02 -05:00
freemo e7b48d5066 docs: Also improved description in implementation plan 2026-02-05 09:16:48 -05:00
freemo b7c3152855 docs: Removed plandex directory and added implementation plan for new architecture 2026-02-05 00:29:05 -05:00
freemo 805140ce37 Merge branch 'master' into run-imp 2026-02-04 17:51:57 -05:00
freemo 3cf6a812ae feat: ported in run behavior as a subcommand of actor 2026-02-04 14:43:08 -05:00
freemo 12b91cef5e Finished port of v2 into actors, phase 7.5 complete 2026-02-02 18:46:33 -05:00
freemo fb0a34dd9a chore(tests): expand YAML/Jinja port coverage and log plan status 2026-01-24 12:06:18 -05:00
freemo 4a1183108a test: add actor-first v2 CLI/Jinja port feature 2026-01-24 10:15:16 -05:00