From daefb63e5367278b9daa60e7d8926080f5af4345 Mon Sep 17 00:00:00 2001 From: Aditya Chhabra Date: Fri, 13 Mar 2026 14:44:42 +0530 Subject: [PATCH] docs: annotate comparative review with implementation responses MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Add [RESPONSE] annotations to each finding in the comparative review: - Findings A, B, C, E: acknowledged as valid with action items - Finding D (binary apply): noted as low priority / theoretical - Finding F (simulation artifacts): corrected — reviewer checked raw LLM outputs (sim*-/generated.py) instead of extracted files (sim*/todo.py etc.) which all pass py_compile Also fix CommittingSessionService._commit() to log exceptions instead of silently swallowing them (valid Finding E). --- src/cleveragents/application/services/session_service.py | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/cleveragents/application/services/session_service.py b/src/cleveragents/application/services/session_service.py index bf4534e3..22602127 100644 --- a/src/cleveragents/application/services/session_service.py +++ b/src/cleveragents/application/services/session_service.py @@ -328,7 +328,11 @@ class CommittingSessionService(PersistentSessionService): sa_session = self._sa_factory() sa_session.commit() except Exception: - pass + import structlog + + structlog.get_logger(__name__).warning( + "session commit failed", exc_info=True + ) def create(self, actor_name: str | None = None) -> Session: result = super().create(actor_name)