clevermicro/user-management
14
0
Fork 0
Code Issues 6 Pull Requests Actions Packages Projects Releases Wiki Activity

Feat#1 creating auth-service, with JUnit test #14

Merged
stanislav.hejny merged 2 commits from Create-Auth-Microservice#1 into develop 2025-05-07 08:38:06 +00:00
Conversation 3 Commits 2 Files Changed 16
+840
abed.alrahman commented 2025-05-05 00:44:08 +00:00
Member
Copy Link
Copy Source

I included the JUnit test class with this version since I already completed it before making the ticket for the test.

I included the JUnit test class with this version since I already completed it before making the ticket for the test.
hurui200320 was assigned by abed.alrahman 2025-05-05 00:44:08 +00:00
stanislav.hejny was assigned by abed.alrahman 2025-05-05 00:44:08 +00:00
abed.alrahman added 1 commit 2025-05-05 00:44:09 +00:00
Feat#1 creating auth-service, with JUnit test 0a16092b3d
stanislav.hejny requested changes 2025-05-05 10:23:45 +00:00
Dismissed
src/main/java/com/cleverthis/authservice/controller/AuthController.java Outdated
@@ -0,0 +64,4 @@
public Mono<ResponseEntity<VerificationResponse>> verify(@RequestHeader(HttpHeaders.AUTHORIZATION) String authorizationHeader) {
log.info("Received token verification request");
if (authorizationHeader == null || !authorizationHeader.startsWith("Bearer ")) {
log.warn("Verification request missing or invalid Bearer token format.");
stanislav.hejny commented 2025-05-05 10:14:11 +00:00
Member
Copy Link
Copy Source

Please add the actual token string to the log message, this will help greatly with debugging (and invalid token leaks no security info)

Please add the actual token string to the log message, this will help greatly with debugging (and invalid token leaks no security info)
abed.alrahman commented 2025-05-06 23:26:32 +00:00
Author
Member
Copy Link
Copy Source

Added

Added
stanislav.hejny marked this conversation as resolved
src/main/java/com/cleverthis/authservice/exception/GlobalExceptionHandler.java Outdated
@@ -0,0 +57,4 @@
@ExceptionHandler(Exception.class)
public ProblemDetail handleGenericException(Exception ex) {
logger.error("An unexpected error occurred: ", ex); // Log the full stack trace
ProblemDetail problemDetail = ProblemDetail.forStatusAndDetail(HttpStatus.INTERNAL_SERVER_ERROR, "An unexpected internal error occurred.");
stanislav.hejny commented 2025-05-05 10:22:08 +00:00
Member
Copy Link
Copy Source

please remove the word 'unexpected' from the message, it gives kind of bad impression when the software reports something 'unexpected', it feels like we made insufficient design and there are things we did not think of.
String "An internal error occurred." will be just fine.

please remove the word 'unexpected' from the message, it gives kind of bad impression when the software reports something 'unexpected', it feels like we made insufficient design and there are things we did not think of. String "An internal error occurred." will be just fine.
abed.alrahman commented 2025-05-06 23:25:55 +00:00
Author
Member
Copy Link
Copy Source

Yes, you are right, I changed it.
Check style used two, sorry, I forgot that I changed my IDE :)

Yes, you are right, I changed it. Check style used two, sorry, I forgot that I changed my IDE :)
stanislav.hejny marked this conversation as resolved
stanislav.hejny commented 2025-05-05 10:30:20 +00:00
Member
Copy Link
Copy Source

Hi Abed,
may I kindly ask to review the parts with commented out code, generally we do not want to keep commented out logic in the source code, unless it refers to future features that are yet to be implemented and that would break the code if present before full implementation, and in this case, please mention this fact in the commented out code itself.

Also, i believe there's a checkstyle rule that says the line of code should not be longer than 100 chars. i know it is bit limiting if you have wide big monitor, but can you perhaps edit your IDE settings to indicate the 100 chars limit and try to fit the Java code line length within that 100chars, where feasible?

Hi Abed, may I kindly ask to review the parts with commented out code, generally we do not want to keep commented out logic in the source code, unless it refers to future features that are yet to be implemented and that would break the code if present before full implementation, and in this case, please mention this fact in the commented out code itself. Also, i believe there's a checkstyle rule that says the line of code should not be longer than 100 chars. i know it is bit limiting if you have wide big monitor, but can you perhaps edit your IDE settings to indicate the 100 chars limit and try to fit the Java code line length within that 100chars, where feasible?
abed.alrahman added 1 commit 2025-05-06 23:23:21 +00:00
Applying check style, and changing the log messages 668bd05e5a
abed.alrahman requested review from stanislav.hejny 2025-05-06 23:23:42 +00:00
stanislav.hejny approved these changes 2025-05-07 08:37:20 +00:00
stanislav.hejny merged commit ac85ff58af into develop 2025-05-07 08:38:06 +00:00
hurui200320 deleted branch Create-Auth-Microservice#1 2025-05-19 05:35:43 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
stanislav.hejny
Labels
Clear labels
Blocked
A ticket in a blocked state and unable to complete until some other task is completed first.
Bounty
$100
A bounty of $100 for any open-source contributor who provides a MR that solves this issue
Bounty
$1000
A bounty of $1000 for any open-source contributor who provides a MR that solves this issue
Bounty
$10000
A bounty of $10000 for any open-source contributor who provides a MR that solves this issue
Bounty
$20
A bounty of $20 for any open-source contributor who provides a MR that solves this issue
Bounty
$2000
A bounty of $2000 for any open-source contributor who provides a MR that solves this issue
Bounty
$250
A bounty of $250 for any open-source contributor who provides a MR that solves this issue
Bounty
$50
A bounty of $50 for any open-source contributor who provides a MR that solves this issue
Bounty
$500
A bounty of $500 for any open-source contributor who provides a MR that solves this issue
Bounty
$5000
A bounty of $5000 for any open-source contributor who provides a MR that solves this issue
Bounty
$750
A bounty of $750 for any open-source contributor who provides a MR that solves this issue
MoSCoW
Could have
Could have feature in order to satisfy the epic/legendary.
MoSCoW
Must have
Must have feature in order to satisfy the epic/legendary.
MoSCoW
Should have
Should have feature in order to satisfy the epic/legendary.
Needs feedback
There are questions in the ticket that can not be completed until the project owner provides clarity.
Points
1
1 man-hours worth of work for an expert with no learning curve.
Points
13
13 man-hours worth of work for an expert with no learning curve.
Points
2
2 man-hours worth of work for an expert with no learning curve.
Points
21
21 man-hours worth of work for an expert with no learning curve.
Points
3
3 man-hours worth of work for an expert with no learning curve.
Points
34
34 man-hours worth of work for an expert with no learning curve.
Points
5
5 man-hours worth of work for an expert with no learning curve.
Points
55
55 man-hours worth of work for an expert with no learning curve.
Points
8
8 man-hours worth of work for an expert with no learning curve.
Points
88
88 man-hours worth of work for an expert with no learning curve.
Priority
Backlog
This ticket has backlogged priority and is not to be worked on yet
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Signed-off: Owner
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.
 Signed-off: Scrum Master
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.
 Signed-off: Tech Lead
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.
 Spike
A ticket for learning a tool or technology that is needed to be able to do future planning and design.
State
Completed
The ticket has been fully implemented, completed, and merged with the source code. This label should only be applied once a ticket is closed.
State
Duplicate
A ticket that represents the same content as an existing ticket.
State
In Progress
A ticket that is actively being developed.
State
In Review
A ticket that has had some code completed to implement but is waiting to pass peer review and is not yet merged in.
State
Paused
This ticket's work started but wasn't finished. It's on hold (likely in a feature branch) and will be resumed later, either due to a blocker or a delay.
State
Unverified
All new tickets start in this state. A developer may set it to show the ticket is unverified. This means we haven't agreed to work on it. It will either move to a verified state or be closed as wontdo.
State
Verified
The issue has been verified by a developer as legitimate. It will be worked on and verified tickets are now considered part of the backlog.
State
Wont Do
This ticket has been decided it wont be done. This may mean the bug has been determined to not be real (cant verify) or the feature is one we have decided we dont want to adopt.
Type
Bug
Something that doesnt work as intended.
Type
Discussion
Anytime a ticket represents a discussion about a subject and doesnt fall into one of the other categories.
Type
Documentation
An error or improvement needed in the documentation.
Type
Epic
Any first tier epic. That is, an epic which contains only issues as children and will not have sub-epics.
Type
Feature
Some new functionality not present.
Type
Legendary
A type of Epic which will contain other Epics.
Type
Support
Someone needs help using the project.
Type
Task
A generic task that doesnt fit into the other type categories.
Type
Testing
Work exclusively focusing on fixing or expanding testing.
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
aleenaumair (Aleena Umair) argocd CoreRasurae (Luis Mendes) drew (Drew Morris) eugen.thaci (Eugen Thaci) freemo (Jeffrey Phillips Freeman) hurui200320 (Rui Hu) justin.morris mngrif (Michael Griffith) org.clevermicro (System User) org.cleverswarm (System User) org.inf-cd salcedo (Brian Salcedo) stanislav.hejny (Stanislav Hejny)
No Assignees hurui200320 stanislav.hejny
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: clevermicro/user-management#14
Delete Branch "Create-Auth-Microservice#1"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?