Files
placeholder/features/steps/cli_lifecycle_robot_alignment_steps.py
freemo 48cff5cfe0 refactor(cli): rename plan lifecycle-list and lifecycle-apply to match specification
Renames `plan lifecycle-list` to `plan list` and `plan lifecycle-apply` to `plan apply` to align with the specification's canonical command names. Removes legacy V2 plan commands that occupied those names.

- Renamed CLI command registrations from lifecycle-list/lifecycle-apply to list/apply
- Removed legacy V2 apply and list commands (~200 lines)
- Updated apply shortcut in main.py to delegate to v3 lifecycle
- Added defensive null check for plan existence in apply command
- Updated 63+ test, doc, and benchmark files for consistency

Closes #881

Co-authored-by: Jeffrey Phillips Freeman <the@jeffreyfreeman.me>
Co-committed-by: Jeffrey Phillips Freeman <the@jeffreyfreeman.me>
2026-04-02 19:09:04 +00:00

327 lines
12 KiB
Python

"""Step definitions for CLI lifecycle Robot alignment feature.
Mirrors the Robot E2E lifecycle flow (action -> plan -> execute -> apply)
in Behave to keep unit and integration test expectations aligned.
All step names are prefixed with ``robot alignment`` to avoid
``AmbiguousStep`` conflicts with existing steps.
"""
from __future__ import annotations
import os
import tempfile
from datetime import datetime
from unittest.mock import MagicMock, patch
from behave import given, then, when
from behave.runner import Context
from typer.testing import CliRunner
from cleveragents.cli.commands.action import app as action_app
from cleveragents.cli.commands.plan import app as plan_app
from cleveragents.core.exceptions import NotFoundError
from cleveragents.domain.models.core.action import Action, ActionState
from cleveragents.domain.models.core.change import (
ChangeEntry,
ChangeOperation,
InMemoryChangeSetStore,
)
from cleveragents.domain.models.core.plan import (
AutomationProfileProvenance,
AutomationProfileRef,
NamespacedName,
Plan,
PlanIdentity,
PlanPhase,
PlanTimestamps,
ProcessingState,
ProjectLink,
)
_PLAN_ULID = "01KHDE6WWS2171PWW3GJEBXZ8T"
_VALID_YAML = """\
name: local/lifecycle-action
description: Lifecycle test action
strategy_actor: openai/gpt-4
execution_actor: openai/gpt-4
definition_of_done: All lifecycle tests pass
"""
def _mock_action(name: str = "local/lifecycle-action") -> Action:
"""Create a minimal valid Action for alignment tests."""
return Action(
namespaced_name=NamespacedName.parse(name),
description="Lifecycle test action",
long_description=None,
definition_of_done="All lifecycle tests pass",
strategy_actor="openai/gpt-4",
execution_actor="openai/gpt-4",
state=ActionState.AVAILABLE,
reusable=True,
read_only=False,
created_at=datetime.now(),
updated_at=datetime.now(),
created_by=None,
)
def _mock_plan(
phase: PlanPhase = PlanPhase.STRATEGIZE,
state: ProcessingState = ProcessingState.QUEUED,
) -> Plan:
"""Create a minimal valid Plan for alignment tests."""
now = datetime.now()
return Plan(
identity=PlanIdentity(plan_id=_PLAN_ULID),
namespaced_name=NamespacedName.parse("local/lifecycle-plan"),
description="Lifecycle test plan",
definition_of_done="Tests pass",
action_name="local/lifecycle-action",
phase=phase,
processing_state=state,
project_links=[ProjectLink(project_name="proj-a")],
arguments={"target_coverage": 80},
arguments_order=["target_coverage"],
automation_profile=AutomationProfileRef(
profile_name="trusted",
provenance=AutomationProfileProvenance.PLAN,
),
strategy_actor="openai/gpt-4",
execution_actor="openai/gpt-4",
reusable=True,
read_only=False,
created_by=None,
timestamps=PlanTimestamps(created_at=now, updated_at=now),
)
# ---------------------------------------------------------------------------
# Background
# ---------------------------------------------------------------------------
@given("a robot alignment CLI runner")
def step_robot_alignment_runner(context: Context) -> None:
"""Set up the CLI runner."""
context.ra_runner = CliRunner()
@given("a robot alignment mocked lifecycle service")
def step_robot_alignment_service(context: Context) -> None:
"""Set up a mock PlanLifecycleService for the plan CLI."""
context.ra_mock_service = MagicMock()
context.ra_action_patcher = patch(
"cleveragents.cli.commands.action._get_lifecycle_service",
return_value=context.ra_mock_service,
)
context.ra_plan_patcher = patch(
"cleveragents.cli.commands.plan._get_lifecycle_service",
return_value=context.ra_mock_service,
)
context.ra_executor_patcher = patch(
"cleveragents.cli.commands.plan._get_plan_executor",
return_value=MagicMock(),
)
context.ra_action_patcher.start()
context.ra_plan_patcher.start()
context.ra_executor_patcher.start()
# Set up changeset store for tracking
context.ra_changeset_store = InMemoryChangeSetStore()
context.ra_changeset_id = context.ra_changeset_store.start(_PLAN_ULID)
if not hasattr(context, "_cleanup_handlers"):
context._cleanup_handlers = []
context._cleanup_handlers.append(context.ra_action_patcher.stop)
context._cleanup_handlers.append(context.ra_plan_patcher.stop)
context._cleanup_handlers.append(context.ra_executor_patcher.stop)
# ---------------------------------------------------------------------------
# Given steps
# ---------------------------------------------------------------------------
@given('a robot alignment action "{name}" is created via config')
def step_robot_alignment_action_create(context: Context, name: str) -> None:
"""Create action via CLI config and configure mocks."""
action = _mock_action(name)
context.ra_mock_service.create_action.return_value = action
context.ra_mock_service.get_action_by_name.return_value = action
context.ra_mock_service.use_action.return_value = _mock_plan()
context.ra_mock_service.get_plan.return_value = _mock_plan(
phase=PlanPhase.STRATEGIZE, state=ProcessingState.COMPLETE
)
context.ra_mock_service.execute_plan.return_value = _mock_plan(
phase=PlanPhase.EXECUTE, state=ProcessingState.QUEUED
)
context.ra_mock_service.apply_plan.return_value = _mock_plan(
phase=PlanPhase.APPLY, state=ProcessingState.QUEUED
)
fd, yaml_path = tempfile.mkstemp(suffix=".yaml")
with os.fdopen(fd, "w") as fh:
fh.write(_VALID_YAML)
context.ra_yaml_path = yaml_path
result = context.ra_runner.invoke(action_app, ["create", "--config", yaml_path])
context.ra_action_result = result
os.unlink(yaml_path)
assert result.exit_code == 0, (
f"action create failed ({result.exit_code}): {result.output}"
)
@given('a robot alignment action "{name}" exists')
def step_robot_alignment_action_exists(context: Context, name: str) -> None:
"""Set up an existing action mock."""
context.ra_mock_service.get_action_by_name.return_value = _mock_action(name)
context.ra_mock_service.use_action.return_value = _mock_plan()
# ---------------------------------------------------------------------------
# When steps
# ---------------------------------------------------------------------------
@when('I run robot alignment plan use "{action}" on project "{project}"')
def step_robot_alignment_plan_use(context: Context, action: str, project: str) -> None:
"""Run plan use."""
context.ra_use_result = context.ra_runner.invoke(plan_app, ["use", action, project])
@when("I run robot alignment plan execute for the plan")
def step_robot_alignment_plan_execute(context: Context) -> None:
"""Run plan execute and record a changeset entry."""
# Record a change entry to mirror the Robot test
context.ra_changeset_store.record(
context.ra_changeset_id,
ChangeEntry(
plan_id=_PLAN_ULID,
resource_id="res-a",
tool_name="builtin/file-write",
operation=ChangeOperation.CREATE,
path="src/new_module.py",
),
)
context.ra_execute_result = context.ra_runner.invoke(
plan_app, ["execute", _PLAN_ULID]
)
@when("I run robot alignment plan apply for the plan")
def step_robot_alignment_plan_apply(context: Context) -> None:
"""Run plan apply and record an additional changeset entry."""
# Record a modify entry to bring total to 2
context.ra_changeset_store.record(
context.ra_changeset_id,
ChangeEntry(
plan_id=_PLAN_ULID,
resource_id="res-a",
tool_name="builtin/file-edit",
operation=ChangeOperation.MODIFY,
path="src/existing.py",
),
)
context.ra_apply_result = context.ra_runner.invoke(
plan_app, ["apply", "--yes", _PLAN_ULID]
)
@when('I run robot alignment plan use with invalid arg "{arg_str}"')
def step_robot_alignment_invalid_arg(context: Context, arg_str: str) -> None:
"""Run plan use with an invalid --arg format."""
context.ra_invalid_arg_result = context.ra_runner.invoke(
plan_app,
["use", "local/lifecycle-action", "proj-a", "--arg", arg_str],
)
@when('I run robot alignment plan use for nonexistent action "{action}"')
def step_robot_alignment_missing_action(context: Context, action: str) -> None:
"""Run plan use for an action that doesn't exist."""
context.ra_mock_service.get_action_by_name.side_effect = NotFoundError(
f"Action '{action}' not found"
)
context.ra_missing_result = context.ra_runner.invoke(
plan_app, ["use", action, "proj-a"]
)
# ---------------------------------------------------------------------------
# Then steps
# ---------------------------------------------------------------------------
@then("the robot alignment plan use should succeed")
def step_robot_alignment_plan_use_ok(context: Context) -> None:
"""Verify plan use succeeded."""
assert context.ra_use_result.exit_code == 0, (
f"plan use failed ({context.ra_use_result.exit_code}): "
f"{context.ra_use_result.output}"
)
@then("the robot alignment plan execute should succeed")
def step_robot_alignment_plan_execute_ok(context: Context) -> None:
"""Verify plan execute succeeded."""
assert context.ra_execute_result.exit_code == 0, (
f"plan execute failed ({context.ra_execute_result.exit_code}): "
f"{context.ra_execute_result.output}"
)
@then('the robot alignment changeset should have {count:d} entry with operation "{op}"')
def step_robot_alignment_changeset_entry(context: Context, count: int, op: str) -> None:
"""Verify changeset entries."""
cs = context.ra_changeset_store.get(context.ra_changeset_id)
assert cs is not None, "changeset not found"
assert len(cs.entries) == count, f"expected {count} entries, got {len(cs.entries)}"
assert cs.entries[0].operation == op, (
f"expected operation={op}, got {cs.entries[0].operation}"
)
@then("the robot alignment plan apply should succeed")
def step_robot_alignment_plan_apply_ok(context: Context) -> None:
"""Verify plan apply succeeded."""
assert context.ra_apply_result.exit_code == 0, (
f"plan apply failed ({context.ra_apply_result.exit_code}): "
f"{context.ra_apply_result.output}"
)
@then("the robot alignment changeset summary should have total {total:d}")
def step_robot_alignment_changeset_total(context: Context, total: int) -> None:
"""Verify changeset summary total."""
summary = context.ra_changeset_store.summarize(context.ra_changeset_id)
assert summary.get("total") == total, (
f"expected total={total}, got {summary.get('total')}"
)
@then("the robot alignment CLI should reject the invalid arg format")
def step_robot_alignment_invalid_arg_rejected(context: Context) -> None:
"""Verify the CLI rejected the invalid arg format."""
result = context.ra_invalid_arg_result
output_lower = result.output.lower()
assert (
result.exit_code != 0
or "invalid argument format" in output_lower
or "aborted" in output_lower
), f"expected rejection, got exit_code={result.exit_code}: {result.output}"
@then("the robot alignment CLI should report action not found")
def step_robot_alignment_action_not_found(context: Context) -> None:
"""Verify the CLI reported action not found."""
result = context.ra_missing_result
output_lower = result.output.lower()
assert (
result.exit_code != 0 or "not found" in output_lower or "error" in output_lower
), f"expected not-found error, got exit_code={result.exit_code}: {result.output}"