freemo
051ee7c290
CI / benchmark-publish (pull_request) Has been skipped
CI / lint (pull_request) Successful in 21s
CI / quality (pull_request) Successful in 31s
CI / typecheck (pull_request) Successful in 47s
CI / security (pull_request) Successful in 52s
CI / build (pull_request) Successful in 56s
CI / e2e_tests (pull_request) Successful in 5m1s
CI / integration_tests (pull_request) Successful in 5m30s
CI / unit_tests (pull_request) Successful in 5m42s
CI / docker (pull_request) Successful in 58s
CI / coverage (pull_request) Successful in 7m35s
CI / build (push) Successful in 21s
CI / docker (push) Has been skipped
CI / benchmark-regression (pull_request) Failing after 49m24s
CI / lint (push) Successful in 22s
CI / quality (push) Successful in 39s
CI / security (push) Successful in 48s
CI / typecheck (push) Successful in 1m26s
CI / benchmark-regression (push) Has been skipped
CI / e2e_tests (push) Successful in 5m53s
CI / coverage (push) Successful in 9m4s
CI / benchmark-publish (push) Successful in 19m10s
CI / integration_tests (push) Failing after 19m18s
CI / unit_tests (push) Failing after 19m20s
Added 52 new .feature files and corresponding _steps.py files targeting previously uncovered code paths in the following areas: - TUI layer: app, commands, persona (state/schema/registry), widgets, input (shell_exec, reference_parser) - Application services: plan lifecycle/service/executor, session, project, repo indexing, correction, checkpoint, actor, llm_actors, strategy coordinator, resource file watcher, service retry wiring - CLI commands: session, resource, repl, plan, db, automation_profile - Domain models: retry_policy, resource_type, cost_budget, docker_compose_analyzer, detail_level, _sql_string_aware, _postgresql_helpers - Core: circuit_breaker, retry_service_patterns - Infrastructure: repositories, transaction_sandbox, strategy_registry, plugins/loader, container - Config: settings - Agents: plan_generation, context_analysis, auto_debug - A2A: facade All new tests follow the Behave/Gherkin BDD standard. Resolved step definition collisions with unique prefixes. Fixed Alembic fileConfig logger disabling issue (disable_existing_loggers=False). ISSUES CLOSED: #1068
49 lines
2.6 KiB
Gherkin
49 lines
2.6 KiB
Gherkin
Feature: Plugin Loader Coverage Boost
|
|
Scenarios targeting uncovered lines in the PluginLoader class:
|
|
- Lines 203-209: entry point load failure exception handler
|
|
- Lines 242, 244-246: validate_protocol fallback to issubclass when instantiation fails
|
|
- Lines 247-248: validate_protocol issubclass raises TypeError
|
|
|
|
Background:
|
|
Given the plugin loader module is imported
|
|
|
|
# -----------------------------------------------------------------------
|
|
# Entry-point discovery: failure path (lines 203-209)
|
|
# -----------------------------------------------------------------------
|
|
|
|
Scenario: Entry point that fails to load is skipped with a warning
|
|
Given the entry points are mocked with one that raises on load
|
|
When I call load_from_entry_points
|
|
Then the plugin result should be an empty descriptor list
|
|
And the failed entry point should have been logged as a warning
|
|
|
|
# -----------------------------------------------------------------------
|
|
# validate_protocol: instantiation fails, issubclass succeeds (lines 242, 244-246)
|
|
# -----------------------------------------------------------------------
|
|
|
|
Scenario: validate_protocol falls back to issubclass when instantiation fails
|
|
Given I have a class that requires constructor arguments
|
|
And I have a runtime checkable protocol the class satisfies via issubclass
|
|
When I call validate_protocol with the non-instantiable class and protocol
|
|
Then validate_protocol should return True
|
|
|
|
# -----------------------------------------------------------------------
|
|
# validate_protocol: instantiation fails, issubclass raises TypeError (lines 247-248)
|
|
# -----------------------------------------------------------------------
|
|
|
|
Scenario: validate_protocol raises ProtocolMismatchError when issubclass raises TypeError
|
|
Given I have a class that cannot be instantiated without arguments
|
|
And I have a protocol-like object that causes issubclass to raise TypeError
|
|
When I call validate_protocol expecting a mismatch error
|
|
Then a plugin-loader ProtocolMismatchError should be raised
|
|
|
|
# -----------------------------------------------------------------------
|
|
# validate_protocol: instantiation fails, issubclass returns False
|
|
# -----------------------------------------------------------------------
|
|
|
|
Scenario: validate_protocol raises ProtocolMismatchError when issubclass returns False
|
|
Given I have a class that cannot be instantiated without arguments
|
|
And I have a runtime checkable protocol the class does not satisfy
|
|
When I call validate_protocol expecting a mismatch error
|
|
Then a plugin-loader ProtocolMismatchError should be raised
|