freemo
051ee7c290
CI / benchmark-publish (pull_request) Has been skipped
CI / lint (pull_request) Successful in 21s
CI / quality (pull_request) Successful in 31s
CI / typecheck (pull_request) Successful in 47s
CI / security (pull_request) Successful in 52s
CI / build (pull_request) Successful in 56s
CI / e2e_tests (pull_request) Successful in 5m1s
CI / integration_tests (pull_request) Successful in 5m30s
CI / unit_tests (pull_request) Successful in 5m42s
CI / docker (pull_request) Successful in 58s
CI / coverage (pull_request) Successful in 7m35s
CI / build (push) Successful in 21s
CI / docker (push) Has been skipped
CI / benchmark-regression (pull_request) Failing after 49m24s
CI / lint (push) Successful in 22s
CI / quality (push) Successful in 39s
CI / security (push) Successful in 48s
CI / typecheck (push) Successful in 1m26s
CI / benchmark-regression (push) Has been skipped
CI / e2e_tests (push) Successful in 5m53s
CI / coverage (push) Successful in 9m4s
CI / benchmark-publish (push) Successful in 19m10s
CI / integration_tests (push) Failing after 19m18s
CI / unit_tests (push) Failing after 19m20s
Added 52 new .feature files and corresponding _steps.py files targeting previously uncovered code paths in the following areas: - TUI layer: app, commands, persona (state/schema/registry), widgets, input (shell_exec, reference_parser) - Application services: plan lifecycle/service/executor, session, project, repo indexing, correction, checkpoint, actor, llm_actors, strategy coordinator, resource file watcher, service retry wiring - CLI commands: session, resource, repl, plan, db, automation_profile - Domain models: retry_policy, resource_type, cost_budget, docker_compose_analyzer, detail_level, _sql_string_aware, _postgresql_helpers - Core: circuit_breaker, retry_service_patterns - Infrastructure: repositories, transaction_sandbox, strategy_registry, plugins/loader, container - Config: settings - Agents: plan_generation, context_analysis, auto_debug - A2A: facade All new tests follow the Behave/Gherkin BDD standard. Resolved step definition collisions with unique prefixes. Fixed Alembic fileConfig logger disabling issue (disable_existing_loggers=False). ISSUES CLOSED: #1068
48 lines
2.2 KiB
Gherkin
48 lines
2.2 KiB
Gherkin
Feature: TUI Shell Exec Coverage
|
|
Scenarios that exercise previously uncovered code paths
|
|
in the tui/input/shell_exec module (lines 48-49, 52-56, 61, 77-82).
|
|
|
|
Background:
|
|
Given the shell_exec module is imported
|
|
|
|
Scenario: Empty command returns error result
|
|
When I run a shell command with an empty string
|
|
Then the shell result exit code should be 2
|
|
And the shell result stderr should be "empty command"
|
|
And the shell result stdout should be empty
|
|
|
|
Scenario: Whitespace-only command returns error result
|
|
When I run a shell command with only whitespace " "
|
|
Then the shell result exit code should be 2
|
|
And the shell result stderr should be "empty command"
|
|
|
|
Scenario: Shell mode disabled via env var set to 1
|
|
Given the environment variable CLEVERAGENTS_DISABLE_SHELL_MODE is set to "1"
|
|
When I run a shell command "echo hello"
|
|
Then the shell result exit code should be 2
|
|
And the shell result stderr should be "shell mode is disabled"
|
|
|
|
Scenario: Shell mode disabled via env var set to true
|
|
Given the environment variable CLEVERAGENTS_DISABLE_SHELL_MODE is set to "true"
|
|
When I run a shell command "echo hello"
|
|
Then the shell result exit code should be 2
|
|
And the shell result stderr should be "shell mode is disabled"
|
|
|
|
Scenario: Dangerous command confirmed via callback proceeds to execution
|
|
Given a confirm_dangerous callback that returns True
|
|
When I run a dangerous command "rm -rf /" with the callback
|
|
Then the dangerous command should have been confirmed
|
|
And the shell result should reflect the executed command
|
|
|
|
Scenario: Dangerous command confirmed but callback returns False is still blocked
|
|
Given a confirm_dangerous callback that returns False
|
|
When I run a dangerous command "rm -rf /" with the callback
|
|
Then the shell result exit code should be 1
|
|
And the shell result stderr should be "blocked dangerous shell command"
|
|
|
|
Scenario: Command that exceeds timeout returns timeout result
|
|
Given subprocess run is mocked to raise TimeoutExpired
|
|
When I run a shell command "sleep 999" with a 1 second timeout
|
|
Then the shell result exit code should be 124
|
|
And the shell result stderr should contain "command timed out after"
|