freemo
8ed13c4c14
Category 1 — Remove stale @tdd_expected_fail (tests pass in CI, bug fixed): - cli_lifecycle.robot: remove from 7 tests (bugs fixed, test helpers work) - cli_formats.robot: remove from 5 tests (format flag works in CI) - tui_smoke.robot: remove from TUI Headless tests (working in CI) - wf02_test_generation_integration.robot: remove from all 4 tests (working) Category 2 — Fix colon/single-space tag format → proper 4-space Robot syntax: - a2a_facade.robot: tdd_issue tdd_issue_4190 → tdd_issue tdd_issue_4190 - container_tool_exec.robot: fix tdd_issue:4188 format - coverage_threshold.robot: fix tdd_issue:4188 format - m6_autonomy_acceptance.robot: fix tdd_issue:4188 format - plan_diff_artifacts.robot: fix single-space format on all tests - project_context_policy.robot: fix single-space format - project_context_set_exec_env_priority.robot: add tdd_expected_fail to Force Tags Category 3 — Add missing @tdd_expected_fail to 32 genuinely failing tests: - cli_lifecycle_e2e.robot: Plan List namespace filter tests (#4301) - config_cli.robot: Config Set Get Roundtrip (#4302) - config_project_scope.robot: Project Scoped CLI roundtrip (#4303) - config_resolution.robot: Config Service Registers All Spec Keys (#4304) - coverage_threshold.robot: Noxfile threshold constant (#4305) - tdd_acms_behavioral_validation.robot: 4 context tests (#4306) - wf17_project_exec_env_priority.robot: context show test (#4307) - invariant_reconciliation_actor.robot: non-overridable invariant (#4308) - m4_e2e_verification.robot: CLI plan tree subplan (#4309) - m6_autonomy_acceptance.robot: M6 full autonomy flow (#4310) - plan_cli_spec.robot: Plan list rich output (#4311) - project_context_cli.robot: 3 context wired tests (#4313) - session_model.robot: CLI dict required keys (#4315) - tdd_budget_eviction_deletes_not_demotes.robot: 2 TDD tests (#4316) - tdd_e2e_implicit_init.robot: 2 implicit init tests (#4317) - tdd_invariant_persistence.robot: 3 invariant persistence tests (#4318) - tdd_plan_correct_auto_resolve.robot: 2 auto-resolve tests (#4319) - tdd_sqlite_url_cwd.robot: 2 SQLite URL tests (#4320) Issues created: #4301–#4320 tracking all remaining failures
159 lines
8.8 KiB
Plaintext
159 lines
8.8 KiB
Plaintext
*** Settings ***
|
|
Documentation Integration tests for container-aware tool execution (#515)
|
|
Resource ${CURDIR}/common.resource
|
|
Suite Setup Setup Test Environment
|
|
Suite Teardown Cleanup Test Environment
|
|
|
|
*** Variables ***
|
|
${TIMEOUT} 60s
|
|
|
|
*** Test Cases ***
|
|
PathMapper Maps Host To Container
|
|
[Documentation] Verify PathMapper translates host paths to container paths
|
|
${script}= Catenate SEPARATOR=\n
|
|
... from cleveragents.tool.path_mapper import PathMapper
|
|
... m = PathMapper('/tmp/sandbox', '/workspace')
|
|
... result = m.host_to_container('/tmp/sandbox/src/f.py')
|
|
... assert result == '/workspace/src/f.py', f"got {result}"
|
|
... print("OK")
|
|
${result}= Run Process ${PYTHON} -c ${script}
|
|
... timeout=${TIMEOUT} on_timeout=kill env:PYTHONPATH=${CURDIR}/../src
|
|
Should Be Equal As Integers ${result.rc} 0 PathMapper host_to_container failed: ${result.stderr}
|
|
Should Be Equal As Strings ${result.stdout.strip()} OK
|
|
|
|
PathMapper Maps Container To Host
|
|
[Documentation] Verify PathMapper translates container paths to host paths
|
|
${script}= Catenate SEPARATOR=\n
|
|
... from cleveragents.tool.path_mapper import PathMapper
|
|
... m = PathMapper('/tmp/sandbox', '/workspace')
|
|
... result = m.container_to_host('/workspace/src/f.py')
|
|
... assert result == '/tmp/sandbox/src/f.py', f"got {result}"
|
|
... print("OK")
|
|
${result}= Run Process ${PYTHON} -c ${script}
|
|
... timeout=${TIMEOUT} on_timeout=kill env:PYTHONPATH=${CURDIR}/../src
|
|
Should Be Equal As Integers ${result.rc} 0 PathMapper container_to_host failed: ${result.stderr}
|
|
Should Be Equal As Strings ${result.stdout.strip()} OK
|
|
|
|
PathMapper Leaves External Paths Unmapped
|
|
[Documentation] Paths outside root are returned unchanged
|
|
${script}= Catenate SEPARATOR=\n
|
|
... from cleveragents.tool.path_mapper import PathMapper
|
|
... m = PathMapper('/tmp/sandbox', '/workspace')
|
|
... result = m.host_to_container('/usr/lib/x')
|
|
... assert result == '/usr/lib/x', f"got {result}"
|
|
... print("OK")
|
|
${result}= Run Process ${PYTHON} -c ${script}
|
|
... timeout=${TIMEOUT} on_timeout=kill env:PYTHONPATH=${CURDIR}/../src
|
|
Should Be Equal As Integers ${result.rc} 0 PathMapper external path mapping failed: ${result.stderr}
|
|
Should Be Equal As Strings ${result.stdout.strip()} OK
|
|
|
|
ContainerConfig Has Defaults
|
|
[Documentation] ContainerConfig defaults to /workspace and 120s timeout
|
|
${script}= Catenate SEPARATOR=\n
|
|
... from cleveragents.tool.container_executor import ContainerConfig
|
|
... c = ContainerConfig()
|
|
... assert c.workspace_folder == '/workspace', f"got {c.workspace_folder}"
|
|
... assert c.timeout_seconds == 120, f"got {c.timeout_seconds}"
|
|
... print("OK")
|
|
${result}= Run Process ${PYTHON} -c ${script}
|
|
... timeout=${TIMEOUT} on_timeout=kill env:PYTHONPATH=${CURDIR}/../src
|
|
Should Be Equal As Integers ${result.rc} 0 ContainerConfig defaults test failed: ${result.stderr}
|
|
Should Be Equal As Strings ${result.stdout.strip()} OK
|
|
|
|
ContainerMetadata Is Frozen
|
|
[Documentation] ContainerMetadata is a frozen Pydantic model
|
|
${script}= Catenate SEPARATOR=\n
|
|
... from cleveragents.tool.container_executor import ContainerMetadata
|
|
... m = ContainerMetadata(container_id='x', image='y')
|
|
... assert m.container_id == 'x', f"got {m.container_id}"
|
|
... assert m.image == 'y', f"got {m.image}"
|
|
... assert m.timed_out is False
|
|
... print("OK")
|
|
${result}= Run Process ${PYTHON} -c ${script}
|
|
... timeout=${TIMEOUT} on_timeout=kill env:PYTHONPATH=${CURDIR}/../src
|
|
Should Be Equal As Integers ${result.rc} 0 ContainerMetadata test failed: ${result.stderr}
|
|
Should Be Equal As Strings ${result.stdout.strip()} OK
|
|
|
|
ContainerToolExecutor Instantiation
|
|
[Documentation] ContainerToolExecutor can be created with ContainerConfig
|
|
${script}= Catenate SEPARATOR=\n
|
|
... import structlog, sys; structlog.configure(logger_factory=structlog.PrintLoggerFactory(file=sys.stderr))
|
|
... from cleveragents.tool.container_executor import ContainerConfig, ContainerToolExecutor
|
|
... c = ContainerConfig(container_id='t')
|
|
... e = ContainerToolExecutor(c)
|
|
... assert e.config.container_id == 't', f"got {e.config.container_id}"
|
|
... assert e.path_mapper is not None
|
|
... print("OK")
|
|
${result}= Run Process ${PYTHON} -c ${script}
|
|
... timeout=${TIMEOUT} on_timeout=kill env:PYTHONPATH=${CURDIR}/../src
|
|
Should Be Equal As Integers ${result.rc} 0 Executor instantiation failed: ${result.stderr}
|
|
Should Be Equal As Strings ${result.stdout.strip()} OK
|
|
|
|
ContainerExecutionError Carries Details
|
|
[Documentation] ContainerExecutionError stores exit_code and stderr
|
|
${script}= Catenate SEPARATOR=\n
|
|
... from cleveragents.tool.container_executor import ContainerExecutionError
|
|
... e = ContainerExecutionError('fail', exit_code=2, stderr='bad')
|
|
... assert e.exit_code == 2, f"got {e.exit_code}"
|
|
... assert e.stderr == 'bad', f"got {e.stderr}"
|
|
... print("OK")
|
|
${result}= Run Process ${PYTHON} -c ${script}
|
|
... timeout=${TIMEOUT} on_timeout=kill env:PYTHONPATH=${CURDIR}/../src
|
|
Should Be Equal As Integers ${result.rc} 0 ContainerExecutionError test failed: ${result.stderr}
|
|
Should Be Equal As Strings ${result.stdout.strip()} OK
|
|
|
|
ContainerTimeoutError Carries Timeout
|
|
[Documentation] ContainerTimeoutError records timeout_seconds
|
|
${script}= Catenate SEPARATOR=\n
|
|
... from cleveragents.tool.container_executor import ContainerTimeoutError
|
|
... e = ContainerTimeoutError(30)
|
|
... assert e.timeout_seconds == 30, f"got {e.timeout_seconds}"
|
|
... assert e.timed_out is True
|
|
... assert '30' in str(e)
|
|
... print("OK")
|
|
${result}= Run Process ${PYTHON} -c ${script}
|
|
... timeout=${TIMEOUT} on_timeout=kill env:PYTHONPATH=${CURDIR}/../src
|
|
Should Be Equal As Integers ${result.rc} 0 ContainerTimeoutError test failed: ${result.stderr}
|
|
Should Be Equal As Strings ${result.stdout.strip()} OK
|
|
|
|
ToolInvocation Has ContainerMetadata Field
|
|
[Documentation] ToolInvocation accepts container_metadata dict
|
|
${script}= Catenate SEPARATOR=\n
|
|
... from cleveragents.domain.models.core.change import ToolInvocation
|
|
... t = ToolInvocation(
|
|
... plan_id='01TESTPLANID000000000000000',
|
|
... tool_name='ns/t',
|
|
... container_metadata={'container_id': 'x'},
|
|
... )
|
|
... assert t.container_metadata['container_id'] == 'x'
|
|
... print("OK")
|
|
${result}= Run Process ${PYTHON} -c ${script}
|
|
... timeout=${TIMEOUT} on_timeout=kill env:PYTHONPATH=${CURDIR}/../src
|
|
Should Be Equal As Integers ${result.rc} 0 ToolInvocation container_metadata test failed: ${result.stderr}
|
|
Should Be Equal As Strings ${result.stdout.strip()} OK
|
|
|
|
ToolRunner Container Routing Without Executor Returns Error
|
|
[Documentation] ToolRunner without ContainerToolExecutor returns error for container env
|
|
[Tags] tdd_issue tdd_issue_4243 tdd_expected_fail
|
|
${script}= Catenate SEPARATOR=\n
|
|
... from unittest.mock import MagicMock
|
|
... from cleveragents.tool.runner import ToolRunner
|
|
... from cleveragents.tool.registry import ToolRegistry
|
|
... from cleveragents.tool.runtime import ToolSpec
|
|
... from cleveragents.domain.models.core.plan import ExecutionEnvironment
|
|
... from cleveragents.application.services.execution_environment_resolver import ExecutionEnvironmentResolver
|
|
... r = MagicMock(spec=ToolRegistry)
|
|
... s = ToolSpec(name='t', description='d', input_schema={}, handler=lambda x: x)
|
|
... r.get.return_value = s
|
|
... ev = MagicMock(spec=ExecutionEnvironmentResolver)
|
|
... ev.resolve_and_validate.return_value = ExecutionEnvironment.CONTAINER
|
|
... runner = ToolRunner(registry=r, execution_environment_resolver=ev)
|
|
... res = runner.execute('t', {})
|
|
... assert not res.success, f"Expected failure but got success"
|
|
... assert 'ContainerToolExecutor' in res.error, f"Expected ContainerToolExecutor in error: {res.error}"
|
|
... print("OK")
|
|
${result}= Run Process ${PYTHON} -c ${script}
|
|
... timeout=${TIMEOUT} on_timeout=kill env:PYTHONPATH=${CURDIR}/../src
|
|
Should Be Equal As Integers ${result.rc} 0 ToolRunner container routing test failed: ${result.stderr}
|
|
Should Be Equal As Strings ${result.stdout.strip()} OK
|