hurui200320
2005b8ef82
CI / push-validation (push) Successful in 18s
CI / build (push) Successful in 19s
CI / helm (push) Successful in 24s
CI / lint (push) Successful in 29s
CI / security (push) Successful in 1m11s
CI / e2e_tests (push) Successful in 2m56s
CI / quality (push) Successful in 3m40s
CI / typecheck (push) Successful in 3m59s
CI / integration_tests (push) Successful in 4m3s
CI / unit_tests (push) Successful in 4m55s
CI / docker (push) Successful in 10s
CI / coverage (push) Successful in 10m44s
CI / status-check (push) Successful in 1s
CI / benchmark-regression (push) Has been skipped
CI / benchmark-publish (push) Successful in 1h13m28s
## Summary Replaces all 234 bare `@skip` occurrences across 82 Behave feature files with the correct TDD issue-capture tagging system described in CONTRIBUTING.md § Bug Fix Workflow. Previously, the noxfile ran Behave with `--tags=not @skip`, silently excluding all `@skip`-tagged scenarios from every CI run. These tests never ran, never inverted results via the `@tdd_expected_fail` mechanism, and never contributed to coverage — defeating the purpose of TDD issue-capture testing. Every `@skip` occurrence had a commented-out hint line immediately above it showing the intended proper tags (e.g., `# @tdd_issue @tdd_issue_4272 @tdd_expected_fail @skip`), confirming they were all intended for conversion. ## Changes ### Mechanical conversion (234 replacements across 82 files) - Extracted the proper TDD tags from the comment hint above each `@skip` line, removed `@skip` from the tag set, and replaced the `@skip` line with those tags. - Removed the now-redundant comment hint lines alongside each replacement. ### Bug-fixed scenarios — `@tdd_expected_fail` removed (84 scenarios) - After conversion, ran `nox -s unit_tests` to identify which newly-enabled `@tdd_expected_fail` scenarios now **pass** (their referenced bugs have already been fixed). Removed `@tdd_expected_fail` from those 84 scenarios and their corresponding feature-level tags, leaving only the permanent `@tdd_issue @tdd_issue_<N>` regression-guard tags. - Affected features include: `tdd_tool_runner_env_precedence`, `tdd_automation_profile_session_leak`, `tls_certificate_check`, `project_create_persist`, `resource_type_bootstrap_*`, and 18 others. ### Noxfile cleanup - Removed all four `--tags=not @skip` arguments from `noxfile.py` (unit_tests and coverage sessions). With zero `@skip` tags remaining in the codebase, this filter was dead code and its presence would mislead future maintainers into thinking `@skip` is still a supported escape mechanism. ### Regression guard files - Split the regression guards into two focused files: - `tdd_regression_guards_exec_env.feature` for bug #4281 (exec-env precedence) - `tdd_regression_guards_session_list.feature` for bug #4271 (session list summary) - Each file carries only its own `@tdd_issue` tags at the feature level, avoiding cross-contamination via Behave tag inheritance. The `Background` step (`session-list-summary mock`) only appears in the session-list file where it is actually needed. ### Duplicate tag cleanup - Removed duplicate `@tdd_issue @tdd_issue_4287` tag lines in `tdd_skill_add_regression.feature` (lines 20 and 29). ### Inline comment for retained `@tdd_expected_fail` - Added inline comment in `ci_workflow_validation.feature:134` explaining why this specific #4227 scenario retains `@tdd_expected_fail` despite #4227 being closed (CI YAML does not encode threshold as a machine-readable value). ### Known edge cases — `@tdd_expected_fail` retained (closed issues, fix on master, scenarios still fail) The following issues are **closed** and their fixes **are on master**, but the specific test assertions still fail because the fixes address other aspects of the bugs. The `@tdd_expected_fail` tags are functionally correct and must remain until the specific scenario assertions pass: - `tdd_exec_env_resolution_precedence.feature` — bug #1080 (closed 2026-03-31). The precedence-level-2-vs-4 scenario still fails. - `session_list_summary_dedup.feature` — bug #3046 (closed 2026-04-05). The dedup-consistency scenarios still fail. - `actor_add_update_enforcement.feature` — bug #2609 (closed 2026-04-05). The enforcement scenarios still fail. - `ci_workflow_validation.feature:134` — #4227 (closed 2026-04-08). The CI YAML threshold assertion still fails. ## Verification - `grep -r "@skip" features/ --include="*.feature"` → **zero results** ✓ - `grep -n "tags=not @skip" noxfile.py` → **zero results** ✓ - `nox -s unit_tests` → **629 features passed, 0 failed** ✓ (up from ~545 before this PR) - CI all green (coverage ≥ 97%) ✓ - Integration tests (Robot Framework) do not use `@skip` — confirmed no action needed ✓ - E2E tests (Robot Framework) do not use `@skip` — confirmed no action needed ✓ - `CHANGELOG.md` updated with entry for this change ✓ - `CONTRIBUTORS.md` — Rui Hu already listed ✓ ## Issues Addressed Closes #7025 Co-authored-by: CleverThis <hal9000@cleverthis.com> Reviewed-on: #7221 Reviewed-by: HAL 9000 <HAL9000@cleverthis.com> Reviewed-by: HAL9001 <hal9001@cleverthis.com> Co-authored-by: Rui Hu <rui.hu@cleverthis.com> Co-committed-by: Rui Hu <rui.hu@cleverthis.com>
67 lines
3.5 KiB
Gherkin
67 lines
3.5 KiB
Gherkin
@tdd_issue @tdd_issue_987 @tdd_issue_4178
|
|
Feature: TDD Bug #987 — AutomationProfileRepository session leak
|
|
As a developer
|
|
I want to verify that AutomationProfileRepository closes sessions
|
|
in auto_commit mode
|
|
So that regressions in session cleanup are caught
|
|
|
|
Regression guard for bug #987. AutomationProfileRepository methods
|
|
previously committed when auto_commit was True but never called
|
|
session.close() in a finally block. The fix added
|
|
``finally: if self._auto_commit: session.close()`` to all public
|
|
session-creating methods (get_by_name, list_all, upsert, delete),
|
|
matching the pattern already used by SessionRepository.
|
|
|
|
These scenarios verify that sessions are properly closed in
|
|
auto_commit mode for both success and error paths across all
|
|
public methods.
|
|
|
|
@tdd_issue @tdd_issue_4274
|
|
Scenario: upsert closes session in auto_commit mode on success
|
|
Given an AutomationProfileRepository with auto_commit enabled and a tracking session factory
|
|
When I upsert a valid automation profile via the repository
|
|
Then the tracking session should have been closed
|
|
|
|
@tdd_issue @tdd_issue_4274
|
|
Scenario: delete closes session in auto_commit mode on success
|
|
Given an AutomationProfileRepository with auto_commit enabled and a tracking session factory
|
|
And a persisted automation profile named "local/leak-test-profile"
|
|
When I delete the automation profile "local/leak-test-profile" via the repository
|
|
Then the tracking session should have been closed
|
|
|
|
@tdd_issue @tdd_issue_4274
|
|
Scenario: upsert closes session in auto_commit mode on database error
|
|
Given an AutomationProfileRepository with auto_commit enabled and a failing session factory
|
|
When I attempt to upsert a profile that triggers a database error
|
|
Then the tracking session should have been closed despite the error
|
|
|
|
@tdd_issue @tdd_issue_4274
|
|
Scenario: delete closes session in auto_commit mode on database error
|
|
Given an AutomationProfileRepository with auto_commit enabled, a pre-populated profile, and a failing-flush tracking session
|
|
When I attempt to delete a profile that triggers a database error
|
|
Then the tracking session should have been closed despite the delete error
|
|
|
|
@tdd_issue @tdd_issue_4274
|
|
Scenario: get_by_name closes session in auto_commit mode on success
|
|
Given an AutomationProfileRepository with auto_commit enabled and a tracking session factory
|
|
When I look up a profile by name via the repository
|
|
Then the tracking session should have been closed
|
|
|
|
@tdd_issue @tdd_issue_4274
|
|
Scenario: list_all closes session in auto_commit mode on success
|
|
Given an AutomationProfileRepository with auto_commit enabled and a tracking session factory
|
|
When I list all profiles via the repository
|
|
Then the tracking session should have been closed
|
|
|
|
@tdd_issue @tdd_issue_4274
|
|
Scenario: get_by_name closes session in auto_commit mode on database error
|
|
Given an AutomationProfileRepository with auto_commit enabled and a failing-query session factory
|
|
When I attempt to look up a profile that triggers a database error
|
|
Then the tracking session should have been closed despite the get_by_name error
|
|
|
|
@tdd_issue @tdd_issue_4274
|
|
Scenario: list_all closes session in auto_commit mode on database error
|
|
Given an AutomationProfileRepository with auto_commit enabled and a failing-query session factory
|
|
When I attempt to list profiles that triggers a database error
|
|
Then the tracking session should have been closed despite the list_all error
|