drew
a21466add2
feat(controller): Phase 4 metadata-hygiene + round-2 adversarial fixes
Five deterministic, idempotent Phase 4 checks:
1. completed_not_closed — close linked issues on MERGED
2. closing_keyword_fixup — add Closes #N to PR bodies
3. label_sync_from_issue — copy Priority/Type/MoSCoW labels
4. state_label_inference — sync State/* label to current_state
5. milestone_assignment — copy milestone from linked issue
All default-off via CONTROLLER_METADATA_HYGIENE_ENABLED +
per-check granular env flags. Dry-run mode shares the grooming
CONTROLLER_GROOMING_DRY_RUN flag.
Round-1 fixes (applied before this commit):
- False-positive idempotency lock (executed=True on skip)
- Unbounded MERGED scan → LEFT JOIN candidate query
- Duplicate _classify_forgejo_status → import from forgejo_writes
- Bare-ref regex too broad ([#42](url) misread) → add [ lookbehind
- Wrong audit stage → 'metadata_hygiene'
Round-2 adversarial fixes (3 architect, 4 principal, 7 test engineer):
- completed_not_closed: executed=True only when ALL refs close;
partial success writes executed=False so remaining issues retry
- milestone_assignment: was calling get_pr_details (hits /pulls/,
returns 404 for plain issues) → now uses get_issue_state
(/issues/{n}) so milestone fetch works for all issue types
- label_sync failure path: write executed=False audit row for
observability; pre-fix left no audit trail for persistent failures
- _BARE_REF_RE: add ( to lookbehind to exclude (#42) link destinations
- state_label_inference: re-read current_state inside inner session to
avoid stale-snapshot spurious label writes across session boundaries
- _last_synced_state: add decision_id DESC tiebreaker for same-second
wall-clock rows
- dry-run completed_not_closed: separate early-return path to avoid
inflating completed_not_closed_executed counter
71 tests (54 round-1 + 17 round-2):
- TestCompletedNotClosedPartialSuccess (3) — partial/zero/full success
- TestLabelSyncAdjustLabelsFailure (2) — failure audit + retry
- TestStateLabelAdjustLabelsFailure (2) — no executed=1 on failure
- TestStateLabelInferenceTerminalWorkflows (3) — MERGED/ABANDONED sync
- TestLastSyncedStateDryRunThenReal (2) — dry-run → real-run
- TestClosingKeywordFixupBareRefAlreadyCovered (2) — candidates subtraction
- TestErrorPathHandlingRound2 (3) — label_sync + state_label errors
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-05-25 17:41:49 -04:00
..
2026-05-25 17:41:49 -04:00
2026-05-20 00:09:17 -04:00
2026-05-20 00:09:17 -04:00
2026-05-20 00:09:17 -04:00
2026-05-20 00:09:17 -04:00
2026-05-20 00:09:17 -04:00
2026-05-24 08:25:24 -04:00
2026-05-03 21:31:16 -04:00
2026-05-20 23:02:07 -04:00
2026-05-20 00:09:17 -04:00
2026-05-20 00:09:17 -04:00
2026-05-20 00:09:17 -04:00
2026-05-20 00:09:17 -04:00
2026-05-20 00:09:17 -04:00
2026-05-20 00:09:17 -04:00
2026-05-20 00:09:17 -04:00
2026-05-20 00:09:17 -04:00
2026-05-20 00:09:17 -04:00
2026-05-20 00:09:17 -04:00
2026-05-20 00:09:17 -04:00
2026-05-20 00:09:17 -04:00
2026-05-20 00:09:17 -04:00
2026-05-20 00:09:17 -04:00
2026-05-20 00:09:17 -04:00
2026-05-20 00:09:17 -04:00
2026-05-20 00:09:17 -04:00
2026-05-21 00:29:11 -04:00
2026-05-20 00:09:17 -04:00
2026-05-25 15:05:29 -04:00
2026-05-20 00:09:17 -04:00
2026-05-21 17:17:16 -04:00
2026-05-20 00:09:17 -04:00
2026-05-20 00:09:17 -04:00
2026-05-20 00:09:17 -04:00
2026-05-20 00:09:17 -04:00
2026-05-20 00:09:17 -04:00
2026-05-20 00:09:17 -04:00
2026-05-20 00:09:17 -04:00
2026-05-20 00:09:17 -04:00
2026-05-20 00:09:17 -04:00
2026-05-20 00:09:17 -04:00
2026-05-20 00:09:17 -04:00
2026-05-20 00:09:17 -04:00
2026-05-20 00:09:17 -04:00
2026-05-20 00:09:17 -04:00
2026-05-20 00:09:17 -04:00
2026-05-20 00:09:17 -04:00
2026-05-20 00:09:17 -04:00
2026-05-20 00:09:17 -04:00
2026-05-20 00:09:17 -04:00
2026-05-20 00:09:17 -04:00
2026-05-20 00:09:17 -04:00
2026-05-20 00:09:17 -04:00
2026-05-20 00:09:17 -04:00
2026-05-11 17:39:23 -04:00
2026-05-20 00:09:17 -04:00
2026-05-20 00:09:17 -04:00
2026-05-20 11:49:05 -04:00
2026-05-03 21:31:16 -04:00
2026-05-20 00:09:17 -04:00
2026-05-20 00:09:17 -04:00
2026-05-20 00:09:17 -04:00
2026-05-20 00:09:17 -04:00
2026-05-24 08:32:35 -04:00
2026-05-20 00:09:17 -04:00
2026-05-20 00:09:17 -04:00
2026-05-20 00:09:17 -04:00
2026-05-20 00:09:17 -04:00
2026-05-20 00:09:17 -04:00
2026-05-20 00:09:17 -04:00
2026-05-20 00:09:17 -04:00
2026-05-20 00:09:17 -04:00
2026-05-20 00:09:17 -04:00
2026-05-24 08:25:24 -04:00
2026-05-24 08:25:24 -04:00
2026-05-20 00:09:17 -04:00
2026-05-20 11:49:05 -04:00
2026-05-24 08:32:35 -04:00
2026-05-20 00:09:17 -04:00
2026-05-20 22:55:09 -04:00
2026-05-20 00:09:17 -04:00
2026-05-22 09:38:52 -04:00
2026-05-20 00:09:17 -04:00
2026-05-20 00:09:17 -04:00
2026-05-22 07:28:21 -04:00
2026-05-20 00:09:17 -04:00
2026-05-03 21:31:16 -04:00
2026-05-03 21:31:16 -04:00
2026-05-20 00:09:17 -04:00
2026-05-20 00:09:17 -04:00
2026-05-20 00:09:17 -04:00
2026-05-03 21:31:16 -04:00
2026-05-06 01:28:41 -04:00
2026-05-04 13:13:52 -04:00
2026-05-20 00:09:17 -04:00
2026-05-20 00:09:17 -04:00
2026-05-03 21:31:16 -04:00
2026-05-20 00:09:17 -04:00
2026-05-20 11:49:05 -04:00
2026-05-25 15:05:29 -04:00
2026-05-20 00:09:17 -04:00
2026-05-20 00:09:17 -04:00
2026-05-20 00:09:17 -04:00
2026-05-22 07:33:18 -04:00
2026-05-20 00:09:17 -04:00
2026-05-20 00:09:17 -04:00
2026-05-20 00:09:17 -04:00
2026-05-20 00:09:17 -04:00
2026-05-20 00:09:17 -04:00
2026-05-20 00:09:17 -04:00