aditya
36c36bc0ee
CI / benchmark-publish (pull_request) Has been skipped
CI / build (pull_request) Successful in 18s
CI / lint (pull_request) Successful in 3m19s
CI / quality (pull_request) Successful in 3m41s
CI / typecheck (pull_request) Successful in 3m54s
CI / security (pull_request) Successful in 4m2s
CI / integration_tests (pull_request) Successful in 6m41s
CI / unit_tests (pull_request) Successful in 6m49s
CI / docker (pull_request) Successful in 1m9s
CI / e2e_tests (pull_request) Successful in 9m19s
CI / coverage (pull_request) Successful in 11m17s
CI / status-check (pull_request) Successful in 1s
CI / benchmark-regression (pull_request) Successful in 50m38s
Add Behave and Robot Framework regression tests for bug #647, where plan tree, plan explain, and plan correct CLI commands crashed with AttributeError when resolving DecisionService from the DI container. Tests use a real DI container with seeded decisions (not MagicMock) to catch the exact class of bug that existing M3 tests missed. Assertions verify successful execution and command-specific output content. Includes Settings.reset() classmethod for robust singleton cleanup in test teardown. Review feedback addressed (hurui200320 Round 5): - Fixed Behave step engine leak by capturing UoW in cleanup closure - Removed dead @then decorator; renamed to private _assert_command_succeeded - Strengthened plan correct assertions with revert/dry-run content checks - Updated misleading get_container() comment to reflect singleton warming - Added test-only warning to Settings.reset() docstring - Added type annotations to 4 settings step functions - Fixed CONTRIBUTORS.md alphabetical ordering and removed duplicate entry - Replaced glob.glob with pathlib suffix iteration in Robot helper - Fixed feature description line break for readability - Removed redundant TYPE_CHECKING import for Decision ISSUES CLOSED: #648
677 B
677 B
Contributors
- Aditya Chhabra aditya.chhabra@cleverthis.com
- Brent E. Edwards brent.edwards@cleverthis.com
- Hamza Khyari hamza.khyari@cleverthis.com
- Jeffrey Phillips Freeman jeffrey.freeman@syncleus.com
- Luis Mendes luis.p.mendes@gmail.com
- Rui Hu rui.hu@cleverthis.com
Details
Below are some of the specific details of various contributions.
- Jeffrey Phillips Freeman has acted as Lead Developer, daily contributor, and Project Owner.
- Brent E. Edwards has contributed quality assurance, test coverage, and CI pipeline improvements.
- This project was made possible thanks to considerable donation of time, money, and resources by CleverThis, Inc.