brent.edwards
eb46f0ff54
CI / push-validation (push) Successful in 40s
CI / helm (push) Successful in 44s
CI / build (push) Successful in 1m14s
CI / lint (push) Successful in 1m18s
CI / quality (push) Successful in 1m36s
CI / e2e_tests (push) Successful in 1m19s
CI / typecheck (push) Successful in 2m22s
CI / security (push) Successful in 2m23s
CI / benchmark-regression (push) Failing after 41s
CI / integration_tests (push) Successful in 4m46s
CI / unit_tests (push) Failing after 20m13s
CI / benchmark-publish (push) Failing after 28m28s
CI / coverage (push) Has been cancelled
CI / docker (push) Has been cancelled
CI / status-check (push) Has been cancelled
## Summary This PR fixes issue #10878 where architecture reviews were truncated because the regex pattern for parsing file output would stop at the first ``` encountered in the Markdown report. ## Changes - Change file delimiters from ``` to >>>>>>>/<<<<<<< to avoid Markdown conflicts - Add tier hydration before strategize phase in plan_executor.py - Increase max_tokens to 16384 in llm_actors.py for longer outputs - Increase context_max_tokens_hot from 16000 to 32000 in settings.py - Fix get_hot_view → get_hot_fragments in strategy_actor.py and plan_executor.py - Add opencode to skip directories in context_tier_hydrator.py - Change sandbox output location to plan-output/ directory in plan.py - Add get_context_summary stub method to acms_service.py ## Testing Run architecture review action and verify the output report is complete with all sections. Reviewed-on: #10938
24 lines
1.3 KiB
Gherkin
24 lines
1.3 KiB
Gherkin
Feature: PlanApplyService branch coverage for handle_merge_failure logger path
|
|
As a developer
|
|
I want to cover the missed branch at line 426→432 in plan_apply_service.py
|
|
So that branch-rate reaches 1.0
|
|
|
|
# The missed branch is the exception-propagation path from the
|
|
# self._logger.error() call inside handle_merge_failure (line 426).
|
|
# When the logger raises, execution skips the ``return plan`` on line 431
|
|
# and exits the function via the exception (line 432).
|
|
|
|
Scenario: handle_merge_failure propagates exception when logger.error raises
|
|
Given pas_branch a service whose logger.error will raise RuntimeError
|
|
When pas_branch I call handle_merge_failure and capture any exception
|
|
Then pas_branch a RuntimeError should have been raised
|
|
And pas_branch the plan error_details should still contain merge_conflict
|
|
And pas_branch lifecycle commit_plan should have been invoked before the error
|
|
And pas_branch lifecycle fail_apply should have been invoked before the error
|
|
|
|
Scenario: handle_merge_failure returns plan when logger.error succeeds
|
|
Given pas_branch a service whose logger.error will succeed normally
|
|
When pas_branch I call handle_merge_failure normally
|
|
Then pas_branch the returned plan should not be None
|
|
And pas_branch the service logger.error should have been called with merge failure details
|