brent.edwards
35e1807f95
CI / lint (pull_request) Successful in 14s
CI / typecheck (pull_request) Successful in 37s
CI / security (pull_request) Successful in 37s
CI / benchmark-publish (pull_request) Has been skipped
CI / quality (pull_request) Successful in 41s
CI / build (pull_request) Successful in 22s
CI / integration_tests (pull_request) Successful in 2m44s
CI / unit_tests (pull_request) Successful in 3m44s
CI / docker (pull_request) Successful in 39s
CI / coverage (pull_request) Successful in 5m3s
CI / e2e_tests (pull_request) Successful in 5m28s
CI / benchmark-regression (pull_request) Failing after 22m0s
Consolidate the execute_plan CLI handler to eliminate a redundant service.get_plan() call (the separate read-only pre-check now reuses the same current_plan reference used for phase detection), update the command-table description from the stale 'Transition to Execute phase' to 'Run phase-aware plan execution', and replace the static post-execution hint with a state-aware message that distinguishes execute/complete (ready for apply) from other states (continue executing). Update corresponding Behave test mocks to match the reduced get_plan call sequence and the updated output panel title. ISSUES CLOSED: #967
165 lines
7.9 KiB
Gherkin
165 lines
7.9 KiB
Gherkin
Feature: Plan lifecycle CLI coverage
|
|
As a developer
|
|
I want to exercise v3 plan lifecycle CLI commands
|
|
So that plan lifecycle branches in plan.py are covered
|
|
|
|
Background:
|
|
Given a plan lifecycle CLI runner
|
|
And a mocked lifecycle service for plan commands
|
|
|
|
Scenario: Plan use parses typed arguments
|
|
When I run plan lifecycle use with parsed arguments
|
|
Then the plan lifecycle command should succeed
|
|
And the plan lifecycle use should pass parsed arguments
|
|
And the plan lifecycle output should contain "Strategize phase"
|
|
|
|
Scenario: Plan use rejects invalid argument format
|
|
When I run plan lifecycle use with invalid argument "badarg"
|
|
Then the plan lifecycle command should abort
|
|
And the plan lifecycle output should contain "Invalid argument format"
|
|
|
|
Scenario: Plan use handles action not available errors
|
|
When I run plan lifecycle use causing "action not available"
|
|
Then the plan lifecycle command should abort
|
|
And the plan lifecycle output should contain "Action not available"
|
|
|
|
Scenario: Plan use handles validation errors
|
|
When I run plan lifecycle use causing "validation error"
|
|
Then the plan lifecycle command should abort
|
|
And the plan lifecycle output should contain "Validation Error"
|
|
|
|
Scenario: Plan use handles general errors
|
|
When I run plan lifecycle use causing "general error"
|
|
Then the plan lifecycle command should abort
|
|
And the plan lifecycle output should contain "Error"
|
|
|
|
Scenario: Plan execute aborts when no plans are ready
|
|
When I run plan execute without a plan id with 0 complete plans
|
|
Then the plan lifecycle command should abort
|
|
And the plan lifecycle output should contain "No plans ready for execution"
|
|
|
|
Scenario: Plan execute aborts when multiple plans are ready
|
|
When I run plan execute without a plan id with 2 complete plans
|
|
Then the plan lifecycle command should abort
|
|
And the plan lifecycle output should contain "Multiple plans ready for execution"
|
|
|
|
Scenario: Plan execute runs when one plan is ready
|
|
When I run plan execute without a plan id with 1 complete plans
|
|
Then the plan lifecycle command should succeed
|
|
And the execute command should run the single ready plan
|
|
And the plan lifecycle output should contain "Plan Executed"
|
|
|
|
Scenario: Plan execute handles invalid phase transition
|
|
When I run plan execute for plan id "01ARZ3NDEKTSV4RRFFQ69G5FAV" causing "invalid transition"
|
|
Then the plan lifecycle command should abort
|
|
And the plan lifecycle output should contain "Invalid transition"
|
|
|
|
Scenario: Plan execute handles plan not ready
|
|
When I run plan execute for plan id "01ARZ3NDEKTSV4RRFFQ69G5FAW" causing "plan not ready"
|
|
Then the plan lifecycle command should abort
|
|
And the plan lifecycle output should contain "Plan not ready"
|
|
|
|
Scenario: Plan execute handles general errors
|
|
When I run plan execute for plan id "01ARZ3NDEKTSV4RRFFQ69G5FAX" causing "general error"
|
|
Then the plan lifecycle command should abort
|
|
And the plan lifecycle output should contain "Error"
|
|
|
|
Scenario: Plan lifecycle apply aborts when no plans are ready
|
|
When I run plan lifecycle apply without a plan id with 0 complete plans
|
|
Then the plan lifecycle command should abort
|
|
And the plan lifecycle output should contain "No plans ready for apply"
|
|
|
|
Scenario: Plan lifecycle apply aborts when multiple plans are ready
|
|
When I run plan lifecycle apply without a plan id with 2 complete plans
|
|
Then the plan lifecycle command should abort
|
|
And the plan lifecycle output should contain "Multiple plans ready for apply"
|
|
|
|
Scenario: Plan lifecycle apply runs when one plan is ready
|
|
When I run plan lifecycle apply without a plan id with 1 complete plans
|
|
Then the plan lifecycle command should succeed
|
|
And the lifecycle apply command should run the single ready plan
|
|
And the plan lifecycle output should contain "Apply phase"
|
|
|
|
Scenario: Plan lifecycle apply handles invalid phase transition
|
|
When I run plan lifecycle apply for plan id "01ARZ3NDEKTSV4RRFFQ69G5FAY" causing "invalid transition"
|
|
Then the plan lifecycle command should abort
|
|
And the plan lifecycle output should contain "Invalid transition"
|
|
|
|
Scenario: Plan lifecycle apply handles plan not ready
|
|
When I run plan lifecycle apply for plan id "01ARZ3NDEKTSV4RRFFQ69G5FAZ" causing "plan not ready"
|
|
Then the plan lifecycle command should abort
|
|
And the plan lifecycle output should contain "Plan not ready"
|
|
|
|
Scenario: Plan lifecycle apply handles general errors
|
|
When I run plan lifecycle apply for plan id "01ARZ3NDEKTSV4RRFFQ69G5FB0" causing "general error"
|
|
Then the plan lifecycle command should abort
|
|
And the plan lifecycle output should contain "Error"
|
|
|
|
Scenario: Plan status shows no plans
|
|
When I run plan status without a plan id and 0 plans exist
|
|
Then the plan lifecycle command should succeed
|
|
And the plan lifecycle output should contain "No v3 lifecycle plans found"
|
|
|
|
Scenario: Plan status lists active plans
|
|
When I run plan status without a plan id and 2 plans exist
|
|
Then the plan lifecycle command should succeed
|
|
And the plan lifecycle output should contain "Active Plans"
|
|
|
|
Scenario: Plan status falls back for legacy plan
|
|
When I run plan status for legacy plan id "01ARZ3NDEKTSV4RRFFQ69G5FB1"
|
|
Then the plan lifecycle command should succeed
|
|
And the plan lifecycle output should contain "Plan: legacy-plan"
|
|
|
|
Scenario: Plan status handles general errors
|
|
When I run plan status causing a general error
|
|
Then the plan lifecycle command should abort
|
|
And the plan lifecycle output should contain "Error"
|
|
|
|
Scenario: Plan lifecycle list rejects invalid phase
|
|
When I run plan lifecycle list with invalid phase "notaphase"
|
|
Then the plan lifecycle command should abort
|
|
And the plan lifecycle output should contain "Invalid phase"
|
|
|
|
Scenario: Plan lifecycle list shows no plans
|
|
When I run plan lifecycle list with no plans
|
|
Then the plan lifecycle command should succeed
|
|
And the plan lifecycle output should contain "No plans found"
|
|
|
|
Scenario: Plan lifecycle list shows project summaries
|
|
When I run plan lifecycle list with plans and phase "execute"
|
|
Then the plan lifecycle command should succeed
|
|
And the plan lifecycle output should contain "V3 Lifecycle Plans"
|
|
And the plan lifecycle output should contain "proj-2"
|
|
And the plan lifecycle output should contain "more"
|
|
|
|
Scenario: Plan lifecycle list handles general errors
|
|
When I run plan lifecycle list causing a general error
|
|
Then the plan lifecycle command should abort
|
|
And the plan lifecycle output should contain "Error"
|
|
|
|
Scenario: Plan cancel reports cancellation with reason
|
|
When I run plan cancel for plan id "01ARZ3NDEKTSV4RRFFQ69G5FB2" with reason "User requested"
|
|
Then the plan lifecycle command should succeed
|
|
And the plan lifecycle output should contain "Plan cancelled"
|
|
And the plan lifecycle output should contain "Reason: User requested"
|
|
|
|
Scenario: Plan cancel reports cancellation without reason
|
|
When I run plan cancel for plan id "01ARZ3NDEKTSV4RRFFQ69G5FB3" without reason
|
|
Then the plan lifecycle command should succeed
|
|
And the plan lifecycle output should contain "Plan cancelled"
|
|
And the plan lifecycle output should not contain "Reason:"
|
|
|
|
Scenario: Plan cancel handles plan errors
|
|
When I run plan cancel for plan id "01ARZ3NDEKTSV4RRFFQ69G5FB4" causing "plan error"
|
|
Then the plan lifecycle command should abort
|
|
And the plan lifecycle output should contain "Cannot cancel"
|
|
|
|
Scenario: Plan cancel handles general errors
|
|
When I run plan cancel for plan id "01ARZ3NDEKTSV4RRFFQ69G5FB5" causing "general error"
|
|
Then the plan lifecycle command should abort
|
|
And the plan lifecycle output should contain "Error"
|
|
|
|
Scenario: Plan execute shares lifecycle service instance with executor
|
|
When I run plan execute verifying lifecycle service sharing
|
|
Then the plan executor should receive the same lifecycle service instance
|