Run-25 surfaced five ways the controller lost or mis-routed correct
implementer work. Each is fixed:
1. Canonical-output salvage (agent_runner.py): when an implementer's
OpenCode session ends cleanly but emits no V1 output, its commits
are no longer discarded — they are pushed and a synthetic
outcome=resolved routes the workflow to AWAITING_CI so CI judges the
code. Guarded by lost_lock_check so a reaped worker cannot race a
fresh one on the shared worktree.
2. Preserve committed-but-unpushed work (workspace.py): the pre-reset
snapshot (auto-scratch/pr-<N>) now captures committed commits ahead
of the reset target, not just dirty edits — a finished-but-unpushed
fix survives for the next attempt to adopt.
3. blocked escalates (outcomes.py): an implementer 'blocked' below
MAX_TIER now escalates to a stronger tier instead of dead-ending at
STUCK; only 'blocked' AT MAX_TIER STUCKs.
4. Diff-size tier floor (tick.py): the estimator's structured
recommended_tier can contradict its own reasoning (a 387-file PR
emitted as tier 0). current_tier is now floored deterministically by
diff size so a huge PR cannot run on the weakest model.
5. CI log excerpt (prompts.py): the per-gate log excerpt is now
tail-clipped, not head-clipped — the failure tracebacks live at the
bottom and were being cut off, leaving the implementer blind.
1121 controller tests pass (+34 new).
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
drew
a6ff7da63c