hamza.khyari 23d8a53f6a fix(resource): address review findings for resource type inheritance ...

Fix 25 of 27 review findings from PR #618 code review:

P1 (Must Fix):
- F3: Fix silent data corruption in _merge_collection for properties
  dict fields (was falling through to string list merge)
- F1: Split 1023-line step file into 3 files + helper module (all <500)
- F4: Add SELECT FOR UPDATE lock on parent type in register_type to
  prevent TOCTOU race in concurrent registrations
- F6: Fix docs claiming exceptions inherit from CleverAgentsError
  (they inherit from ValueError)
- F7: Fix docs incorrectly describing validate_chain return type

P2 (Should Fix):
- F9: Replace dict[str, Any] with TypeRegistryMap type alias
- F10: Replace import logging with structlog in inheritance.py
- F11: Add __all__ to inheritance.py
- F13: Fix _load_type_registry to derive built_in from namespace column
- F14: Add warning log for unregistered types in resolve_inheritance_chain
- F15: Return defensive copies from resolve_fields
- F16: Add chain validation to bootstrap_builtin_types
- F17: Narrow except Exception to specific types in step files
- F18: Add side-effect verification scenarios after error cases
- F19: Always include inherits key in JSON output for consistent schema
- F20: Log actual exception instead of hardcoded string in CLI

P3 (Nit):
- F21: Reject whitespace-only inherits values in validate_chain
- F23: Wrap chain errors in HandlerResolutionError in resolver
- F24: Return defensive copies from as_cli_dict
- F25: Replace tautological assertion with ResourceHandler isinstance
- F26: Add whitespace inherits test scenario
- F27: Fix find_subtypes docstring to note it excludes ancestor_name

Deferred:
- F2: type: ignore in step files — pyright only checks src/, matches
  existing project pattern (91 occurrences in resource_dag_steps.py)
- F5: CLI integration tests require full DI container setup
- F8: resource_registry_service.py size is pre-existing (971 on master)
- F12: Coverage boost file changes are test adaptations, not scope creep
- F22: FK constraint intentionally omitted per docs (SQLite compat)

2026-03-10 03:39:32 +00:00

..

acms_backends.md

feat(acms): add text, vector, and graph backend protocol implementations

2026-03-03 03:29:31 +00:00

acms.md

refactor(acms): unify ContextFragment model hierarchies by extending CRP base types

2026-03-05 21:38:55 +00:00

acp.md

feat(acp): wire ACP local facade handlers to live services

2026-03-02 22:45:55 -05:00

action_cli.md

feat(cli): add action and plan CLI extensions

2026-02-23 10:46:53 +00:00

actor_cli.md

feat(cli): align actor commands to YAML

2026-02-24 19:12:01 +00:00

actor_compiler.md

feat(actor): compile hierarchical actor configs to LangGraph

2026-02-24 17:57:18 +00:00

actor_config.md

feat(actor): extend hierarchical actor YAML schema and loader

2026-02-25 10:30:42 +00:00

actor_hierarchy.md

feat(actor): extend hierarchical actor YAML schema and loader

2026-02-25 10:30:42 +00:00

actor_runtime.md

feat(actor): add tool-calling runtime for execution actors

2026-02-22 08:31:45 +00:00

actors_examples.md

fix(actor): address code review findings on plan_subplan tool

2026-03-02 08:17:21 +00:00

actors_loading.md

feat(actor): add actor registry and loader

2026-02-19 11:29:34 +00:00

actors_schema.md

docs(actor): add comprehensive actor schema reference documentation

2026-02-17 13:26:15 +00:00

agent_skills.md

feat(skill): add agent skills loader

2026-02-26 09:10:35 +00:00

async_architecture.md

feat(async): add async command execution and workers

2026-03-04 23:47:20 +00:00

async_safety.md

fix(security): address PR #435 review feedback

2026-02-26 14:30:43 +00:00

audit_logging.md

feat(security): add audit logging for apply

2026-02-19 19:23:30 +00:00

automation_profile_service.md

Merge branch 'master' into develop-20260217

2026-02-18 03:27:00 +00:00

automation_profiles.md

feat(automation): add autonomy guardrails and audit trail

2026-02-28 22:06:57 +00:00

change_tracking.md

feat(change): add ChangeSet models and invocation tracker

2026-02-21 16:27:40 +00:00

changeset_model.md

Merge branch 'master' into develop-20260217

2026-02-18 03:27:00 +00:00

changeset.md

feat(changeset): persist changesets and diff artifacts

2026-02-26 02:47:14 +00:00

checkpointing.md

feat(checkpoint): add checkpointing and rollback

2026-03-02 10:18:14 +00:00

cleanup.md

feat(ops): add cleanup commands

2026-02-19 13:46:48 +00:00

cli_system_commands.md

docs(cli): add system command reference and diagnostics check list

2026-02-18 12:18:42 +00:00

concurrency.md

feat(concurrency): add plan and project locks

2026-02-25 10:48:05 -05:00

config_cli.md

feat(cli): add config get/set/list commands

2026-02-19 23:48:40 +00:00

config_resolution.md

feat(config): add project-scoped config overrides

2026-03-02 15:05:20 +00:00

context_indexing.md

feat(context): add repo indexing service

2026-03-09 23:55:33 +00:00

context_strategies.md

feat(acms): add context strategy registry

2026-03-05 22:00:15 +00:00

context_tiers.md

feat(context): add hot/warm/cold tiers and actor views

2026-03-03 17:01:57 +00:00

cost_controls.md

feat(provider): add cost controls and fallback

2026-02-25 12:08:01 -05:00

crp.md

feat(acms): add context request protocol models

2026-03-02 14:32:31 +00:00

database_schema.md

feat(skill): persist flattened tool sets

2026-02-27 20:09:26 +00:00

decision_correction.md

feat(M4.2): Correction service with revert/append BFS + dry-run

2026-02-22 16:40:06 +00:00

decision_model.md

feat(decision): add decision domain and context snapshots

2026-02-23 22:19:19 +00:00

decision_service.md

feat(service): add decision recording and snapshot store

2026-03-03 12:18:27 +00:00

definition_of_done.md

feat(dod): enforce definition-of-done gating

2026-02-25 10:04:31 +00:00

devcontainer_resources.md

feat(resource): add devcontainer resource type and auto-discovery handler

2026-03-02 22:09:37 -05:00

di.md

fix(service): align test and doc refs with DecisionService API

2026-03-03 12:18:27 +00:00

diagnostics_checks.md

docs: Moved the last elements from implementation plan to their respective locations and deleted the plan from the repo

2026-02-23 17:53:26 -05:00

diff_review.md

feat(change): add diff review artifacts

2026-02-25 10:02:38 +00:00

error_handling.md

fix(security): enforce explicit exception handling

2026-02-25 10:05:57 +00:00

error_recovery.md

feat(plan): add error recovery patterns and CLI hints

2026-02-25 10:05:10 +00:00

event_bus.md

feat(events): add EventBus protocol and ReactiveEventBus implementation

2026-03-02 11:54:53 +00:00

invariants.md

feat(invariant): add invariant models and enforcement

2026-02-22 09:23:35 +00:00

large_project_decomposition.md

feat(plan): add large-project decomposition and dependency closure

2026-03-03 21:44:20 +00:00

lsp_stub.md

feat(lsp): add LSP server stub

2026-03-06 18:16:47 +00:00

lsp.md

feat(lsp): add registry and runtime stubs

2026-02-22 10:15:25 +00:00

mcp_adapter.md

feat(skill): add MCP adapter for external tools

2026-02-25 13:17:26 +00:00

multi_project_plans.md

feat(plan): add multi-project subplan support

2026-03-03 14:55:58 -05:00

observability.md

feat(observability): add LLMTrace model and operational metrics

2026-03-03 17:04:17 -05:00

output_rendering.md

feat(cli): add output rendering framework with materialization strategies

2026-02-21 10:19:45 -05:00

permissions.md

feat(security): add permission system

2026-02-28 20:21:18 +00:00

phase_reversion.md

feat(plan): add phase reversion state machine

2026-02-23 10:45:01 +00:00

plan_apply.md

feat(plan): add error recovery patterns and CLI hints

2026-02-25 10:05:10 +00:00

plan_cli.md

fix(cli): address review findings for plan explain and tree commands

2026-03-03 12:10:25 +00:00

plan_execute.md

feat(plan): add error recovery patterns and CLI hints

2026-02-25 10:05:10 +00:00

project_context_cli.md

feat(cli): wire project context CLI stubs to ACMS pipeline

2026-03-03 23:36:15 +00:00

project_context_policy.md

Merge branch 'master' into develop-20260217

2026-02-18 03:27:00 +00:00

read_only_actions.md

fix(security): wire read_only through ExecuteStubActor and replace stubs with real tests

2026-02-26 20:33:20 +00:00

repl.md

feat(cli): add interactive repl

2026-02-23 03:11:12 +00:00

resource_cli.md

feat(cli): add resource tree and inspect commands

2026-02-20 08:48:33 -05:00

resource_dag.md

Docs: Add resource DAG operational semantics, tool reachability, cross-mechanism coordination, container, and LSP resource type ADRs (036-040)

2026-02-21 19:51:28 -05:00

resource_handlers.md

feat(resource): add handler runtime for git-checkout and fs-directory

2026-02-23 22:20:44 +00:00

resource_type_inheritance.md

fix(resource): address review findings for resource type inheritance

2026-03-10 03:39:32 +00:00

resource_types_builtin.md

Merge branch 'master' into develop-20260217

2026-02-18 03:27:00 +00:00

resources.md

feat(resource): add resource registry and DAG metadata

2026-02-23 22:20:44 +00:00

safety_profile.md

feat(security): add safety profile model and enforcement stubs

2026-03-02 17:44:18 +00:00

safety_profiles.md

feat(security): add safety profile enforcement

2026-03-03 22:21:14 +00:00

sandbox.md

feat(sandbox): add checkpoint and rollback hooks

2026-02-27 23:08:55 +00:00

scoped_backend_view.md

feat(acms): add scoped backend view filtering

2026-03-06 00:49:33 +00:00

secrets_handling.md

feat(security): add secrets masking and validation (H-21/SEC5)

2026-02-19 11:15:18 +00:00

security_eval.md

fix(security): remove eval-based config parsing

2026-02-21 16:32:03 +00:00

semantic_validation_coverage.md

test(validation): add semantic validation suites

2026-03-02 22:05:53 +00:00

semantic_validation.md

feat(validation): add semantic validation service

2026-02-28 17:46:54 +00:00

server_client_stubs.md

feat(interfaces): add server client stubs

2026-03-02 09:47:40 -05:00

session_cli.md

feat(cli): add session commands

2026-02-20 01:10:19 +00:00

session_model.md

test(session): add robot session model smoke tests

2026-02-17 20:33:53 +00:00

skeleton_compressor.md

feat(acms): add skeleton compressor

2026-03-03 03:36:33 +00:00

skill_cli.md

feat(cli): add skill tools and refresh commands

2026-02-26 10:57:07 +00:00

skill_refresh.md

feat(skill): add MCP refresh hooks

2026-02-26 12:29:49 +00:00

skill_registry.md

feat(apply): run validation attachments

2026-02-25 10:03:21 +00:00

skill_resolution.md

test(skill): add robot skill resolver smoke tests

2026-02-17 19:58:15 +00:00

skills_context.md

feat(skill): add skill context and registry

2026-02-20 08:50:08 -05:00

skills_file.md

feat(skill): add file operation skills

2026-02-21 10:18:26 -05:00

skills_git.md

feat(skill): add git operation skills

2026-02-21 16:30:33 +00:00

skills_inline.md

feat(skill): add inline tool executor

2026-02-20 08:50:08 -05:00

skills_protocol.md

feat(skill): add skill protocol and metadata

2026-02-20 08:50:08 -05:00

skills_search.md

feat(skill): add directory and search skills

2026-02-21 10:18:26 -05:00

subplan_service.md

feat(service): add subplan service and spawn workflow

2026-03-02 09:41:25 -05:00

subplans.md

feat(subplan): execute and merge subplans

2026-03-01 09:07:06 +00:00

template_security.md

fix(security): harden template rendering

2026-02-25 10:06:27 +00:00

tool_bindings.md

Docs: Added JINJA2 details to docs

2026-02-20 15:57:21 +00:00

tool_cli.md

feat(cli): add tool and validation commands

2026-02-20 08:49:30 -05:00

tool_model.md

test(tool): add robot tool model smoke tests

2026-02-17 21:14:46 +00:00

tool_router.md

feat(change): add tool router for providers

2026-02-21 10:23:31 -05:00

uko.md

feat(uko): add UKO ontology scaffolding

2026-03-04 22:40:34 +00:00

validation_pipeline.md

feat(validation): add validation pipeline and results model

2026-02-25 10:03:57 +00:00