hurui200320
2005b8ef82
CI / push-validation (push) Successful in 18s
CI / build (push) Successful in 19s
CI / helm (push) Successful in 24s
CI / lint (push) Successful in 29s
CI / security (push) Successful in 1m11s
CI / e2e_tests (push) Successful in 2m56s
CI / quality (push) Successful in 3m40s
CI / typecheck (push) Successful in 3m59s
CI / integration_tests (push) Successful in 4m3s
CI / unit_tests (push) Successful in 4m55s
CI / docker (push) Successful in 10s
CI / coverage (push) Successful in 10m44s
CI / status-check (push) Successful in 1s
CI / benchmark-regression (push) Has been skipped
CI / benchmark-publish (push) Successful in 1h13m28s
## Summary Replaces all 234 bare `@skip` occurrences across 82 Behave feature files with the correct TDD issue-capture tagging system described in CONTRIBUTING.md § Bug Fix Workflow. Previously, the noxfile ran Behave with `--tags=not @skip`, silently excluding all `@skip`-tagged scenarios from every CI run. These tests never ran, never inverted results via the `@tdd_expected_fail` mechanism, and never contributed to coverage — defeating the purpose of TDD issue-capture testing. Every `@skip` occurrence had a commented-out hint line immediately above it showing the intended proper tags (e.g., `# @tdd_issue @tdd_issue_4272 @tdd_expected_fail @skip`), confirming they were all intended for conversion. ## Changes ### Mechanical conversion (234 replacements across 82 files) - Extracted the proper TDD tags from the comment hint above each `@skip` line, removed `@skip` from the tag set, and replaced the `@skip` line with those tags. - Removed the now-redundant comment hint lines alongside each replacement. ### Bug-fixed scenarios — `@tdd_expected_fail` removed (84 scenarios) - After conversion, ran `nox -s unit_tests` to identify which newly-enabled `@tdd_expected_fail` scenarios now **pass** (their referenced bugs have already been fixed). Removed `@tdd_expected_fail` from those 84 scenarios and their corresponding feature-level tags, leaving only the permanent `@tdd_issue @tdd_issue_<N>` regression-guard tags. - Affected features include: `tdd_tool_runner_env_precedence`, `tdd_automation_profile_session_leak`, `tls_certificate_check`, `project_create_persist`, `resource_type_bootstrap_*`, and 18 others. ### Noxfile cleanup - Removed all four `--tags=not @skip` arguments from `noxfile.py` (unit_tests and coverage sessions). With zero `@skip` tags remaining in the codebase, this filter was dead code and its presence would mislead future maintainers into thinking `@skip` is still a supported escape mechanism. ### Regression guard files - Split the regression guards into two focused files: - `tdd_regression_guards_exec_env.feature` for bug #4281 (exec-env precedence) - `tdd_regression_guards_session_list.feature` for bug #4271 (session list summary) - Each file carries only its own `@tdd_issue` tags at the feature level, avoiding cross-contamination via Behave tag inheritance. The `Background` step (`session-list-summary mock`) only appears in the session-list file where it is actually needed. ### Duplicate tag cleanup - Removed duplicate `@tdd_issue @tdd_issue_4287` tag lines in `tdd_skill_add_regression.feature` (lines 20 and 29). ### Inline comment for retained `@tdd_expected_fail` - Added inline comment in `ci_workflow_validation.feature:134` explaining why this specific #4227 scenario retains `@tdd_expected_fail` despite #4227 being closed (CI YAML does not encode threshold as a machine-readable value). ### Known edge cases — `@tdd_expected_fail` retained (closed issues, fix on master, scenarios still fail) The following issues are **closed** and their fixes **are on master**, but the specific test assertions still fail because the fixes address other aspects of the bugs. The `@tdd_expected_fail` tags are functionally correct and must remain until the specific scenario assertions pass: - `tdd_exec_env_resolution_precedence.feature` — bug #1080 (closed 2026-03-31). The precedence-level-2-vs-4 scenario still fails. - `session_list_summary_dedup.feature` — bug #3046 (closed 2026-04-05). The dedup-consistency scenarios still fail. - `actor_add_update_enforcement.feature` — bug #2609 (closed 2026-04-05). The enforcement scenarios still fail. - `ci_workflow_validation.feature:134` — #4227 (closed 2026-04-08). The CI YAML threshold assertion still fails. ## Verification - `grep -r "@skip" features/ --include="*.feature"` → **zero results** ✓ - `grep -n "tags=not @skip" noxfile.py` → **zero results** ✓ - `nox -s unit_tests` → **629 features passed, 0 failed** ✓ (up from ~545 before this PR) - CI all green (coverage ≥ 97%) ✓ - Integration tests (Robot Framework) do not use `@skip` — confirmed no action needed ✓ - E2E tests (Robot Framework) do not use `@skip` — confirmed no action needed ✓ - `CHANGELOG.md` updated with entry for this change ✓ - `CONTRIBUTORS.md` — Rui Hu already listed ✓ ## Issues Addressed Closes #7025 Co-authored-by: CleverThis <hal9000@cleverthis.com> Reviewed-on: #7221 Reviewed-by: HAL 9000 <HAL9000@cleverthis.com> Reviewed-by: HAL9001 <hal9001@cleverthis.com> Co-authored-by: Rui Hu <rui.hu@cleverthis.com> Co-committed-by: Rui Hu <rui.hu@cleverthis.com>
172 lines
7.6 KiB
Gherkin
172 lines
7.6 KiB
Gherkin
Feature: Plan explain and decision tree CLI commands
|
|
Validates the plan explain and plan tree commands including
|
|
formatting, filtering, and flag-controlled detail views.
|
|
|
|
# ------------------------------------------------------------------
|
|
# plan explain - default format
|
|
# ------------------------------------------------------------------
|
|
|
|
Scenario: Explain a decision with default format
|
|
Given a test decision for explain
|
|
When I build the explain dict with default options
|
|
Then the explain dict should contain key "decision_id"
|
|
And the explain dict should contain key "question"
|
|
And the explain dict should contain key "chosen"
|
|
And the explain dict should contain key "type"
|
|
And the explain dict should contain key "alternatives_considered"
|
|
And the explain dict should not contain key "rationale"
|
|
And the explain dict should not contain key "context_snapshot"
|
|
|
|
# ------------------------------------------------------------------
|
|
# plan explain - show-context
|
|
# ------------------------------------------------------------------
|
|
|
|
Scenario: Explain with show-context flag
|
|
Given a test decision with context snapshot for explain
|
|
When I build the explain dict with show-context enabled
|
|
Then the explain dict should contain key "context_snapshot"
|
|
And the context snapshot should contain key "hot_context_hash"
|
|
And the context snapshot should contain key "relevant_resources"
|
|
|
|
# ------------------------------------------------------------------
|
|
# plan explain - show-reasoning
|
|
# ------------------------------------------------------------------
|
|
|
|
Scenario: Explain with show-reasoning flag
|
|
Given a test decision with reasoning for explain
|
|
When I build the explain dict with show-reasoning enabled
|
|
Then the explain dict should contain key "rationale"
|
|
And the explain dict should contain key "actor_reasoning"
|
|
|
|
# ------------------------------------------------------------------
|
|
# plan explain - alternatives always included
|
|
# ------------------------------------------------------------------
|
|
|
|
Scenario: Explain includes alternatives by default
|
|
Given a test decision with alternatives for explain
|
|
When I build the explain dict with default options
|
|
Then the explain dict should contain key "alternatives_considered"
|
|
And the alternatives list should have 2 items
|
|
|
|
# ------------------------------------------------------------------
|
|
# plan explain - json format
|
|
# ------------------------------------------------------------------
|
|
|
|
Scenario: Explain with json format
|
|
Given a test decision for explain
|
|
When I format the explain dict as json
|
|
Then the json output should contain "decision_id"
|
|
And the json output should be valid json
|
|
|
|
# ------------------------------------------------------------------
|
|
# plan explain - yaml format
|
|
# ------------------------------------------------------------------
|
|
|
|
Scenario: Explain with yaml format
|
|
Given a test decision for explain
|
|
When I format the explain dict as yaml
|
|
Then the yaml output should contain "decision_id"
|
|
|
|
# ------------------------------------------------------------------
|
|
# plan explain - non-existent decision
|
|
# ------------------------------------------------------------------
|
|
|
|
Scenario: Explain for non-existent decision returns error marker
|
|
Given a non-existent decision id
|
|
Then the explain lookup should indicate not found
|
|
|
|
# ------------------------------------------------------------------
|
|
# plan tree - default format
|
|
# ------------------------------------------------------------------
|
|
|
|
Scenario: Tree with default format builds tree structure
|
|
Given a set of test decisions forming a tree
|
|
When I build the decision tree with default options
|
|
Then the tree should have at least 1 root node
|
|
And the first root node should have children
|
|
|
|
# ------------------------------------------------------------------
|
|
# plan tree - show-superseded
|
|
# ------------------------------------------------------------------
|
|
|
|
Scenario: Tree with show-superseded includes superseded decisions
|
|
Given a set of test decisions with superseded entries
|
|
When I build the decision tree with show-superseded enabled
|
|
Then the tree should include superseded decision nodes
|
|
|
|
# ------------------------------------------------------------------
|
|
# plan tree - depth limit
|
|
# ------------------------------------------------------------------
|
|
|
|
Scenario: Tree with depth limit restricts tree depth
|
|
Given a set of test decisions forming a deep tree
|
|
When I build the decision tree with depth 1
|
|
Then the root nodes should have no children
|
|
|
|
# ------------------------------------------------------------------
|
|
# plan tree - json format
|
|
# ------------------------------------------------------------------
|
|
|
|
@tdd_issue @tdd_issue_4254 @tdd_expected_fail
|
|
Scenario: Tree with json format
|
|
Given a set of test decisions forming a tree
|
|
When I format the tree as json
|
|
Then the json tree output should be valid json
|
|
And the json tree output should contain "decision_id"
|
|
|
|
# ------------------------------------------------------------------
|
|
# plan tree - yaml format
|
|
# ------------------------------------------------------------------
|
|
|
|
Scenario: Tree with yaml format
|
|
Given a set of test decisions forming a tree
|
|
When I format the tree as yaml
|
|
Then the yaml tree output should contain "decision_id"
|
|
|
|
# ------------------------------------------------------------------
|
|
# plan tree - no decisions
|
|
# ------------------------------------------------------------------
|
|
|
|
Scenario: Tree for plan with no decisions
|
|
Given an empty list of decisions
|
|
When I build the decision tree with default options from empty list
|
|
Then the tree should be empty
|
|
|
|
# ------------------------------------------------------------------
|
|
# plan tree - filters superseded by default
|
|
# ------------------------------------------------------------------
|
|
|
|
Scenario: Tree filters out superseded decisions by default
|
|
Given a set of test decisions with superseded entries
|
|
When I build the decision tree with default options
|
|
Then the tree should not include superseded decision nodes
|
|
|
|
# ------------------------------------------------------------------
|
|
# plan tree - per-type ordinals in decision labels
|
|
# ------------------------------------------------------------------
|
|
|
|
Scenario: Decision labels use per-type ordinals
|
|
Given a set of test decisions with multiple types for ordinal testing
|
|
When I generate decision labels with per-type ordinals
|
|
Then the first invariant should be labeled "Invariant 1"
|
|
And the second invariant should be labeled "Invariant 2"
|
|
And the first strategy should be labeled "Strategy"
|
|
And the first parallel should be labeled "Parallel 1"
|
|
|
|
Scenario: Decision labels restart counting per decision type
|
|
Given a set of test decisions with mixed types
|
|
When I generate decision labels with per-type ordinals
|
|
Then each decision type should start counting from 1
|
|
And invariants should have sequential numbers
|
|
And parallel spawns should have sequential numbers
|
|
And spawn decisions should have sequential numbers
|
|
|
|
Scenario: Full tree output includes per-type ordinal labels
|
|
Given a set of test decisions forming a tree with multiple types
|
|
When I build the plain format tree output with decision labels
|
|
Then the decision tree output should contain "Invariant 1"
|
|
And the decision tree output should contain "Invariant 2"
|
|
And the decision tree output should contain "Strategy"
|
|
And the decision tree output should not contain "Invariant 6"
|
|
And the decision tree output should not contain "Strategy 7"
|