Files
cleveragents-core/robot/legacy_plan_removal.robot
freemo b122ec7ed5
CI / lint (pull_request) Successful in 23s
CI / quality (pull_request) Successful in 51s
CI / typecheck (pull_request) Successful in 1m0s
CI / security (pull_request) Successful in 55s
CI / build (pull_request) Successful in 25s
CI / helm (pull_request) Successful in 32s
CI / push-validation (pull_request) Successful in 26s
CI / e2e_tests (pull_request) Successful in 3m38s
CI / integration_tests (pull_request) Successful in 6m42s
CI / unit_tests (pull_request) Successful in 8m19s
CI / docker (pull_request) Successful in 13s
CI / coverage (pull_request) Successful in 15m23s
CI / status-check (pull_request) Successful in 2s
fix(test-infra): remove redundant ${PYTHON} variable definitions from robot files
Remove the local ${PYTHON}    python (and python3) variable definitions from
the *** Variables *** sections of all affected robot files. These local
definitions were overriding the pabot-injected venv Python path passed via
--variable PYTHON:/path/to/venv/python, causing tests to use the system
Python (which lacks required packages like structlog, sqlalchemy, etc.)
instead of the nox venv Python.

The correct ${PYTHON} value is already set by Setup Test Environment in
common.resource via sys.executable, and pabot passes it via --variable.
The local fallback definitions are redundant and harmful in parallel runs.

Audit found 56 robot files with the pattern (more than the 9 originally
identified in the issue). All occurrences have been removed.

ISSUES CLOSED: #1309
2026-04-14 14:50:55 +00:00

34 lines
1.6 KiB
Plaintext

*** Settings ***
Documentation Verify legacy plan commands emit deprecation warnings.
Library Process
Library OperatingSystem
Variables ${CURDIR}/helper_plan_lifecycle_persistence.py
*** Keywords ***
Run Python Script
[Arguments] ${script} @{extra_args}
${result}= Run Process ${PYTHON} @{extra_args} ${CURDIR}/legacy_plan_removal_helper.py ${script}
... env:PYTHONPATH\=src:. timeout=120s on_timeout=kill
RETURN ${result}
*** Test Cases ***
Legacy Plan Tell Emits Deprecation Warning
[Documentation] Verify that importing and using legacy PlanService triggers a deprecation warning.
${result}= Run Python Script plan_service -W all
Should Contain ${result.stderr} DeprecationWarning
Legacy PlanRepository Emits Deprecation Warning
[Documentation] Verify PlanRepository emits DeprecationWarning on instantiation.
${result}= Run Python Script plan_repository -W all
Should Contain ${result.stderr} DeprecationWarning
Legacy ChangeRepository Emits Deprecation Warning
[Documentation] Verify ChangeRepository emits DeprecationWarning on instantiation.
${result}= Run Python Script change_repository -W all
Should Contain ${result.stderr} DeprecationWarning
V3 Lifecycle Service Does Not Emit Deprecation
[Documentation] Verify PlanLifecycleService does NOT emit DeprecationWarning.
${result}= Run Python Script lifecycle_service -W error::DeprecationWarning
Should Be Equal As Integers ${result.rc} 0