Files
cleveragents-core/robot/google_provider.robot
freemo b122ec7ed5
CI / lint (pull_request) Successful in 23s
CI / quality (pull_request) Successful in 51s
CI / typecheck (pull_request) Successful in 1m0s
CI / security (pull_request) Successful in 55s
CI / build (pull_request) Successful in 25s
CI / helm (pull_request) Successful in 32s
CI / push-validation (pull_request) Successful in 26s
CI / e2e_tests (pull_request) Successful in 3m38s
CI / integration_tests (pull_request) Successful in 6m42s
CI / unit_tests (pull_request) Successful in 8m19s
CI / docker (pull_request) Successful in 13s
CI / coverage (pull_request) Successful in 15m23s
CI / status-check (pull_request) Successful in 2s
fix(test-infra): remove redundant ${PYTHON} variable definitions from robot files
Remove the local ${PYTHON}    python (and python3) variable definitions from
the *** Variables *** sections of all affected robot files. These local
definitions were overriding the pabot-injected venv Python path passed via
--variable PYTHON:/path/to/venv/python, causing tests to use the system
Python (which lacks required packages like structlog, sqlalchemy, etc.)
instead of the nox venv Python.

The correct ${PYTHON} value is already set by Setup Test Environment in
common.resource via sys.executable, and pabot passes it via --variable.
The local fallback definitions are redundant and harmful in parallel runs.

Audit found 56 robot files with the pattern (more than the 9 originally
identified in the issue). All occurrences have been removed.

ISSUES CLOSED: #1309
2026-04-14 14:50:55 +00:00

164 lines
8.2 KiB
Plaintext

*** Settings ***
Resource ${CURDIR}/common.resource
Library Process
Library OperatingSystem
Library Collections
Suite Setup Setup Test Environment
Suite Teardown Cleanup Test Environment
*** Variables ***
${SRC_DIR} ${CURDIR}/..
*** Test Cases ***
Google Provider Generates Changes
${script}= Catenate SEPARATOR=\n
... import sys
... from unittest.mock import MagicMock, patch
... sys.path.insert(0, '${SRC_DIR}/src')
... from cleveragents.providers.llm.google_provider import GoogleChatProvider
... project = MagicMock(name='Project')
... plan = MagicMock(name='Plan')
... plan.prompt = 'Add logging'
... contexts = [MagicMock(name='Context')]
... contexts[0].content = 'ctx'
... chat_patcher = patch('cleveragents.providers.llm.google_provider.ChatGoogleGenerativeAI')
... graph_patcher = patch('cleveragents.providers.llm.langchain_chat_provider.PlanGenerationGraph')
... chat_cls = chat_patcher.start()
... graph_cls = graph_patcher.start()
... chat_instance = MagicMock(name='ChatGoogleGenerativeAIInstance')
... chat_instance.get_num_tokens.return_value = 64
... chat_cls.return_value = chat_instance
... change = {'plan_id': 1, 'file_path': 'robot_google.py', 'operation': 'modify', 'new_content': '# code'}
... graph_instance = MagicMock(name='GraphInstance')
... graph_instance.invoke.return_value = {'generated_changes': [change], 'validation_result': {'status': 'PASS'}, 'error': None}
... graph_cls.return_value = graph_instance
... provider = GoogleChatProvider(api_key='sk-google-robot', model='gemini-2.0-flash')
... response = provider.generate_changes(project, plan, contexts)
... chat_patcher.stop()
... graph_patcher.stop()
... assert len(response.changes) == 1
... assert response.changes[0].file_path == 'robot_google.py'
... assert response.token_count == 64
... print('google-provider-success')
${result}= Run Process ${PYTHON} -c ${script}
Log Process Failure ${result}
Should Be Equal As Integers ${result.rc} 0
Should Contain ${result.stdout} google-provider-success
Google Provider Streams Events
${script}= Catenate SEPARATOR=\n
... import sys
... from unittest.mock import MagicMock, patch
... sys.path.insert(0, '${SRC_DIR}/src')
... from cleveragents.providers.llm.google_provider import GoogleChatProvider
... project = MagicMock(name='Project')
... plan = MagicMock(name='Plan')
... plan.prompt = 'Stream plan'
... contexts = [MagicMock(name='Context')]
... contexts[0].content = 'ctx'
... chat_patcher = patch('cleveragents.providers.llm.google_provider.ChatGoogleGenerativeAI')
... graph_patcher = patch('cleveragents.providers.llm.langchain_chat_provider.PlanGenerationGraph')
... chat_cls = chat_patcher.start()
... graph_cls = graph_patcher.start()
... chat_instance = MagicMock(name='ChatGoogleGenerativeAIInstance')
... chat_instance.get_num_tokens.return_value = 32
... chat_cls.return_value = chat_instance
... graph_instance = MagicMock(name='GraphInstance')
... events = [
... {'load_context': {'status': 'ok'}},
... {'generate_plan': {'generated_changes': [{'plan_id': 1, 'file_path': 'stream_google.py', 'operation': 'modify', 'new_content': '# stream'}]}},
... {'validate': {'validation_result': {'status': 'PASS'}}},
... ]
... graph_instance.stream.side_effect = lambda *_args, **_kwargs: iter(events)
... graph_instance.invoke.return_value = {'generated_changes': [], 'validation_result': {'status': 'PASS'}, 'error': None}
... graph_cls.return_value = graph_instance
... provider = GoogleChatProvider(api_key='sk-google-robot', model='gemini-2.0-flash')
... streamed = list(provider.stream_changes(project, plan, contexts))
... chat_patcher.stop()
... graph_patcher.stop()
... assert streamed[-1]['__end__']['response'].model_used == 'gemini-2.0-flash'
... assert len(streamed[-1]['__end__']['response'].changes) == 1
... print('google-stream-success')
${result}= Run Process ${PYTHON} -c ${script}
Log Process Failure ${result}
Should Be Equal As Integers ${result.rc} 0
Should Contain ${result.stdout} google-stream-success
Google Provider Surfaces Graph Errors
${script}= Catenate SEPARATOR=\n
... import sys
... from unittest.mock import MagicMock, patch
... sys.path.insert(0, '${SRC_DIR}/src')
... from cleveragents.providers.llm.google_provider import GoogleChatProvider
... project = MagicMock(name='Project')
... plan = MagicMock(name='Plan')
... plan.prompt = 'Error plan'
... contexts = [MagicMock(name='Context')]
... contexts[0].content = 'ctx'
... chat_patcher = patch('cleveragents.providers.llm.google_provider.ChatGoogleGenerativeAI')
... graph_patcher = patch('cleveragents.providers.llm.langchain_chat_provider.PlanGenerationGraph')
... chat_cls = chat_patcher.start()
... graph_cls = graph_patcher.start()
... chat_instance = MagicMock(name='ChatGoogleGenerativeAIInstance')
... chat_instance.get_num_tokens.return_value = 0
... chat_cls.return_value = chat_instance
... graph_instance = MagicMock(name='GraphInstance')
... graph_instance.invoke.side_effect = ValueError('graph exploded')
... graph_cls.return_value = graph_instance
... provider = GoogleChatProvider(api_key='sk-google-robot', model='gemini-2.0-flash')
... response = provider.generate_changes(project, plan, contexts)
... chat_patcher.stop()
... graph_patcher.stop()
... assert response.error_message == 'graph exploded'
... assert response.changes == []
... print('google-provider-error')
${result}= Run Process ${PYTHON} -c ${script}
Log Process Failure ${result}
Should Be Equal As Integers ${result.rc} 0
Should Contain ${result.stdout} google-provider-error
Google Provider Reports Runtime Error
${script}= Catenate SEPARATOR=\n
... import sys
... from unittest.mock import MagicMock, patch
... sys.path.insert(0, '${SRC_DIR}/src')
... from cleveragents.providers.llm.google_provider import GoogleChatProvider
... project = MagicMock(name='Project')
... plan = MagicMock(name='Plan')
... plan.prompt = 'Retry plan'
... contexts = [MagicMock(name='Context')]
... contexts[0].content = 'ctx'
... chat_patcher = patch('cleveragents.providers.llm.google_provider.ChatGoogleGenerativeAI')
... graph_patcher = patch('cleveragents.providers.llm.langchain_chat_provider.PlanGenerationGraph')
... chat_cls = chat_patcher.start()
... graph_cls = graph_patcher.start()
... chat_instance = MagicMock(name='ChatGoogleGenerativeAIInstance')
... chat_instance.get_num_tokens.return_value = 0
... chat_cls.return_value = chat_instance
... graph_instance = MagicMock(name='GraphInstance')
... graph_instance.invoke.side_effect = RuntimeError('deadline reached')
... graph_cls.return_value = graph_instance
... provider = GoogleChatProvider(api_key='sk-google-robot', model='gemini-2.0-flash')
... response = provider.generate_changes(project, plan, contexts)
... chat_patcher.stop()
... graph_patcher.stop()
... assert response.error_message == 'deadline reached'
... assert response.changes == []
... print('google-provider-runtime-error')
${result}= Run Process ${PYTHON} -c ${script}
Log Process Failure ${result}
Should Be Equal As Integers ${result.rc} 0
Should Contain ${result.stdout} google-provider-runtime-error
*** Keywords ***
Log Process Failure
[Arguments] ${result}
Run Keyword If ${result.rc} == 0 Return From Keyword
Log To Console Process failed with rc=${result.rc}
Log To Console STDOUT:${\n}${result.stdout}
Log To Console STDERR:${\n}${result.stderr}