freemo
051ee7c290
CI / benchmark-publish (pull_request) Has been skipped
CI / lint (pull_request) Successful in 21s
CI / quality (pull_request) Successful in 31s
CI / typecheck (pull_request) Successful in 47s
CI / security (pull_request) Successful in 52s
CI / build (pull_request) Successful in 56s
CI / e2e_tests (pull_request) Successful in 5m1s
CI / integration_tests (pull_request) Successful in 5m30s
CI / unit_tests (pull_request) Successful in 5m42s
CI / docker (pull_request) Successful in 58s
CI / coverage (pull_request) Successful in 7m35s
CI / build (push) Successful in 21s
CI / docker (push) Has been skipped
CI / benchmark-regression (pull_request) Failing after 49m24s
CI / lint (push) Successful in 22s
CI / quality (push) Successful in 39s
CI / security (push) Successful in 48s
CI / typecheck (push) Successful in 1m26s
CI / benchmark-regression (push) Has been skipped
CI / e2e_tests (push) Successful in 5m53s
CI / coverage (push) Successful in 9m4s
CI / benchmark-publish (push) Successful in 19m10s
CI / integration_tests (push) Failing after 19m18s
CI / unit_tests (push) Failing after 19m20s
Added 52 new .feature files and corresponding _steps.py files targeting previously uncovered code paths in the following areas: - TUI layer: app, commands, persona (state/schema/registry), widgets, input (shell_exec, reference_parser) - Application services: plan lifecycle/service/executor, session, project, repo indexing, correction, checkpoint, actor, llm_actors, strategy coordinator, resource file watcher, service retry wiring - CLI commands: session, resource, repl, plan, db, automation_profile - Domain models: retry_policy, resource_type, cost_budget, docker_compose_analyzer, detail_level, _sql_string_aware, _postgresql_helpers - Core: circuit_breaker, retry_service_patterns - Infrastructure: repositories, transaction_sandbox, strategy_registry, plugins/loader, container - Config: settings - Agents: plan_generation, context_analysis, auto_debug - A2A: facade All new tests follow the Behave/Gherkin BDD standard. Resolved step definition collisions with unique prefixes. Fixed Alembic fileConfig logger disabling issue (disable_existing_loggers=False). ISSUES CLOSED: #1068
52 lines
2.5 KiB
Gherkin
52 lines
2.5 KiB
Gherkin
Feature: Sandbox Strategy Registry Coverage
|
|
Scenarios targeting uncovered lines in strategy_registry.py:
|
|
lines 65-68, 167, 196-200, 205-209.
|
|
|
|
Background:
|
|
Given the sandbox strategy registry module is imported
|
|
|
|
# --- CustomStrategyConfig success (lines 65-68) ---
|
|
|
|
Scenario: CustomStrategyConfig stores valid fields
|
|
When I create a CustomStrategyConfig with name "my_strat" module "pkg.mod" and class "Cls"
|
|
Then the config should have name "my_strat" module "pkg.mod" and class_name "Cls"
|
|
And the config options should default to an empty dict
|
|
|
|
Scenario: CustomStrategyConfig stores explicit options
|
|
When I create a CustomStrategyConfig with name "x" module "a.b" class "C" and options
|
|
Then the config options should contain the provided values
|
|
|
|
# --- register_from_config (line 167) ---
|
|
|
|
Scenario: register_from_config delegates to register and returns the class
|
|
Given a registry with a mock loader that returns a compliant class
|
|
And a CustomStrategyConfig named "cfg_strat" with module "fake.mod" and class "FakeCls"
|
|
When I call register_from_config with that config
|
|
Then the strategy "cfg_strat" should be registered in the registry
|
|
|
|
# --- register_all_from_config skips missing module (lines 196-200) ---
|
|
|
|
Scenario: register_all_from_config skips entry with missing module
|
|
Given a registry with a mock loader that returns a compliant class
|
|
When I call register_all_from_config with an entry that has an empty module
|
|
Then the returned list should not contain the skipped entry name
|
|
And a warning should be logged about the skipped entry
|
|
|
|
Scenario: register_all_from_config skips entry with missing class
|
|
Given a registry with a mock loader that returns a compliant class
|
|
When I call register_all_from_config with an entry that has an empty class
|
|
Then the returned list should not contain the skipped entry name
|
|
|
|
# --- register_all_from_config error handling (lines 205-209) ---
|
|
|
|
Scenario: register_all_from_config catches PluginLoadError and continues
|
|
Given a registry whose loader raises PluginLoadError
|
|
When I call register_all_from_config with an entry that will fail to load
|
|
Then the returned list should be empty
|
|
And an error should be logged about the failed registration
|
|
|
|
Scenario: register_all_from_config catches ProtocolMismatchError and continues
|
|
Given a registry whose loader returns a non-compliant class
|
|
When I call register_all_from_config with an entry that will fail protocol check
|
|
Then the returned list should be empty
|