freemo
02250473ad
Fix all failing CI quality gates (lint, unit_tests, format) without suppressing any quality enforcement. Root causes and fixes: 1. Format: features/steps/plan_namespaced_name_tdd_steps.py had trailing whitespace; fixed by running ruff format. 2. Unit tests - A2A JSON-RPC 2.0 migration (commit9c6d6915) renamed A2aRequest fields (operation→method, request_id→id, a2a_version→jsonrpc) and A2aResponse fields (status+data→result, request_id→id) but did not update all step files and feature files: - a2a_jsonrpc_wire_format_steps.py: added use_step_matcher('re') and reset to 'parse' at end to prevent parallel test interference - a2a_facade_wiring_steps.py: updated operation= to method=, .status/.data to .result - a2a_facade_steps.py: updated request_id→id, a2a_version→jsonrpc, A2aResponse(request_id=..., status=...) to new API - m6_facade_steps.py: updated all old API usage - devcontainer_cleanup_steps.py: updated A2aRequest(operation=...) - plan_prompt_command_steps.py: updated A2aRequest(operation=...) - wf03_plan_prompt_confidence_steps.py: updated A2aRequest(operation=...) - consolidated_misc.feature: updated old A2aRequest/A2aResponse scenarios 3. Unit tests - Session CLI output changed (commit0d5d9cf0and others): - 'Session Created' → 'Session created' (lowercase) - 'Session Details' → 'Session Summary' - 'Sessions (N total)' → 'Sessions' - session list JSON: top-level 'total' → nested 'summary.total' - Fixed in: session_cli.feature, session_cli_coverage_boost.feature, session_cli_uncovered_branches.feature, session_list_error.feature, tdd_session_create_persist_steps.py 4. Unit tests - Plan list output changed (commit1a07a891): - 'V3 Lifecycle Plans' → 'Plans' - 'Lifecycle Plans' → 'Plans' - Name column removed (restored in source) - Invariants column removed (restored in source) - Project truncation removed (restored in source) - Fixed in: plan_cli_cancel_revert_coverage.feature, plan_lifecycle_cli_coverage.feature, plan_cli_coverage_boost_steps.py, plan.py (source code restored) 5. Unit tests - Plan apply command now requires ULID (commit300a5d6d): - plan_cli_coverage_r3.feature: updated 'PLAN-001' to valid ULID - plan_cli_coverage_r3_steps.py: added --yes flag, added new step for no-eligible-plans path 6. Unit tests - Various source code bugs: - ThoughtBlock: converted from @dataclass to Pydantic BaseModel (architecture test requires all dataclasses to use Pydantic) - session.py: added DatabaseError handling to export, import, tell commands - database.py: fixed rollback_to() to reuse checkpoint connection for writes - database.py: added _get_checkpoint_conn() helper - check-tls-cert.py: fixed SSLCertVerificationError.reason AttributeError 7. Unit tests - Test step bugs: - error_recovery_coverage_boost_steps.py: fixed invalid ULID _PLAN_ID - session_service_coverage_steps.py: fixed 'sha256:' prefix bug in checksum - database_models_new_coverage_steps.py: added 'name' field to session mock - async_audit_recording_steps.py: fixed Settings(audit_async=False) via env var - coverage_threshold_config_steps.py: added --coverage-min pattern support - m5_acms_smoke_steps.py: updated usage hint text - actor_cli_yaml_steps.py: updated 'Removed actor' → 'Actor removed' - aimodelscredentials_steps.py: set context.imported_class in import step - domain_base_model.feature: added missing 'When I examine model_config' step - tui_first_run_steps.py: fixed module reload to restore cleveragents.tui.* modules after test (prevented patch interference in subsequent tests) - tui_first_run_steps.py: added set_search('') step for empty string - resource_handler_base_coverage_r3_steps.py: use _MinimalHandler instead of DatabaseResourceHandler for NotImplementedError tests - resource_handler_crud.feature: updated to test new DatabaseHandler behavior - resource_handler_sandbox.feature: updated to test new DatabaseHandler behavior - tdd_json_decode_crash_persistence.feature: fixed @tdd_bug → @tdd_issue tags 8. Parallel test interference: - All step files using use_step_matcher('re') now reset to 'parse' at end to prevent global matcher state leaking to subsequent step files
82 lines
4.2 KiB
Gherkin
82 lines
4.2 KiB
Gherkin
Feature: Resource handler sandbox and checkpoint operations
|
|
Tests for create_sandbox (idempotent), create_checkpoint, rollback_to,
|
|
and project_access methods on GitCheckoutHandler, FsDirectoryHandler,
|
|
and base handler NotImplementedError defaults.
|
|
|
|
Issue #836: ResourceHandler sandbox and checkpoint methods.
|
|
|
|
# ============================================================
|
|
# FsDirectory sandbox lifecycle
|
|
# ============================================================
|
|
|
|
Scenario: FsDirectory handler create_sandbox provisions a copy-on-write sandbox
|
|
Given rh836- a temp directory with file "data.txt" containing "original"
|
|
And rh836- an fs-directory resource and sandbox manager
|
|
When rh836- I call create_sandbox on the fs-directory handler
|
|
Then rh836- the sandbox result should be created
|
|
And rh836- the sandbox result path should exist
|
|
|
|
Scenario: FsDirectory handler create_sandbox is idempotent
|
|
Given rh836- a temp directory with file "data.txt" containing "original"
|
|
And rh836- an fs-directory resource and sandbox manager
|
|
When rh836- I call create_sandbox on the fs-directory handler
|
|
And rh836- I call create_sandbox on the fs-directory handler again
|
|
Then rh836- the second sandbox result should not be created
|
|
And rh836- both sandbox results should have the same sandbox_id
|
|
|
|
Scenario: FsDirectory handler checkpoint and rollback cycle
|
|
Given rh836- a temp directory with file "data.txt" containing "original"
|
|
And rh836- an fs-directory resource and sandbox manager
|
|
When rh836- I call create_sandbox on the fs-directory handler
|
|
And rh836- I create a checkpoint on the fs-directory handler
|
|
And rh836- I modify the sandbox file "data.txt" to "modified"
|
|
And rh836- I rollback the fs-directory handler to the checkpoint
|
|
Then rh836- the rollback result should be successful
|
|
And rh836- the sandbox file "data.txt" should contain "original"
|
|
|
|
# ============================================================
|
|
# GitCheckout sandbox lifecycle
|
|
# ============================================================
|
|
|
|
Scenario: GitCheckout handler create_sandbox provisions a git worktree sandbox
|
|
Given rh836- a temp git repo with file "code.py" containing "# hello"
|
|
And rh836- a git-checkout resource and sandbox manager
|
|
When rh836- I call create_sandbox on the git-checkout handler
|
|
Then rh836- the sandbox result should be created
|
|
And rh836- the sandbox result path should exist
|
|
|
|
Scenario: GitCheckout handler checkpoint and rollback cycle
|
|
Given rh836- a temp git repo with file "code.py" containing "# hello"
|
|
And rh836- a git-checkout resource and sandbox manager
|
|
When rh836- I call create_sandbox on the git-checkout handler
|
|
And rh836- I create a checkpoint on the git-checkout handler
|
|
And rh836- I modify the sandbox file "code.py" to "# changed"
|
|
And rh836- I rollback the git-checkout handler to the checkpoint
|
|
Then rh836- the rollback result should be successful
|
|
And rh836- the sandbox file "code.py" should contain "# hello"
|
|
|
|
# ============================================================
|
|
# Project access
|
|
# ============================================================
|
|
|
|
Scenario: FsDirectory handler project_access returns permitted in local mode
|
|
Given rh836- a temp directory with file "data.txt" containing "test"
|
|
And rh836- an fs-directory resource and sandbox manager
|
|
When rh836- I check project_access for principal "agent-1" action "write"
|
|
Then rh836- the access result should be permitted
|
|
And rh836- the access result reason should contain "local mode"
|
|
|
|
# ============================================================
|
|
# Base handler NotImplementedError defaults
|
|
# ============================================================
|
|
|
|
Scenario: Database handler create_checkpoint returns a result
|
|
Given rh836- a database handler and dummy resource
|
|
When rh836- I call create_checkpoint on the database handler
|
|
Then rh836- a checkpoint result should be returned without error
|
|
|
|
Scenario: Database handler rollback_to returns a result
|
|
Given rh836- a database handler and dummy resource
|
|
When rh836- I call rollback_to on the database handler
|
|
Then rh836- a rollback result should be returned without error
|