HAL9000
63241f1859
Workers were systematically omitting CHANGELOG.md, CONTRIBUTORS.md, and commit footer (ISSUES CLOSED: #N), causing all PRs to be blocked from merge. Added a mandatory 8-item PR Compliance Checklist to the worker prompt body in implementation-supervisor.md that supervisors must pass to every worker. The checklist covers: 1. CHANGELOG.md update under [Unreleased] 2. CONTRIBUTORS.md update 3. Commit footer with ISSUES CLOSED: #N 4. CI verification (all quality gates green) 5. BDD/Behave test coverage 6. Epic reference in PR description 7. Labels applied via forgejo-label-manager 8. Milestone assignment Also removed @tdd_expected_fail tag from PlanContextInheritance test in depth_breadth_projection.feature (bug #4198 is fixed). Added BDD tests in features/pr_compliance_checklist.feature with 10 scenarios covering all 8 checklist items. ISSUES CLOSED: #9824
59 lines
2.9 KiB
Gherkin
59 lines
2.9 KiB
Gherkin
@mock_only
|
|
Feature: PR Compliance Checklist in Implementation Supervisor
|
|
|
|
As an implementation supervisor
|
|
I want to pass a mandatory PR compliance checklist to every worker prompt
|
|
So that workers complete all required items before creating a PR and avoid systemic merge blockers
|
|
|
|
Background:
|
|
Given the implementation-supervisor.md agent definition exists
|
|
|
|
Scenario: Supervisor worker prompt includes the PR compliance checklist
|
|
When I read the implementation supervisor agent definition
|
|
Then the worker prompt body includes the PR compliance checklist section
|
|
And the checklist is marked as MANDATORY
|
|
|
|
Scenario: Checklist item 1 — CHANGELOG.md update required
|
|
When I read the implementation supervisor agent definition
|
|
Then the worker prompt body includes a CHANGELOG.md checklist item
|
|
And the item instructs workers to add an entry under the Unreleased section
|
|
|
|
Scenario: Checklist item 2 — CONTRIBUTORS.md update required
|
|
When I read the implementation supervisor agent definition
|
|
Then the worker prompt body includes a CONTRIBUTORS.md checklist item
|
|
And the item instructs workers to add or update their contribution entry
|
|
|
|
Scenario: Checklist item 3 — commit footer required
|
|
When I read the implementation supervisor agent definition
|
|
Then the worker prompt body includes a commit footer checklist item
|
|
And the item specifies the ISSUES CLOSED footer format
|
|
|
|
Scenario: Checklist item 4 — CI must pass before PR creation
|
|
When I read the implementation supervisor agent definition
|
|
Then the worker prompt body includes a CI passes checklist item
|
|
And the item instructs workers to verify all quality gates are green
|
|
|
|
Scenario: Checklist item 5 — BDD/Behave tests required
|
|
When I read the implementation supervisor agent definition
|
|
Then the worker prompt body includes a BDD tests checklist item
|
|
And the item instructs workers to add or update Behave feature files
|
|
|
|
Scenario: Checklist item 6 — Epic reference required in PR description
|
|
When I read the implementation supervisor agent definition
|
|
Then the worker prompt body includes an Epic reference checklist item
|
|
And the item instructs workers to reference the parent Epic issue number
|
|
|
|
Scenario: Checklist item 7 — Labels must be applied
|
|
When I read the implementation supervisor agent definition
|
|
Then the worker prompt body includes a labels checklist item
|
|
And the item instructs workers to apply labels via forgejo-label-manager
|
|
|
|
Scenario: Checklist item 8 — Milestone must be assigned
|
|
When I read the implementation supervisor agent definition
|
|
Then the worker prompt body includes a milestone checklist item
|
|
And the item instructs workers to assign the earliest open milestone
|
|
|
|
Scenario: All 8 checklist items are present in the worker prompt
|
|
When I read the implementation supervisor agent definition
|
|
Then the worker prompt body contains all 8 mandatory checklist items
|