freemo
02250473ad
Fix all failing CI quality gates (lint, unit_tests, format) without suppressing any quality enforcement. Root causes and fixes: 1. Format: features/steps/plan_namespaced_name_tdd_steps.py had trailing whitespace; fixed by running ruff format. 2. Unit tests - A2A JSON-RPC 2.0 migration (commit9c6d6915) renamed A2aRequest fields (operation→method, request_id→id, a2a_version→jsonrpc) and A2aResponse fields (status+data→result, request_id→id) but did not update all step files and feature files: - a2a_jsonrpc_wire_format_steps.py: added use_step_matcher('re') and reset to 'parse' at end to prevent parallel test interference - a2a_facade_wiring_steps.py: updated operation= to method=, .status/.data to .result - a2a_facade_steps.py: updated request_id→id, a2a_version→jsonrpc, A2aResponse(request_id=..., status=...) to new API - m6_facade_steps.py: updated all old API usage - devcontainer_cleanup_steps.py: updated A2aRequest(operation=...) - plan_prompt_command_steps.py: updated A2aRequest(operation=...) - wf03_plan_prompt_confidence_steps.py: updated A2aRequest(operation=...) - consolidated_misc.feature: updated old A2aRequest/A2aResponse scenarios 3. Unit tests - Session CLI output changed (commit0d5d9cf0and others): - 'Session Created' → 'Session created' (lowercase) - 'Session Details' → 'Session Summary' - 'Sessions (N total)' → 'Sessions' - session list JSON: top-level 'total' → nested 'summary.total' - Fixed in: session_cli.feature, session_cli_coverage_boost.feature, session_cli_uncovered_branches.feature, session_list_error.feature, tdd_session_create_persist_steps.py 4. Unit tests - Plan list output changed (commit1a07a891): - 'V3 Lifecycle Plans' → 'Plans' - 'Lifecycle Plans' → 'Plans' - Name column removed (restored in source) - Invariants column removed (restored in source) - Project truncation removed (restored in source) - Fixed in: plan_cli_cancel_revert_coverage.feature, plan_lifecycle_cli_coverage.feature, plan_cli_coverage_boost_steps.py, plan.py (source code restored) 5. Unit tests - Plan apply command now requires ULID (commit300a5d6d): - plan_cli_coverage_r3.feature: updated 'PLAN-001' to valid ULID - plan_cli_coverage_r3_steps.py: added --yes flag, added new step for no-eligible-plans path 6. Unit tests - Various source code bugs: - ThoughtBlock: converted from @dataclass to Pydantic BaseModel (architecture test requires all dataclasses to use Pydantic) - session.py: added DatabaseError handling to export, import, tell commands - database.py: fixed rollback_to() to reuse checkpoint connection for writes - database.py: added _get_checkpoint_conn() helper - check-tls-cert.py: fixed SSLCertVerificationError.reason AttributeError 7. Unit tests - Test step bugs: - error_recovery_coverage_boost_steps.py: fixed invalid ULID _PLAN_ID - session_service_coverage_steps.py: fixed 'sha256:' prefix bug in checksum - database_models_new_coverage_steps.py: added 'name' field to session mock - async_audit_recording_steps.py: fixed Settings(audit_async=False) via env var - coverage_threshold_config_steps.py: added --coverage-min pattern support - m5_acms_smoke_steps.py: updated usage hint text - actor_cli_yaml_steps.py: updated 'Removed actor' → 'Actor removed' - aimodelscredentials_steps.py: set context.imported_class in import step - domain_base_model.feature: added missing 'When I examine model_config' step - tui_first_run_steps.py: fixed module reload to restore cleveragents.tui.* modules after test (prevented patch interference in subsequent tests) - tui_first_run_steps.py: added set_search('') step for empty string - resource_handler_base_coverage_r3_steps.py: use _MinimalHandler instead of DatabaseResourceHandler for NotImplementedError tests - resource_handler_crud.feature: updated to test new DatabaseHandler behavior - resource_handler_sandbox.feature: updated to test new DatabaseHandler behavior - tdd_json_decode_crash_persistence.feature: fixed @tdd_bug → @tdd_issue tags 8. Parallel test interference: - All step files using use_step_matcher('re') now reset to 'parse' at end to prevent global matcher state leaking to subsequent step files
92 lines
4.6 KiB
Gherkin
92 lines
4.6 KiB
Gherkin
Feature: Plan CLI cancel, revert, and list rich coverage
|
|
As a developer
|
|
I want to exercise the uncovered cancel_plan, revert_plan,
|
|
and list_plans rich table rendering paths
|
|
So that coverage for plan.py lines 1817, 1821-1822, 1845-1855, 1878-1888 is achieved
|
|
|
|
Background:
|
|
Given a CLI runner for cancel-revert coverage
|
|
And a mocked lifecycle service for cancel-revert coverage
|
|
|
|
# ---------- list rich table rendering (lines 1817, 1820-1822) ----------
|
|
|
|
Scenario: list in rich format renders created_at timestamp
|
|
Given the service returns plans with project links and timestamps for rich list
|
|
When I invoke list in rich format for cancel-revert coverage
|
|
Then the cancel-revert command should succeed
|
|
And the cancel-revert output should contain "Plans"
|
|
|
|
Scenario: list in rich format renders automation profile column
|
|
Given the service returns plans with an automation profile for rich list
|
|
When I invoke list in rich format for cancel-revert coverage
|
|
Then the cancel-revert command should succeed
|
|
And the cancel-revert output should contain "Plans"
|
|
|
|
Scenario: list in rich format renders multiple project links
|
|
Given the service returns a plan with three project links for rich list
|
|
When I invoke list in rich format for cancel-revert coverage
|
|
Then the cancel-revert command should succeed
|
|
And the cancel-revert output should contain "more"
|
|
|
|
Scenario: list in rich format renders invariant count
|
|
Given the service returns plans with invariants for rich list
|
|
When I invoke list in rich format for cancel-revert coverage
|
|
Then the cancel-revert command should succeed
|
|
|
|
# ---------- cancel_plan (lines 1845-1855) ----------
|
|
|
|
Scenario: cancel_plan succeeds in rich format without reason
|
|
Given the service can cancel a plan for cancel-revert coverage
|
|
When I invoke cancel in rich format without reason for cancel-revert coverage
|
|
Then the cancel-revert command should succeed
|
|
And the cancel-revert output should contain "Plan cancelled"
|
|
|
|
Scenario: cancel_plan succeeds in rich format with reason
|
|
Given the service can cancel a plan for cancel-revert coverage
|
|
When I invoke cancel in rich format with reason "no longer needed" for cancel-revert coverage
|
|
Then the cancel-revert command should succeed
|
|
And the cancel-revert output should contain "Plan cancelled"
|
|
And the cancel-revert output should contain "no longer needed"
|
|
|
|
Scenario: cancel_plan succeeds in JSON format without reason
|
|
Given the service can cancel a plan for cancel-revert coverage
|
|
When I invoke cancel with format "json" and no reason for cancel-revert coverage
|
|
Then the cancel-revert command should succeed
|
|
And the cancel-revert output should contain "plan_id"
|
|
And the cancel-revert output should not contain "cancel_reason"
|
|
|
|
Scenario: cancel_plan succeeds in JSON format with reason
|
|
Given the service can cancel a plan for cancel-revert coverage
|
|
When I invoke cancel with format "json" and reason "obsolete" for cancel-revert coverage
|
|
Then the cancel-revert command should succeed
|
|
And the cancel-revert output should contain "cancel_reason"
|
|
And the cancel-revert output should contain "obsolete"
|
|
|
|
# ---------- revert_plan (lines 1878-1888) ----------
|
|
|
|
Scenario: revert_plan succeeds in rich format with default phase
|
|
Given the service can revert a plan for cancel-revert coverage
|
|
When I invoke revert in rich format with default phase for cancel-revert coverage
|
|
Then the cancel-revert command should succeed
|
|
And the cancel-revert output should contain "Plan Reverted"
|
|
And the cancel-revert output should contain "Reversion count"
|
|
|
|
Scenario: revert_plan succeeds in rich format with reason
|
|
Given the service can revert a plan for cancel-revert coverage
|
|
When I invoke revert in rich format with reason "constraints too strict" for cancel-revert coverage
|
|
Then the cancel-revert command should succeed
|
|
And the cancel-revert output should contain "Plan Reverted"
|
|
|
|
Scenario: revert_plan succeeds in JSON format
|
|
Given the service can revert a plan for cancel-revert coverage
|
|
When I invoke revert with format "json" for cancel-revert coverage
|
|
Then the cancel-revert command should succeed
|
|
And the cancel-revert output should contain "plan_id"
|
|
And the cancel-revert output should contain "reversion_reason"
|
|
|
|
Scenario: revert_plan rejects invalid phase
|
|
Given the service can revert a plan for cancel-revert coverage
|
|
When I invoke revert with invalid phase "bogus" for cancel-revert coverage
|
|
Then the cancel-revert command should abort
|
|
And the cancel-revert output should contain "Invalid phase"
|