freemo
02250473ad
Fix all failing CI quality gates (lint, unit_tests, format) without suppressing any quality enforcement. Root causes and fixes: 1. Format: features/steps/plan_namespaced_name_tdd_steps.py had trailing whitespace; fixed by running ruff format. 2. Unit tests - A2A JSON-RPC 2.0 migration (commit9c6d6915) renamed A2aRequest fields (operation→method, request_id→id, a2a_version→jsonrpc) and A2aResponse fields (status+data→result, request_id→id) but did not update all step files and feature files: - a2a_jsonrpc_wire_format_steps.py: added use_step_matcher('re') and reset to 'parse' at end to prevent parallel test interference - a2a_facade_wiring_steps.py: updated operation= to method=, .status/.data to .result - a2a_facade_steps.py: updated request_id→id, a2a_version→jsonrpc, A2aResponse(request_id=..., status=...) to new API - m6_facade_steps.py: updated all old API usage - devcontainer_cleanup_steps.py: updated A2aRequest(operation=...) - plan_prompt_command_steps.py: updated A2aRequest(operation=...) - wf03_plan_prompt_confidence_steps.py: updated A2aRequest(operation=...) - consolidated_misc.feature: updated old A2aRequest/A2aResponse scenarios 3. Unit tests - Session CLI output changed (commit0d5d9cf0and others): - 'Session Created' → 'Session created' (lowercase) - 'Session Details' → 'Session Summary' - 'Sessions (N total)' → 'Sessions' - session list JSON: top-level 'total' → nested 'summary.total' - Fixed in: session_cli.feature, session_cli_coverage_boost.feature, session_cli_uncovered_branches.feature, session_list_error.feature, tdd_session_create_persist_steps.py 4. Unit tests - Plan list output changed (commit1a07a891): - 'V3 Lifecycle Plans' → 'Plans' - 'Lifecycle Plans' → 'Plans' - Name column removed (restored in source) - Invariants column removed (restored in source) - Project truncation removed (restored in source) - Fixed in: plan_cli_cancel_revert_coverage.feature, plan_lifecycle_cli_coverage.feature, plan_cli_coverage_boost_steps.py, plan.py (source code restored) 5. Unit tests - Plan apply command now requires ULID (commit300a5d6d): - plan_cli_coverage_r3.feature: updated 'PLAN-001' to valid ULID - plan_cli_coverage_r3_steps.py: added --yes flag, added new step for no-eligible-plans path 6. Unit tests - Various source code bugs: - ThoughtBlock: converted from @dataclass to Pydantic BaseModel (architecture test requires all dataclasses to use Pydantic) - session.py: added DatabaseError handling to export, import, tell commands - database.py: fixed rollback_to() to reuse checkpoint connection for writes - database.py: added _get_checkpoint_conn() helper - check-tls-cert.py: fixed SSLCertVerificationError.reason AttributeError 7. Unit tests - Test step bugs: - error_recovery_coverage_boost_steps.py: fixed invalid ULID _PLAN_ID - session_service_coverage_steps.py: fixed 'sha256:' prefix bug in checksum - database_models_new_coverage_steps.py: added 'name' field to session mock - async_audit_recording_steps.py: fixed Settings(audit_async=False) via env var - coverage_threshold_config_steps.py: added --coverage-min pattern support - m5_acms_smoke_steps.py: updated usage hint text - actor_cli_yaml_steps.py: updated 'Removed actor' → 'Actor removed' - aimodelscredentials_steps.py: set context.imported_class in import step - domain_base_model.feature: added missing 'When I examine model_config' step - tui_first_run_steps.py: fixed module reload to restore cleveragents.tui.* modules after test (prevented patch interference in subsequent tests) - tui_first_run_steps.py: added set_search('') step for empty string - resource_handler_base_coverage_r3_steps.py: use _MinimalHandler instead of DatabaseResourceHandler for NotImplementedError tests - resource_handler_crud.feature: updated to test new DatabaseHandler behavior - resource_handler_sandbox.feature: updated to test new DatabaseHandler behavior - tdd_json_decode_crash_persistence.feature: fixed @tdd_bug → @tdd_issue tags 8. Parallel test interference: - All step files using use_step_matcher('re') now reset to 'parse' at end to prevent global matcher state leaking to subsequent step files
140 lines
6.8 KiB
Gherkin
140 lines
6.8 KiB
Gherkin
Feature: DomainBaseModel shared configuration
|
|
As a developer working on the domain layer
|
|
I want all domain models to inherit from DomainBaseModel
|
|
So that the shared model_config is defined in exactly one place
|
|
|
|
Scenario: DomainBaseModel is importable from the domain models package
|
|
Given the cleveragents package is available
|
|
When I import DomainBaseModel from the domain models base module
|
|
Then the DomainBaseModel class should be available
|
|
And DomainBaseModel should be a subclass of pydantic BaseModel
|
|
|
|
Scenario: DomainBaseModel carries the expected model_config
|
|
Given the cleveragents package is available
|
|
When I inspect the DomainBaseModel model_config
|
|
Then the DomainBaseModel str_strip_whitespace should be True
|
|
And the DomainBaseModel validate_assignment should be True
|
|
And the DomainBaseModel arbitrary_types_allowed should be False
|
|
And the DomainBaseModel populate_by_name should be True
|
|
And the DomainBaseModel use_enum_values should be True
|
|
|
|
Scenario: ModelProviderOption inherits from DomainBaseModel
|
|
Given the cleveragents package is available
|
|
When I import ModelProviderOption from aimodelscredentials
|
|
Then ModelProviderOption should be a subclass of DomainBaseModel
|
|
And the ModelProviderOption model_config should match DomainBaseModel
|
|
|
|
Scenario: ModelError inherits from DomainBaseModel
|
|
Given the cleveragents package is available
|
|
When I import ModelError from aimodelserrors
|
|
Then ModelError should be a subclass of DomainBaseModel
|
|
And the ModelError model_config should match DomainBaseModel
|
|
|
|
Scenario: FallbackResult inherits from DomainBaseModel
|
|
Given the cleveragents package is available
|
|
When I import FallbackResult from aimodelserrors
|
|
Then FallbackResult should be a subclass of DomainBaseModel
|
|
And the FallbackResult model_config should match DomainBaseModel
|
|
|
|
Scenario: ModelProviderExtraAuthVars inherits from DomainBaseModel
|
|
Given the cleveragents package is available
|
|
When I import ModelProviderExtraAuthVars from aimodelsproviders
|
|
Then ModelProviderExtraAuthVars should be a subclass of DomainBaseModel
|
|
And the ModelProviderExtraAuthVars model_config should match DomainBaseModel
|
|
|
|
Scenario: ModelProviderConfigSchema inherits from DomainBaseModel
|
|
Given the cleveragents package is available
|
|
When I import ModelProviderConfigSchema from aimodelsproviders
|
|
Then ModelProviderConfigSchema should be a subclass of DomainBaseModel
|
|
And the ModelProviderConfigSchema model_config should match DomainBaseModel
|
|
|
|
Scenario: AuthHeader inherits from DomainBaseModel
|
|
Given the cleveragents package is available
|
|
When I import AuthHeader from auth
|
|
Then AuthHeader should be a subclass of DomainBaseModel
|
|
And the AuthHeader model_config should match DomainBaseModel
|
|
|
|
Scenario: TrialPlansExceededError inherits from DomainBaseModel
|
|
Given the cleveragents package is available
|
|
When I import TrialPlansExceededError from auth
|
|
Then TrialPlansExceededError should be a subclass of DomainBaseModel
|
|
And the TrialPlansExceededError model_config should match DomainBaseModel
|
|
|
|
Scenario: TrialMessagesExceededError inherits from DomainBaseModel
|
|
Given the cleveragents package is available
|
|
When I import TrialMessagesExceededError from auth
|
|
Then TrialMessagesExceededError should be a subclass of DomainBaseModel
|
|
And the TrialMessagesExceededError model_config should match DomainBaseModel
|
|
|
|
Scenario: BillingError inherits from DomainBaseModel
|
|
Given the cleveragents package is available
|
|
When I import BillingError from auth
|
|
Then BillingError should be a subclass of DomainBaseModel
|
|
And the BillingError model_config should match DomainBaseModel
|
|
|
|
Scenario: ApiError inherits from DomainBaseModel
|
|
Given the cleveragents package is available
|
|
When I import ApiError from auth
|
|
Then ApiError should be a subclass of DomainBaseModel
|
|
And the ApiError model_config should match DomainBaseModel
|
|
|
|
Scenario: ClientAccount inherits from DomainBaseModel
|
|
Given the cleveragents package is available
|
|
When I import ClientAccount from auth
|
|
Then ClientAccount should be a subclass of DomainBaseModel
|
|
And the ClientAccount model_config should match DomainBaseModel
|
|
|
|
Scenario: ClientAuth inherits from DomainBaseModel
|
|
Given the cleveragents package is available
|
|
When I import ClientAuth from auth
|
|
Then ClientAuth should be a subclass of DomainBaseModel
|
|
And the ClientAuth model_config should match DomainBaseModel
|
|
|
|
Scenario: PlanConfig inherits from DomainBaseModel
|
|
Given the cleveragents package is available
|
|
When I import PlanConfig from planconfig
|
|
Then PlanConfig should be a subclass of DomainBaseModel
|
|
And the PlanConfig model_config should match DomainBaseModel
|
|
|
|
Scenario: ConfigSetting inherits from DomainBaseModel
|
|
Given the cleveragents package is available
|
|
When I import ConfigSetting from planconfig
|
|
Then ConfigSetting should be a subclass of DomainBaseModel
|
|
And the ConfigSetting model_config should match DomainBaseModel
|
|
|
|
Scenario: DomainBaseModel config is applied to ModelProviderOption instances
|
|
Given the cleveragents package is available
|
|
When I create a ModelProviderOption with only priority set to 1
|
|
Then the ModelProviderOption should have priority 1
|
|
When I examine the ModelProviderOption model_config
|
|
Then the ModelProviderOption str_strip_whitespace should be True
|
|
And the ModelProviderOption validate_assignment should be True
|
|
And the ModelProviderOption arbitrary_types_allowed should be False
|
|
And the ModelProviderOption populate_by_name should be True
|
|
And the ModelProviderOption use_enum_values should be True
|
|
|
|
Scenario: No inline model_config duplication in aimodelscredentials
|
|
Given the cleveragents package is available
|
|
When I inspect the ModelProviderOption class definition
|
|
Then ModelProviderOption should not define its own model_config
|
|
|
|
Scenario: No inline model_config duplication in aimodelserrors
|
|
Given the cleveragents package is available
|
|
When I inspect the ModelError class definition
|
|
Then ModelError should not define its own model_config
|
|
|
|
Scenario: No inline model_config duplication in aimodelsproviders
|
|
Given the cleveragents package is available
|
|
When I inspect the ModelProviderConfigSchema class definition
|
|
Then ModelProviderConfigSchema should not define its own model_config
|
|
|
|
Scenario: No inline model_config duplication in auth
|
|
Given the cleveragents package is available
|
|
When I inspect the AuthHeader class definition
|
|
Then AuthHeader should not define its own model_config
|
|
|
|
Scenario: No inline model_config duplication in planconfig
|
|
Given the cleveragents package is available
|
|
When I inspect the PlanConfig class definition
|
|
Then PlanConfig should not define its own model_config
|