hurui200320
2005b8ef82
CI / push-validation (push) Successful in 18s
CI / build (push) Successful in 19s
CI / helm (push) Successful in 24s
CI / lint (push) Successful in 29s
CI / security (push) Successful in 1m11s
CI / e2e_tests (push) Successful in 2m56s
CI / quality (push) Successful in 3m40s
CI / typecheck (push) Successful in 3m59s
CI / integration_tests (push) Successful in 4m3s
CI / unit_tests (push) Successful in 4m55s
CI / docker (push) Successful in 10s
CI / coverage (push) Successful in 10m44s
CI / status-check (push) Successful in 1s
CI / benchmark-regression (push) Has been skipped
CI / benchmark-publish (push) Successful in 1h13m28s
## Summary Replaces all 234 bare `@skip` occurrences across 82 Behave feature files with the correct TDD issue-capture tagging system described in CONTRIBUTING.md § Bug Fix Workflow. Previously, the noxfile ran Behave with `--tags=not @skip`, silently excluding all `@skip`-tagged scenarios from every CI run. These tests never ran, never inverted results via the `@tdd_expected_fail` mechanism, and never contributed to coverage — defeating the purpose of TDD issue-capture testing. Every `@skip` occurrence had a commented-out hint line immediately above it showing the intended proper tags (e.g., `# @tdd_issue @tdd_issue_4272 @tdd_expected_fail @skip`), confirming they were all intended for conversion. ## Changes ### Mechanical conversion (234 replacements across 82 files) - Extracted the proper TDD tags from the comment hint above each `@skip` line, removed `@skip` from the tag set, and replaced the `@skip` line with those tags. - Removed the now-redundant comment hint lines alongside each replacement. ### Bug-fixed scenarios — `@tdd_expected_fail` removed (84 scenarios) - After conversion, ran `nox -s unit_tests` to identify which newly-enabled `@tdd_expected_fail` scenarios now **pass** (their referenced bugs have already been fixed). Removed `@tdd_expected_fail` from those 84 scenarios and their corresponding feature-level tags, leaving only the permanent `@tdd_issue @tdd_issue_<N>` regression-guard tags. - Affected features include: `tdd_tool_runner_env_precedence`, `tdd_automation_profile_session_leak`, `tls_certificate_check`, `project_create_persist`, `resource_type_bootstrap_*`, and 18 others. ### Noxfile cleanup - Removed all four `--tags=not @skip` arguments from `noxfile.py` (unit_tests and coverage sessions). With zero `@skip` tags remaining in the codebase, this filter was dead code and its presence would mislead future maintainers into thinking `@skip` is still a supported escape mechanism. ### Regression guard files - Split the regression guards into two focused files: - `tdd_regression_guards_exec_env.feature` for bug #4281 (exec-env precedence) - `tdd_regression_guards_session_list.feature` for bug #4271 (session list summary) - Each file carries only its own `@tdd_issue` tags at the feature level, avoiding cross-contamination via Behave tag inheritance. The `Background` step (`session-list-summary mock`) only appears in the session-list file where it is actually needed. ### Duplicate tag cleanup - Removed duplicate `@tdd_issue @tdd_issue_4287` tag lines in `tdd_skill_add_regression.feature` (lines 20 and 29). ### Inline comment for retained `@tdd_expected_fail` - Added inline comment in `ci_workflow_validation.feature:134` explaining why this specific #4227 scenario retains `@tdd_expected_fail` despite #4227 being closed (CI YAML does not encode threshold as a machine-readable value). ### Known edge cases — `@tdd_expected_fail` retained (closed issues, fix on master, scenarios still fail) The following issues are **closed** and their fixes **are on master**, but the specific test assertions still fail because the fixes address other aspects of the bugs. The `@tdd_expected_fail` tags are functionally correct and must remain until the specific scenario assertions pass: - `tdd_exec_env_resolution_precedence.feature` — bug #1080 (closed 2026-03-31). The precedence-level-2-vs-4 scenario still fails. - `session_list_summary_dedup.feature` — bug #3046 (closed 2026-04-05). The dedup-consistency scenarios still fail. - `actor_add_update_enforcement.feature` — bug #2609 (closed 2026-04-05). The enforcement scenarios still fail. - `ci_workflow_validation.feature:134` — #4227 (closed 2026-04-08). The CI YAML threshold assertion still fails. ## Verification - `grep -r "@skip" features/ --include="*.feature"` → **zero results** ✓ - `grep -n "tags=not @skip" noxfile.py` → **zero results** ✓ - `nox -s unit_tests` → **629 features passed, 0 failed** ✓ (up from ~545 before this PR) - CI all green (coverage ≥ 97%) ✓ - Integration tests (Robot Framework) do not use `@skip` — confirmed no action needed ✓ - E2E tests (Robot Framework) do not use `@skip` — confirmed no action needed ✓ - `CHANGELOG.md` updated with entry for this change ✓ - `CONTRIBUTORS.md` — Rui Hu already listed ✓ ## Issues Addressed Closes #7025 Co-authored-by: CleverThis <hal9000@cleverthis.com> Reviewed-on: #7221 Reviewed-by: HAL 9000 <HAL9000@cleverthis.com> Reviewed-by: HAL9001 <hal9001@cleverthis.com> Co-authored-by: Rui Hu <rui.hu@cleverthis.com> Co-committed-by: Rui Hu <rui.hu@cleverthis.com>
104 lines
5.7 KiB
Gherkin
104 lines
5.7 KiB
Gherkin
Feature: Config CLI coverage boost
|
|
Supplementary scenarios targeting uncovered lines in
|
|
cleveragents/cli/commands/config.py to increase branch and line coverage.
|
|
|
|
Background:
|
|
Given a cfg-boost isolated temp config directory
|
|
|
|
# ── _env_var_for_key: line 135 ──────────────────────────────────────
|
|
|
|
Scenario: _env_var_for_key returns the registered env_var for a known key
|
|
When I call cfg-boost _env_var_for_key with a registered key "core.log.level"
|
|
Then the cfg-boost returned env var should match the registry for "core.log.level"
|
|
|
|
# ── _resolve_source error path: lines 145-146 ──────────────────────
|
|
|
|
Scenario: _resolve_source returns default when resolve raises ValueError
|
|
When I call cfg-boost _resolve_source with a key that triggers ValueError
|
|
Then the cfg-boost returned source should be "default"
|
|
|
|
# ── _resolution_chain error path: lines 155-156 ─────────────────────
|
|
|
|
Scenario: _resolution_chain returns empty list when resolve raises KeyError
|
|
When I call cfg-boost _resolution_chain with a key that triggers KeyError
|
|
Then the cfg-boost returned chain should be empty
|
|
|
|
# ── config_set --project with non-scopable key: line 210 ────────────
|
|
|
|
Scenario: config set --project fails for non-project-scopable key
|
|
When I invoke cfg-boost config set "core.data-dir" "val" with project "myproj"
|
|
Then the cfg-boost CLI result should have failed
|
|
And the cfg-boost CLI output should include "not project-scopable"
|
|
|
|
# ── config_set --project with corrupted project section: line 213 ───
|
|
|
|
Scenario: config set --project handles corrupted project section (not a dict)
|
|
Given the cfg-boost config file has a non-dict "project" value
|
|
When I invoke cfg-boost config set "plan.concurrency" "8" with project "myproj"
|
|
Then the cfg-boost CLI result should have succeeded
|
|
And the cfg-boost CLI output should include "plan.concurrency"
|
|
|
|
# ── config_set --project with corrupted proj overrides: line 216 ────
|
|
|
|
Scenario: config set --project handles corrupted project override entry (not a dict)
|
|
Given the cfg-boost config file has a non-dict project override for "myproj"
|
|
When I invoke cfg-boost config set "plan.concurrency" "6" with project "myproj"
|
|
Then the cfg-boost CLI result should have succeeded
|
|
And the cfg-boost CLI output should include "plan.concurrency"
|
|
|
|
# ── config_get verbose non-rich with Path value in chain entry: line 306 ──
|
|
|
|
Scenario: config get verbose non-rich format serialises Path values in resolution chain
|
|
When I invoke cfg-boost config get "core.data-dir" verbose format "json" with path-like chain
|
|
Then the cfg-boost CLI result should have succeeded
|
|
And the cfg-boost JSON resolution chain entries should have string values
|
|
|
|
# ── config_list --project with key regex filter skipping: lines 398-401 ──
|
|
|
|
Scenario: config list --project filters keys by regex pattern
|
|
Given the cfg-boost config file has project "testproj" override "plan.concurrency" as "10"
|
|
When I invoke cfg-boost config list with project "testproj" pattern "nonexistent"
|
|
Then the cfg-boost list output should show no matching overrides
|
|
|
|
# ── config_list --project with value filter skipping: line 405 ──────
|
|
|
|
Scenario: config list --project filters values by regex
|
|
Given the cfg-boost config file has project "testproj" override "plan.concurrency" as "10"
|
|
When I invoke cfg-boost config list with project "testproj" value-filter "NOMATCH999"
|
|
Then the cfg-boost list output should show no matching overrides
|
|
|
|
# ── config_list --project with secret masking: line 410 ─────────────
|
|
|
|
@tdd_issue @tdd_issue_4237 @tdd_expected_fail
|
|
Scenario: config list --project masks secret keys by default
|
|
Given the cfg-boost config file has project "secproj" secret override "provider.openai.api-key" as "sk-supersecret"
|
|
When I invoke cfg-boost config list project "secproj" format "json"
|
|
Then the cfg-boost CLI result should have succeeded
|
|
And the cfg-boost JSON list should show masked secret values
|
|
|
|
# ── config_list --project non-rich with Path fspath: line 430 ───────
|
|
|
|
@tdd_issue @tdd_issue_4237 @tdd_expected_fail
|
|
Scenario: config list --project non-rich format serialises Path values
|
|
Given the cfg-boost config file has project "pathproj" override "core.data-dir" as "/tmp/somepath"
|
|
When I invoke cfg-boost config list project "pathproj" format "json" with path value
|
|
Then the cfg-boost CLI result should have succeeded
|
|
And the cfg-boost JSON list entries should have only primitive values
|
|
|
|
# ── config_list --project rich format table rendering: lines 434-452 ──
|
|
|
|
Scenario: config list --project renders rich table for project overrides
|
|
Given the cfg-boost config file has project "richproj" override "plan.concurrency" as "12"
|
|
When I invoke cfg-boost config list project "richproj" in default rich format
|
|
Then the cfg-boost CLI result should have succeeded
|
|
And the cfg-boost CLI output should include "plan.concurrency"
|
|
And the cfg-boost CLI output should include "12"
|
|
|
|
# ── config_list all non-rich with Path fspath: line 501 ─────────────
|
|
|
|
@tdd_issue @tdd_issue_4237 @tdd_expected_fail
|
|
Scenario: config list non-rich format serialises Path objects in all-keys mode
|
|
When I invoke cfg-boost config list format "json" with path value in resolve_all
|
|
Then the cfg-boost CLI result should have succeeded
|
|
And the cfg-boost JSON all-keys list should have stringified path values
|