freemo
051ee7c290
CI / benchmark-publish (pull_request) Has been skipped
CI / lint (pull_request) Successful in 21s
CI / quality (pull_request) Successful in 31s
CI / typecheck (pull_request) Successful in 47s
CI / security (pull_request) Successful in 52s
CI / build (pull_request) Successful in 56s
CI / e2e_tests (pull_request) Successful in 5m1s
CI / integration_tests (pull_request) Successful in 5m30s
CI / unit_tests (pull_request) Successful in 5m42s
CI / docker (pull_request) Successful in 58s
CI / coverage (pull_request) Successful in 7m35s
CI / build (push) Successful in 21s
CI / docker (push) Has been skipped
CI / benchmark-regression (pull_request) Failing after 49m24s
CI / lint (push) Successful in 22s
CI / quality (push) Successful in 39s
CI / security (push) Successful in 48s
CI / typecheck (push) Successful in 1m26s
CI / benchmark-regression (push) Has been skipped
CI / e2e_tests (push) Successful in 5m53s
CI / coverage (push) Successful in 9m4s
CI / benchmark-publish (push) Successful in 19m10s
CI / integration_tests (push) Failing after 19m18s
CI / unit_tests (push) Failing after 19m20s
Added 52 new .feature files and corresponding _steps.py files targeting previously uncovered code paths in the following areas: - TUI layer: app, commands, persona (state/schema/registry), widgets, input (shell_exec, reference_parser) - Application services: plan lifecycle/service/executor, session, project, repo indexing, correction, checkpoint, actor, llm_actors, strategy coordinator, resource file watcher, service retry wiring - CLI commands: session, resource, repl, plan, db, automation_profile - Domain models: retry_policy, resource_type, cost_budget, docker_compose_analyzer, detail_level, _sql_string_aware, _postgresql_helpers - Core: circuit_breaker, retry_service_patterns - Infrastructure: repositories, transaction_sandbox, strategy_registry, plugins/loader, container - Config: settings - Agents: plan_generation, context_analysis, auto_debug - A2A: facade All new tests follow the Behave/Gherkin BDD standard. Resolved step definition collisions with unique prefixes. Fixed Alembic fileConfig logger disabling issue (disable_existing_loggers=False). ISSUES CLOSED: #1068
61 lines
3.1 KiB
Gherkin
61 lines
3.1 KiB
Gherkin
Feature: Circuit Breaker Coverage
|
|
Scenarios that exercise previously uncovered code paths in
|
|
the circuit_breaker module, focusing on edge-case exception
|
|
handling, stale-generation guards, and async equivalents.
|
|
|
|
Background:
|
|
Given the circuit breaker coverage module is imported
|
|
|
|
# --- Sync path: inner CircuitBreakerOpen during HALF_OPEN (lines 160-169) ---
|
|
|
|
Scenario: Sync call restores half-open permit when inner service raises CircuitBreakerOpen
|
|
Given a coverage circuit breaker with failure threshold 2 and fast recovery
|
|
And the coverage circuit breaker is transitioned to half-open state
|
|
When I sync-call a function that raises inner CircuitBreakerOpen
|
|
Then the caught exception should be a CircuitBreakerOpen
|
|
And the coverage half-open permit count should be restored
|
|
|
|
# --- Sync path: BaseException during HALF_OPEN (lines 191-195) ---
|
|
|
|
Scenario: Sync call restores half-open permit when function raises a BaseException subclass
|
|
Given a coverage circuit breaker with failure threshold 2 and fast recovery
|
|
And the coverage circuit breaker is transitioned to half-open state
|
|
When I sync-call a function that raises a KeyboardInterrupt
|
|
Then the caught exception should be a KeyboardInterrupt
|
|
And the coverage half-open permit count should be restored
|
|
|
|
# --- Async path: inner CircuitBreakerOpen during HALF_OPEN (lines 286-295) ---
|
|
|
|
Scenario: Async call restores half-open permit when inner service raises CircuitBreakerOpen
|
|
Given a coverage circuit breaker with failure threshold 2 and fast recovery
|
|
And the coverage circuit breaker is transitioned to half-open state
|
|
When I async-call a function that raises inner CircuitBreakerOpen
|
|
Then the caught exception should be a CircuitBreakerOpen
|
|
And the coverage half-open permit count should be restored
|
|
|
|
# --- Async path: BaseException during HALF_OPEN (covers async BaseException handler) ---
|
|
|
|
Scenario: Async call restores half-open permit when function raises a BaseException subclass
|
|
Given a coverage circuit breaker with failure threshold 2 and fast recovery
|
|
And the coverage circuit breaker is transitioned to half-open state
|
|
When I async-call a function that raises a KeyboardInterrupt
|
|
Then the caught exception should be a KeyboardInterrupt
|
|
And the coverage half-open permit count should be restored
|
|
|
|
# --- Stale generation discarded in _on_success (line 360) ---
|
|
|
|
Scenario: Stale half-open generation is discarded on success
|
|
Given a coverage circuit breaker in half-open state with generation 3
|
|
When _on_success is called with stale generation 1
|
|
Then the _on_success result should be False
|
|
And the coverage circuit breaker should still be half-open
|
|
|
|
# --- _on_failure when already OPEN (line 384) ---
|
|
|
|
Scenario: _on_failure is a no-op when circuit is already open
|
|
Given a coverage circuit breaker that is already in the open state
|
|
When _on_failure is called on the already-open breaker
|
|
Then the _on_failure result should be False
|
|
And the coverage circuit breaker state should still be open
|
|
And the failure count should not have changed
|