hurui200320
2005b8ef82
CI / push-validation (push) Successful in 18s
CI / build (push) Successful in 19s
CI / helm (push) Successful in 24s
CI / lint (push) Successful in 29s
CI / security (push) Successful in 1m11s
CI / e2e_tests (push) Successful in 2m56s
CI / quality (push) Successful in 3m40s
CI / typecheck (push) Successful in 3m59s
CI / integration_tests (push) Successful in 4m3s
CI / unit_tests (push) Successful in 4m55s
CI / docker (push) Successful in 10s
CI / coverage (push) Successful in 10m44s
CI / status-check (push) Successful in 1s
CI / benchmark-regression (push) Has been skipped
CI / benchmark-publish (push) Successful in 1h13m28s
## Summary Replaces all 234 bare `@skip` occurrences across 82 Behave feature files with the correct TDD issue-capture tagging system described in CONTRIBUTING.md § Bug Fix Workflow. Previously, the noxfile ran Behave with `--tags=not @skip`, silently excluding all `@skip`-tagged scenarios from every CI run. These tests never ran, never inverted results via the `@tdd_expected_fail` mechanism, and never contributed to coverage — defeating the purpose of TDD issue-capture testing. Every `@skip` occurrence had a commented-out hint line immediately above it showing the intended proper tags (e.g., `# @tdd_issue @tdd_issue_4272 @tdd_expected_fail @skip`), confirming they were all intended for conversion. ## Changes ### Mechanical conversion (234 replacements across 82 files) - Extracted the proper TDD tags from the comment hint above each `@skip` line, removed `@skip` from the tag set, and replaced the `@skip` line with those tags. - Removed the now-redundant comment hint lines alongside each replacement. ### Bug-fixed scenarios — `@tdd_expected_fail` removed (84 scenarios) - After conversion, ran `nox -s unit_tests` to identify which newly-enabled `@tdd_expected_fail` scenarios now **pass** (their referenced bugs have already been fixed). Removed `@tdd_expected_fail` from those 84 scenarios and their corresponding feature-level tags, leaving only the permanent `@tdd_issue @tdd_issue_<N>` regression-guard tags. - Affected features include: `tdd_tool_runner_env_precedence`, `tdd_automation_profile_session_leak`, `tls_certificate_check`, `project_create_persist`, `resource_type_bootstrap_*`, and 18 others. ### Noxfile cleanup - Removed all four `--tags=not @skip` arguments from `noxfile.py` (unit_tests and coverage sessions). With zero `@skip` tags remaining in the codebase, this filter was dead code and its presence would mislead future maintainers into thinking `@skip` is still a supported escape mechanism. ### Regression guard files - Split the regression guards into two focused files: - `tdd_regression_guards_exec_env.feature` for bug #4281 (exec-env precedence) - `tdd_regression_guards_session_list.feature` for bug #4271 (session list summary) - Each file carries only its own `@tdd_issue` tags at the feature level, avoiding cross-contamination via Behave tag inheritance. The `Background` step (`session-list-summary mock`) only appears in the session-list file where it is actually needed. ### Duplicate tag cleanup - Removed duplicate `@tdd_issue @tdd_issue_4287` tag lines in `tdd_skill_add_regression.feature` (lines 20 and 29). ### Inline comment for retained `@tdd_expected_fail` - Added inline comment in `ci_workflow_validation.feature:134` explaining why this specific #4227 scenario retains `@tdd_expected_fail` despite #4227 being closed (CI YAML does not encode threshold as a machine-readable value). ### Known edge cases — `@tdd_expected_fail` retained (closed issues, fix on master, scenarios still fail) The following issues are **closed** and their fixes **are on master**, but the specific test assertions still fail because the fixes address other aspects of the bugs. The `@tdd_expected_fail` tags are functionally correct and must remain until the specific scenario assertions pass: - `tdd_exec_env_resolution_precedence.feature` — bug #1080 (closed 2026-03-31). The precedence-level-2-vs-4 scenario still fails. - `session_list_summary_dedup.feature` — bug #3046 (closed 2026-04-05). The dedup-consistency scenarios still fail. - `actor_add_update_enforcement.feature` — bug #2609 (closed 2026-04-05). The enforcement scenarios still fail. - `ci_workflow_validation.feature:134` — #4227 (closed 2026-04-08). The CI YAML threshold assertion still fails. ## Verification - `grep -r "@skip" features/ --include="*.feature"` → **zero results** ✓ - `grep -n "tags=not @skip" noxfile.py` → **zero results** ✓ - `nox -s unit_tests` → **629 features passed, 0 failed** ✓ (up from ~545 before this PR) - CI all green (coverage ≥ 97%) ✓ - Integration tests (Robot Framework) do not use `@skip` — confirmed no action needed ✓ - E2E tests (Robot Framework) do not use `@skip` — confirmed no action needed ✓ - `CHANGELOG.md` updated with entry for this change ✓ - `CONTRIBUTORS.md` — Rui Hu already listed ✓ ## Issues Addressed Closes #7025 Co-authored-by: CleverThis <hal9000@cleverthis.com> Reviewed-on: #7221 Reviewed-by: HAL 9000 <HAL9000@cleverthis.com> Reviewed-by: HAL9001 <hal9001@cleverthis.com> Co-authored-by: Rui Hu <rui.hu@cleverthis.com> Co-committed-by: Rui Hu <rui.hu@cleverthis.com>
130 lines
8.6 KiB
Gherkin
130 lines
8.6 KiB
Gherkin
@checkpoint @auto_triggers
|
|
Feature: Automatic checkpoint triggers during Execute phase
|
|
As a plan executor
|
|
I want checkpoints to be created automatically at key points during execution
|
|
So that fine-grained rollback is possible without manual intervention
|
|
|
|
# ───────────────────────────────────────────────────────────
|
|
# before_tool_execute trigger
|
|
# ───────────────────────────────────────────────────────────
|
|
|
|
Scenario: before_tool_execute checkpoint created before a write tool runs
|
|
Given a tool runner with a checkpoint service and plan_id "01ARZ3NDEKTSV4RRFFQ69G5FA1"
|
|
And a write tool "local/write-file" is registered
|
|
When I execute tool "local/write-file" with plan_id "01ARZ3NDEKTSV4RRFFQ69G5FA1"
|
|
Then a checkpoint with phase "before_tool_execute" should exist for plan "01ARZ3NDEKTSV4RRFFQ69G5FA1"
|
|
|
|
Scenario: before_tool_execute checkpoint NOT created for read-only tools
|
|
Given a tool runner with a checkpoint service and plan_id "01ARZ3NDEKTSV4RRFFQ69G5FA2"
|
|
And a read-only tool "local/read-file" is registered
|
|
When I execute tool "local/read-file" with plan_id "01ARZ3NDEKTSV4RRFFQ69G5FA2"
|
|
Then no checkpoint with phase "before_tool_execute" should exist for plan "01ARZ3NDEKTSV4RRFFQ69G5FA2"
|
|
|
|
Scenario: before_tool_execute trigger can be disabled
|
|
Given a tool runner with a checkpoint service and plan_id "01ARZ3NDEKTSV4RRFFQ69G5FA3"
|
|
And the "before_tool_execute" trigger is disabled
|
|
And a write tool "local/write-file" is registered
|
|
When I execute tool "local/write-file" with plan_id "01ARZ3NDEKTSV4RRFFQ69G5FA3"
|
|
Then no checkpoint with phase "before_tool_execute" should exist for plan "01ARZ3NDEKTSV4RRFFQ69G5FA3"
|
|
|
|
# ───────────────────────────────────────────────────────────
|
|
# after_tool_execute trigger
|
|
# ───────────────────────────────────────────────────────────
|
|
|
|
Scenario: after_tool_execute checkpoint created after a write tool succeeds
|
|
Given a tool runner with a checkpoint service and plan_id "01ARZ3NDEKTSV4RRFFQ69G5FA4"
|
|
And a write tool "local/write-file" is registered
|
|
When I execute tool "local/write-file" with plan_id "01ARZ3NDEKTSV4RRFFQ69G5FA4"
|
|
Then a checkpoint with phase "after_tool_execute" should exist for plan "01ARZ3NDEKTSV4RRFFQ69G5FA4"
|
|
|
|
Scenario: after_tool_execute checkpoint NOT created for read-only tools
|
|
Given a tool runner with a checkpoint service and plan_id "01ARZ3NDEKTSV4RRFFQ69G5FA5"
|
|
And a read-only tool "local/read-file" is registered
|
|
When I execute tool "local/read-file" with plan_id "01ARZ3NDEKTSV4RRFFQ69G5FA5"
|
|
Then no checkpoint with phase "after_tool_execute" should exist for plan "01ARZ3NDEKTSV4RRFFQ69G5FA5"
|
|
|
|
Scenario: after_tool_execute trigger can be disabled
|
|
Given a tool runner with a checkpoint service and plan_id "01ARZ3NDEKTSV4RRFFQ69G5FA6"
|
|
And the "after_tool_execute" trigger is disabled
|
|
And a write tool "local/write-file" is registered
|
|
When I execute tool "local/write-file" with plan_id "01ARZ3NDEKTSV4RRFFQ69G5FA6"
|
|
Then no checkpoint with phase "after_tool_execute" should exist for plan "01ARZ3NDEKTSV4RRFFQ69G5FA6"
|
|
|
|
Scenario: Both before and after checkpoints created for a single write tool execution
|
|
Given a tool runner with a checkpoint service and plan_id "01ARZ3NDEKTSV4RRFFQ69G5FA7"
|
|
And a write tool "local/write-file" is registered
|
|
When I execute tool "local/write-file" with plan_id "01ARZ3NDEKTSV4RRFFQ69G5FA7"
|
|
Then 2 checkpoints should exist for plan "01ARZ3NDEKTSV4RRFFQ69G5FA7"
|
|
|
|
# ───────────────────────────────────────────────────────────
|
|
# on_subplan_spawn trigger
|
|
# ───────────────────────────────────────────────────────────
|
|
|
|
@tdd_issue @tdd_issue_4236 @tdd_expected_fail
|
|
Scenario: on_subplan_spawn checkpoint created when a child plan is spawned
|
|
Given a subplan execution service with a checkpoint service and parent_plan_id "01ARZ3NDEKTSV4RRFFQ69G5FA8"
|
|
And a subplan "01ARZ3NDEKTSV4RRFFQ69G5FAA" is configured
|
|
When the subplan execution service executes the subplan
|
|
Then a checkpoint with phase "execute" should exist for plan "01ARZ3NDEKTSV4RRFFQ69G5FA8"
|
|
And the checkpoint source_tool should be "subplan_execution_service"
|
|
|
|
Scenario: on_subplan_spawn trigger can be disabled
|
|
Given a subplan execution service with a checkpoint service and parent_plan_id "01ARZ3NDEKTSV4RRFFQ69G5FAB"
|
|
And the "on_subplan_spawn" trigger is disabled on the subplan service
|
|
And a subplan "01ARZ3NDEKTSV4RRFFQ69G5FAC" is configured
|
|
When the subplan execution service executes the subplan
|
|
Then no checkpoints should exist for plan "01ARZ3NDEKTSV4RRFFQ69G5FAB"
|
|
|
|
Scenario: on_subplan_spawn checkpoint created for each spawned subplan
|
|
Given a subplan execution service with a checkpoint service and parent_plan_id "01ARZ3NDEKTSV4RRFFQ69G5FAD"
|
|
And 3 subplans are configured
|
|
When the subplan execution service executes all subplans
|
|
Then 3 checkpoints should exist for plan "01ARZ3NDEKTSV4RRFFQ69G5FAD"
|
|
|
|
# ───────────────────────────────────────────────────────────
|
|
# on_error trigger
|
|
# ───────────────────────────────────────────────────────────
|
|
|
|
Scenario: on_error checkpoint created when Execute phase fails (stub mode)
|
|
Given a plan executor with a checkpoint manager and plan_id "01ARZ3NDEKTSV4RRFFQ69G5FAE"
|
|
And the execute actor raises an error
|
|
When I run the execute phase for plan "01ARZ3NDEKTSV4RRFFQ69G5FAE"
|
|
Then the execute phase should fail
|
|
And a checkpoint with phase "on_error" should have been created for plan "01ARZ3NDEKTSV4RRFFQ69G5FAE"
|
|
|
|
Scenario: on_error trigger can be disabled
|
|
Given a plan executor with a checkpoint manager and plan_id "01ARZ3NDEKTSV4RRFFQ69G5FAF"
|
|
And the "on_error" trigger is disabled on the executor
|
|
And the execute actor raises an error
|
|
When I run the execute phase for plan "01ARZ3NDEKTSV4RRFFQ69G5FAF"
|
|
Then the execute phase should fail
|
|
And no on_error checkpoint should have been created for plan "01ARZ3NDEKTSV4RRFFQ69G5FAF"
|
|
|
|
# ───────────────────────────────────────────────────────────
|
|
# No checkpoint service — all hooks silently skipped
|
|
# ───────────────────────────────────────────────────────────
|
|
|
|
Scenario: No checkpoints created when no checkpoint service is wired to tool runner
|
|
Given a tool runner WITHOUT a checkpoint service
|
|
And a write tool "local/write-file" is registered
|
|
When I execute tool "local/write-file" without a plan_id
|
|
Then no auto-trigger exception should be raised
|
|
|
|
Scenario: No checkpoints created when no checkpoint service is wired to subplan service
|
|
Given a subplan execution service WITHOUT a checkpoint service
|
|
And a subplan "01ARZ3NDEKTSV4RRFFQ69G5FAG" is configured
|
|
When the subplan execution service executes the subplan
|
|
Then no auto-trigger exception should be raised
|
|
|
|
# ───────────────────────────────────────────────────────────
|
|
# core.checkpoints.auto_create_on config key
|
|
# ───────────────────────────────────────────────────────────
|
|
|
|
Scenario: auto_create_on config key is registered with correct default
|
|
Given the config service is initialized
|
|
When I get the config key "core.checkpoints.auto_create_on"
|
|
Then the value should contain "before_tool_execute"
|
|
And the value should contain "after_tool_execute"
|
|
And the value should contain "on_subplan_spawn"
|
|
And the value should contain "on_error"
|