Files
cleveragents-core/features/async_worker_coverage_boost.feature
freemo a808c395f9
CI / benchmark-publish (pull_request) Has been skipped
CI / lint (pull_request) Successful in 15s
CI / build (pull_request) Successful in 15s
CI / quality (pull_request) Successful in 17s
CI / typecheck (pull_request) Successful in 35s
CI / security (pull_request) Successful in 50s
CI / unit_tests (pull_request) Successful in 2m46s
CI / integration_tests (pull_request) Successful in 3m16s
CI / docker (pull_request) Successful in 40s
CI / coverage (pull_request) Successful in 5m6s
CI / lint (push) Successful in 13s
CI / quality (push) Successful in 16s
CI / build (push) Successful in 18s
CI / security (push) Successful in 32s
CI / typecheck (push) Successful in 35s
CI / benchmark-regression (push) Has been skipped
CI / unit_tests (push) Successful in 2m52s
CI / integration_tests (push) Successful in 3m8s
CI / docker (push) Successful in 39s
CI / coverage (push) Successful in 5m53s
CI / benchmark-publish (push) Successful in 16m55s
CI / benchmark-regression (pull_request) Successful in 33m0s
test(coverage): add Behave BDD tests to improve unit test coverage across 53 source modules
Add 53 new .feature files and corresponding step definition files targeting
uncovered lines identified in build/coverage.xml. Fix AmbiguousStep conflicts
in 7 pre-existing step files by disambiguating step text.

New tests cover: ACP clients/facade, actor CLI/config, application container,
ACMS service/strategies, async worker, automation profile CLI, autonomy
guardrail, bridge, change model, config CLI/service, context service,
cross-plan correction, database models, decision service, decomposition
clustering/service, discovery handler, langchain chat provider, langgraph
nodes, materializers, multi-project service, plan apply/CLI/lifecycle/model/
preflight/resume/service, PostgreSQL analyzer, project CLI/context CLI,
provider registry, reactive application/route, repositories, resolver handler,
resource registry service, resume model, retry patterns, sandbox protocol,
server CLI, skill CLI/service, skills registry, subplan execution/service,
system CLI, UKO loader, UoW, and YAML template engine.

Closes #645
2026-03-09 13:01:58 -04:00

80 lines
3.7 KiB
Gherkin

Feature: AsyncWorker uncovered code paths
As a developer
I want full test coverage of async_worker.py edge cases
So that race conditions, signal handling, and error recovery are verified
# ---- cancel_job: InvalidJobTransitionError on queued job (lines 515-516) ----
Scenario: cancel_job returns False when queued job transitions concurrently
Given a coverage-boost async worker is initialised
And a coverage-boost queued job exists
And the queued job mark_cancelled is patched to raise InvalidJobTransitionError
When I call cancel_job on the coverage-boost worker
Then the cancel_job result should be False
# ---- detect_stuck_jobs: InvalidJobTransitionError (lines 543-544) ----
Scenario: detect_stuck_jobs ignores job whose mark_failed raises InvalidJobTransitionError
Given a coverage-boost async worker with job_timeout 1
And a coverage-boost running job with expired heartbeat exists
And the stuck job mark_failed is patched to raise InvalidJobTransitionError
When the coverage-boost worker detects stuck jobs
Then the stuck jobs list should be empty
# ---- _poll_loop: shutdown break during job dispatch (line 604) ----
Scenario: Poll loop breaks out of dispatch when shutdown is requested mid-iteration
Given a coverage-boost async worker is initialised
And 5 coverage-boost queued jobs exist
And the shutdown event is pre-set before dispatch
When I run one poll loop iteration
Then not all 5 queued jobs should have been dispatched
# ---- _poll_loop: exception handler (lines 606-607) ----
Scenario: Poll loop logs and continues when an exception occurs
Given a coverage-boost async worker is initialised
And the job store list_by_status is patched to raise RuntimeError
When I run one poll loop iteration catching the exception
Then the poll loop should have handled the exception gracefully
# ---- _dispatch_job: fallback with no thread pool (lines 614-615) ----
Scenario: _dispatch_job falls back to direct execution when thread pool is None
Given a coverage-boost async worker is initialised
And a coverage-boost queued job exists
And the worker thread pool is None
When I dispatch the job directly via _dispatch_job
Then the coverage-boost job should be in a terminal state
# ---- _dispatch_job: duplicate dispatch guard (line 618) ----
Scenario: _dispatch_job skips job that is already in the futures dict
Given a coverage-boost async worker is initialised with a started pool
And a coverage-boost queued job exists
And the job is already registered in the futures dict
When I dispatch the job directly via _dispatch_job
Then the futures dict should still contain exactly one entry for the job
# ---- _signal_handler: direct invocation (lines 632-633) ----
Scenario: Signal handler sets the shutdown event
Given a coverage-boost async worker is initialised
When I invoke the signal handler directly with SIGINT
Then the worker shutdown event should be set
# ---- _install_signal_handlers: OSError/ValueError from non-main thread (lines 642, 644) ----
Scenario: Signal handler installation silently fails from non-main thread
Given a coverage-boost async worker is initialised
When I install signal handlers from a background thread
Then no exception should be raised during signal installation
# ---- _restore_signal_handlers: OSError/ValueError from non-main thread (lines 653-654) ----
Scenario: Signal handler restoration silently fails from non-main thread
Given a coverage-boost async worker is initialised
And the worker has original signal handler references set
When I restore signal handlers from a background thread
Then no exception should be raised during signal restoration